split 1.3.2 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91c3eb51951c16c9e8e486a3ae93ec0c277d3e1b
-  data.tar.gz: 19f62b612e02dfcd34c2bee94a5332a742f2864d
+  metadata.gz: d5ce44cc3d861186dd8d1acce66eea15acb2f5af
+  data.tar.gz: 85bd7d57f7e56d0c4ac06ab8eecfbce40ec96060
 SHA512:
-  metadata.gz: 0ff2e3af704c2169f6aa7714b6d9eff0d9fc52e2297caffa7312cc50ae43065bf4b73f9d2ad284ee4b55515ef970df00ed16e4c403eabf90d7b3aa57c26c8dab
-  data.tar.gz: 4c94d4e88dd4f18aef4ca10db437d25720acd9d82fa3718cecd11037863ea0d7515676973f6b49d87cf3e126d09c2595de18ae08e70790930bc1c38a63bad686
+  metadata.gz: 9aa91bd0caab6c179b0393bb25f075efa1782bee1ce6cc238b470dac58d76b9819d0e5534e18a68e872ee88d81f01f6fba9ac97e89bc0ede5add5dc00b5a16a6
+  data.tar.gz: 2aca58592f7a381482dbcfaec0ba8b490ccb2f032ad68a3e4a495a8dd56a26a337066929954380188da53fef7a21b21520a0601adb5a7125b3f62aae6dcc9340

data/.travis.yml

@@ -1,6 +1,6 @@
 language: ruby
 rvm:
-  - 2.2.4
+  - 2.3.0
 
 gemfile:
   - gemfiles/4.1.gemfile

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## 1.4.0 (April 2nd, 2016)
+
+Features:
+
+- Added experiment filters to dashboard (@ccallebs, #363, #364)
+- Added Contributor Covenant Code of Conduct
+
 ## 1.3.2 (January 2nd, 2016)
 
 Bugfixes:

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,74 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, gender identity and expression, level of experience,
+nationality, personal appearance, race, religion, or sexual identity and
+orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at andrewnez@gmail.com. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/

data/README.md

@@ -8,7 +8,6 @@ Split is designed to be hacker friendly, allowing for maximum customisation and
 
 [![Gem Version](https://badge.fury.io/rb/split.svg)](http://badge.fury.io/rb/split)
 [![Build Status](https://secure.travis-ci.org/splitrb/split.svg?branch=master)](http://travis-ci.org/splitrb/split)
-[![Dependency Status](https://gemnasium.com/splitrb/split.svg)](https://gemnasium.com/splitrb/split)
 [![Code Climate](https://codeclimate.com/github/splitrb/split.svg)](https://codeclimate.com/github/splitrb/split)
 [![Coverage Status](http://img.shields.io/coveralls/splitrb/split.svg)](https://coveralls.io/r/splitrb/split)
 
@@ -37,7 +36,7 @@ gem install split
 
 ### Rails
 
-Adding `gem 'split'` to your Gemfile will autoloaded it when rails starts up, as long as you've configured redis it will 'just work'.
+Adding `gem 'split'` to your Gemfile will autoload it when rails starts up, as long as you've configured redis it will 'just work'.
 
 ### Sinatra
 

data/lib/split.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 %w[algorithms
    alternative
    configuration

data/lib/split/algorithms.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 %w[weighted_sample whiplash].each do |f|
   require "split/algorithms/#{f}"
-end
+end

data/lib/split/algorithms/weighted_sample.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   module Algorithms
     module WeightedSample
@@ -14,4 +15,4 @@ module Split
       end
     end
   end
-end
+end

data/lib/split/algorithms/whiplash.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A multi-armed bandit implementation inspired by
 # @aaronsw and victorykit/whiplash
 require 'simple-random'

data/lib/split/alternative.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'split/zscore'
 
 # TODO - take out require and implement using file paths?

data/lib/split/configuration.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   class Configuration
     attr_accessor :bots

data/lib/split/dashboard.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'sinatra/base'
 require 'split'
 require 'bigdecimal'

data/lib/split/dashboard/helpers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   module DashboardHelpers
     def h(text)

data/lib/split/dashboard/public/dashboard-filtering.js

@@ -0,0 +1,43 @@
+$(function() {
+  $('#filter').on('keyup', function() {
+    $input = $(this);
+
+    if ($input.val() == '') {
+      $('div.experiment').show();
+      return false;
+    }
+
+    $('div.experiment').hide();
+    selector = 'div.experiment[data-name*="' + $input.val() + '"]';
+    $(selector).show();
+  });
+
+  $('#clear-filter').on('click', function() {
+    $('#filter').val('');
+    $('div.experiment').show();
+    $('#toggle-active').val('Hide active');
+    $('#toggle-completed').val('Hide completed');
+  });
+
+  $('#toggle-active').on('click', function() {
+    $button = $(this);
+    if ($button.val() == 'Hide active') {
+      $button.val('Show active');
+    } else {
+      $button.val('Hide active');
+    }
+
+    $('div.experiment[data-complete="false"]').toggle();
+  });
+
+  $('#toggle-completed').on('click', function() {
+    $button = $(this);
+    if ($button.val() == 'Hide completed') {
+      $button.val('Show completed');
+    } else {
+      $button.val('Hide completed');
+    }
+
+    $('div.experiment[data-complete="true"]').toggle();
+  });
+});

data/lib/split/dashboard/public/style.css

@@ -312,4 +312,8 @@ a.button.green:focus, button.green:focus, input[type="submit"].green:focus {
   background:#768E7A;
 }
 
+#filter, #clear-filter {
+  padding: 10px;
+}
+
 

data/lib/split/dashboard/views/_experiment.erb

@@ -6,7 +6,7 @@
 
 <% experiment.calc_winning_alternatives %>
 
-<div class="<%= experiment_class %>">
+<div class="<%= experiment_class %>" data-name="<%= experiment.name %>" data-complete="<%= experiment.has_winner? %>">
   <div class="experiment-header">
     <h2>
       Experiment: <%= experiment.name %>

data/lib/split/dashboard/views/index.erb

@@ -1,6 +1,11 @@
 <% if @experiments.any? %>
   <p class="intro">The list below contains all the registered experiments along with the number of test participants, completed and conversion rate currently in the system.</p>
 
+  <input type="text" placeholder="Begin typing to filter" id="filter" />
+  <input type="button" id="toggle-completed" value="Hide completed" />
+  <input type="button" id="toggle-active" value="Hide active" />
+  <input type="button" id="clear-filter" value="Clear filters" />
+
   <% @experiments.each do |experiment| %>
     <% if experiment.goals.empty? %>
       <%= erb :_experiment, :locals => {:goal => nil, :experiment => experiment} %>
@@ -14,4 +19,4 @@
 <% else %>
   <p class="intro">No experiments have started yet, you need to define them in your code and introduce them to your users.</p>
   <p class="intro">Check out the <a href='https://github.com/splitrb/split#readme'>Readme</a> for more help getting started.</p>
-<% end %>
+<% end %>

data/lib/split/dashboard/views/layout.erb

@@ -6,6 +6,7 @@
 <link href="<%= url 'style.css' %>" media="screen" rel="stylesheet" type="text/css">
 <script type="text/javascript" src='<%= url 'dashboard.js' %>'></script>
 <script type="text/javascript" src='<%= url 'jquery-1.11.1.min.js' %>'></script>
+<script type="text/javascript" src='<%= url 'dashboard-filtering.js' %>'></script>
 <title>Split</title>
 
 </head>
@@ -23,4 +24,4 @@
     <p>Powered by <a href="http://github.com/splitrb/split">Split</a> v<%=Split::VERSION %></p>
   </div>
 </body>
-</html>
+</html>

data/lib/split/encapsulated_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Split's helper exposes all kinds of methods we don't want to
 # mix into our model classes.
 #

data/lib/split/engine.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   class Engine < ::Rails::Engine
     initializer "split" do |app|

data/lib/split/exceptions.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   class InvalidPersistenceAdapterError < StandardError; end
   class ExperimentNotFound < StandardError; end

data/lib/split/experiment.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   class Experiment
     attr_accessor :name

data/lib/split/experiment_catalog.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   class ExperimentCatalog
     # Return all experiments

data/lib/split/extensions.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 %w[array string].each do |f|
   require "split/extensions/#{f}"
-end
+end

data/lib/split/extensions/array.rb

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
 class Array
   # maintain backwards compatibility with 1.8.7
   alias_method :sample, :choice unless method_defined?(:sample)
-end
+end

data/lib/split/extensions/string.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class String
   # Constatntize is often provided by ActiveSupport, but ActiveSupport is not a dependency of Split.
   unless method_defined?(:constantize)
@@ -12,4 +13,4 @@ class String
       constant
     end
   end
-end
+end

data/lib/split/helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   module Helper
     module_function

data/lib/split/metric.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   class Metric
     attr_accessor :name

data/lib/split/persistence.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 %w[session_adapter cookie_adapter redis_adapter].each do |f|
   require "split/persistence/#{f}"
 end

data/lib/split/persistence/cookie_adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "json"
 
 module Split

data/lib/split/persistence/redis_adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   module Persistence
     class RedisAdapter

data/lib/split/persistence/session_adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   module Persistence
     class SessionAdapter
@@ -25,4 +26,4 @@ module Split
 
     end
   end
-end
+end

data/lib/split/trial.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   class Trial
     attr_accessor :experiment

data/lib/split/version.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 module Split
   MAJOR   = 1
-  MINOR   = 3
-  PATCH   = 2
+  MINOR   = 4
+  PATCH   = 0
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/lib/split/zscore.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Split
   module Zscore
 

data/spec/algorithms/weighted_sample_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe Split::Algorithms::WeightedSample do

data/spec/algorithms/whiplash_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe Split::Algorithms::Whiplash do

data/spec/alternative_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'split/alternative'
 

data/spec/configuration_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Split::Configuration do

data/spec/dashboard_helpers_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'split/dashboard/helpers'
 

data/spec/dashboard_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'rack/test'
 require 'split/dashboard'

data/spec/encapsulated_helper_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Split::EncapsulatedHelper do

data/spec/experiment_catalog_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe Split::ExperimentCatalog do

data/spec/experiment_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'split/experiment'
 require 'split/algorithms'

data/spec/helper_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 # TODO change some of these tests to use Rack::Test
@@ -916,7 +917,7 @@ describe Split::Helper do
 
     it "fails gracefully if config is missing alternatives" do
       Split.configuration.experiments[:my_experiment] = { :foo => "Bar" }
-      expect(lambda { ab_test :my_experiment }).to raise_error
+      expect(lambda { ab_test :my_experiment }).to raise_error(NoMethodError)
     end
   end
 

data/spec/metric_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'split/metric'
 

data/spec/persistence/cookie_adapter_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe Split::Persistence::CookieAdapter do

data/spec/persistence/redis_adapter_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe Split::Persistence::RedisAdapter do

data/spec/persistence/session_adapter_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe Split::Persistence::SessionAdapter do

data/spec/persistence_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe Split::Persistence do

data/spec/spec_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 ENV['RACK_ENV'] = "test"
 
 require 'rubygems'

data/spec/support/cookies_mock.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class CookiesMock
 
   def initialize
@@ -16,4 +17,4 @@ class CookiesMock
     @cookies.delete(key)
   end
 
-end
+end

data/spec/trial_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'split/trial'
 

data/split.gemspec

@@ -28,6 +28,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'bundler',     '~> 1.10'
   s.add_development_dependency 'coveralls',   '~> 0.8'
   s.add_development_dependency 'rack-test',   '~> 0.6'
-  s.add_development_dependency 'rake',        '~> 10.4'
+  s.add_development_dependency 'rake',        '~> 11.1'
   s.add_development_dependency 'rspec',       '~> 3.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.4.0
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-02 00:00:00.000000000 Z
+date: 2016-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.4'
+        version: '11.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.4'
+        version: '11.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -147,6 +147,7 @@ files:
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
+- CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE
@@ -162,6 +163,7 @@ files:
 - lib/split/configuration.rb
 - lib/split/dashboard.rb
 - lib/split/dashboard/helpers.rb
+- lib/split/dashboard/public/dashboard-filtering.js
 - lib/split/dashboard/public/dashboard.js
 - lib/split/dashboard/public/jquery-1.11.1.min.js
 - lib/split/dashboard/public/reset.css