split 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1819f5bb2d97f871dce0a859b30f0d6a10a94341
-  data.tar.gz: b9026aa79967696c5f29de4ea320972257a0327d
+  metadata.gz: c1834f125bb0c03db28dc8b364780d88ca80c91a
+  data.tar.gz: c3ef6d85b761eda4171eacbc22aff42e25423a57
 SHA512:
-  metadata.gz: 2736a69b3f38e61393b4bb3a44fa9bea24a5ed2982689eff841d1e3c2e9516cb870795bf2fd7299e394bd8c520a13335e8399163eacf92dd512cdd46cfeff212
-  data.tar.gz: 3ca9fecdbe966b6e64586e3bcaa500be8daaa1b2a2aab2cefac664d98e73297f539b218fe9728a567fc612770bb947dcc2bd90db7343dc5a59490a9d3377aefd
+  metadata.gz: c8a2e79917f954236b2f58170eabb68672bd710474bee06b3787fc5a876bf2c8af9948c5be471bcf372bf0cb558dc74dda6214d194008268fe3e979bc0c94917
+  data.tar.gz: 42591e96c7458973b9eabb6e2e9c08d8e489ff6998701ff92424037f54462818248f0d536c8c5c3bd23da86092c1fca4ca3ee7b7430500b34dcfc21adebd6e34

data/README.mdown

@@ -631,6 +631,7 @@ end
   - [Split::Export](http://github.com/andrew/split-export) - easily export ab test data out of Split
   - [Split::Analytics](http://github.com/andrew/split-analytics) - push test data to google analytics
   - [Split::Mongoid](https://github.com/MongoHQ/split-mongoid) - store experiment data in mongoid (still uses redis)
+  - [Split::Cacheable](https://github.com/harrystech/split_cacheable) - automatically create cache buckets per test
 
 ## Screencast
 

data/lib/split/dashboard.rb

@@ -17,6 +17,9 @@ module Split
     get '/' do
       # Display experiments without a winner at the top of the dashboard
       @experiments = Split::Experiment.all_active_first
+
+      @metrics = Split::Metric.all
+
       # Display Rails Environment mode (or Rack version if not using Rails)
       if Object.const_defined?('Rails')
         @current_env = Rails.env.titlecase

data/lib/split/dashboard/views/_experiment.erb

@@ -9,6 +9,10 @@
       Experiment: <%= experiment.name %>
       <% if experiment.version > 1 %><span class='version'>v<%= experiment.version %></span><% end %>
       <% unless goal.nil? %><span class='goal'>Goal:<%= goal %></span><% end %>
+      <% metrics = @metrics.select {|metric| metric.experiments.include? experiment} %>
+      <% unless metrics.empty? %>
+        <span class='goal'>Metrics:<%= metrics.map(&:name).join(', ') %></span>
+      <% end %>
     </h2>
 
     <% if goal.nil? %>

data/lib/split/experiment_catalog.rb

@@ -1,7 +1,9 @@
 module Split
   class ExperimentCatalog
+    # Return all experiments
     def self.all
-      Split.redis.smembers(:experiments).map {|e| find(e)}
+      # Call compact to prevent nil experiments from being returned -- seems to happen during gem upgrades
+      Split.redis.smembers(:experiments).map {|e| find(e)}.compact
     end
 
     # Return experiments without a winner (considered "active") first

data/lib/split/helper.rb

@@ -166,7 +166,7 @@ module Split
 
     def start_trial(trial)
       experiment = trial.experiment
-      if override_present?(experiment.name)
+      if override_present?(experiment.name) and experiment[override_alternative(experiment.name)]
         ret = override_alternative(experiment.name)
         ab_user[experiment.key] = ret if Split.configuration.store_override
       elsif experiment.has_winner?

data/lib/split/metric.rb

@@ -42,6 +42,25 @@ module Split
       metric
     end
 
+    def self.find_or_create(attrs)
+      metric = find(attrs[:name])
+      unless metric
+        metric = new(attrs)
+        metric.save
+      end
+      metric
+    end
+
+    def self.all
+      redis_metrics = Split.redis.hgetall(:metrics).collect do |key, value|
+        find(key)
+      end
+      configuration_metrics = Split.configuration.metrics.collect do |key, value|
+        new(name: key, experiments: value)
+      end
+      redis_metrics | configuration_metrics
+    end
+
     def self.possible_experiments(metric_name)
       experiments = []
       metric  = Split::Metric.find(metric_name)
@@ -78,4 +97,4 @@ module Split
       return metric_name, goals
     end
   end
-end
+end

data/lib/split/version.rb

@@ -1,6 +1,6 @@
 module Split
   MAJOR   = 0
   MINOR   = 7
-  PATCH   = 1
+  PATCH   = 2
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/spec/dashboard_helpers_spec.rb

@@ -19,7 +19,7 @@ describe Split::DashboardHelpers do
       confidence_level(2.00).should eql('95% confidence')
     end
 
-    it "should consider a z-score of z >= 2.58 as 95% confident" do
+    it "should consider a z-score of z >= 2.58 as 99% confident" do
       confidence_level(2.58).should eql('99% confidence')
       confidence_level(3.00).should eql('99% confidence')
     end

data/spec/dashboard_spec.rb

@@ -21,6 +21,10 @@ describe Split::Dashboard do
     Split::Experiment.find_or_create({"link_color" => ["goal_1", "goal_2"]}, "blue", "red")
   }
 
+  let(:metric) {
+    Split::Metric.find_or_create(name: 'testmetric', experiments: [experiment, experiment_with_goals])
+  }
+
   let(:red_link) { link("red") }
   let(:blue_link) { link("blue") }
 
@@ -43,6 +47,15 @@ describe Split::Dashboard do
         post "/start/#{experiment.name}"
         get '/'
         last_response.body.should include('Reset Data')
+        last_response.body.should_not include('Metrics:')
+      end
+    end
+
+    context "experiment with metrics" do
+      it "should display the names of associated metrics" do
+        metric
+        get '/'
+        last_response.body.should include('Metrics:testmetric')
       end
     end
 

data/spec/helper_spec.rb

@@ -101,6 +101,12 @@ describe Split::Helper do
       alternative.should eql('red')
     end
 
+    it "should not allow an arbitrary alternative" do
+      @params = {'link_color' => 'pink'}
+      alternative = ab_test('link_color', 'blue')
+      alternative.should eql('blue')
+    end
+
     it "should not store the split when a param forced alternative" do
       @params = {'link_color' => 'blue'}
       ab_user.should_not_receive(:[]=)

metadata

@@ -1,139 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-20 00:00:00.000000000 Z
+date: 2014-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.1'
 - !ruby/object:Gem::Dependency
   name: redis-namespace
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.6
 - !ruby/object:Gem::Dependency
   name: simple-random
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.5.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.5.7
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -143,8 +143,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Appraisals
 - CHANGELOG.mdown
 - CONTRIBUTING.md
@@ -220,17 +220,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: split
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Rack based split testing framework