split 0.4.3 → 0.4.4

data/CHANGELOG.mdown

@@ -1,3 +1,14 @@
+## 0.4.4 (August 9, 2012)
+
+Features:
+
+  - Allow parameter overrides, even without Redis. (@bhcarpenter, #62)
+
+Bugfixes:
+
+  - Fixes version number always increasing when alternatives are changed (@philnash, #63)
+  - updated guard-rspec to version 1.2
+
 ## 0.4.3 (July 8, 2012)
 
 Features:

data/lib/split/configuration.rb

@@ -4,6 +4,7 @@ module Split
     attr_accessor :ignore_ip_addresses
     attr_accessor :db_failover
     attr_accessor :db_failover_on_db_error
+    attr_accessor :db_failover_allow_parameter_override
     attr_accessor :allow_multiple_experiments
     attr_accessor :enabled
 
@@ -12,8 +13,9 @@ module Split
       @ignore_ip_addresses = []
       @db_failover = false
       @db_failover_on_db_error = proc{|error|} # e.g. use Rails logger here
+      @db_failover_allow_parameter_override = false
       @allow_multiple_experiments = false
       @enabled = true
     end
   end
-end
+end

data/lib/split/experiment.rb

@@ -98,6 +98,9 @@ module Split
         Split.redis.sadd(:experiments, name)
         Split.redis.hset(:experiment_start_times, @name, Time.now)
         @alternatives.reverse.each {|a| Split.redis.lpush(name, a.name) }
+      else
+        Split.redis.del(name)
+        @alternatives.reverse.each {|a| Split.redis.lpush(name, a.name) }
       end
     end
 
@@ -137,10 +140,11 @@ module Split
       alts = initialize_alternatives(alternatives, name)
 
       if Split.redis.exists(name)
-        if load_alternatives_for(name) == alts.map(&:name)
+        existing_alternatives = load_alternatives_for(name)
+        if existing_alternatives == alts.map(&:name)
           experiment = self.new(name, *alternatives)
         else
-          exp = self.new(name, *load_alternatives_for(name))
+          exp = self.new(name, *existing_alternatives)
           exp.reset
           exp.alternatives.each(&:delete)
           experiment = self.new(name, *alternatives)

data/lib/split/helper.rb

@@ -118,7 +118,14 @@ module Split
       rescue => e
         raise unless Split.configuration.db_failover
         Split.configuration.db_failover_on_db_error.call(e)
-        ret = control_variable(control)
+        if Split.configuration.db_failover_allow_parameter_override
+          all_alternatives = *([control] + alternatives)
+          alternative_names = all_alternatives.map{|a| a.is_a?(Hash) ? a.keys : a}.flatten
+          ret = override(experiment_name, alternative_names)
+        end
+        unless ret
+          ret = control_variable(control)
+        end
       end
       ret
     end

data/lib/split/version.rb

@@ -1,3 +1,3 @@
 module Split
-  VERSION = "0.4.3"
+  VERSION = "0.4.4"
 end

data/spec/experiment_spec.rb

@@ -176,6 +176,15 @@ describe Split::Experiment do
       new_blue = Split::Alternative.new('blue', 'link_color')
       new_blue.participant_count.should eql(0)
     end
+
+    it "should only reset once" do
+      experiment = Split::Experiment.find_or_create('link_color', 'blue', 'red', 'green')
+      experiment.version.should eql(0)
+      same_experiment = Split::Experiment.find_or_create('link_color', 'blue', 'yellow', 'orange')
+      same_experiment.version.should eql(1)
+      same_experiment_again = Split::Experiment.find_or_create('link_color', 'blue', 'yellow', 'orange')
+      same_experiment_again.version.should eql(1)
+    end
   end
 
   describe 'alternatives passed as non-strings' do

data/spec/helper_spec.rb

@@ -410,6 +410,27 @@ describe Split::Helper do
             "shared/#{alternative}"
           end.should eq('shared/blue')
         end
+
+        context 'and db_failover_allow_parameter_override config option is turned on' do
+          before(:each) do
+            Split.configure do |config|
+              config.db_failover_allow_parameter_override = true
+            end
+          end
+
+          context 'and given an override parameter' do
+            it 'should use given override instead of the first alternative' do
+              @params = {'link_color' => 'red'}
+              ab_test('link_color', 'blue', 'red').should eq('red')
+              ab_test('link_color', 'blue', 'red', 'green').should eq('red')
+              ab_test('link_color', {'blue' => 0.01}, 'red' => 0.2).should eq('red')
+              ab_test('link_color', {'blue' => 0.8}, {'red' => 20}).should eq('red')
+              ab_test('link_color', 'blue', 'red') do |alternative|
+                "shared/#{alternative}"
+              end.should eq('shared/red')
+            end
+          end
+        end
       end
 
       describe 'finished' do

data/split.gemspec

@@ -26,5 +26,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'bundler',     '~> 1.0'
   s.add_development_dependency 'rspec',       '~> 2.6'
   s.add_development_dependency 'rack-test',   '~> 0.6'
-  s.add_development_dependency 'guard-rspec', '~> 0.4'
+  s.add_development_dependency 'guard-rspec', '~> 1.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-08 00:00:00.000000000 Z
+date: 2012-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &70320238811700 !ruby/object:Gem::Requirement
+  requirement: &70151613684420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '2.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70320238811700
+  version_requirements: *70151613684420
 - !ruby/object:Gem::Dependency
   name: redis-namespace
-  requirement: &70320238804560 !ruby/object:Gem::Requirement
+  requirement: &70151613683840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 1.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *70320238804560
+  version_requirements: *70151613683840
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &70320238803180 !ruby/object:Gem::Requirement
+  requirement: &70151613683320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: 1.2.6
   type: :runtime
   prerelease: false
-  version_requirements: *70320238803180
+  version_requirements: *70151613683320
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70320238802020 !ruby/object:Gem::Requirement
+  requirement: &70151613682760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70320238802020
+  version_requirements: *70151613682760
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70320238800860 !ruby/object:Gem::Requirement
+  requirement: &70151613695660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '1.0'
   type: :development
   prerelease: false
-  version_requirements: *70320238800860
+  version_requirements: *70151613695660
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70320238799240 !ruby/object:Gem::Requirement
+  requirement: &70151613695120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +76,10 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *70320238799240
+  version_requirements: *70151613695120
 - !ruby/object:Gem::Dependency
   name: rack-test
-  requirement: &70320238798220 !ruby/object:Gem::Requirement
+  requirement: &70151613694660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,18 +87,18 @@ dependencies:
         version: '0.6'
   type: :development
   prerelease: false
-  version_requirements: *70320238798220
+  version_requirements: *70151613694660
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &70320238797400 !ruby/object:Gem::Requirement
+  requirement: &70151613694080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '1.2'
   type: :development
   prerelease: false
-  version_requirements: *70320238797400
+  version_requirements: *70151613694080
 description: 
 email:
 - andrewnez@gmail.com