split 0.2.3 → 0.2.4

data/CHANGELOG.mdown

@@ -1,3 +1,13 @@
+## 0.2.4 (July 18, 2011)
+
+Features:
+
+  - Added option to finished to not reset the users session
+
+Bugfixes:
+
+  - Only allow strings as alternatives, fixes strange errors when passing true/false or symbols
+
 ## 0.2.3 (June 26, 2011)
 
 Features:

data/README.mdown

@@ -95,6 +95,8 @@ Example: Conversion tracking (in a view)
 
     Thanks for signing up, dude! <% finished("signup_page_redesign") >
 
+You can find more examples, tutorials and guides on the [wiki](https://github.com/andrew/split/wiki).
+
 ### Overriding alternatives
 
 For development and testing, you may wish to force your app to always return an alternative.
@@ -214,4 +216,4 @@ Tests can be ran with `rake spec`
 
 ## Copyright
 
-Copyright (c) 2011 Andrew Nesbitt. See LICENSE for details.
+Copyright (c) 2011 Andrew Nesbitt. See [LICENSE](https://github.com/andrew/split/blob/master/LICENSE) for details.

data/lib/split/experiment.rb

@@ -106,7 +106,10 @@ module Split
     end
 
     def self.find_or_create(key, *alternatives)
-      name = key.split(':')[0]
+      name = key.to_s.split(':')[0]
+
+      raise InvalidArgument, 'Alternatives must be strings' if alternatives.map(&:class).uniq != [String]
+
       if Split.redis.exists(name)
         if load_alternatives_for(name) == alternatives
           experiment = self.new(name, *load_alternatives_for(name))

data/lib/split/helper.rb

@@ -34,13 +34,13 @@ module Split
       end
     end
 
-    def finished(experiment_name)
+    def finished(experiment_name, options = {:reset => true})
       return if exclude_visitor?
       experiment = Split::Experiment.find(experiment_name)
       if alternative_name = ab_user[experiment.key]
         alternative = Split::Alternative.find(alternative_name, experiment_name)
         alternative.increment_completion
-        session[:split].delete(experiment_name)
+        session[:split].delete(experiment_name) if options[:reset]
       end
     end
 

data/lib/split/version.rb

@@ -1,3 +1,3 @@
 module Split
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

data/spec/dashboard_spec.rb

@@ -9,6 +9,8 @@ describe Split::Dashboard do
     @app ||= Split::Dashboard
   end
 
+  before(:each) { Split.redis.flushall }
+
   it "should respond to /" do
     get '/'
     last_response.should be_ok

data/spec/experiment_spec.rb

@@ -160,4 +160,11 @@ describe Split::Experiment do
       new_blue.participant_count.should eql(0)
     end
   end
+
+  describe 'alternatives passed as non-strings' do
+    it "should throw an exception if an alternative is passed that is not a string" do
+      lambda { Split::Experiment.find_or_create('link_color', :blue, :red) }.should raise_error
+      lambda { Split::Experiment.find_or_create('link_enabled', true, false) }.should raise_error
+    end
+  end
 end

data/spec/helper_spec.rb

@@ -83,6 +83,17 @@ describe Split::Helper do
       finished('link_color')
       session[:split].should == {}
     end
+
+    it "should not clear out the users session if reset is false" do
+      experiment = Split::Experiment.find_or_create('link_color', 'blue', 'red')
+      alternative_name = ab_test('link_color', 'blue', 'red')
+
+      previous_completion_count = Split::Alternative.find(alternative_name, 'link_color').completed_count
+
+      session[:split].should eql("link_color" => alternative_name)
+      finished('link_color', :reset => false)
+      session[:split].should eql("link_color" => alternative_name)
+    end
   end
   
   describe 'conversions' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: split
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 31
   prerelease: false
   segments: 
   - 0
   - 2
-  - 3
-  version: 0.2.3
+  - 4
+  version: 0.2.4
 platform: ruby
 authors: 
 - Andrew Nesbitt
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-26 00:00:00 +01:00
+date: 2011-07-18 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency