spinach 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5b707d1189dcf7e14b981a5c71720a2c5e15535c
-  data.tar.gz: c446d9797269a2a2ac125a6a38f13b4afa8573c8
+  metadata.gz: 83c66a61a7a2acb9a68481350f9eb89d95e48eec
+  data.tar.gz: 7e2f76bef3a0796aa342bb9bdd0f1589de02e678
 SHA512:
-  metadata.gz: 3cb1779c57669967a3996b12e99359af58029e0447614bc6b08e4d97b2ce9a38fa1b301cba09a27d6e71a51f6da8c45d742c91de1f3c3edc2782a1720afb0020
-  data.tar.gz: 56d2b4fa3ebf70c65e9d5b19306171cd0c6be991a62c234053b824f261287212aeaef3705c97a1e705602e3d2e7c4e6972cb1013a4404798bc2ed29eb3f37895
+  metadata.gz: 68e0b156aa56a28d06cae2585f6504fda3648ea943db9fb5ccc33ecf5afc2ab9e2be16cd55187f0bc18febd3ab147d25263a7a2130d82c576696ff8b441c09ef
+  data.tar.gz: fdd2eec1dc6d73374f6bbbb7c6b8610c0f73d56cb3110c8e01fb2cf60a46a912a506c09a0abb03173dccb9011b68842691cfc50b240eca9e223370e9d1fb8e16

data/.gitignore

@@ -17,3 +17,4 @@ test/version_tmp
 tmp
 capybara-*.html
 Gemfile.lock
+tags

data/.ruby-version

@@ -1 +1 @@
-2.0.0
+2.0.0-p0

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+== 0.8.3
+* Add ```--fail-fast``` option. When specified, the suite will terminate after the first failed scenario
+
 == 0.8.2
 * upgrade to gherkin-ruby 0.3 in order to avoid naming conflicts when using at
 the same time spinach & cucumber (transitioning)
@@ -51,4 +54,4 @@ the same time spinach & cucumber (transitioning)
   * Add docs on how to use shared steps.
 
 * deprecations
-  * Nothing
+  * Nothing

data/Gemfile

@@ -4,6 +4,7 @@ source 'http://rubygems.org'
 gemspec
 
 gem 'rake'
+gem 'coveralls', require: false
 
 group :test do
   gem 'guard'

data/README.markdown

@@ -1,4 +1,8 @@
-# Spinach - BDD framework on top of Gherkin [![Build Status](https://secure.travis-ci.org/codegram/spinach.png)](http://travis-ci.org/codegram/spinach) [![Dependency Status](https://gemnasium.com/codegram/spinach.png)](http://gemnasium.com/codegram/spinach)
+# Spinach - BDD framework on top of Gherkin 
+[![Gem Version](https://badge.fury.io/rb/spinach.png)](http://badge.fury.io/rb/spinach)
+[![Build Status](https://secure.travis-ci.org/codegram/spinach.png)](http://travis-ci.org/codegram/spinach) 
+[![Dependency Status](https://gemnasium.com/codegram/spinach.png)](http://gemnasium.com/codegram/spinach)
+[![Coverage Status](https://coveralls.io/repos/codegram/spinach/badge.png?branch=master)](https://coveralls.io/r/codegram/spinach)
 
 Spinach is a high-level BDD framework that leverages the expressive
 [Gherkin language][gherkin] (used by [Cucumber][cucumber]) to help you define
@@ -12,8 +16,7 @@ Conceived as an alternative to Cucumber, here are some of its design goals:
 * Step reusability: In case you want to reuse steps across features, you can
   always wrap those in plain ol' Ruby modules.
 
-Spinach is tested against **MRI 1.9.3 and 2.0.0**. Rubinius 2.0 support 
-is on the works.
+Spinach is tested against **MRI 1.9.3 and 2.0.0**.
 
 We are not planning to make it compatible with MRI 1.8.7 since, you know, this
 would be irresponsible :)
@@ -162,6 +165,8 @@ This is one way to make that reusable:
 # ... features/steps/common_steps/login.rb
 module CommonSteps
   module Login
+    include Spinach::DSL
+    
     step 'I am logged in' do
       # log in stuff...
     end
@@ -349,3 +354,7 @@ You can easily contribute to Spinach. Its codebase is simple and
 ## License
 
 MIT License. Copyright 2011 [Codegram Technologies](http://codegram.com)
+
+
+[![Bitdeli Badge](https://d2weczhvl823v0.cloudfront.net/codegram/spinach/trend.png)](https://bitdeli.com/free "Bitdeli Badge")
+

data/features/fail_fast.feature

@@ -0,0 +1,10 @@
+Feature: Fail fast option
+  In order to save running time
+  As a developer
+  I want spinach to fail fast when I so desire
+
+  Scenario: fail fast
+    Given I have a feature that has a failure
+    And I have a feature that has no error or failure
+    When I run both of them with fail-fast option
+    Then the tests stop at the first one

data/features/steps/exit_status.rb

@@ -5,36 +5,11 @@ class ExitStatus < Spinach::FeatureSteps
   include Integration::SpinachRunner
 
   Given "I have a feature that has no error or failure" do
-    write_file('features/success_feature.feature', """
-Feature: A success feature
-
-  Scenario: This is scenario will succeed
-    Then I succeed
-""")
-    write_file('features/steps/success_feature.rb',
-    'class ASuccessFeature < Spinach::FeatureSteps
-      feature "A success feature"
-      Then "I succeed" do
-      end
-     end')
-    @feature = "features/success_feature.feature"
+    @feature = Integration::FeatureGenerator.success_feature
   end
 
   Given "I have a feature that has a failure" do
-    write_file('features/failure_feature.feature', """
-Feature: A failure feature
-
-  Scenario: This is scenario will fail
-    Then I fail
-""")
-    write_file('features/steps/failure_feature.rb',
-    'class AFailureFeature < Spinach::FeatureSteps
-      feature "A failure feature"
-      Then "I fail" do
-        true.must_equal false
-      end
-     end')
-    @feature = "features/failure_feature.feature"
+    @feature = Integration::FeatureGenerator.failure_feature
   end
 
   When "I run it" do

data/features/steps/fail_fast_option.rb

@@ -0,0 +1,21 @@
+class Spinach::Features::FailFastOption < Spinach::FeatureSteps
+  include Integration::SpinachRunner
+
+  step 'I have a feature that has a failure' do
+    @features ||= []
+    @features << Integration::FeatureGenerator.failure_feature_with_two_scenarios
+  end
+
+  step 'I have a feature that has no error or failure' do
+    @features ||= []
+    @features << Integration::FeatureGenerator.success_feature
+  end
+
+  step 'I run both of them with fail-fast option' do
+    run_feature @features.join(" "), append: '--fail-fast'
+  end
+
+  step 'the tests stop at the first one' do
+    @stdout.must_match("(0) Successful")
+  end
+end

data/features/steps/rspec_compatibility.rb

@@ -29,8 +29,7 @@ Feature: Feature with failures
 
   Scenario: This scenario will fail
     Given true is false
-    Then remove all the files in my hard drive
-""")
+    Then remove all the files in my hard drive""")
 
     write_file('features/steps/failure_feature.rb',
                'class FeatureWithFailures < Spinach::FeatureSteps

data/features/support/env.rb

@@ -1,6 +1,20 @@
 require 'minitest/spec'
 require_relative 'filesystem'
 
+require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+if ENV['CI']
+  require 'simplecov'
+
+  SimpleCov.start do
+    add_filter '/test/'
+    add_filter '/features/'
+  end
+end
+
+
 Spinach.hooks.after_run do |scenario|
   FileUtils.rm_rf(Filesystem.dirs)
 end

data/features/support/feature_generator.rb

@@ -0,0 +1,115 @@
+module Integration
+  class FeatureGenerator
+    class << self
+      include Filesystem
+
+      # Generate a feature with 1 scenario that should pass
+      #
+      # @return feature_filename
+      #   The feature file name
+      #
+      # @api private
+      def success_feature
+        feature= success_scenario_title + success_scenario
+        steps = success_step_class_str + success_step + "\nend"
+        write_feature 'features/success_feature.feature', feature,
+          'features/steps/success_feature.rb', steps
+      end
+
+      # Generate a feature that has 2 scenarios. The first one should
+      # pass and the second one should fail
+      #
+      # @return feature_filename
+      #   The feature file name
+      #
+      # @api private
+      def failure_feature_with_two_scenarios
+        feature = failure_feature_title + failure_sceario + success_scenario
+        steps = failure_step + success_step + "\nend"
+        write_feature failure_filename, feature,
+          failure_step_filename, steps
+      end
+
+      # Generate a feature with 1 scenario that should fail
+      #
+      # @return feature_filename
+      #   The feature file name
+      #
+      # @api private
+      def failure_feature
+        feature = failure_feature_title + failure_sceario
+        write_feature failure_filename, feature,
+          failure_step_filename, failure_step + "\nend"
+      end
+
+      private
+
+      # Write feature file and its associated step file
+      # @param feature_file
+      #   The name of the feature file to be written to
+      # @param feature
+      #   The string to be written into the feature file
+      # @param step_file
+      #   The name of the step ruby file to be written to
+      # @param steps
+      #   The string to be written into the step file
+      #
+      # @return feature_filename
+      #   The feature file name
+      #
+      # @api private
+      def write_feature(feature_file, feature, step_file, steps)
+        write_file(feature_file, feature)
+        write_file(step_file, steps)
+        feature_file
+      end
+
+      def failure_step
+        'class AFailureFeature < Spinach::FeatureSteps
+      feature "A failure feature"
+      Then "I fail" do
+        true.must_equal false
+      end'
+      end
+
+      def success_scenario
+        'Scenario: This is scenario will succeed
+    Then I succeed'
+      end
+
+      def success_scenario_title
+        "Feature: A success feature\n\n"
+      end
+
+      def success_step
+        '
+      step "I succeed" do
+      end'
+      end
+
+      def success_step_class_str
+        %Q|class ASuccessFeature < Spinach::FeatureSteps
+        feature "A success feature"\n\n|
+      end
+
+      def failure_step_filename
+        'features/steps/failure_feature.rb'
+      end
+
+      def failure_filename
+        "features/failure_feature.feature"
+      end
+
+      def failure_feature_title
+        "Feature: A failure feature\n\n"
+      end
+
+      def failure_sceario
+        """
+  Scenario: This is scenario will fail
+    Then I fail
+        """
+      end
+    end
+  end
+end

data/lib/spinach/capybara.rb

@@ -1,6 +1,7 @@
 require 'capybara'
 require 'capybara/dsl'
 require 'rbconfig'
+require 'spinach/config'
 require_relative 'feature_steps'
 
 module Spinach
@@ -59,7 +60,7 @@ module Spinach
 end
 
 Spinach.hooks.after_scenario do
-  ::Capybara.current_session.reset! if ::Capybara.app
+  ::Capybara.reset_sessions! if ::Capybara.app
   ::Capybara.use_default_driver
 end
 

data/lib/spinach/cli.rb

@@ -126,6 +126,11 @@ module Spinach
                   'Formatter class name') do |class_name|
             config[:reporter_class] = reporter_class(class_name)
           end
+
+          opts.on_tail('--fail-fast',
+                       'Terminate the suite run on the first failure') do |class_name|
+            config[:fail_fast] = true
+          end
         end.parse!(@args)
 
         Spinach.config.parse_from_file

data/lib/spinach/config.rb

@@ -32,7 +32,8 @@ module Spinach
                 :generate,
                 :save_and_open_page_on_failure,
                 :reporter_class,
-                :reporter_options
+                :reporter_options,
+                :fail_fast
 
 
     # The "features path" holds the place where your features will be
@@ -131,6 +132,17 @@ module Spinach
       @failure_exceptions ||= []
     end
 
+    # The "fail_fast" determines if the suite run should exit
+    # when encountering a failure/error
+    #
+    # @return [true/false]
+    #    The fail_fast flag.
+    #
+    # @api public
+    def fail_fast
+      @fail_fast
+    end
+
     # It allows you to set a config file to parse for all the other options to be set
     #
     # @return [String]

data/lib/spinach/hooks.rb

@@ -83,7 +83,7 @@ module Spinach
     # Runs after every step execution
     #
     # @example
-    #   Spinach.hooks.before_step do |step_data, step_definitions|
+    #   Spinach.hooks.after_step do |step_data, step_definitions|
     #     # step_data contains a hash with this step's data
     #   end
     hook :after_step

data/lib/spinach/runner.rb

@@ -75,6 +75,7 @@ module Spinach
         feature = Parser.open_file(filename).parse
         success = FeatureRunner.new(feature, line).run
         successful = false unless success
+        break if fail_fast? && !successful
       end
 
       Spinach.hooks.run_after_run(successful)
@@ -133,6 +134,12 @@ module Spinach
     def required_files
       support_files + step_definition_files
     end
+
+    private
+
+    def fail_fast?
+      Spinach.config.fail_fast
+    end
   end
 end
 

data/lib/spinach/runner/feature_runner.rb

@@ -68,6 +68,7 @@ module Spinach
           if run_scenario?(scenario, current_scenario_index)
             success = ScenarioRunner.new(scenario).run
             @failed = true unless success
+            break if Spinach.config.fail_fast && @failed
           end
         end
       end

data/lib/spinach/version.rb

@@ -1,4 +1,4 @@
 module Spinach
   # Spinach version.
-  VERSION = "0.8.2"
+  VERSION = "0.8.3"
 end

data/spinach.gemspec

@@ -19,7 +19,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'simplecov'
   gem.add_development_dependency 'rspec'
   gem.add_development_dependency 'minitest'
-  gem.add_development_dependency 'turn'
 
   gem.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   gem.files         = `git ls-files`.split("\n")

data/test/spinach/cli_test.rb

@@ -21,6 +21,14 @@ describe Spinach::Cli do
       config[:reporter_options].must_equal({})
     end
 
+    it 'sets the default fail-fast option to false' do
+      config = Spinach::Config.new
+      Spinach.stubs(:config).returns(config)
+      cli = Spinach::Cli.new([])
+      cli.options
+      config[:fail_fast].wont_equal(true)
+    end
+
     it 'sets default tags' do
       config = Spinach::Config.new
       Spinach.stubs(:config).returns(config)
@@ -154,6 +162,15 @@ tags:
       end
     end
 
+    describe 'fail-fast' do
+      it 'set the fail_fast flag, given "--fail-fast"' do
+        config = Spinach::Config.new
+        Spinach.stubs(:config).returns(config)
+        Spinach::Cli.new(["--fail-fast"]).options
+        config.fail_fast.must_equal true
+      end
+    end
+
     describe "version" do
       %w{-v --version}.each do |opt|
         it "outputs the version" do
@@ -256,7 +273,7 @@ tags:
 
           File.stubs(:directory?).returns(true)
           Dir.expects(:glob).with('path/to/features/**/*.feature')
-            .returns(['several features'])
+          .returns(['several features'])
 
           File.stubs(:exists?).returns(true)
 

data/test/spinach/runner/feature_runner_test.rb

@@ -70,6 +70,22 @@ describe Spinach::Runner::FeatureRunner do
 
           @runner.run.must_equal false
         end
+
+        describe "with config option fail_fast set" do
+          let(:runners) { [ stub('runner1', run: false), stub('runner2') ] }
+
+          before(:each) do
+            Spinach.config.stubs(:fail_fast).returns(true)
+            @scenarios.each_with_index do |scenario, i|
+              Spinach::Runner::ScenarioRunner.stubs(:new).with(scenario).returns runners[i]
+            end
+          end
+
+          it "breaks with fail_fast config option" do
+            runners[1].expects(:run).never
+            @runner.run.must_equal(false)
+          end
+        end
       end
     end
 

data/test/spinach/runner/scenario_runner_test.rb

@@ -43,7 +43,7 @@ module Spinach
             step_definitions.stubs(:before_each)
             step_definitions.stubs(:after_each)
           end
-          
+
           it 'runs hooks in order' do
             hooks = sequence('hooks')
 

data/test/spinach/runner_test.rb

@@ -72,12 +72,12 @@ describe Spinach::Runner do
   end
 
   describe '#run' do
-    before do
+    before(:each) do
       @feature_runner = stub
       filenames.each do |filename|
-        Spinach::Parser.expects(:open_file).with(filename).returns parser = stub
+        Spinach::Parser.stubs(:open_file).with(filename).returns parser = stub
         parser.stubs(:parse).returns feature = stub
-        Spinach::Runner::FeatureRunner.expects(:new).
+        Spinach::Runner::FeatureRunner.stubs(:new).
           with(feature, anything).
           returns(@feature_runner)
       end
@@ -100,6 +100,35 @@ describe Spinach::Runner do
       @feature_runner.stubs(:run).returns(false)
       runner.run.must_equal false
     end
+
+    describe "when fail_fast set" do
+      let(:feature_runners) { [ stub, stub ] }
+
+      before(:each) do
+        filenames.each_with_index do |filename, i|
+          Spinach::Parser.stubs(:open_file).with(filename).returns parser = stub
+          parser.stubs(:parse).returns feature = stub
+          Spinach::Runner::FeatureRunner.stubs(:new).
+            with(feature, anything).
+            returns(feature_runners[i])
+        end
+
+        feature_runners[0].stubs(:run).returns(false)
+        runner.stubs(required_files: [])
+        Spinach.config.stubs(:fail_fast).returns true
+      end
+
+      it "breaks with a failure" do
+        feature_runners[1].expects(:run).never
+        runner.run.must_equal false
+      end
+
+      it "doesn't break when success" do
+        feature_runners[0].stubs(:run).returns(true)
+        feature_runners[1].expects(:run).returns true
+        runner.run.must_equal true
+      end
+    end
   end
 
   describe '#require_dependencies' do

data/test/test_helper.rb

@@ -1,6 +1,8 @@
-gem 'minitest'
+require 'simplecov'
+require 'coveralls'
 
-if ENV['COVERAGE']
+SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+if ENV['CI']
   require 'simplecov'
 
   SimpleCov.start do
@@ -9,13 +11,12 @@ if ENV['COVERAGE']
   end
 end
 
-require 'minitest/spec'
 require 'minitest/autorun'
+require 'minitest/spec'
 require 'mocha/setup'
 require 'ostruct'
 require 'stringio'
 require 'pry'
-require 'turn'
 
 require 'spinach'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spinach
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Josep Jaume Rey
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-19 00:00:00.000000000 Z
+date: 2013-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin-ruby
@@ -153,20 +153,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: turn
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Spinach is a BDD framework on top of gherkin
 email:
 - info@codegram.com
@@ -195,6 +181,7 @@ files:
 - features/before_and_after_hooks.feature
 - features/before_and_after_hooks_inheritance.feature
 - features/exit_status.feature
+- features/fail_fast.feature
 - features/feature_name_guessing.feature
 - features/reporting/customized_reporter.feature
 - features/reporting/display_run_summary.feature
@@ -208,6 +195,7 @@ files:
 - features/steps/before_and_after_hooks.rb
 - features/steps/before_and_after_hooks_inheritance.rb
 - features/steps/exit_status.rb
+- features/steps/fail_fast_option.rb
 - features/steps/feature_name_guessing.rb
 - features/steps/reporting/display_run_summary.rb
 - features/steps/reporting/error_reporting.rb
@@ -218,6 +206,7 @@ files:
 - features/steps/rspec_compatibility.rb
 - features/support/env.rb
 - features/support/error_reporting.rb
+- features/support/feature_generator.rb
 - features/support/filesystem.rb
 - features/support/spinach_runner.rb
 - lib/spinach.rb
@@ -311,6 +300,7 @@ test_files:
 - features/before_and_after_hooks.feature
 - features/before_and_after_hooks_inheritance.feature
 - features/exit_status.feature
+- features/fail_fast.feature
 - features/feature_name_guessing.feature
 - features/reporting/customized_reporter.feature
 - features/reporting/display_run_summary.feature
@@ -324,6 +314,7 @@ test_files:
 - features/steps/before_and_after_hooks.rb
 - features/steps/before_and_after_hooks_inheritance.rb
 - features/steps/exit_status.rb
+- features/steps/fail_fast_option.rb
 - features/steps/feature_name_guessing.rb
 - features/steps/reporting/display_run_summary.rb
 - features/steps/reporting/error_reporting.rb
@@ -334,6 +325,7 @@ test_files:
 - features/steps/rspec_compatibility.rb
 - features/support/env.rb
 - features/support/error_reporting.rb
+- features/support/feature_generator.rb
 - features/support/filesystem.rb
 - features/support/spinach_runner.rb
 - test/spinach/background_test.rb
@@ -365,4 +357,3 @@ test_files:
 - test/spinach_test.rb
 - test/support/filesystem.rb
 - test/test_helper.rb
-has_rdoc: