spinach 0.1.1 → 0.1.2

data/Gemfile

@@ -6,7 +6,6 @@ gemspec
 group :test do
   gem 'guard'
   gem 'guard-minitest'
-  gem 'pry', git: 'git://github.com/pry/pry.git'
 end
 
 group :darwin do

data/features/reporting/show_step_source_location.feature

@@ -0,0 +1,14 @@
+Feature: Show step source location
+  As a developer
+  I want spinach to give me every step source location in output
+  So I can easyly know where I defined a step
+
+  Scenario: Show class steps source location in output
+    Given I have a feature that has no error or failure
+    When I run it
+    Then I should see the source location of each step of every scenario
+
+  Scenario: Show in output the source location of external modules steps
+    Given I have a feature that has no error or failure and use external steps
+    When I run it
+    Then I should see the source location of each step, even external ones

data/features/reporting/undefined_feature_reporting.feature

@@ -0,0 +1,9 @@
+Feature: Undefined feature reporting
+  In order to be aware of what features I've still not defined
+  As a developer
+  I want spinach to tell me which of them I'm missing
+
+  Scenario: Undefined feature
+    Given I've written a feature but not its steps
+    When I run spinach
+    Then I should see a message telling me that there's an undefined feature

data/features/steps/reporting/show_step_source_location.rb

@@ -0,0 +1,57 @@
+require 'aruba/api'
+
+Feature "Show step source location" do
+  include Integration::SpinachRunner
+
+  Given "I have a feature that has no error or failure" do
+    write_file('features/success_feature.feature',
+     'Feature: A success feature
+
+      Scenario: This is scenario will succeed
+        Then I succeed
+     ')
+    write_file('features/steps/success_feature.rb',
+    'Feature "A success feature" do
+      Then "I succeed" do
+      end
+     end')
+    @feature = "features/success_feature.feature"
+  end
+
+  When "I run it" do
+    run_feature @feature
+  end
+
+  Then "I should see the source location of each step of every scenario" do
+    all_stdout.must_match(
+      /I succeed.*features\/steps\/success_feature\.rb.*2/
+    )
+  end
+
+  Given "I have a feature that has no error or failure and use external steps" do
+    write_file('features/success_feature.feature',
+     'Feature: A feature that uses external steps
+
+      Scenario: This is scenario will succeed
+        Given this is a external step
+     ')
+    write_file('features/steps/success_feature.rb',
+    'Feature "A feature that uses external steps" do
+      include ExternalSteps
+     end')
+    write_file('features/support/external_steps.rb',
+    'module ExternalSteps
+      include Spinach::DSL
+      Given "this is a external step" do
+      end
+    end')
+    @feature = "features/success_feature.feature"
+  end
+
+  Then "I should see the source location of each step, even external ones" do
+    all_stdout.must_match(
+      /this is a external step.*features\/support\/external_steps\.rb.*3/
+    )
+  end
+end
+

data/features/steps/reporting/undefined_feature_reporting.rb

@@ -0,0 +1,21 @@
+Feature "Undefined feature reporting" do
+  include Integration::SpinachRunner
+
+  Given "I've written a feature but not its steps" do
+    write_file('features/feature_without_steps.feature',
+               'Feature: Feature without steps
+
+                Scenario: A scenario without steps
+                  Given I have no steps
+                  Then I should do nothing
+               ')
+  end
+
+  When "I run spinach" do
+    run_feature 'features/feature_without_steps.feature'
+  end
+
+  Then "I should see a message telling me that there's an undefined feature" do
+    all_stderr.must_match /Undefined features.*1/
+  end
+end

data/features/support/spinach_runner.rb

@@ -6,11 +6,14 @@ module Integration
 
     def self.included(base)
       base.class_eval do
-        before do
+        before_scenario do
           in_current_dir do
             FileUtils.rmdir('features')
           end
         end
+        before do
+          @aruba_timeout_seconds = 6
+        end
       end
     end
 

data/lib/spinach/dsl.rb

@@ -47,7 +47,7 @@ module Spinach
       #
       # @api public
       def Given(step, &block)
-        define_method(step, &block)
+        define_method(Spinach::Support.underscore(step), &block)
       end
 
       alias_method :When, :Given
@@ -84,11 +84,15 @@ module Spinach
       #
       # @api public
       def execute_step(step)
+        step = Spinach::Support.underscore(step)
+        location = nil
         if self.respond_to?(step)
+          location = method(step).source_location
           self.send(step)
         else
           raise Spinach::StepNotDefinedException.new(self, step)
         end
+        location
       end
 
       # @return [String]

data/lib/spinach/exceptions.rb

@@ -16,15 +16,10 @@ module Spinach
     #
     # @api public
     def message
-      [%Q{Could not find steps for `#{@feature}` feature.
-      Please create the file #{Spinach::Support.underscore(@missing_class)}.rb
-      at #{Spinach.config[:step_definitions_path]}, with:}.gsub(/^\s{6,7}/, ''),
-      %Q{class #{@missing_class} << Spinach::FeatureSteps
-         #
-         # define your steps here
-         #
-      end}.gsub(/^\s{6,7}/, '')].join("\n\n").red
+      "Could not find steps for `#{@feature}` feature"
     end
+
+    attr_reader :missing_class
   end
 
   # This class represents the exception raised when Spinach can't find a step

data/lib/spinach/reporter/stdout.rb

@@ -22,6 +22,7 @@ module Spinach
         super(*args)
         @out = options[:output] || $stdout
         @error = options[:error] || $stderr
+        @max_step_name_length = 0
       end
 
       # Prints the feature name to the standard output
@@ -40,9 +41,9 @@ module Spinach
       #   The feature in a JSON Gherkin format
       #
       def before_scenario_run(data)
+        @max_step_name_length = data['steps'].map{|step| step['name'].length}.max if data['steps']
         name = data['name']
         out.puts "\n  #{'Scenario:'.green} #{name.light_green}"
-        out.puts
       end
 
       # Adds an error report and re
@@ -62,8 +63,8 @@ module Spinach
       # @param [Hash] step
       #   The step in a JSON Gherkin format
       #
-      def on_successful_step(step)
-        output_step('✔', step, :green)
+      def on_successful_step(step, step_location)
+        output_step('✔', step, :green, step_location)
       end
 
       # Adds a failing step to the output buffer.
@@ -74,8 +75,8 @@ module Spinach
       # @param [Exception] failure
       #   The exception that caused the failure
       #
-      def on_failed_step(step, failure)
-        output_step('✘', step, :red)
+      def on_failed_step(step, failure, step_location)
+        output_step('✘', step, :red, step_location)
         self.scenario_error = [current_feature, current_scenario, step, failure]
         failed_steps << scenario_error
       end
@@ -88,8 +89,8 @@ module Spinach
       # @param [Exception] failure
       #   The exception that caused the failure
       #
-      def on_error_step(step, failure)
-        output_step('!', step, :red)
+      def on_error_step(step, failure, step_location)
+        output_step('!', step, :red, step_location)
         self.scenario_error = [current_feature, current_scenario, step, failure]
         error_steps << scenario_error
       end
@@ -99,12 +100,41 @@ module Spinach
       # @param [Hash] step
       #   The step in a JSON Gherkin format
       #
-      def on_undefined_step(step)
+      def on_undefined_step(step, failure)
         output_step('?', step, :yellow)
         self.scenario_error = [current_feature, current_scenario, step]
         undefined_steps << scenario_error
       end
 
+      # Adds a feature not found message to the output buffer.
+      #
+      # @param [Hash] feature
+      #   the feature in a json gherkin format
+      #
+      # @param [Spinach::FeatureNotFoundException] exception
+      #   the related exception
+      #
+      def on_feature_not_found(feature, exception)
+        lines = "#{exception.message}\n"
+
+        lines << "\nPlease create the file #{Spinach::Support.underscore(exception.missing_class)}.rb at #{Spinach.config[:step_definitions_path]}, with:\n\n"
+
+        lines << "Feature '#{feature['name']}' do\n"
+
+        # TODO: Write the actual steps. We can do this since we have the entire
+        # feature just here. We should iterate over all the scenarios and return
+        # the different steps
+        #
+        lines << "  # Write your steps here"
+        lines << "end\n\n"
+
+        lines.split("\n").each do |line|
+          out.puts "    #{line}".yellow
+        end
+
+        undefined_features << feature
+      end
+
       # Adds a step that has been skipped to the output buffer.
       #
       # @param [Hash] step
@@ -126,8 +156,14 @@ module Spinach
       # @param [Symbol] color
       #   The color code to use with Colorize to colorize the output.
       #
-      def output_step(symbol, step, color)
-        out.puts "    #{symbol.colorize(:"light_#{color}")}  #{step['keyword'].strip.colorize(:"light_#{color}")} #{step['name'].strip.colorize(color)}"
+      # @param [Array] step_location
+      #   step source location and file line
+      #
+      def output_step(symbol, step, color, step_location = nil)
+        step_location = step_location.first.gsub("#{File.expand_path('.')}/", '# ')+":#{step_location.last.to_s}" if step_location
+        max_length = @max_step_name_length + 60 # Colorize and output format correction
+        # REMEMBER TO CORRECT PREVIOUS MAX LENGTH IF OUTPUT FORMAT IS MODIFIED
+        out.puts "    #{symbol.colorize(:"light_#{color}")}  #{step['keyword'].strip.colorize(:"light_#{color}")} #{step['name'].strip.colorize(color)} ".ljust(max_length) + step_location.to_s.colorize(:grey)
       end
 
       # It prints the error summary if the run has failed
@@ -145,6 +181,7 @@ module Spinach
         error.puts "\nError summary:\n"
         report_error_steps
         report_failed_steps
+        report_undefined_features
         report_undefined_steps
       end
 
@@ -166,6 +203,15 @@ module Spinach
         report_errors('Undefined steps', undefined_steps, :yellow) if undefined_steps.any?
       end
 
+      def report_undefined_features
+        if undefined_features.any?
+          error.puts "  Undefined features (#{undefined_features.length})".light_yellow
+          undefined_features.each do |feature|
+            error.puts "    #{feature['name']}".yellow
+          end
+        end
+      end
+
       # Prints the error for a given set of steps
       #
       # @param [String] banner
@@ -178,7 +224,7 @@ module Spinach
       #   The color code to use with Colorize to colorize the output.
       #
       def report_errors(banner, steps, color)
-        error.puts "#{banner} (#{steps.length})".colorize(color)
+        error.puts "  #{banner} (#{steps.length})".colorize(color)
         steps.each do |error|
           report_error error
         end
@@ -218,7 +264,7 @@ module Spinach
       #
       def summarized_error(error)
         feature, scenario, step, exception = error
-        summary = "  #{feature['name']} :: #{scenario['name']} :: #{full_step step}"
+        summary = "    #{feature['name']} :: #{scenario['name']} :: #{full_step step}"
         if exception.kind_of?(Spinach::StepNotDefinedException)
           summary.yellow
         else

data/lib/spinach/reporter.rb

@@ -10,6 +10,7 @@ module Spinach
     def initialize(options = {})
       @errors = []
       @options = options
+      @undefined_features = []
       @undefined_steps = []
       @failed_steps = []
       @error_steps = []
@@ -21,15 +22,17 @@ module Spinach
 
     attr_accessor :current_feature, :current_scenario
 
-    attr_reader :undefined_steps, :failed_steps, :error_steps
+    attr_reader :undefined_steps, :failed_steps, :error_steps, :undefined_features
 
     def bind
       runner.after_run method(:after_run)
       feature_runner.before_run method(:before_feature_run)
       feature_runner.after_run method(:after_feature_run)
+      feature_runner.when_not_found method(:on_feature_not_found)
       scenario_runner.before_run method(:before_scenario_run)
       scenario_runner.after_run method(:after_scenario_run)
       scenario_runner.on_successful_step method(:on_successful_step)
+      scenario_runner.on_undefined_step method(:on_undefined_step)
       scenario_runner.on_failed_step method(:on_failed_step)
       scenario_runner.on_error_step method(:on_error_step)
       scenario_runner.on_skipped_step method(:on_skipped_step)
@@ -47,6 +50,7 @@ module Spinach
     def after_run(*args); end;
     def before_feature_run(*args); end
     def after_feature_run(*args); end
+    def on_feature_not_found(*args); end
     def before_scenario_run(*args); end
     def after_scenario_run(*args); end
     def on_successful_step(*args); end;

data/lib/spinach/runner/feature.rb

@@ -15,6 +15,7 @@ module Spinach
 
       define_hook :before_run
       define_hook :after_run
+      define_hook :when_not_found
 
       # @param [String] filename
       #   path to the feature file. Scenario line could be passed to run just
@@ -81,6 +82,9 @@ module Spinach
         feature.run_hook :after, data
         run_hook :after_run, data
 
+      rescue Spinach::FeatureStepsNotFoundException => e
+        run_hook :when_not_found, data, e
+      ensure
         return !!@success
       end
     end

data/lib/spinach/runner/scenario.rb

@@ -44,17 +44,17 @@ module Spinach
           feature.run_hook :before_step, step
           unless @exception
             begin
-              feature.execute_step(step['name'])
-              run_hook :on_successful_step, step
+              step_location = feature.execute_step(step['name'])
+              run_hook :on_successful_step, step, step_location
             rescue *Spinach.config[:failure_exceptions] => e
               @exception = e
-              run_hook :on_failed_step, step, @exception
+              run_hook :on_failed_step, step, @exception, step_location
             rescue Spinach::StepNotDefinedException => e
               @exception = e
               run_hook :on_undefined_step, step, @exception
-            rescue StandardError => e
+            rescue Exception => e
               @exception = e
-              run_hook :on_error_step, step, @exception
+              run_hook :on_error_step, step, @exception, step_location
             end
           else
             run_hook :on_skipped_step, step

data/lib/spinach/version.rb

@@ -1,4 +1,4 @@
 module Spinach
-  # Spianch version.
-  VERSION = "0.1.1"
+  # Spinach version.
+  VERSION = "0.1.2"
 end

data/test/exceptions_test.rb

@@ -7,20 +7,7 @@ describe Spinach::FeatureStepsNotFoundException do
 
   describe 'message' do
     it 'tells the user that the steps could not be found' do
-      subject.message.must_include 'Could not find steps for `This feature does not exist` feature.'
-    end
-
-    it 'tells the user to create the file' do
-      subject.message.must_include 'Please create the file this_feature_does_not_exist.rb'
-    end
-
-    it 'tells the user where to create the file respecting the step definitions path' do
-      Spinach.config.stubs(:step_definitions_path).returns('my/path')
-      subject.message.must_include 'at my/path, with:'
-    end
-
-    it 'tells the user what to write in the file' do
-      subject.message.must_include 'class ThisFeatureDoesNotExist << Spinach::FeatureSteps'
+      subject.message.must_include 'Could not find steps for `This feature does not exist` feature'
     end
   end
 end

data/test/spinach/config_test.rb

@@ -1,45 +1,45 @@
 require_relative '../test_helper'
 
 describe Spinach::Config do
-  before do
-    @config = Spinach::Config.new
+  subject do
+    Spinach::Config.new
   end
 
   describe '#step_definitions_path' do
     it 'returns a default' do
-      @config[:step_definitions_path].must_be_kind_of String
+      subject[:step_definitions_path].must_be_kind_of String
     end
 
     it 'can be overwritten' do
-      @config[:step_definitions_path] = 'steps'
-      @config[:step_definitions_path].must_equal 'steps'
+      subject[:step_definitions_path] = 'steps'
+      subject[:step_definitions_path].must_equal 'steps'
     end
   end
 
   describe '#support_path' do
     it 'returns a default' do
-      @config[:support_path].must_be_kind_of String
+      subject[:support_path].must_be_kind_of String
     end
 
     it 'can be overwritten' do
-      @config[:support_path] = 'support'
-      @config[:support_path].must_equal 'support'
+      subject[:support_path] = 'support'
+      subject[:support_path].must_equal 'support'
     end
   end
 
   describe '#failure_exceptions' do
     it 'returns a default' do
-      @config[:failure_exceptions].must_be_kind_of Array
+      subject[:failure_exceptions].must_be_kind_of Array
     end
 
     it 'can be overwritten' do
-      @config[:failure_exceptions] = [1, 2, 3]
-      @config[:failure_exceptions].must_equal [1,2,3]
+      subject[:failure_exceptions] = [1, 2, 3]
+      subject[:failure_exceptions].must_equal [1,2,3]
     end
 
     it 'allows adding elements' do
-      @config[:failure_exceptions] << RuntimeError
-      @config[:failure_exceptions].must_include RuntimeError
+      subject[:failure_exceptions] << RuntimeError
+      subject[:failure_exceptions].must_include RuntimeError
     end
   end
 end

data/test/spinach/dsl_test.rb

@@ -10,11 +10,22 @@ describe Spinach::DSL do
   describe 'class methods' do
     describe '#When' do
       it 'defines a method with the step name' do
+        step_executed = false
+        @feature.When('I say goodbye') do
+          step_executed = true
+        end
+
+        @feature.new.execute_step('I say goodbye')
+        step_executed.must_equal true
+      end
+
+      it 'returns step source location' do
         @feature.When('I say goodbye') do
           'You say hello'
         end
 
-        @feature.new.send('I say goodbye').must_equal 'You say hello'
+        @feature.new.execute_step('I say goodbye').first.must_include '/dsl_test.rb'
+        @feature.new.execute_step('I say goodbye').last.must_be_kind_of Fixnum
       end
     end
 

data/test/spinach/reporter/stdout_test.rb

@@ -68,8 +68,9 @@ describe Spinach::Reporter::Stdout do
   end
 
   describe '#on_successful_step' do
+    let(:step_location){['error_step_location', 1]}
     it 'adds the step to the output buffer' do
-      @reporter.on_successful_step({'keyword' => 'Given', 'name' => 'I am too cool'})
+      @reporter.on_successful_step({'keyword' => 'Given', 'name' => 'I am too cool'}, step_location)
 
       @out.string.must_include '✔'
       @out.string.must_include 'Given'
@@ -79,9 +80,10 @@ describe Spinach::Reporter::Stdout do
 
   describe '#on_failed_step' do
     let(:step) { {'keyword' => 'Then', 'name' => 'I write failing steps'} }
+    let(:step_location){['error_step_location', 1]}
 
     it 'adds the step to the output buffer' do
-      @reporter.on_failed_step(step, anything)
+      @reporter.on_failed_step(step, anything, step_location)
 
       @out.string.must_include '✘'
       @out.string.must_include 'Then'
@@ -89,13 +91,13 @@ describe Spinach::Reporter::Stdout do
     end
 
     it 'sets the current scenario error' do
-      @reporter.on_failed_step(step, anything)
+      @reporter.on_failed_step(step, anything, step_location)
 
       @reporter.scenario_error.must_include step
     end
 
     it 'adds the step to the failing steps' do
-      @reporter.on_failed_step(step, anything)
+      @reporter.on_failed_step(step, anything, step_location)
 
       @reporter.failed_steps.last.must_include step
     end
@@ -103,9 +105,10 @@ describe Spinach::Reporter::Stdout do
 
   describe '#on_error_step' do
     let(:step) { {'keyword' => 'And', 'name' => 'I even make syntax errors'} }
+    let(:step_location){['error_step_location', 1]}
 
     it 'adds the step to the output buffer' do
-      @reporter.on_error_step(step, anything)
+      @reporter.on_error_step(step, anything, step_location)
 
       @out.string.must_include '!'
       @out.string.must_include 'And'
@@ -113,13 +116,13 @@ describe Spinach::Reporter::Stdout do
     end
 
     it 'sets the current scenario error' do
-      @reporter.on_error_step(step, anything)
+      @reporter.on_error_step(step, anything, step_location)
 
       @reporter.scenario_error.must_include step
     end
 
     it 'adds the step to the error steps' do
-      @reporter.on_error_step(step, anything)
+      @reporter.on_error_step(step, anything, step_location)
 
       @reporter.error_steps.last.must_include step
     end
@@ -129,7 +132,7 @@ describe Spinach::Reporter::Stdout do
     let(:step) { {'keyword' => 'When', 'name' => 'I forgot to write steps'} }
 
     it 'adds the step to the output buffer' do
-      @reporter.on_undefined_step(step)
+      @reporter.on_undefined_step(step, anything)
 
       @out.string.must_include '?'
       @out.string.must_include 'When'
@@ -137,18 +140,50 @@ describe Spinach::Reporter::Stdout do
     end
 
     it 'sets the current scenario error' do
-      @reporter.on_undefined_step(step)
+      @reporter.on_undefined_step(step, anything)
 
       @reporter.scenario_error.must_include step
     end
 
     it 'adds the step to the undefined steps' do
-      @reporter.on_undefined_step(step)
+      @reporter.on_undefined_step(step, anything)
 
       @reporter.undefined_steps.last.must_include step
     end
   end
 
+  describe "#on_feature_not_found" do
+    before do
+      @feature = {
+        'name' => 'This feature does not exist'
+      }
+      Spinach.config.stubs(:step_definitions_path).returns('my/path')
+      exception = stub(
+        message: "This is a \nmultiple line error message",
+        missing_class: "ThisFeatureDoesNotExist"
+      )
+      @reporter.on_feature_not_found(@feature, exception)
+    end
+    it "outputs a message" do
+      @out.string.must_include "this_feature_does_not_exist.rb"
+      @out.string.must_include "This is a"
+      @out.string.must_include "multiple line error message"
+      @reporter.undefined_features.must_include @feature
+    end
+
+    it 'tells the user to create the file' do
+      @out.string.must_include 'Please create the file this_feature_does_not_exist.rb'
+    end
+
+    it 'tells the user where to create the file respecting the step definitions path' do
+      @out.string.must_include 'at my/path, with:'
+    end
+
+    it 'tells the user what to write in the file' do
+      @out.string.must_include 'Feature \'This feature does not exist\' do'
+    end
+  end
+
   describe '#on_skipped_step' do
     it 'adds the step to the output buffer' do
       @reporter.on_skipped_step({'keyword' => 'Then', 'name' => 'some steps are not even called'})
@@ -191,6 +226,7 @@ describe Spinach::Reporter::Stdout do
       @reporter.expects(:report_error_steps).once
       @reporter.expects(:report_failed_steps).once
       @reporter.expects(:report_undefined_steps).once
+      @reporter.expects(:report_undefined_features).once
 
       @reporter.error_summary
 
@@ -258,6 +294,27 @@ describe Spinach::Reporter::Stdout do
     end
   end
 
+  describe '#report_undefined_features' do
+    describe 'when some features are undefined' do
+      it 'outputs the undefined features' do
+        @reporter.undefined_features << {'name' => 'Undefined feature name'}
+        @reporter.report_undefined_features
+
+        @error.string.must_include "Undefined features (1)"
+        @error.string.must_include "Undefined feature name"
+      end
+    end
+
+    describe 'when there are no undefined features' do
+      it 'does nothing' do
+        error = @error.string.dup
+        @reporter.report_undefined_steps
+
+        error.must_equal @error.string
+      end
+    end
+  end
+
   describe '#report_errors' do
     describe 'when some steps have raised an error' do
       it 'outputs a the banner with the number of steps given' do

data/test/spinach/reporter_test.rb

@@ -51,33 +51,45 @@ module Spinach
         @callback = mock
         @reporter.stubs(:method)
       end
+
       it "binds a callback after running all the suite" do
         @reporter.expects(:method).with(:after_run).returns(@callback)
         @reporter.runner.expects(:after_run).with(@callback)
         @reporter.bind
       end
+
       it "binds a callback before running every feature" do
         @reporter.expects(:method).with(:before_feature_run).returns(@callback)
         @reporter.feature_runner.expects(:before_run).with(@callback)
         @reporter.bind
       end
+
       it "binds a callback after running every feature" do
         @reporter.expects(:method).with(:after_feature_run).returns(@callback)
         @reporter.feature_runner.expects(:after_run).with(@callback)
         @reporter.bind
       end
+
+      it "binds a callback for not defined features" do
+        @reporter.expects(:method).with(:on_feature_not_found).returns(@callback)
+        @reporter.feature_runner.expects(:when_not_found).with(@callback)
+        @reporter.bind
+      end
+
       it "binds a callback before running every scenario" do
         @reporter.expects(:method).with(:before_scenario_run).returns(@callback)
         @reporter.scenario_runner.expects(:before_run).with(@callback)
         @reporter.bind
       end
+
       it "binds a callback after running every feature" do
         @reporter.expects(:method).with(:after_scenario_run).returns(@callback)
         @reporter.scenario_runner.expects(:after_run).with(@callback)
         @reporter.bind
       end
+
       describe "when running steps" do
-        %w{successful failed error skipped}.each do |type|
+        %w{successful failed error undefined skipped}.each do |type|
           it "binds a callback after running a #{type} step" do
             @reporter.expects(:method).with(:"on_#{type}_step").returns(@callback)
             @reporter.scenario_runner.expects(:"on_#{type}_step").with(@callback)
@@ -85,22 +97,26 @@ module Spinach
           end
         end
       end
+
       describe "binds the context methods" do
         it "binds the current feature setter" do
           @reporter.expects(:method).with(:current_feature=).returns(@callback)
           @reporter.feature_runner.expects(:before_run).with(@callback)
           @reporter.bind
         end
+
         it "binds the current feature clearer" do
           @reporter.expects(:method).with(:clear_current_feature).returns(@callback)
           @reporter.feature_runner.expects(:after_run).with(@callback)
           @reporter.bind
         end
+
         it "binds the current scenario setter" do
           @reporter.expects(:method).with(:current_scenario=).returns(@callback)
           @reporter.scenario_runner.expects(:before_run).with(@callback)
           @reporter.bind
         end
+
         it "binds the current feature clearer" do
           @reporter.expects(:method).with(:clear_current_scenario).returns(@callback)
           @reporter.scenario_runner.expects(:after_run).with(@callback)
@@ -131,11 +147,13 @@ module Spinach
           @reporter.feature_runner.must_be_kind_of Class
         end
       end
+
       describe "#scenario_runner" do
         it "returns a runner class" do
           @reporter.scenario_runner.must_be_kind_of Class
         end
       end
+
       describe "#runner" do
         it "returns a runner class" do
           @reporter.runner.must_be_kind_of Class
@@ -156,6 +174,5 @@ module Spinach
         end
       end
     end
-
   end
 end

data/test/spinach/runner/feature_test.rb

@@ -93,5 +93,19 @@ describe Spinach::Runner::Feature do
       Spinach::Runner::Scenario.expects(:new).with(anything, anything, @feature.scenarios[1], anything).once.returns(stub_everything)
       @feature.run
     end
+
+    it "fires a hook if the feature is not defined" do
+      feature = Spinach::Runner::Feature.new(filename)
+      data = mock
+      exception = Spinach::FeatureStepsNotFoundException.new([anything, anything])
+      feature.stubs(:feature).raises(exception)
+      feature.stubs(:data).returns(data)
+      not_found_called = false
+      feature.class.when_not_found do |data, exception|
+        not_found_called = [data, exception]
+      end
+      feature.run
+      not_found_called.must_equal [data, exception]
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spinach
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -12,11 +12,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-09 00:00:00.000000000Z
+date: 2011-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
-  requirement: &70133830838360 !ruby/object:Gem::Requirement
+  requirement: &2164332760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -24,10 +24,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70133830838360
+  version_requirements: *2164332760
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70133830837940 !ruby/object:Gem::Requirement
+  requirement: &2164330700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -35,10 +35,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70133830837940
+  version_requirements: *2164330700
 - !ruby/object:Gem::Dependency
   name: colorize
-  requirement: &70133830837520 !ruby/object:Gem::Requirement
+  requirement: &2164330180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -46,10 +46,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70133830837520
+  version_requirements: *2164330180
 - !ruby/object:Gem::Dependency
   name: hooks
-  requirement: &70133830837100 !ruby/object:Gem::Requirement
+  requirement: &2164329420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -57,10 +57,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70133830837100
+  version_requirements: *2164329420
 - !ruby/object:Gem::Dependency
   name: purdytest
-  requirement: &70133830836680 !ruby/object:Gem::Requirement
+  requirement: &2164328540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -68,10 +68,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830836680
+  version_requirements: *2164328540
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70133830836260 !ruby/object:Gem::Requirement
+  requirement: &2164328020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -79,10 +79,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830836260
+  version_requirements: *2164328020
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70133830835840 !ruby/object:Gem::Requirement
+  requirement: &2164373480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -90,10 +90,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830835840
+  version_requirements: *2164373480
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &70133830835420 !ruby/object:Gem::Requirement
+  requirement: &2164372820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -101,10 +101,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830835420
+  version_requirements: *2164372820
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: &70133830835000 !ruby/object:Gem::Requirement
+  requirement: &2164372260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -112,10 +112,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830835000
+  version_requirements: *2164372260
 - !ruby/object:Gem::Dependency
   name: aruba
-  requirement: &70133830834580 !ruby/object:Gem::Requirement
+  requirement: &2164371820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -123,10 +123,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830834580
+  version_requirements: *2164371820
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &70133830834160 !ruby/object:Gem::Requirement
+  requirement: &2164371000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -134,10 +134,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830834160
+  version_requirements: *2164371000
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70133830833740 !ruby/object:Gem::Requirement
+  requirement: &2164370500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -145,10 +145,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830833740
+  version_requirements: *2164370500
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70133830833320 !ruby/object:Gem::Requirement
+  requirement: &2164369940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -156,7 +156,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133830833320
+  version_requirements: *2164369940
 description: Spinach is a BDD framework on top of gherkin
 email:
 - info@codegram.com
@@ -177,13 +177,17 @@ files:
 - Rakefile
 - Readme.md
 - bin/spinach
-- features/error_reporting.feature
 - features/exit_status.feature
 - features/feature_name_guessing.feature
+- features/reporting/error_reporting.feature
+- features/reporting/show_step_source_location.feature
+- features/reporting/undefined_feature_reporting.feature
 - features/rspec_compatibility.feature
-- features/steps/error_reporting.rb
 - features/steps/exit_status.rb
 - features/steps/feature_name_guessing.rb
+- features/steps/reporting/error_reporting.rb
+- features/steps/reporting/show_step_source_location.rb
+- features/steps/reporting/undefined_feature_reporting.rb
 - features/steps/rspec_compatibility.rb
 - features/support/env.rb
 - features/support/error_reporting.rb
@@ -235,26 +239,36 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 1257566033182471881
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 1257566033182471881
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.6
+rubygems_version: 1.8.5
 signing_key: 
 specification_version: 3
 summary: Spinach is a BDD framework on top of gherkin
 test_files:
-- features/error_reporting.feature
 - features/exit_status.feature
 - features/feature_name_guessing.feature
+- features/reporting/error_reporting.feature
+- features/reporting/show_step_source_location.feature
+- features/reporting/undefined_feature_reporting.feature
 - features/rspec_compatibility.feature
-- features/steps/error_reporting.rb
 - features/steps/exit_status.rb
 - features/steps/feature_name_guessing.rb
+- features/steps/reporting/error_reporting.rb
+- features/steps/reporting/show_step_source_location.rb
+- features/steps/reporting/undefined_feature_reporting.rb
 - features/steps/rspec_compatibility.rb
 - features/support/env.rb
 - features/support/error_reporting.rb