spicerack-styleguide 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a9356a8cdbe27835042926ed784501356e009f0437df1626bc7a5d97368cd25a
-  data.tar.gz: 158ce9b108cccfe56ff2d3271744d3e62ef379ab7e6b123bc4e56d2797be5e0c
+  metadata.gz: 34560c8bdffbefb68fde970b7b212ce4337c53a3fe8aadfe1bf8ba1057533b72
+  data.tar.gz: ad57bcc0c17c3973584d09d25ea4e30ef04a5c7d8f214b9c3508d20a3bf79532
 SHA512:
-  metadata.gz: 8fdd00b84551f878bbc3713d737895caf581df8d52c99a0607863ee1076084a01b2d5c243e15df6f3e12deb140af467843a32908d701166e36df0bc0242ddf0a
-  data.tar.gz: 1b07d81dd8d2cfc89d4d3b731dbc1a0ec00621f7f7a6824c4e2385de2ecfb7d7ebe1b8e50bf43014e69a89e3f5dcbf4ff2e6afb2b62d7443bd6436492066b222
+  metadata.gz: 05d3f3788589c76cb114bfed1979d1a26a8bca64041c4424aa5aabf4a98b7048f67c089df8647aa7870c5d74b4bc5564b9dd4696440e100c0c41aff5d10bb4e0
+  data.tar.gz: 1800298d631c67de658d7bba2f2e904e36538de2a052ebe40a6667a72de2501167bbe819ba1222508b5edab21f0e2d8075f022663601d31596b2f8edbba88b46

data/lib/spicerack/styleguide/version.rb

@@ -3,6 +3,6 @@
 module Spicerack
   module Styleguide
     # This constant is managed by spicerack
-    VERSION = "0.7.2"
+    VERSION = "0.7.3"
   end
 end

data/rubocop.yml

@@ -1,7 +1,9 @@
-require: rubocop-rspec
+require:
+ - rubocop-rspec
+ - rubocop-performance
 
 AllCops:
-  TargetRubyVersion: 2.5.3
+  TargetRubyVersion: 2.6
   Exclude:
     - bin/**/*
     - Gemfile*
@@ -106,17 +108,22 @@ Layout/FirstMethodArgumentLineBreak:
   Enabled: true
 Layout/FirstMethodParameterLineBreak:
   Enabled: true
-Layout/FirstParameterIndentation:
+Layout/HeredocArgumentClosingParenthesis:
   Enabled: true
-  EnforcedStyle: consistent
-Layout/IndentArray:
+Lint/HeredocMethodCallPosition:
   Enabled: true
-  EnforcedStyle: consistent
 Layout/IndentAssignment:
   Enabled: false
-Layout/IndentHash:
+Layout/IndentFirstArgument:
+  Enabled: true
+Layout/IndentFirstArrayElement:
   Enabled: true
   EnforcedStyle: consistent
+Layout/IndentFirstHashElement:
+  Enabled: true
+  EnforcedStyle: consistent
+Layout/IndentFirstParameter:
+  Enabled: true
 Layout/IndentHeredoc:
   Enabled: true
   EnforcedStyle: auto_detection
@@ -265,6 +272,8 @@ Lint/EndInMethod:
   Enabled: true
 Lint/EnsureReturn:
   Enabled: true
+Lint/FlipFlop:
+  Enabled: true
 Lint/FloatOutOfRange:
   Enabled: true
 Lint/FormatParameterMismatch:
@@ -326,6 +335,8 @@ Lint/ReturnInVoidContext:
   Enabled: true
 Lint/SafeNavigationChain:
   Enabled: true
+Lint/SafeNavigationWithEmpty:
+  Enabled: true
 Lint/ScriptPermission:
   Enabled: true
 Lint/ShadowedArgument:
@@ -336,6 +347,8 @@ Lint/ShadowingOuterLocalVariable:
   Enabled: true
 Lint/StringConversionInInterpolation:
   Enabled: true
+Lint/ToJSON:
+  Enabled: true
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
 Lint/UnifiedInteger:
@@ -381,6 +394,7 @@ Metrics/BlockLength:
   Enabled: true
   Max: 24
   Exclude:
+    - "**/concerns/*"
     - config/environments/*
     - spec/**/*
 Metrics/BlockNesting:
@@ -448,6 +462,9 @@ Naming/PredicateName:
   Exclude:
     - app/serializers/*_serializer.rb
     - spec/**/*
+Naming/RescuedExceptionsVariableName:
+  Enabled: true
+  PreferredName: exception
 Naming/UncommunicativeBlockParamName:
   Enabled: true
   MinNameLength: 1
@@ -493,8 +510,10 @@ Performance/FixedSize:
   Enabled: true
 Performance/FlatMap:
   Enabled: true
-Performance/LstripRstrip:
+Performance/OpenStruct:
   Enabled: true
+  Exclude:
+    - spec/**/*
 Performance/RangeInclude:
   Enabled: true
 Performance/RedundantBlockCall:
@@ -503,14 +522,10 @@ Performance/RedundantMatch:
   Enabled: true
 Performance/RedundantMerge:
   Enabled: true
-Performance/RedundantSortBy:
-  Enabled: true
 Performance/RegexpMatch:
   Enabled: true
 Performance/ReverseEach:
   Enabled: true
-Performance/Sample:
-  Enabled: true
 Performance/Size:
   Enabled: true
 Performance/StartWith:
@@ -523,10 +538,11 @@ Performance/UnfreezeString:
   Enabled: true
 Performance/UriDefaultParser:
   Enabled: true
-
 Rails/ActionFilter:
   Enabled: true
   EnforcedStyle: action
+Rails/ActiveRecordOverride:
+  Enabled: true
 Rails/ActiveRecordAliases:
   Enabled: true
 Rails/ActiveSupportAliases:
@@ -535,6 +551,8 @@ Rails/ApplicationJob:
   Enabled: true
 Rails/ApplicationRecord:
   Enabled: true
+Rails/BelongsTo:
+  Enabled: true
 Rails/Blank:
   Enabled: true
 Rails/CreateTableWithTimestamps:
@@ -577,6 +595,8 @@ Rails/HttpPositionalArguments:
 Rails/HttpStatus:
   Enabled: true
   EnforcedStyle: symbolic
+Rails/IgnoredSkipActionFilterOption:
+  Enabled: true
 Rails/InverseOf:
   Enabled: true
   Include:
@@ -585,6 +605,8 @@ Rails/LexicallyScopedActionFilter:
   Enabled: true
   Include:
     - app/controllers/**/*.rb
+Rails/LinkToBlank:
+  Enabled: true
 Rails/NotNullColumn:
   Enabled: true
   Include:
@@ -611,8 +633,12 @@ Rails/ReadWriteAttribute:
   Enabled: true
   Include:
     - app/models/**/*.rb
+Rails/RedundantAllowNil:
+  Enabled: true
 Rails/RedundantReceiverInWithOptions:
   Enabled: true
+Rails/ReflectionClassName:
+  Enabled: true
 Rails/RelativeDateConstant:
   Enabled: true
 Rails/RequestReferer:
@@ -736,6 +762,8 @@ Style/ConditionalAssignment:
   EnforcedStyle: assign_inside_condition
   SingleLineConditionsOnly: false
   IncludeTernaryExpressions: false
+Style/ConstantVisibility:
+  Enabled: false
 Style/Copyright:
   Enabled: false
 Style/DateTime:
@@ -744,6 +772,8 @@ Style/DefWithParentheses:
   Enabled: true
 Style/Dir:
   Enabled: true
+Style/DisjunctiveAssignmentInConstructor:
+  Enabled: true
 Style/Documentation:
   Enabled: false
 Style/DocumentationMethod:
@@ -780,8 +810,6 @@ Style/EvenOdd:
   Enabled: true
 Style/ExpandPathArguments:
   Enabled: true
-Style/FlipFlop:
-  Enabled: true
 Style/For:
   Enabled: true
   EnforcedStyle: each
@@ -970,6 +998,8 @@ Style/RedundantReturn:
   AllowMultipleReturnValues: false
 Style/RedundantSelf:
   Enabled: true
+Style/RedundantSortBy:
+  Enabled: true
 Style/RegexpLiteral:
   Enabled: true
   EnforcedStyle: percent_r
@@ -991,6 +1021,8 @@ Style/SafeNavigation:
     - presence
     - try
     - try!
+Style/Sample:
+  Enabled: true
 Style/SelfAssignment:
   Enabled: true
 Style/Semicolon:
@@ -1025,6 +1057,8 @@ Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
 Style/StringMethods:
   Enabled: true
+Style/Strip:
+  Enabled: true
 Style/StructInheritance:
   Enabled: true
 Style/SymbolArray:
@@ -1106,7 +1140,7 @@ Style/WordArray:
   MinSize: 0
 Style/YodaCondition:
   Enabled: true
-  EnforcedStyle: all_comparison_operators
+  EnforcedStyle: forbid_for_all_comparison_operators
 Style/ZeroLengthPredicate:
   Enabled: true
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spicerack-styleguide
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Allen Rettberg
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-01 00:00:00.000000000 Z
+date: 2019-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.59.2
+        version: 0.68.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.59.2
+        version: 0.68.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.29.1
+        version: 1.32.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.29.1
+        version: 1.32.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.1.0
 description: Wanna write code the Freshly way? Inherit this gem in your rubocop.yml
   and keep your code fresh
 email: