spicerack-styleguide 0.28.0 → 0.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1af4f057357ba1fee729ab369d3e60df89537e131849273f6701bf83a217ed2f
-  data.tar.gz: 8ca9843dd292b75ed3d2c8ad483b5dba69eb90afb4af22b3f10c5fa400fe9470
+  metadata.gz: e5a822c6e522c67af5a390ba33997bdad1efcea2542ca7f2189c195350795c83
+  data.tar.gz: c460b7421e921a090fe47ee54cf80c0f5b0198fca9a9eff8806c0148e6dcc5b2
 SHA512:
-  metadata.gz: f9e7838b3018e345fc4e1d4c7a704cb7d997d39f3502bcb5cce41d70828f4bbb43691a1b843afdea2d3fc28dc8c32728df348b8a32dd0ef74543e263e86c57b3
-  data.tar.gz: 1efb06ddd40d23ea58caa18e303ba08e4ce576283c9aeccea783f2b7eefd74f05097a55d2ee9b060bf3dbbd4e286c37b717895da9f3b013481d58a5795be7acf
+  metadata.gz: 4483e8d87aaf64de0fb51220e7884c4d8d9a422d3ca8e616059b7d86e9f2681e7bf87811a678e664a1903b779cb31e72cccdc32b17c81747f622f451329237a4
+  data.tar.gz: 7bb5f1fa75b20f86739b84554e2dbb15f43585272f5e30dcfc359df2fe36334554a7562dab856387208e0db0de23749788554c9b1ef9f25d2829c85858c4787d

data/README.md

@@ -64,7 +64,7 @@ This... is a yml. You don't develop it. Go home, boilerplate gem README text, yo
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/Freshly/spicerack.
+Bug reports and pull requests are welcome on GitHub at https://github.com/RubyAfterAll/spicerack.
 
 ## License
 

data/lib/spicerack/styleguide/version.rb

@@ -3,6 +3,6 @@
 module Spicerack
   module Styleguide
     # This constant is managed by spicerack
-    VERSION = "0.28.0"
+    VERSION = "0.29.0"
   end
 end

data/rubocop.yml

@@ -5,6 +5,7 @@ require:
 
 AllCops:
   TargetRubyVersion: 2.7
+  NewCops: enable
   Exclude:
     - "**/bin/**/*"
     - Rakefile
@@ -55,8 +56,24 @@ Layout/DefEndAlignment:
 Layout/DotPosition:
   Enabled: true
   EnforcedStyle: trailing
+Lint/AmbiguousAssignment:
+  Enabled: true
+Lint/DuplicateBranch:
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
 Layout/ElseAlignment:
   Enabled: true
+Lint/EmptyBlock:
+  Enabled: true
+Lint/EmptyClass:
+  Enabled: true
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: true
+Lint/ToEnumArguments:
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
 Layout/EmptyComment:
   Enabled: true
   AllowBorderComment: true
@@ -200,6 +217,8 @@ Layout/SpaceAroundOperators:
 Layout/SpaceBeforeBlockBraces:
   Enabled: true
   EnforcedStyle: space
+Layout/SpaceBeforeBrackets:
+  Enabled: true
 Layout/SpaceBeforeComma:
   Enabled: true
 Layout/SpaceBeforeComment:
@@ -402,6 +421,8 @@ Lint/ToJSON:
   Enabled: true
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
+Lint/UnexpectedBlockArity:
+  Enabled: true
 Lint/UnifiedInteger:
   Enabled: true
 Lint/RaiseException:
@@ -572,6 +593,8 @@ Performance/CompareWithBlock:
   Enabled: true
 Performance/ConstantRegexp:
   Enabled: true
+Performance/ConcurrentMonotonicTime:
+  Enabled: true
 Performance/Count:
   Enabled: true
 Performance/Detect:
@@ -586,6 +609,8 @@ Performance/FlatMap:
   Enabled: true
 Performance/IoReadlines:
   Enabled: true
+Performance/MapCompact:
+  Enabled: true
 Performance/MethodObjectAsBlock:
   Enabled: true
 Performance/OpenStruct:
@@ -614,6 +639,8 @@ Performance/ReverseEach:
   Enabled: true
 Performance/ReverseFirst:
   Enabled: true
+Performance/SelectMap:
+  Enabled: true
 Performance/Size:
   Enabled: true
 Performance/SortReverse:
@@ -622,6 +649,8 @@ Performance/Squeeze:
   Enabled: true
 Performance/StartWith:
   Enabled: true
+Performance/StringIdentifierArgument:
+  Enabled: true
 Performance/StringInclude:
   Enabled: true
 Performance/StringReplacement:
@@ -646,6 +675,8 @@ Rails/ActiveRecordOverride:
   Enabled: true
 Rails/ActiveSupportAliases:
   Enabled: true
+Rails/AddColumnIndex:
+  Enabled: true
 Rails/ApplicationController:
   Enabled: true
 Rails/ApplicationMailer:
@@ -685,8 +716,14 @@ Rails/EnumUniqueness:
   Enabled: true
 Rails/EnvironmentComparison:
   Enabled: true
+Rails/EnvironmentVariableAccess:
+  Enabled: true
+  AllowReads: true
+  AllowWrites: false
 Rails/Exit:
   Enabled: true
+Rails/ExpandedDateRange:
+  Enabled: true
 Rails/FilePath:
   Enabled: true
   EnforcedStyle: arguments
@@ -715,6 +752,8 @@ Rails/HttpPositionalArguments:
 Rails/HttpStatus:
   Enabled: true
   EnforcedStyle: symbolic
+Rails/I18nLocaleAssignment:
+  Enabled: true
 Rails/IndexBy:
   Enabled: true
 Rails/IndexWith:
@@ -800,6 +839,12 @@ Rails/ReversibleMigration:
   Enabled: true
   Include:
     - db/migrate/*.rb
+Rails/RequireDependency:
+  Enabled: false # Theoretically not all projects could use zeitwerk
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: true
+  Include:
+    - db/migrate/*.rb
 Rails/SafeNavigation:
   Enabled: true
 Rails/SafeNavigationWithBlank:
@@ -831,6 +876,8 @@ Rails/SquishedSQLHeredocs:
 Rails/TimeZone:
   Enabled: true
   EnforcedStyle: flexible
+Rails/TimeZoneAssignment:
+  Enabled: true
 Rails/UniqBeforePluck:
   Enabled: true
   EnforcedStyle: conservative
@@ -842,6 +889,10 @@ Rails/UnknownEnv:
     - development
     - test
     - production
+Rails/UnusedIgnoredColumns:
+  Enabled: true
+Rails/EagerEvaluationLogMessage:
+  Enabled: true
 Rails/WhereExists:
   Enabled: true
 Rails/WhereEquals:
@@ -872,6 +923,8 @@ Style/Alias:
 Style/AndOr:
   Enabled: true
   EnforcedStyle: conditionals
+Style/ArgumentsForwarding:
+  Enabled: true
 Style/ArrayCoercion:
   Enabled: true
 Style/ArrayJoin:
@@ -915,6 +968,8 @@ Style/ClassMethodsDefinitions:
   EnforcedStyle: self_class
 Style/ClassVars:
   Enabled: true
+Style/CollectionCompact:
+  Enabled: true
 Style/CollectionMethods:
   Enabled: false
 Style/ColonMethodCall:
@@ -954,6 +1009,8 @@ Style/DisableCopsWithinSourceCodeDirective:
   Enabled: false
 Style/Documentation:
   Enabled: false
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
 Style/DocumentationMethod:
   Enabled: false
 Style/DoubleNegation:
@@ -1020,6 +1077,8 @@ Style/HashAsLastArrayItem:
   EnforcedStyle: no_braces
 Style/HashEachMethods:
   Enabled: true
+Style/HashExcept:
+  Enabled: false # TODO: enable once ruby 3.0 is supported
 Style/HashLikeCase:
   Enabled: true
 Style/HashSyntax:
@@ -1102,6 +1161,8 @@ Style/MutableConstant:
 Style/NegatedIf:
   Enabled: true
   EnforcedStyle: both
+Style/NegatedIfElseCondition:
+  Enabled: true
 Style/NegatedUnless:
   Enabled: true
   EnforcedStyle: both
@@ -1136,6 +1197,8 @@ Style/Next:
   EnforcedStyle: skip_modifier_ifs
 Style/NilComparison:
   Enabled: true
+Style/NilLambda:
+  Enabled: true
 Style/NonNilCheck:
   Enabled: true
 Style/Not:
@@ -1189,6 +1252,8 @@ Style/RaiseArgs:
   EnforcedStyle: exploded
 Style/RandomWithOffset:
   Enabled: true
+Style/RedundantArgument:
+  Enabled: true
 Style/RedundantAssignment:
   Enabled: true
 Style/RedundantBegin:
@@ -1268,6 +1333,8 @@ Style/SpecialGlobalVars:
 Style/StabbyLambdaParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses
+Style/StaticClass:
+  Enabled: false
 Style/StderrPuts:
   Enabled: true
 Style/StringConcatenation:
@@ -1354,6 +1421,8 @@ Style/RedundantPercentQ:
   Enabled: true
 Style/RedundantSort:
   Enabled: true
+Style/SwapValues:
+  Enabled: true
 Style/UnpackFirst:
   Enabled: true
 Style/VariableInterpolation:
@@ -1471,6 +1540,8 @@ RSpec/HookArgument:
   EnforcedStyle: implicit
 RSpec/HooksBeforeExamples:
  Enabled: true
+RSpec/IdenticalEqualityAssertion:
+  Enabled: true
 RSpec/ImplicitBlockExpectation:
  Enabled: true
 RSpec/ImplicitExpect:
@@ -1525,6 +1596,8 @@ RSpec/PredicateMatcher:
   Enabled: true
   Strict: false
   EnforcedStyle: inflected
+RSpec/Rails/AvoidSetupHook:
+  Enabled: true
 RSpec/RepeatedDescription:
   Enabled: true
 RSpec/RepeatedExample:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spicerack-styleguide
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.29.0
 platform: ruby
 authors:
 - Allen Rettberg
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-06 00:00:00.000000000 Z
+date: 2022-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: '2.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.2
+        version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.2
+        version: '1.13'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: '2.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: '2.11'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 description: Wanna write code the Freshly way? Inherit this gem in your rubocop.yml
   and keep your code fresh
 email:
@@ -83,14 +97,14 @@ files:
 - lib/spicerack/styleguide.rb
 - lib/spicerack/styleguide/version.rb
 - rubocop.yml
-homepage: https://github.com/Freshly/spicerack/tree/main/spicerack-styleguide
+homepage: https://github.com/RubyAfterAll/spicerack/tree/main/spicerack-styleguide
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/Freshly/spicerack/tree/main/spicerack-styleguide
-  source_code_uri: https://github.com/Freshly/spicerack/tree/main/spicerack-styleguide
-  changelog_uri: https://github.com/Freshly/spicerack/blob/main/spicerack-styleguide/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/spicerack-styleguide/0.28.0
+  homepage_uri: https://github.com/RubyAfterAll/spicerack/tree/main/spicerack-styleguide
+  source_code_uri: https://github.com/RubyAfterAll/spicerack/tree/main/spicerack-styleguide
+  changelog_uri: https://github.com/RubyAfterAll/spicerack/blob/main/spicerack-styleguide/CHANGELOG.md
+  documentation_uri: https://www.rubydoc.info/gems/spicerack-styleguide/0.29.0
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -106,7 +120,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.9
+rubygems_version: 3.3.8
 signing_key:
 specification_version: 4
 summary: Rubocop Styleguide for Rails and RSpec.