speedy_gcm 0.9.0 → 0.9.1

data/.gitignore

@@ -1,2 +1,4 @@
 .DS_Store
-.rvmrc
+.rvmrc
+Gemfile.lock
+*.gem

data/lib/speedy_gcm/version.rb

@@ -1,3 +1,3 @@
 module SpeedyGCM
-  VERSION = "0.9.0"
+  VERSION = "0.9.1"
 end

data/lib/speedy_gcm.rb

@@ -32,6 +32,9 @@ module SpeedyGCM
         headers = { "Content-Type" => "application/json",
                     "Authorization" => "key=#{@api_key}" }
 
+        # symbolize all keys
+        message_opts = symbolize_keys(message_opts)
+
         # validate the message options
         message_validation(message_opts)
 
@@ -46,6 +49,14 @@ module SpeedyGCM
       end
 
       private
+
+      def symbolize_keys(myhash)
+        myhash.keys.each do |key|
+          myhash[(key.to_sym rescue key) || key] = myhash.delete(key)
+        end
+        return myhash
+      end
+
       def message_validation(message_opts)
         # check if message_opts has required info
         raise ArgumentError, "registration_ids is a required param of the GCM message" unless message_opts.has_key? :registration_ids
@@ -67,6 +78,7 @@ module SpeedyGCM
 
         # registration_ids must contain at least 1 and at most 1000 registration IDs
         registration_ids = message_opts[:registration_ids]
+
         if (registration_ids.length < 1) or (registration_ids.length > 1000)
           raise ArgumentError, "registration_ids must contain at least 1 and at most 1000 registration IDs"
         end

data/test/test_speedy_gcm.rb

@@ -7,6 +7,11 @@ require "net/https"
 
 class TestSpeedyGCM < Test::Unit::TestCase
 
+  # If you receive an "Unavailable" error code when you try to send a GCM:
+  # Generate a Browser API Key from the Google APIs Console, and use it instead of the server key in the "Authorization" header. Once you do that, this error will go away.
+  # This is caused by a serious mistake in the GCM Documentation that states you should use a Server Key in the Authorization header (as written here:  http://developer.android.com/guide/google/gcm/gs.html)
+
+  # use a "browser_api_key" - see note above!
   GCM_API_KEY = "TODO - Fill in with your GCM API Key"
   TEST_PHONE_GCM_REGISTRATION_ID = "TODO - Fill in with some GCM Registration ID"
 
@@ -143,35 +148,33 @@ class TestSpeedyGCM < Test::Unit::TestCase
     end
   end
 
-  should "not raise an error if a send notification call succeeds" do
+  should "not raise an error and send a message with a success response" do
     assert_nothing_raised do
       SpeedyGCM::API.set_account(GCM_API_KEY)
 
       message_options = {}
-      message_options.merge!({ :registration_ids => [1] })
-      message_options.merge!({ :collapse_key => "foobar" })
-      message_options.merge!({ :data => { :score => "3x1" } })
-      message_options.merge!({ :time_to_live => 1 })
+      message_options.merge!({ :registration_ids => [TEST_PHONE_GCM_REGISTRATION_ID] })
+      message_options.merge!({ :collapse_key => Time.now.to_s })
+      message_options.merge!({ :data => { :vmr_id => "3" } })
 
       response = SpeedyGCM::API.send_notification(message_options)
+
+      assert response[:code].eql? 200
     end
   end
 
-  should "not raise an error and send a message with a success response" do
+  should "not raise an error and send a message with a success response if using strings instead of symbols for keys" do
     assert_nothing_raised do
       SpeedyGCM::API.set_account(GCM_API_KEY)
 
       message_options = {}
-      message_options.merge!({ :registration_ids => [TEST_PHONE_GCM_REGISTRATION_ID] })
-      message_options.merge!({ :collapse_key => Time.now.to_s })
-      message_options.merge!({ :data => { :vmr_id => "3" } })
+      message_options.merge!({ "registration_ids" => [TEST_PHONE_GCM_REGISTRATION_ID] })
+      message_options.merge!({ "collapse_key" => Time.now.to_s })
+      message_options.merge!({ "data" => { "vmr_id" => "3" } })
 
       response = SpeedyGCM::API.send_notification(message_options)
 
       assert response[:code].eql? 200
-
-      # puts response[:code]
-      # puts response[:message]
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: speedy_gcm
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-01 00:00:00.000000000 Z
+date: 2012-10-03 00:00:00.000000000 Z
 dependencies: []
 description: Speedy GCM efficiently sends push notifications to Android devices via
   GCM (Google Cloud Messaging).