spbtv_code_style 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0de24f59699801bfff09af903c583958f4b3c755
-  data.tar.gz: 197af631ec792872175430b8c7ccfe1dfacdb1a2
+  metadata.gz: 4956a8305ed40f13b8cd8755a32f328387249738
+  data.tar.gz: 520b8c516309e102eb5d82647064150747d21116
 SHA512:
-  metadata.gz: 0abe4066eb2bb1c5ef46f06f721d97d2d0f3b771533e5feb483f6d00a9fea89c16b3dd1c28d6c2da4d6ef573df3e0f21161a72d69f4f3a566fc4b0edf765b5b7
-  data.tar.gz: 259dfdec5f01c3632aef02bec2f6445dbcd2120c310e2ec59177107a0d33e72b212a29bd95a7ac2eedb6c222416a0c3637ea62b5ca3222717e026a8b2394132e
+  metadata.gz: 3d3a932c5e7d4d53c43bc7760a42895f77073d84a9c9f66754c745254cd3c92890ef39caef3e1f2d8c2aa6ec5b4d2cf7867d6b0ce9fd83d869cabbad19b30d26
+  data.tar.gz: 3a544aab231e45442c74a3bc180a20ede42eda2ee6cb5b700862030da35722d3c7e486edf663a8086e2c9226a36e3ed9ffaa3566cc47abb9e492d3b7cbe4569b

data/lib/rubocop/cop/spbtv/postgres/find_each.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Spbtv
+      module Postgres
+        # Do not use find_each with Postgresql.
+        #
+        # ActiveRecord's find_each and find_in_batches ignore non-integer primary keys,
+        # thus limiting output to 1000 records.
+        # Workaround: use https://github.com/afair/postgresql_cursor gem with its each_instance method.
+        #
+        # @example
+        #   @bad
+        #   Model.find_each { |instance| instance.do_something }
+        #   @good
+        #   Model.each_instance { |instance| instance.do_something }
+        #
+        class FindEach < Cop
+          MSG = 'Do not use find_each or find_in_batches, as the keys are non-integer.'.freeze
+
+          def on_send(node)
+            _, method, * = *node
+            if method == :find_each || method == :find_in_batches
+              add_offense(node, :selector, MSG)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/spbtv.rb

@@ -3,4 +3,5 @@ require_relative 'cop/spbtv/postgres/add_column_with_default'
 require_relative 'cop/spbtv/postgres/add_column_with_not_null'
 require_relative 'cop/spbtv/postgres/add_index'
 require_relative 'cop/spbtv/postgres/change_column'
+require_relative 'cop/spbtv/postgres/find_each'
 require_relative 'cop/spbtv/multiple_validation'

data/lib/spbtv_code_style.rb

@@ -1,4 +1,4 @@
 # Just namespace for version number
 module SpbtvCodeStyle
-  VERSION = '1.6.0'.freeze
+  VERSION = '1.7.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spbtv_code_style
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Tema Bolshakov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-01 00:00:00.000000000 Z
+date: 2016-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop-checkstyle_formatter
@@ -130,6 +130,7 @@ files:
 - lib/rubocop/cop/spbtv/postgres/add_column_with_not_null.rb
 - lib/rubocop/cop/spbtv/postgres/add_index.rb
 - lib/rubocop/cop/spbtv/postgres/change_column.rb
+- lib/rubocop/cop/spbtv/postgres/find_each.rb
 - lib/rubocop/spbtv.rb
 - lib/spbtv_code_style.rb
 - spbtv_code_style.gemspec