spark_api 1.4.2 → 1.4.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Y2U5OGIwYmZhZWFlZWQ2Njc1NzA4YmMxNzhjN2NiYTZlNjEzZTA5Yg==
+    ZmUwNzIwNTgwOWUxN2MzMGZhNmZmNzM1MWQwODJmNTUwOTRlMWIyNw==
   data.tar.gz: !binary |-
-    MzM2NGZjNmMxMWU1MWY4OTMwZDczN2VhZmVmM2EzMjUyM2ZmNTM2MA==
+    YWQyMWM3Y2Q5ODFlYzIzMTdlZjk1NDQwMDczNmNiMWQ2NTIwZDdlZA==
 SHA512:
   metadata.gz: !binary |-
-    ODY1Mjk3OTZhYTc3YmQ4ZTgwMzc1NGM5YjMxNjg2NjM3ZDFhYmRiOGVkYWFm
-    MTVhYWUxZmViNzI1NTY4NTI5MjBhMTEyM2IzMDI4Y2Q1NTBkOTM3YzRiYmI2
-    ZjUyYWVmYTk0NzFhY2IyMGY1NmVjMGRlNGJjYTYxYWNkODZjY2I=
+    OGI2N2M2YTY2Mzg0MGVmYTlkZGFiOGI4YjVmNDFhYTIxYjYxODA4ZjQ5ZDEz
+    MTc2Yjk3NWZjNzU1MDVjZTAyYmYyYmViZTE5ODBkN2Y5YjZiOGMwOWJiZTYy
+    NGMxODEyOTJiN2YyNDRiYTM4MzkyZWZhMWM2MmNkYTQ5MzhmMjc=
   data.tar.gz: !binary |-
-    MTJmZTBiMDdhM2ZmY2U0Y2JmNGI0OTNlMWI2M2RmMGU2NmU5YTk0NGZmNjJl
-    ODMwY2EyODBjZTAwNWVhOWIzYmY4ODllNWMzMTNkOGQzNDkwNDJiNmRiNTVh
-    NTA5ZmYzYjg1ZWEyNWEyZjZiNzI0ZDkzYjE1NGVkMWY0Y2M1YTI=
+    ZDBjOTcwMWU4MmFiOGRkZmE0YTVjZmYwZTlhMjQ4NmEwMjJiZGQ2ZGFmNDBm
+    M2ExM2I5MGNkNmRiZjZhN2MzYWIwNTc0MzdlYTY4OWE1ZjdjMTMzNmIzYzgw
+    YzgxZWRlNTliNDM4NGM0Y2I3NWJmYjQ3YTUxZGZhYWI1NWY4MjQ=

data/VERSION

@@ -1 +1 @@
-1.4.2
+1.4.4

data/lib/spark_api/models/defaultable.rb

@@ -19,15 +19,19 @@ module SparkApi
       module ClassMethods
 
         def default(options = {})
-          find(DEFAULT_ID, options)
+          response = connection.get("/#{element_name}/default", options).first
+          unless response.nil?
+            response["Id"] = DEFAULT_ID if response["Id"].nil?
+            new(response)
+          end
         end
 
         def find(*arguments)
-          result = original_find(*arguments)
           if arguments.first == DEFAULT_ID
-            result.Id = DEFAULT_ID if result.Id.nil?
+            default
+          else
+            original_find(*arguments)
           end
-          result
         end
 
       end

data/spec/unit/spark_api/models/defaultable_spec.rb

@@ -14,24 +14,33 @@ describe Defaultable do
 
   describe 'default' do
 
-    it 'calls find' do
-      expect(TestClass).to receive(:find).with('default', {})
-      TestClass.default
+    it 'returns an instance of the class' do
+      allow(TestClass).to receive(:connection).and_return(double(get: [{"Name" => 'foo'}]))
+      expect(TestClass.default).to be_a TestClass
+    end
+
+    it 'returns nil when there are no results' do
+      allow(TestClass).to receive(:connection).and_return(double(get: []))
+      expect(TestClass.default).to be nil
+    end
+
+    it "assigns the default id to the instance if it doesn't have an id" do
+      allow(TestClass).to receive(:connection).and_return(double(get: [{"Name" => 'foo'}]))
+      expect(TestClass.default.Id).to eq TestClass::DEFAULT_ID
+    end
+
+    it "doesn't override the id if one is present" do
+      allow(TestClass).to receive(:connection).and_return(double(get: [{"Id" => '5', "Name" => 'foo'}]))
+      expect(TestClass.default.Id).to eq '5'
     end
     
   end
   
   describe 'find' do
 
-    it "adds the id 'default'" do
-      allow(TestClass).to receive(:connection).and_return(double(get: [{Id: nil, Name: 'foo'}]))
-      default = TestClass.find(TestClass::DEFAULT_ID)
-      expect(default.Id).to eq 'default'
-    end
-
-    it "doesn't override the id if one is present" do
-      allow(TestClass).to receive(:connection).and_return(double(get: [{Id: '5', Name: 'foo'}]))
-      expect(TestClass.find(TestClass::DEFAULT_ID).Id).to eq '5'
+    it "calls 'default' when given the default id" do
+      expect(TestClass).to receive(:default)
+      TestClass.find(TestClass::DEFAULT_ID)
     end
 
     it "calls Finders.find when given a normal id" do

data/spec/unit/spark_api/models/finders_spec.rb

@@ -49,4 +49,5 @@ describe Finders, "Finders model" do
     end
 
   end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spark_api
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.4
 platform: ruby
 authors:
 - Brandon Hornseth
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-06 00:00:00.000000000 Z
+date: 2016-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -233,6 +233,34 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: listen
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.0.8
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.0.8
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: The spark_api gem handles most of the boilerplate for communicating with
   the Spark API rest services, including authentication and request parsing.
 email: api-support@sparkapi.com