spark_api 1.4.10 → 1.4.11

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    OTFjNDIzMzZlZTliYWQ5ZmFhZTI0YzgxOTIzZGM4NjczMDExZjI2Nw==
+    ZWRkMjMxNzQ0ZGM1YWRmZDNhNjMyNDQ1ODk1ZTMzODQ1YTc3ZjY0Yw==
   data.tar.gz: !binary |-
-    MzlkZTQ2YjlkNjBhMDExMTU2ZDA5NWQxOWE5NDRjMTAwNDFkZjQ4Yg==
+    OGQ4NjhjYmQ5NWM1MzM5YTQ1ZDgxOTc0MDAyNWQ3MThlYTM1NDg1NQ==
 SHA512:
   metadata.gz: !binary |-
-    ZDExMTM5MWMxNzA0MGFlMTdkNzVjYjdhZmJjOTcxYjRmMjc1ZGExNjkxOTcw
-    MDdiNjAwZjY2N2MwNDY2ZjMxYjcyZWM2Y2NkNmU3MzI1Yjk2YWFlY2UxMWM2
-    ZjA4ZmY2OWJkMjQzMmRkYWRmZGE2ZTEyZDA1MGNjZGIzNDFmMGE=
+    NmZlOTEyY2RiZmI1Y2I0MzcwZmY2Y2ZmZWZiODA3MjQ1OWRlNzE5OWFkZDEw
+    MWIwNmJjMTNhNWZkZmJiZjllY2RhNzZkYjA3MmQ3MzAyNjJkNGYxMzk4Mjgx
+    MGNmOWU0NDM3YWQ2YmY2OGVjMTIxMTRkOWE0MmJhMTU0NWY2YmM=
   data.tar.gz: !binary |-
-    NDFmNjk3ZTY5NTQ5Y2FkNDFkZDAwYTk4Y2I4ZTNhODI0NTZhOGY4ZmYzYjA1
-    ZWYwYzU3OWZmZjY4OWJiNzJhYWJlZjRiY2Q0OTlhNTFhZWJmOGZjYmY1NmVi
-    OWQ4MmQ5ZWFhZGY0YTg5NzlmZTIxNWY1Y2U3ODY2ZGNhNzQ3ZTI=
+    OTk4MDAwOTVlOWQ5MDVlYjVmNDdmMjVhZTIyMjAyYTIxNmRkYjllYmE1ZTc5
+    NzhmMzkwOGE3NTU2YzhiYWJhMWIxNjRiZTg0MmRiNDA3MWZmYzkzY2FiZmNl
+    NzQ3ZTQyYTI0MDI3ZDMwYjZmZjliNGNjYmU0MTExNjMxYWY2MTQ=

data/VERSION

@@ -1 +1 @@
-1.4.10
+1.4.11

data/lib/spark_api/models/listing.rb

@@ -188,7 +188,7 @@ module SparkApi
         false
       end
       def reorder_photos!(arguments={})
-        results = connection.put "#{self.class.path}/#{self.Id}/photos", arguments
+        results = connection.put subresource_path("photos"), arguments
         true
       end
 
@@ -207,7 +207,7 @@ module SparkApi
         false
       end
       def reorder_photo!(photo_id, index)
-        connection.put "#{self.class.path}/#{self.Id}/photos/#{photo_id}", "Photos" => [{"Order"=>index}]
+        connection.put subresource_path("photos") + "/#{photo_id}", "Photos" => [{"Order"=>index}]
         true
       end
 
@@ -235,6 +235,26 @@ module SparkApi
         end
       end
 
+      def delete_photos!(photoIds, args={})
+        connection.delete subresource_path("photos") + "/#{photoIds}", args
+        true
+      end
+
+      def delete_photos(photoIds, args={})
+        unless photoIds.is_a? String
+          raise ArgumentError, "Batch photo delete failed. '#{photoIds}' is not a string."
+        end
+
+        begin
+          return delete_photos!(photoIds, args)
+        rescue BadResourceRequest => e
+          SparkApi.logger.warn { "Failed to delete photos from resource #{self}: #{e.message}" }
+        rescue NotFound => e
+          SparkApi.logger.error { "Failed to delete photos from resource #{self}: #{e.message}" }
+        end
+        false
+      end
+
       private
 
       # TODO trim this down so we're only overriding the StandardFields access
@@ -272,6 +292,10 @@ module SparkApi
         end
       end
 
+      def subresource_path(subresource)
+        "#{self.class.path}/#{self.Id}/#{subresource}"
+      end
+
     end
   end
 end

data/spec/unit/spark_api/models/listing_spec.rb

@@ -351,6 +351,16 @@ describe Listing do
           l.editable?(:PriceChange).should eq(true)
           l.editable?(:Photos).should eq(false)
         end
+
+        on_delete_it "should bulk delete listing photos" do
+          list_id = "20060725224713296297000000"
+          stub_api_get("/listings/#{list_id}", 'listings/with_photos.json', { :_expand => "Photos" })
+          l = Listing.find(list_id, :_expand => "Photos")
+          photo_id1 = l.photos[0].Id
+          photo_id2 = l.photos[1].Id
+          stub_api_delete("/listings/#{list_id}/photos/#{photo_id1},#{photo_id2}", 'success.json')
+          l.delete_photos(photo_id1 + "," + photo_id2).should be(true)
+        end
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spark_api
 version: !ruby/object:Gem::Version
-  version: 1.4.10
+  version: 1.4.11
 platform: ruby
 authors:
 - Brandon Hornseth