spark-component 1.1.3 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e3e0ad334927fb07eb25c2decef437583ba133adcc5ff0d9a6e6ed0e06513cf
-  data.tar.gz: adaec489d853409d38ffbb58c1b0aee91d599f45ea64a8fe4065f77b6c34def9
+  metadata.gz: 55e7c87e7b78b2e073ed5d8ba8612f51fd038aa4a91902782930a5a2367d305b
+  data.tar.gz: b13756de2909fef4c1cdc93b1e674350c5c100c0b1109c6ba001187081f5cfd2
 SHA512:
-  metadata.gz: 1669ffd2003ef564d045bb103a479ff210ae143635b81deccaa445f566079410659cda4463a0d5b3cb90dd0e3309184e00957d83fbf9ed2c536cd508261e98c9
-  data.tar.gz: 6b39bb0f6c86b2c87a991cab875680930b3e4fc7296837c428e0c189de6697e244b9abc8625d2845ea892a05650a9479440fb952fc72760ef8fdd6522a96a94b
+  metadata.gz: 69753141da46b8361c76f0dd895ae440c123e5ece47f71a17bd9e95aa4a8c597c74a576d39c882fdcd33eb38afabd6d15a8dedab164d1bb4d1f2b8b688058da5
+  data.tar.gz: 1a04eab2d9d35cdb8e691173d14f5874e94ecbee3d82ae5b823dadb71c07fa1537f28909a4eda3cdbec93e4648c4d5f604f47e56ba96906255996f922fb4a06b

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# v1.1.4 - 2020-01-28
+- Fix: attrtibute_default_group now accepts booleans and normalizes keys.
+- Fix: element_attribute_default now merges attributes.
+
 # v1.1.3 - 2020-01-15
 - Fix: Extending a component will now extend its class defined tag attributes, aria attributes, and data attributes.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    spark-component (1.1.3)
+    spark-component (1.1.4)
 
 GEM
   remote: https://rubygems.org/

data/lib/spark/component/attribute.rb

@@ -75,12 +75,34 @@ module Spark
         end
       end
 
+      # Takes attributes passed to a component or element and assigns values to other
+      # attributes as defined in their group.
+      #
+      # For example, with an attribute group:
+      #   theme: {
+      #     notice: { icon: "message", color: "blue" }
+      #     error: { icon: "error", color: "red" }
+      #   }
+      #
+      # If the attributes include `theme: :notice`, the icon and color attributes
+      # would default to "message" and "blue", but could be overriden if the user
+      # set values for them.
+      #
       def initialize_attribute_default_groups(attrs)
         self.class.attribute_default_groups.each do |group, group_options|
           # Determine what group name is set for this attribute.
+          # In the above example the group would be `theme` and the name
+          # would be the value passed for `theme`, or its default value.
+          #
+          # So `name` might be `:notice`.
           name = attrs[group] || self.class.attributes[group]
 
+          # Normalize name for hash lookup. to_s.to_sym converts booleans as well.
+          name = name.to_s.to_sym unless name.nil?
+
           # Get defaults to set from group name
+          # In the above example, if the name were `notice` this would be the hash
+          # `{ icon: "message", color: "blue" }`
           defaults = group_options[name]
 
           next unless defaults

data/lib/spark/component/element.rb

@@ -95,7 +95,8 @@ module Spark
 
       # Override the default value for an element's attribute(s)
       def set_element_attribute_default(element, attrs = {})
-        element_attribute_default[element] = attrs
+        element_attribute_default[element] ||= {}
+        element_attribute_default[element].merge!(attrs)
       end
 
       def element_attribute_default

data/lib/spark/component/version.rb

@@ -2,6 +2,6 @@
 
 module Spark
   module Component
-    VERSION = "1.1.3"
+    VERSION = "1.1.4"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spark-component
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.1.4
 platform: ruby
 authors:
 - Brandon Mathis
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-15 00:00:00.000000000 Z
+date: 2020-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview-component