spanish_vat_validators 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 042cc74c82fad9975ca931b60656399205481640
-  data.tar.gz: f10c5c00c7a24dfbe6d242233f5853a993caa570
+SHA256:
+  metadata.gz: 995ed6c4e633b68a19b9389d085b5547ed9af33df5fef486b2ee465f4b79cc4c
+  data.tar.gz: c27a6100f2899bec7a73c878408d35d487024ca656411a47e9a68503571524a3
 SHA512:
-  metadata.gz: de01a00f17c2b6a170377962f9684526282ab56e70e80aba607a4d5b58ca3ac964924d3355e49f3fe49831ab99067be8179e07483510c42915b7f89208f89d0b
-  data.tar.gz: 6356d4cb13fbcd74cf0e44693238390a5b54c07d76ecbb982c623865824ab1377df9c1137131a008f5058ea2c800ea17f11332ca6c09c68982006da819966ab1
+  metadata.gz: 91242e0f2e4951057255ce3d7549d135d4caa20aa706cec9ea9c778c95b51f58d61362262a4535c7daed11b30df1e2a8491abcbaff595af41383751bc02c03f9
+  data.tar.gz: 2922558e2018e8f3b5af22a5e33ff85475b0868aaeefb831419fb8c739e3473e2176f62d3304b417c40aec1752f04a46896368ef92c8b4c911a7521dcbd497b2

data/lib/spanish_vat_validators/version.rb

@@ -1,3 +1,3 @@
 module SpanishVatValidators
-  VERSION = '0.0.6'
+  VERSION = '0.0.7'
 end

data/lib/spanish_vat_validators.rb

@@ -13,7 +13,7 @@ module ActiveModel::Validations
     def validate_nif(v)
       return false if v.nil? || v.empty?
       value = v.upcase
-      return false unless value.match(/^[0-9]{8}[a-z]$/i)
+      return false unless value.match(/\A[0-9]{8}[a-z]\z/i)
       letters = "TRWAGMYFPDXBNJZSQVHLCKE"
       check = value.slice!(value.length - 1)
       calculated_letter = letters[value.to_i % 23].chr
@@ -24,12 +24,12 @@ module ActiveModel::Validations
     def validate_cif(v)
       return false if v.nil? || v.empty?
       value = v.clone
-      return false unless value.match(/^[a-wyz][0-9]{7}[0-9a-z]$/i)
+      return false unless value.match(/\A[a-wyz][0-9]{7}[0-9a-z]\z/i)
       even = 0
       odd = 0
       uletter = ["J", "A", "B", "C", "D", "E", "F", "G", "H", "I"]
       text = value.upcase
-      regular = /^[ABCDEFGHJKLMNPQRSVW]\d{7}[0-9,A-J]$/#g);
+      regular = /\A[ABCDEFGHJKLMNPQRSVW]\d{7}[0-9,A-J]\z/i
       if regular.match(value).blank?
         false
       else
@@ -54,7 +54,7 @@ module ActiveModel::Validations
     def validate_nie(v)
       return false if v.nil? || v.empty?
       value = v.upcase
-      return false unless value.match(/^[xyz][0-9]{7}[a-z]$/i)
+      return false unless value.match(/\A[xyz][0-9]{7}[a-z]\z/i)
       value[0] = {"X" => "0", "Y" => "1", "Z" => "2"}[value[0]]
       validate_nif(value)
     end

data/spanish_vat_validators.gemspec

@@ -2,7 +2,7 @@
 require File.expand_path('../lib/spanish_vat_validators/version', __FILE__)
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["Javier Toledo"]
+  gem.authors       = ["David Gil", "Javier Toledo"]
   gem.email         = ["javier@theagilemonkeys.com"]
   gem.description   = %q{Provides validators for spanish VAT numbers (NIF, CIF and NIE)}
   gem.summary       = %q{Provides Rails3+ compatible validators for spanish VAT numbers (NIF, CIF and NIE), with support for I18n}

data/spec/spanish_vat_validators_spec.rb

@@ -22,6 +22,26 @@ describe ActiveModel::Validations::ValidSpanishVatValidator do
         should_be_invalid(record, 'invalid')
       end
     end
+
+    it 'adds errors when there are surrounding characters' do
+      %w[22472947S S6185663I Y8527549Z].each do |identification_number|
+        surrounded = %W[junk#{identification_number} #{identification_number}junk junk#{identification_number}junk]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
+
+    it 'adds errors when there are surrounding lines' do
+      %w[22472947S S6185663I Y8527549Z].each do |identification_number|
+        surrounded = %W[\n#{identification_number} #{identification_number}\n \n#{identification_number}\n]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
   end
 end
 
@@ -48,6 +68,28 @@ describe ActiveModel::Validations::ValidSpanishIdValidator do
         should_be_invalid(record, 'invalid')
       end
     end
+
+    it 'adds errors when there are surrounding characters' do
+      %w[22472947S 96380632Y 28459349T 35696134L 86159868M 29052409M
+         Y8527549Z Y8305424T X9393496C X0012309G Y9370869Q Y2995306F].each do |identification_number|
+        surrounded = %W[junk#{identification_number} #{identification_number}junk junk#{identification_number}junk]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
+
+    it 'adds errors when there are surrounding lines' do
+      %w[22472947S 96380632Y 28459349T 35696134L 86159868M 29052409M
+         Y8527549Z Y8305424T X9393496C X0012309G Y9370869Q Y2995306F].each do |identification_number|
+        surrounded = %W[\n#{identification_number} #{identification_number}\n \n#{identification_number}\n]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
   end
 end
 
@@ -73,6 +115,26 @@ describe ActiveModel::Validations::ValidNifValidator do
         should_be_invalid(record, 'invalid')
       end
     end
+
+    it 'adds errors when there are surrounding characters' do
+      %w[22472947S 96380632Y 28459349T 35696134L 86159868M 29052409M].each do |identification_number|
+        surrounded = %W[junk#{identification_number} #{identification_number}junk junk#{identification_number}junk]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
+
+    it 'adds errors when there are surrounding lines' do
+      %w[22472947S 96380632Y 28459349T 35696134L 86159868M 29052409M].each do |identification_number|
+        surrounded = %W[\n#{identification_number} #{identification_number}\n \n#{identification_number}\n]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
   end
 end
 
@@ -98,6 +160,26 @@ describe ActiveModel::Validations::ValidCifValidator do
         should_be_invalid(record, 'invalid')
       end
     end
+
+    it 'adds errors when there are surrounding characters' do
+      %w[S6185663I C2871341J G37880135 F43766880 A58818501 J27950005 V63423321].each do |identification_number|
+        surrounded = %W[junk#{identification_number} #{identification_number}junk junk#{identification_number}junk]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
+
+    it 'adds errors when there are surrounding lines' do
+      %w[S6185663I C2871341J G37880135 F43766880 A58818501 J27950005 V63423321].each do |identification_number|
+        surrounded = %W[\n#{identification_number} #{identification_number}\n \n#{identification_number}\n]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
   end
 end
 
@@ -123,6 +205,26 @@ describe ActiveModel::Validations::ValidNieValidator do
         should_be_invalid(record, 'invalid')
       end
     end
+
+    it 'adds errors when there are surrounding characters' do
+      %w[Y8527549Z Y8305424T X9393496C X0012309G Y9370869Q Y2995306F].each do |identification_number|
+        surrounded = %W[junk#{identification_number} #{identification_number}junk junk#{identification_number}junk]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
+
+    it 'adds errors when there are surrounding lines' do
+      %w[Y8527549Z Y8305424T X9393496C X0012309G Y9370869Q Y2995306F].each do |identification_number|
+        surrounded = %W[\n#{identification_number} #{identification_number}\n \n#{identification_number}\n]
+        surrounded.each do |surrounded_identification_number|
+          record = build_record(surrounded_identification_number)
+          should_be_invalid(record)
+        end
+      end
+    end
   end
 end
 

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: spanish_vat_validators
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
+- David Gil
 - Javier Toledo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-22 00:00:00.000000000 Z
+date: 2019-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -156,8 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Provides Rails3+ compatible validators for spanish VAT numbers (NIF, CIF