spanish_vat_validators 0.0.1 → 0.0.2

data/README.md

@@ -30,25 +30,25 @@ Or install it yourself as:
 
 Just use any of the following validators.
 
-  # A person id
-  class Person < ActiveRecord::Base
-    validates :dni, :valid_nif => true
-  end
-
-  # A company id
-  class Company < ActiveRecord::Base
-    validates :cif, :valid_cif => true
-  end
-
-  # A foreigner id
-  class Alien < ActiveRecord::Base
-    validates :nie, :valid_nie => true
-  end
-
-  # Any kind of id is valid
-  class SpanishSubject < ActiveRecord::Base
-    validates :id, :valid_spanish_vat => true
-  end
+    # A person id
+    class Person < ActiveRecord::Base
+      validates :dni, :valid_nif => true
+    end
+
+    # A company id
+    class Company < ActiveRecord::Base
+      validates :cif, :valid_cif => true
+    end
+
+    # A foreigner id
+    class Alien < ActiveRecord::Base
+      validates :nie, :valid_nie => true
+    end
+
+    # Any kind of id is valid
+    class SpanishSubject < ActiveRecord::Base
+      validates :id, :valid_spanish_vat => true
+    end
 
 ## Contributing
 

data/lib/spanish_vat_validators.rb

@@ -1,3 +1,4 @@
+#encoding: utf-8
 require "spanish_vat_validators/version"
 
 module ActiveModel::Validations
@@ -8,7 +9,9 @@ module ActiveModel::Validations
     end
 
     # Validates NIF
-    def validate_nif(value)
+    def validate_nif(v)
+      return false if v.nil? || v.empty?
+      value = v.clone
       return false unless value.match(/[0-9]{8}[a-z]/i)
       letters = "TRWAGMYFPDXBNJZSQVHLCKE"
       check = value.slice!(value.length - 1..value.length - 1).upcase
@@ -17,7 +20,9 @@ module ActiveModel::Validations
     end
 
     # Validates CIF
-    def validate_cif(value)
+    def validate_cif(v)
+      return false if v.nil? || v.empty?
+      value = v.clone
       return false unless value.match(/[a-wyz][0-9]{7}[0-9a-z]/i)
       pares = 0
       impares = 0
@@ -49,7 +54,9 @@ module ActiveModel::Validations
 
     # Validates NIE, in fact is a fake, a NIE is really a NIF with first number changed to capital 'X' letter, so we change the first X to a 0 and then try to
     # pass the nif validator
-    def validate_nie(value)
+    def validate_nie(v)
+      return false if v.nil? || v.empty?
+      value = v.clone
       return false unless value.match(/[x][0-9]{7,8}[a-z]/i)
       value[0] = '0'
       value.slice(0) if value.size > 9
@@ -61,7 +68,7 @@ module ActiveModel::Validations
   class ValidSpanishVatValidator < ActiveModel::EachValidator
     include SpanishVatValidatorsHelpers
     def validate_each(record, attribute, value)
-      record.errors[attribute] = message unless validate_nif(value.clone) or validate_cif(value.clone) or validate_nie(value.clone)
+      record.errors[attribute] = message unless validate_nif(value) or validate_cif(value) or validate_nie(value)
     end
   end
 
@@ -69,7 +76,7 @@ module ActiveModel::Validations
   class ValidNifValidator < ActiveModel::EachValidator
     include SpanishVatValidatorsHelpers
     def validate_each(record, attribute,value)
-      record.errors[attribute] = message('nif') unless validate_nif(value.clone)
+      record.errors[attribute] = message('nif') unless validate_nif(value)
     end
   end
 
@@ -77,7 +84,7 @@ module ActiveModel::Validations
   class ValidCifValidator < ActiveModel::EachValidator
     include SpanishVatValidatorsHelpers
     def validate_each(record, attribute,value)
-      record.errors[attribute] = message('cif') unless validate_cif(value.clone)
+      record.errors[attribute] = message('cif') unless validate_cif(value)
     end
   end
 
@@ -85,7 +92,7 @@ module ActiveModel::Validations
   class ValidNieValidator < ActiveModel::EachValidator
     include SpanishVatValidatorsHelpers
     def validate_each(record, attribute,value)
-      record.errors[attribute] = message('nie') unless validate_cif(value.clone)
+      record.errors[attribute] = message('nie') unless validate_cif(value)
     end
   end
 

data/lib/spanish_vat_validators/version.rb

@@ -1,3 +1,3 @@
 module SpanishVatValidators
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spanish_vat_validators
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-22 00:00:00.000000000 Z
+date: 2012-08-25 00:00:00.000000000 Z
 dependencies: []
 description: Provides validators for spanish VAT numbers (NIF, CIF and NIE)
 email: