spaceship 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bee636c5de7df79ede26deda935649fb5a738e3f
-  data.tar.gz: 0e846d25300e1c0658e036f208991f841d55b5d7
+  metadata.gz: 0f8c0b6228e0f397f7f6b04eac0970e292e5dfd9
+  data.tar.gz: 92605b06ec0181b05d85f4ea1c8324a20f8c65d0
 SHA512:
-  metadata.gz: 5a81882cdb7b1169c78d456e4a9c531da3888632ad6d9ecd9cb36d3b546a1c95db5e98a88369d3996847a5a61b5f6b80663fb2db4b4950d612c417e84989d80b
-  data.tar.gz: c894e87a4e5819716c5959cfeba5b8de19b2b82c91ef46c4ab506225e1fabfedd51058a46b1ca545eaabd7ae48bf8bbad3499a276f453ca930759d0fe7cd9197
+  metadata.gz: cf24cf176b3e186e21f8e9acdd4ebe51625a7f22d6ec0035aea748ea7255b1b11142b31fb5549d9c58f1544b743158db66506e6dd002df0b1c1b186dd0ccf9bc
+  data.tar.gz: 4d94ea406b064d1e2aeb86c8ec8f55995485753b5e201a5122c1792bb4a181648cb6057d5e6d99763879da4c7b73c525dc711438c18a38d57b46d03862dc4275

data/README.md

@@ -16,7 +16,8 @@
   <a href="https://github.com/KrauseFx/codes">codes</a> &bull;
   <b>spaceship</b> &bull;
   <a href="https://github.com/fastlane/pilot">pilot</a> &bull;
-  <a href="https://github.com/fastlane/boarding">boarding</a>
+  <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
+  <a href="https://github.com/fastlane/gym">gym</a>
 </p>
 -------
 
@@ -180,12 +181,3 @@ The initial release was sponsored by [ZeroPush](https://zeropush.com).
 This project is licensed under the terms of the MIT license. See the LICENSE file.
 
 > This project and all fastlane tools are in no way affiliated with Apple Inc. This project is open source under the MIT license, which means you have full access to the source code and can modify it to fit your own needs. All fastlane tools run on your own computer or server, so your credentials or other sensitive information will never leave your own computer. You are responsible for how you use fastlane tools.
-
-# Contributing
-
-1. Create an issue to start a discussion about your idea
-2. Fork it (https://github.com/fastlane/spaceship/fork)
-3. Create your feature branch (`git checkout -b my-new-feature`)
-4. Commit your changes (`git commit -am 'Add some feature'`)
-5. Push to the branch (`git push origin my-new-feature`)
-6. Create a new Pull Request

data/lib/spaceship/base.rb

@@ -62,10 +62,12 @@ module Spaceship
       ##
       # Sets client and returns self for chaining.
       # @return (Spaceship::Base)
+      # rubocop:disable Style/AccessorMethodName
       def set_client(client)
         self.client = client
         self
       end
+      # rubocop:enable Style/AccessorMethodName
 
       ##
       # Binds attributes getters and setters to underlying data returned from the API.
@@ -143,7 +145,7 @@ module Spaceship
       def method_missing(method_sym, *args, &block)
         module_name = method_sym.to_s
         module_name.sub!(/^[a-z\d]/) { $&.upcase }
-        module_name.gsub!(/(?:_|(\/))([a-z\d])/) { $2.upcase }
+        module_name.gsub!(%r{(?:_|(/))([a-z\d])}) { $2.upcase }
         if const_defined?(module_name)
           klass = const_get(module_name)
           klass.set_client(@client)
@@ -153,6 +155,10 @@ module Spaceship
       end
     end
 
+    ##
+    # @return (Spaceship::Client) The current spaceship client used by the model to make requests.
+    attr_reader :client
+
     ##
     # @return (Hash/Array) Holds the raw data we got from Apple's
     #   server to use it later
@@ -177,12 +183,6 @@ module Spaceship
     def setup
     end
 
-    ##
-    # @return (Spaceship::Client) The current spaceship client used by the model to make requests.
-    def client
-      @client
-    end
-
     #####################################################
     # @!group Storing the `attr_accessor`
     #####################################################

data/lib/spaceship/client.rb

@@ -48,7 +48,7 @@ module Spaceship
       if instance.login(user, password)
         instance
       else
-        raise InvalidUserCredentialsError.new
+        raise InvalidUserCredentialsError.new, "Invalid User Credentials"
       end
     end
 
@@ -76,6 +76,7 @@ module Spaceship
     # /tmp/spaceship[time].log by default
     def logger
       unless @logger
+        # rubocop:disable Style/GlobalVars
         if $verbose || ENV["VERBOSE"]
           @logger = Logger.new(STDOUT)
         else
@@ -83,9 +84,10 @@ module Spaceship
           path = "/tmp/spaceship#{Time.now.to_i}.log"
           @logger = Logger.new(path)
         end
+        # rubocop:enable Style/GlobalVars
 
         @logger.formatter = proc do |severity, datetime, progname, msg|
-          string = "[#{datetime.strftime('%H:%M:%S')}]: #{msg}\n"
+          "[#{datetime.strftime('%H:%M:%S')}]: #{msg}\n"
         end
       end
 
@@ -110,9 +112,9 @@ module Spaceship
         page += 1
         current = yield(page)
 
-        results = results + current
+        results += current
 
-        break if ((current || []).count < page_size) # no more results
+        break if (current || []).count < page_size # no more results
       end
 
       return results
@@ -144,7 +146,7 @@ module Spaceship
       end
 
       if user.to_s.strip.empty? or password.to_s.strip.empty?
-        raise NoUserCredentialsError.new("No login data provided")
+        raise NoUserCredentialsError.new, "No login data provided"
       end
 
       send_login_request(user, password) # different in subclasses
@@ -171,14 +173,14 @@ module Spaceship
     # Is called from `parse_response` to store the latest csrf_token (if available)
     def store_csrf_tokens(response)
       if response and response.headers
-        tokens = response.headers.select { |k, v| %w[csrf csrf_ts].include?(k) }
-        if tokens and not tokens.empty?
+        tokens = response.headers.select { |k, v| %w(csrf csrf_ts).include?(k) }
+        if tokens and !tokens.empty?
           @csrf_tokens = tokens
         end
       end
     end
 
-      # memoize the last csrf tokens from responses
+    # memorize the last csrf tokens from responses
     def csrf_tokens
       @csrf_tokens || {}
     end
@@ -220,8 +222,8 @@ module Spaceship
       logger.debug("#{method.upcase}: #{url}: #{response.body}")
     end
 
-      # Actually sends the request to the remote server
-      # Automatically retries the request up to 3 times if something goes wrong
+    # Actually sends the request to the remote server
+    # Automatically retries the request up to 3 times if something goes wrong
     def send_request(method, url_or_path, params, headers, &block)
       with_retry do
         @client.send(method, url_or_path, params, headers, &block)
@@ -235,8 +237,8 @@ module Spaceship
         content = response.body
       end
 
-      if content == nil
-        raise UnexpectedResponse.new(response.body)
+      if content.nil?
+        raise UnexpectedResponse.new, response.body
       else
         store_csrf_tokens(response)
         content

data/lib/spaceship/helper/plist_middleware.rb

@@ -7,7 +7,7 @@ module FaradayMiddleware
     end
 
     define_parser do |body|
-      Plist::parse_xml(body)
+      Plist.parse_xml(body)
     end
   end
 end

data/lib/spaceship/portal/certificate.rb

@@ -130,7 +130,7 @@ module Spaceship
         "4APLUP237T" => ApplePay
       }
 
-      #class methods
+      # Class methods
       class << self
         # Create a new code signing request that can be used to
         # generate a new certificate
@@ -181,8 +181,10 @@ module Spaceship
           end
 
           # Parse the dates
+          # rubocop:disable Style/RescueModifier
           attrs['expirationDate'] = (Time.parse(attrs['expirationDate']) rescue attrs['expirationDate'])
           attrs['dateCreated'] = (Time.parse(attrs['dateCreated']) rescue attrs['dateCreated'])
+          # rubocop:enable Style/RescueModifier
 
           # Here we go
           klass = CERTIFICATE_TYPE_IDS[attrs['certificateTypeDisplayId']]
@@ -265,9 +267,11 @@ module Spaceship
       end
 
       # @return (Bool): Is this certificate a push profile for apps?
+      # rubocop:disable Style/PredicateName
       def is_push?
         self.kind_of? PushCertificate
       end
+      # rubocop:enable Style/PredicateName
     end
   end
 end

data/lib/spaceship/portal/device.rb

@@ -27,12 +27,28 @@ module Spaceship
       #   "c"
       attr_accessor :status
 
+      # @return (String) Model (can be nil)
+      # @example
+      #   'iPhone 6', 'iPhone 4 GSM'
+      attr_accessor :model
+
+      # @return (String) Device type
+      # @example
+      #   'pc'     - Apple TV
+      #   'watch'  - Apple Watch
+      #   'ipad'   - iPad
+      #   'iphone' - iPhone
+      #   'ipod'   - iPod
+      attr_accessor :device_type
+
       attr_mapping({
         'deviceId' => :id,
         'name' => :name,
         'deviceNumber' => :udid,
         'devicePlatform' => :platform,
-        'status' => :status
+        'status' => :status,
+        'deviceClass' => :device_type,
+        'model' => :model
       })
 
       class << self
@@ -47,6 +63,31 @@ module Spaceship
           client.devices.map { |device| self.factory(device) }
         end
 
+        # @return (Array) Returns all Apple TVs registered for this account
+        def all_apple_tvs
+          client.devices_by_class('pc').map { |device| self.factory(device) }
+        end
+
+        # @return (Array) Returns all Watches registered for this account
+        def all_watches
+          client.devices_by_class('watch').map { |device| self.factory(device) }
+        end
+
+        # @return (Array) Returns all iPads registered for this account
+        def all_ipads
+          client.devices_by_class('ipad').map { |device| self.factory(device) }
+        end
+
+        # @return (Array) Returns all iPhones registered for this account
+        def all_iphones
+          client.devices_by_class('iphone').map { |device| self.factory(device) }
+        end
+
+        # @return (Array) Returns all iPods registered for this account
+        def all_ipod_touches
+          client.devices_by_class('ipod').map { |device| self.factory(device) }
+        end
+
         # @return (Device) Find a device based on the ID of the device. *Attention*:
         #  This is *not* the UDID. nil if no device was found.
         def find(device_id)
@@ -77,7 +118,7 @@ module Spaceship
         # @return (Device): The newly created device
         def create!(name: nil, udid: nil)
           # Check whether the user has passed in a UDID and a name
-          unless (udid and name)
+          unless udid && name
             raise "You cannot create a device without a device_id (UDID) and name"
           end
 
@@ -86,10 +127,7 @@ module Spaceship
             raise "The device UDID '#{udid}' already exists on this team."
           end
 
-          # Find the device by name, raise an exception if it already exists
-          if self.find_by_name(name)
-            raise "The device name '#{name}' already exists on this team, use different one."
-          end
+          # It is valid to have the same name for multiple devices
 
           device = client.create_device!(name, udid)
 

data/lib/spaceship/portal/portal_base.rb

@@ -3,10 +3,10 @@ module Spaceship
     class << self
       def client
         (
-            @client or
-            Spaceship::Portal.client or
-            raise "Please login using `Spaceship::Portal.login('user', 'password')`"
-          )
+          @client or
+          Spaceship::Portal.client or
+          raise "Please login using `Spaceship::Portal.login('user', 'password')`"
+        )
       end
     end
   end

data/lib/spaceship/portal/portal_client.rb

@@ -22,12 +22,12 @@ module Spaceship
       logger.info("GET: " + landing_url)
       headers = @client.get(landing_url).headers
       results = headers['location'].match(/.*appIdKey=(\h+)/)
-      if results.length > 1
+      if (results || []).length > 1
         api_key = results[1]
         File.write(cache_path, api_key)
         return api_key
       else
-        raise "Could not find latest API Key from the Dev Portal"
+        raise "Could not find latest API Key from the Dev Portal - the server might be slow right now"
       end
     end
 
@@ -43,7 +43,7 @@ module Spaceship
         return @client
       else
         # User Credentials are wrong
-        raise InvalidUserCredentialsError.new(response)
+        raise InvalidUserCredentialsError.new, response
       end
     end
 
@@ -123,11 +123,11 @@ module Spaceship
     end
 
     def associate_groups_with_app(app, groups)
-      r = request(:post, 'account/ios/identifiers/assignApplicationGroupToAppId.action', {
+      request(:post, 'account/ios/identifiers/assignApplicationGroupToAppId.action', {
         teamId: team_id,
         appIdId: app.app_id,
         displayId: app.app_id,
-        applicationGroups: groups.map { |g| g.app_group_id }
+        applicationGroups: groups.map(&:app_group_id)
       })
 
       details_for_app(app)
@@ -135,21 +135,21 @@ module Spaceship
 
     def create_app!(type, name, bundle_id)
       ident_params = case type.to_sym
-      when :explicit
-        {
-          type: 'explicit',
-          explicitIdentifier: bundle_id,
-          appIdentifierString: bundle_id,
-          push: 'on',
-          inAppPurchase: 'on',
-          gameCenter: 'on'
-        }
-      when :wildcard
-        {
-          type: 'wildcard',
-          wildcardIdentifier: bundle_id,
-          appIdentifierString: bundle_id
-        }
+                     when :explicit
+                       {
+                         type: 'explicit',
+                         explicitIdentifier: bundle_id,
+                         appIdentifierString: bundle_id,
+                         push: 'on',
+                         inAppPurchase: 'on',
+                         gameCenter: 'on'
+                       }
+                     when :wildcard
+                       {
+                         type: 'wildcard',
+                         wildcardIdentifier: bundle_id,
+                         appIdentifierString: bundle_id
+                       }
       end
 
       params = {
@@ -220,6 +220,19 @@ module Spaceship
       end
     end
 
+    def devices_by_class(deviceClass)
+      paging do |page_number|
+        r = request(:post, 'account/ios/device/listDevices.action', {
+          teamId: team_id,
+          pageNumber: page_number,
+          pageSize: page_size,
+          sort: 'name=asc',
+          deviceClasses: deviceClass
+        })
+        parse_response(r, 'devices')
+      end
+    end
+
     def create_device!(device_name, device_id)
       req = request(:post) do |r|
         r.url "https://developerservices2.apple.com/services/#{PROTOCOL_VERSION}/ios/addDevice.action"

data/lib/spaceship/portal/provisioning_profile.rb

@@ -152,16 +152,16 @@ module Spaceship
           # available values of `distributionMethod` at this point: ['adhoc', 'store', 'limited']
 
           klass = case attrs['distributionMethod']
-          when 'limited'
-            Development
-          when 'store'
-            AppStore
-          when 'adhoc'
-            AdHoc
-          when 'inhouse'
-            InHouse
-          else
-            raise "Can't find class '#{attrs['distributionMethod']}'"
+                  when 'limited'
+                    Development
+                  when 'store'
+                    AppStore
+                  when 'adhoc'
+                    AdHoc
+                  when 'inhouse'
+                    InHouse
+                  else
+                    raise "Can't find class '#{attrs['distributionMethod']}'"
           end
 
           attrs['appId'] = App.factory(attrs['appId'])
@@ -202,9 +202,9 @@ module Spaceship
           # Fill in sensible default values
           name ||= [bundle_id, self.pretty_type].join(' ')
 
-          devices = [] if (self == AppStore or self == InHouse) # App Store Profiles MUST NOT have devices
+          devices = [] if self == AppStore || self == InHouse # App Store Profiles MUST NOT have devices
 
-          certificate_parameter = certificate.collect { |c| c.id } if certificate.kind_of? Array
+          certificate_parameter = certificate.collect(&:id) if certificate.kind_of? Array
           certificate_parameter ||= [certificate.id]
 
           # Fix https://github.com/KrauseFx/fastlane/issues/349
@@ -222,7 +222,7 @@ module Spaceship
                                                 self.type,
                                                 app.app_id,
                                                 certificate_parameter,
-                                                devices.map {|d| d.id} )
+                                                devices.map(&:id) )
           end
 
           self.new(profile)
@@ -237,9 +237,7 @@ module Spaceship
           end
 
           # filter out the profiles managed by xcode
-          profiles.delete_if do |profile|
-            profile.managed_by_xcode?
-          end
+          profiles.delete_if(&:managed_by_xcode?)
 
           return profiles if self == ProvisioningProfile
 
@@ -335,8 +333,8 @@ module Spaceship
             name,
             distribution_method,
             app.app_id,
-            certificates.map { |c| c.id },
-            devices.map { |d| d.id }
+            certificates.map(&:id),
+            devices.map(&:id)
           )
         end
 
@@ -353,7 +351,7 @@ module Spaceship
       def certificate_valid?
         return false if (certificates || []).count == 0
         certificates.each do |c|
-          if Spaceship::Certificate.all.collect { |s| s.id }.include?(c.id)
+          if Spaceship::Certificate.all.collect(&:id).include?(c.id)
             return true
           end
         end

data/lib/spaceship/tunes/app_submission.rb

@@ -98,8 +98,6 @@ module Spaceship
         # Create a new object based on a hash.
         # This is used to create a new object based on the server response.
         def factory(attrs)
-          orig = attrs.dup
-
           # fill content rights section if iTC returns nil
           if attrs["contentRights"].nil?
             attrs.merge!("contentRights" => {
@@ -117,8 +115,7 @@ module Spaceship
         end
 
         # @param application (Spaceship::Tunes::Application) The app this submission is for
-        # @param app_id (String) The unique Apple ID of this app
-        def create(application, app_id, version)
+        def create(application, version)
           stage = "start"
           attrs = client.send_app_submission(application.apple_id, version.raw_data, stage)
           attrs.merge!(application: application)

data/lib/spaceship/tunes/app_version.rb

@@ -161,7 +161,6 @@ module Spaceship
         # Create a new object based on a hash.
         # This is used to create a new object based on the server response.
         def factory(attrs)
-          orig = attrs.dup
           obj = self.new(attrs)
           obj.unfold_languages
 
@@ -181,9 +180,11 @@ module Spaceship
       end
 
       # @return (Bool) Is that version currently available in the App Store?
+      # rubocop:disable Style/PredicateName
       def is_live?
         is_live
       end
+      # rubocop:enable Style/PredicateName
 
       # Call this method to make sure the given languages are available for this app
       # You should call this method before accessing the name, description and other localized values
@@ -264,7 +265,7 @@ module Spaceship
       end
 
       def supports_apple_watch
-        (super != nil)
+        !super.nil?
       end
 
       def primary_category=(value)
@@ -299,7 +300,7 @@ module Spaceship
 
       private
 
-        # generates the nested data structure to represent screenshots
+      # generates the nested data structure to represent screenshots
       def setup_screenshots(row)
         screenshots = row.fetch('screenshots', {}).fetch('value', nil)
         return [] unless screenshots

data/lib/spaceship/tunes/application.rb

@@ -101,7 +101,7 @@ module Spaceship
       # @return (Spaceship::AppVersion) Receive the version that is currently live on the
       #  App Store. You can't modify all values there, so be careful.
       def live_version
-        v = Spaceship::AppVersion.find(self, self.apple_id, true)
+        Spaceship::AppVersion.find(self, self.apple_id, true)
       end
 
       # @return (Spaceship::AppVersion) Receive the version that can fully be edited
@@ -210,7 +210,7 @@ module Spaceship
           raise "Could not find a valid version to submit for review"
         end
 
-        Spaceship::AppSubmission.create(self, self.apple_id, version)
+        Spaceship::AppSubmission.create(self, version)
       end
 
       # Cancels all ongoing TestFlight beta submission for this application
@@ -218,7 +218,7 @@ module Spaceship
         self.builds do |build|
           begin
             build.cancel_beta_review!
-          rescue => ex
+          rescue
             # We really don't care about any errors here
           end
         end

data/lib/spaceship/tunes/build.rb

@@ -146,7 +146,6 @@ module Spaceship
 
           # Optional Metadata:
           privacy_policy_url: nil,
-          review_notes: nil,
           review_user_name: nil,
           review_password: nil,
           encryption: false
@@ -170,7 +169,7 @@ module Spaceship
           end
         end
 
-        if (Time.at(self.internal_expiry_date / 1000) > Time.now)
+        if Time.at(self.internal_expiry_date / 1000) > Time.now
           testing ||= "Inactive"
         else
           testing = "Expired"
@@ -190,35 +189,35 @@ module Spaceship
 end
 
 # Example response
-  # "buildVersion": "0.9.10",
-  # "trainVersion": "0.9.10",
-  # "uploadDate": 1413966436000,
-  # "iconUrl": "https://is5-ssl.mzstatic.com/image/thumb/Newsstand5/v4/e8/ab/f8/e8abf8ca-6c22-a519-aa1b-c73901c4917e/Icon-60@2x.png.png/150x150bb-80.png",
-  # "appName": "Yeahaa",
-  # "platform": "ios",
-  # "betaEntitled": false,
-  # "id": 523299,
-  # "valid": true,
-  # "missingExportCompliance": false,
-  # "waitingForExportComplianceApproval": false,
-  # "addedInternalUsersCount": 0,
-  # "addedExternalUsersCount": 0,
-  # "invitedExternalUsersCount": 0,
-  # "invitedInternalUsersCount": 0,
-  # "acceptedInternalUsersCount": 0,
-  # "acceptedExternalUsersCount": 0,
-  # "installCount": 0,
-  # "internalInstallCount": 0,
-  # "externalInstallCount": 0,
-  # "sessionCount": null,
-  # "crashCount": null,
-  # "promotedVersion": null,
-  # "internalState": "noBetaEntitlement",
-  # "betaState": "noBetaEntitlement",
-  # "internalExpiry": 1416562036000,
-  # "externalExpiry": 0,
-  # "watchKitEnabled": false,
-  # "readyToInstall": false,
-  # "sdkBuildWhitelisted": true,
-  # "internalTesting": null,
-  # "externalTesting": null
+#   "buildVersion": "0.9.10",
+#   "trainVersion": "0.9.10",
+#   "uploadDate": 1413966436000,
+#   "iconUrl": "https://is5-ssl.mzstatic.com/image/thumb/Newsstand5/v4/e8/ab/f8/e8abf8ca-6c22-a519-aa1b-c73901c4917e/Icon-60@2x.png.png/150x150bb-80.png",
+#   "appName": "Yeahaa",
+#   "platform": "ios",
+#   "betaEntitled": false,
+#   "id": 523299,
+#   "valid": true,
+#   "missingExportCompliance": false,
+#   "waitingForExportComplianceApproval": false,
+#   "addedInternalUsersCount": 0,
+#   "addedExternalUsersCount": 0,
+#   "invitedExternalUsersCount": 0,
+#   "invitedInternalUsersCount": 0,
+#   "acceptedInternalUsersCount": 0,
+#   "acceptedExternalUsersCount": 0,
+#   "installCount": 0,
+#   "internalInstallCount": 0,
+#   "externalInstallCount": 0,
+#   "sessionCount": null,
+#   "crashCount": null,
+#   "promotedVersion": null,
+#   "internalState": "noBetaEntitlement",
+#   "betaState": "noBetaEntitlement",
+#   "internalExpiry": 1416562036000,
+#   "externalExpiry": 0,
+#   "watchKitEnabled": false,
+#   "readyToInstall": false,
+#   "sdkBuildWhitelisted": true,
+#   "internalTesting": null,
+#   "externalTesting": null

data/lib/spaceship/tunes/language_converter.rb

@@ -29,16 +29,16 @@ module Spaceship
 
         private
 
-          # Path to the gem to fetch resoures
+        # Path to the gem to fetch resoures
         def spaceship_gem_path
-          if Gem::Specification::find_all_by_name('spaceship').any?
+          if Gem::Specification.find_all_by_name('spaceship').any?
             return Gem::Specification.find_by_name('spaceship').gem_dir
           else
             return './'
           end
         end
 
-          # Get the mapping JSON parsed
+        # Get the mapping JSON parsed
         def mapping
           @languages ||= JSON.parse(File.read(File.join(spaceship_gem_path, "lib", "assets", "languageMapping.json")))
         end

data/lib/spaceship/tunes/tunes_client.rb

@@ -24,7 +24,7 @@ module Spaceship
 
       host = "https://itunesconnect.apple.com"
       begin
-        url = host + request(:get, self.class.hostname).body.match(/action="(\/WebObjects\/iTunesConnect.woa\/wo\/.*)"/)[1]
+        url = host + request(:get, self.class.hostname).body.match(%r{action="(/WebObjects/iTunesConnect.woa/wo/.*)"})[1]
         raise "" unless url.length > 0
 
         File.write(cache_path, url)
@@ -57,15 +57,15 @@ module Spaceship
           ]
 
           @cookie = to_use.join(';')
-        rescue => ex
+        rescue
           # User Credentials are wrong
-          raise InvalidUserCredentialsError.new(response)
+          raise InvalidUserCredentialsError.new, response
         end
 
         return @client
       else
         # User Credentials are wrong
-        raise InvalidUserCredentialsError.new(response)
+        raise InvalidUserCredentialsError.new, response
       end
     end
 
@@ -86,24 +86,23 @@ module Spaceship
         errors = []
         if hash.kind_of? Hash
           hash.each do |key, value|
-            errors = errors + handle_response_hash.call(value)
+            errors += handle_response_hash.call(value)
 
             if key == 'errorKeys' and value.kind_of? Array and value.count > 0
-              errors = errors + value
+              errors += value
             end
           end
         elsif hash.kind_of? Array
           hash.each do |value|
-            errors = errors + handle_response_hash.call(value)
+            errors += handle_response_hash.call(value)
           end
-        else
-          # We don't care about simple values
+          # else: We don't care about simple values
         end
         return errors
       end
 
       errors = handle_response_hash.call(data)
-      errors = errors + data.fetch('sectionErrorKeys') if data['sectionErrorKeys']
+      errors += data.fetch('sectionErrorKeys') if data['sectionErrorKeys']
 
       # Sometimes there is a different kind of error in the JSON response
       # e.g. {"warn"=>nil, "error"=>["operation_failed"], "info"=>nil}
@@ -111,7 +110,7 @@ module Spaceship
       errors << different_error if different_error
 
       if errors.count > 0 # they are separated by `.` by default
-        raise ITunesConnectError.new(errors.join(' '))
+        raise ITunesConnectError.new, errors.join(' ')
       end
 
       puts data['sectionInfoKeys'] if data['sectionInfoKeys']
@@ -176,7 +175,7 @@ module Spaceship
 
     def get_resolution_center(app_id)
       r = request(:get, "ra/apps/#{app_id}/resolutionCenter?v=latest")
-      data = parse_response(r, 'data')
+      parse_response(r, 'data')
     end
 
     #####################################################
@@ -214,7 +213,7 @@ module Spaceship
       raise "app_id is required" unless app_id
 
       r = request(:get, "ra/apps/#{app_id}/trains/")
-      data = parse_response(r, 'data')
+      parse_response(r, 'data')
     end
 
     def update_build_trains!(app_id, data)
@@ -242,7 +241,6 @@ module Spaceship
                                             app_id: nil,
                                             train: nil,
                                             build_number: nil,
-                                            cancel_other_submissions: false,
 
                                             # Required Metadata:
                                             changelog: nil,
@@ -256,7 +254,6 @@ module Spaceship
 
                                             # Optional Metadata:
                                             privacy_policy_url: nil,
-                                            review_notes: nil,
                                             review_user_name: nil,
                                             review_password: nil,
                                             encryption: false)

data/lib/spaceship/ui.rb

@@ -7,21 +7,21 @@ end
 module Spaceship
   class Client
     # Public getter for all UI related code
+    # rubocop:disable Style/MethodName
     def UI
       UserInterface.new(self)
     end
+    # rubocop:enable Style/MethodName
 
     # All User Interface related code lives in this class
     class UserInterface
+      # Access the client this UserInterface object is for
+      attr_reader :client
+
       # Is called by the client to generate one instance of UserInterface
       def initialize(c)
         @client = c
       end
-
-      # Access the client this UserInterface object is for
-      def client
-        @client
-      end
     end
   end
 end

data/lib/spaceship/version.rb

@@ -1,3 +1,3 @@
 module Spaceship
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
-- Stefan Natchev
 - Felix Krause
+- Stefan Natchev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-07 00:00:00.000000000 Z
+date: 2015-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager
@@ -95,6 +95,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: fastlane
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.15.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.15.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -210,8 +224,8 @@ dependencies:
 description: Because you would rather spend your time building stuff than fighting
   provisioning
 email:
-- stefan@natchev.com
 - spaceship@krausefx.com
+- stefan@natchev.com
 executables: []
 extensions: []
 extra_rdoc_files: []