spaceship 0.38.5 → 0.39.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e2d0423843f2bf21256f59a2703893b78836bb8
-  data.tar.gz: 538db633652b1b2bb6adb9018a5800208720eda1
+  metadata.gz: 76862f69fcc199bcda08fcab61497db6a41e3873
+  data.tar.gz: ce8e7254767f3efd3c1dfe4ff9745c277db99bbf
 SHA512:
-  metadata.gz: 25dcdb5312db9d7efd4a886ef26e195cc7214cf2c10b54f5a6031fef186ade6d2638bb7497444384b4e78e794bcbea3e557ca5e59d870dd8fd89656da3067e1d
-  data.tar.gz: 04565a1c6d91b4560d1963fc9154d891d1b4a724852000126cdc32d0be65b89c16f8bc74902e2ddcba0cad21aa834274ba7b9cac05bbbaaf73d4fbed5a19718e
+  metadata.gz: 356d066446fa9befa67bbc553897ce3fabd260a061c1b14ed1246d1edaf7223b700084fa8bcca7b78bc706a65afa03f12e73dcdeda91b1c877d446b7315fd77c
+  data.tar.gz: a306ce8b516182d6816b6563fc1c01b148270ee27db80e87fa625c018a369f00902800ebe1dfef7debd9442dec337d4022f8875a59b0e861b2e5d2131e1f3ab4

data/lib/spaceship/base.rb

@@ -185,8 +185,7 @@ module Spaceship
 
     # This method can be used by subclasses to do additional initialisation
     # using the `raw_data`
-    def setup
-    end
+    def setup; end
 
     #####################################################
     # @!group Storing the `attr_accessor`

data/lib/spaceship/portal/provisioning_profile.rb

@@ -426,9 +426,11 @@ module Spaceship
       def devices
         fetch_details
 
-        @devices = (self.profile_details["devices"] || []).collect do |device|
-          Device.set_client(client).factory(device)
-        end if (@devices || []).empty?
+        if (@devices || []).empty?
+          @devices = (self.profile_details["devices"] || []).collect do |device|
+            Device.set_client(client).factory(device)
+          end
+        end
 
         @devices
       end
@@ -436,9 +438,11 @@ module Spaceship
       def certificates
         fetch_details
 
-        @certificates = (profile_details["certificates"] || []).collect do |cert|
-          Certificate.set_client(client).factory(cert)
-        end if (@certificates || []).empty?
+        if (@certificates || []).empty?
+          @certificates = (profile_details["certificates"] || []).collect do |cert|
+            Certificate.set_client(client).factory(cert)
+          end
+        end
 
         return @certificates
       end

data/lib/spaceship/tunes/app_details.rb

@@ -122,8 +122,7 @@ module Spaceship
       #####################################################
       # @!group General
       #####################################################
-      def setup
-      end
+      def setup; end
 
       private
 

data/lib/spaceship/tunes/app_image.rb

@@ -12,6 +12,8 @@ module Spaceship
 
       attr_accessor :url
 
+      attr_accessor :is_imessage
+
       attr_mapping(
         'assetToken' => :asset_token,
         'sortOrder' => :sort_order,

data/lib/spaceship/tunes/app_version.rb

@@ -702,7 +702,8 @@ module Spaceship
             screenshot_data = screenshot["value"]
             data = {
                 device_type: display_family['name'],
-                language: row["language"]
+                language: row["language"],
+                is_imessage: true # to identify imessage screenshots later on (e.g: during download)
             }.merge(screenshot_data)
             result << Tunes::AppScreenshot.factory(data)
           end

data/lib/spaceship/tunes/application.rb

@@ -61,9 +61,10 @@ module Spaceship
 
         # @return (Spaceship::Tunes::Application) Returns the application matching the parameter
         #   as either the App ID or the bundle identifier
-        def find(identifier)
+        def find(identifier, mac: false)
           all.find do |app|
-            (app.apple_id == identifier.to_s or app.bundle_id == identifier)
+            (app.apple_id == identifier.to_s || app.bundle_id == identifier) &&
+              app.version_sets.any? { |v| v.platform == (mac ? "osx" : "ios") }
           end
         end
 
@@ -79,14 +80,18 @@ module Spaceship
         #   can't be changed after you submit your first build.
         # @param company_name (String): The company name or developer name to display on the App Store for your apps.
         # It cannot be changed after you create your first app.
-        def create!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil)
+        # @param platform (String): Platform one of (ios,osx)
+        #  should it be an ios or an osx app
+
+        def create!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil)
           client.create_application!(name: name,
                          primary_language: primary_language,
                                   version: version,
                                       sku: sku,
                                 bundle_id: bundle_id,
                                 bundle_id_suffix: bundle_id_suffix,
-                                company_name: company_name)
+                                company_name: company_name,
+                                    platform: platform)
         end
       end
 

data/lib/spaceship/tunes/build_train.rb

@@ -118,11 +118,12 @@ module Spaceship
 
       # @param (testing_type) internal or external
       def update_testing_status!(new_value, testing_type, build = nil)
-        data = client.build_trains(self.application.apple_id, testing_type, platform: self.application.platform)
-
         build ||= latest_build if testing_type == 'external'
+        platform = build ? build.platform : self.application.platform
         testing_key = "#{testing_type}Testing"
 
+        data = client.build_trains(self.application.apple_id, testing_type, platform: platform)
+
         # Delete the irrelevant trains and update the relevant one to enable testing
         data['trains'].delete_if do |train|
           if train['versionString'] != version_string

data/lib/spaceship/tunes/tunes_client.rb

@@ -264,11 +264,11 @@ module Spaceship
     # @param sku (String): A unique ID for your app that is not visible on the App Store.
     # @param bundle_id (String): The bundle ID must match the one you used in Xcode. It
     #   can't be changed after you submit your first build.
-    def create_application!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil)
+    def create_application!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil)
       # First, we need to fetch the data from Apple, which we then modify with the user's values
       primary_language ||= "English"
-      app_type = 'ios'
-      r = request(:get, "ra/apps/create/v2/?platformString=#{app_type}")
+      platform ||= "ios"
+      r = request(:get, "ra/apps/create/v2/?platformString=#{platform}")
       data = parse_response(r, 'data')
 
       # Now fill in the values we have
@@ -281,10 +281,10 @@ module Spaceship
       data['vendorId'] = { value: sku }
       data['bundleIdSuffix'] = { value: bundle_id_suffix }
       data['companyName'] = { value: company_name } if company_name
-      data['enabledPlatformsForCreation'] = { value: [app_type] }
+      data['enabledPlatformsForCreation'] = { value: [platform] }
 
-      data['initialPlatform'] = app_type
-      data['enabledPlatformsForCreation'] = { value: [app_type] }
+      data['initialPlatform'] = platform
+      data['enabledPlatformsForCreation'] = { value: [platform] }
 
       # Now send back the modified hash
       r = request(:post) do |req|

data/lib/spaceship/version.rb

@@ -1,4 +1,4 @@
 module Spaceship
-  VERSION = "0.38.5".freeze
+  VERSION = "0.39.0".freeze
   DESCRIPTION = "Ruby library to access the Apple Dev Center and iTunes Connect".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.38.5
+  version: 0.39.0
 platform: ruby
 authors:
 - Felix Krause
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-05 00:00:00.000000000 Z
+date: 2016-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager
@@ -105,14 +105,14 @@ dependencies:
   name: fastimage
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
@@ -417,7 +417,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Ruby library to access the Apple Dev Center and iTunes Connect