spaceship 0.38.3 → 0.38.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aae5d35a4c23744e481a23cef1fa491b14776c3e
-  data.tar.gz: 1731dad227784f370063203f9872696dd7214669
+  metadata.gz: 5a0b40b9749f12ba27a122c73293eca70cbd3126
+  data.tar.gz: a7e094dd79ed180c483b6dcf311d09c8d1321aa4
 SHA512:
-  metadata.gz: 32170186f60ac67542177b62e63f08ff6add6de77c2e151856127c756ff8491c1a497b83f778c4b6143f7631901594583bbc8f575a244c7a45af5577097f1ac8
-  data.tar.gz: 698b62cd941759dfc62c57ef01c9acaccc356f0aef9ca2b8f13244130cc7eb10e9d551d80a772fd80906af769e0f8d5edb1b232ac67aebbcc89cb4186cabf73c
+  metadata.gz: 9505aee9d3c1cd29fb389d22cad898c21d4c044b0061f5d6e842064bdc26d8aeb52a0f5c72586894f10910e4c79f0fa019289499872c3b07cda46fb7cc253bd0
+  data.tar.gz: 19be4b30b6ddf123b5b6794f288d3e44570862a5ed8fe9283f5dbe29d97d13ea9f7d07059913a049e16bf70584ac450234ffc39f76c42558ff7a170ccae56e0f

data/lib/spaceship/babosa_fix.rb

@@ -0,0 +1,28 @@
+# Babosa has a conflict with the unicode-string_width gem. unicode-string_width defines
+# a module called `Unicode`, but Babosa uses the presence of this constant as
+# the sign that it should try to require the `unicode` gem, which will not be present.
+#
+# We don't want to introduce the `unicode` gem because it depends on native extensions.
+#
+# This works around the possibility that the unicode-string_width gem may already be
+# loaded by temporarily undefining the `Unicode` constant while we load Babosa,
+# then restoring it to its previous state if necessary.
+class BabosaFix
+  def apply
+    unicode_removed = false
+
+    if defined? Unicode
+      orig_unicode = Unicode
+      Object.send(:remove_const, :Unicode)
+      unicode_removed = true
+    end
+
+    require 'babosa'
+
+    if unicode_removed
+      Object.send(:const_set, :Unicode, orig_unicode)
+    end
+  end
+end
+
+BabosaFix.new.apply

data/lib/spaceship/client.rb

@@ -6,6 +6,7 @@ require 'spaceship/ui'
 require 'spaceship/helper/plist_middleware'
 require 'spaceship/helper/net_http_generic_request'
 require 'tmpdir'
+require 'spaceship/babosa_fix'
 
 Faraday::Utils.default_params_encoder = Faraday::FlatParamsEncoder
 

data/lib/spaceship/portal/portal_client.rb

@@ -132,6 +132,18 @@ module Spaceship
       details_for_app(app)
     end
 
+    def valid_name_for(input)
+      latinized = input.to_slug.transliterate
+      latinized = latinized.gsub(/[^0-9A-Za-z\d\s]/, '') # remove non-valid characters
+      # Check if the input string was modified, since it might be empty now
+      # (if it only contained non-latin symbols) or the duplicate of another app
+      if latinized != input
+        latinized << " "
+        latinized << Digest::MD5.hexdigest(input)
+      end
+      latinized
+    end
+
     def create_app!(type, name, bundle_id, mac: false)
       # We moved the ensure_csrf to the top of this method
       # as we got some users with issues around creating new apps
@@ -155,7 +167,7 @@ module Spaceship
                      end
 
       params = {
-        name: name,
+        name: valid_name_for(name),
         teamId: team_id
       }
 
@@ -195,7 +207,7 @@ module Spaceship
       ensure_csrf(Spaceship::AppGroup)
 
       r = request(:post, 'account/ios/identifiers/addApplicationGroup.action', {
-        name: name,
+        name: valid_name_for(name),
         identifier: group_id,
         teamId: team_id
       })

data/lib/spaceship/version.rb

@@ -1,4 +1,4 @@
 module Spaceship
-  VERSION = "0.38.3".freeze
+  VERSION = "0.38.4".freeze
   DESCRIPTION = "Ruby library to access the Apple Dev Center and iTunes Connect".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.38.3
+  version: 0.38.4
 platform: ruby
 authors:
 - Felix Krause
@@ -115,6 +115,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: babosa
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.0.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.0.2
 - !ruby/object:Gem::Dependency
   name: colored
   requirement: !ruby/object:Gem::Requirement
@@ -328,6 +342,7 @@ files:
 - lib/assets/languageMapping.json
 - lib/assets/languageMappingReadable.json
 - lib/spaceship.rb
+- lib/spaceship/babosa_fix.rb
 - lib/spaceship/base.rb
 - lib/spaceship/client.rb
 - lib/spaceship/du/du_client.rb
@@ -402,7 +417,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Ruby library to access the Apple Dev Center and iTunes Connect