spaceship 0.34.3 → 0.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bf577b8fd2b5d6f538ff6f26e2f5c8cf4abaa947
-  data.tar.gz: 47e771c715dd55f3d334234ab6fcbb09896e7595
+  metadata.gz: f6e196e1baa469a54ac174956340461c7de400ef
+  data.tar.gz: 6045182579d60750159c0c89770e6d17520cf5f4
 SHA512:
-  metadata.gz: 6a270d3d3f892feb254305b4fd58dcd24628d4dd5f535f8c1e0fba52b798177e55b4a2db4e9b0e899bfcfeab83f4d6b0022a5d8b1f44d6fd353bad920069cafe
-  data.tar.gz: 899c011e4dacc8f0200029eafa12ee50ac72fe0f3d310d32d505298e0ca50606076c095848c55087d0af722bebd6c5302b7140b5fa6904bf46282516ced641ed
+  metadata.gz: b170cd42e3aa6798499273c39084fa7568b8bc0372d037078add1ec088e6873d1b0f94c751753d190976db38b2929ab2c24af6ed9b53f71760b10b1c3331d393
+  data.tar.gz: bce68dcebd6777dc984e661078a5e0bd4ec11f0746aa6b0d23009739e39593c4cd419f58581db5f48a4545e7807bc93768164d618fd08bdd3334ea6f14a52f95

data/lib/spaceship/tunes/app_status.rb

@@ -31,10 +31,6 @@ module Spaceship
       UPLOAD_RECEIVED = "Upload Received"
       PENDING_DEVELOPER_RELEASE = "Pending Developer Release"
       PROCESSING_FOR_APP_STORE = "Processing for App Store"
-
-      # Unused app states
-      # PENDING_APPLE_RELASE = "Pending Apple Release"
-
       # WAITING_FOR_EXPORT_COMPLIANCE = "Waiting For Export Compliance"
       # METADATA_REJECTED = "Metadata Rejected"
       # REMOVED_FROM_SALE = "Removed From Sale"
@@ -49,7 +45,8 @@ module Spaceship
           'pendingContract' => PENDING_CONTRACT,
           'developerRemovedFromSale' => DEVELOPER_REMOVED_FROM_SALE,
           'waitingForReview' => WAITING_FOR_REVIEW,
-          'inReview' => IN_REVIEW
+          'inReview' => IN_REVIEW,
+          'pendingDeveloperRelease' => PENDING_DEVELOPER_RELEASE
         }
 
         mapping.each do |k, v|

data/lib/spaceship/tunes/tester.rb

@@ -220,7 +220,8 @@ module Spaceship
       def self.url
         {
           index:  "ra/users/iap",
-          create: "ra/users/iap/add"
+          create: "ra/users/iap/add",
+          delete: "ra/users/iap/delete"
         }
       end
 
@@ -239,6 +240,14 @@ module Spaceship
         )
         self.new(data)
       end
+
+      def self.delete!(emails)
+        client.delete_sandbox_testers!(self, emails)
+      end
+
+      def self.delete_all!
+        delete!(self.all.map(&:email))
+      end
     end
   end
 end

data/lib/spaceship/tunes/tunes_client.rb

@@ -1,3 +1,5 @@
+require "securerandom"
+
 module Spaceship
   # rubocop:disable Metrics/ClassLength
   class TunesClient < Spaceship::Client
@@ -66,6 +68,23 @@ module Spaceship
 
     # Set a new team ID which will be used from now on
     def team_id=(team_id)
+      # First, we verify the team actually exists, because otherwise iTC would return the
+      # following confusing error message
+      #
+      #     invalid content provider id
+      #
+      available_teams = teams.collect do |team|
+        (team["contentProvider"] || {})["contentProviderId"]
+      end
+
+      result = available_teams.find do |available_team_id|
+        team_id.to_s == available_team_id.to_s
+      end
+
+      unless result
+        raise ITunesConnectError.new, "Could not set team ID to '#{team_id}', only found the following available teams: #{available_teams.join(', ')}"
+      end
+
       response = request(:post) do |req|
         req.url "ra/v1/session/webSession"
         req.body = { contentProviderId: team_id }.to_json
@@ -83,15 +102,21 @@ module Spaceship
       t_id = (ENV['FASTLANE_ITC_TEAM_ID'] || '').strip
       t_name = (ENV['FASTLANE_ITC_TEAM_NAME'] || '').strip
 
-      if t_name.length > 0
+      if t_name.length > 0 && t_id.length.zero? # we prefer IDs over names, they are unique
+        puts "Looking for iTunes Connect Team with name #{t_name}" if $verbose
+
         teams.each do |t|
           t_id = t['contentProvider']['contentProviderId'].to_s if t['contentProvider']['name'].casecmp(t_name.downcase).zero?
         end
+
+        puts "Could not find team with name '#{t_name}', trying to fallback to default team" if t_id.length.zero?
       end
 
       t_id = teams.first['contentProvider']['contentProviderId'].to_s if teams.count == 1
 
       if t_id.length > 0
+        puts "Looking for iTunes Connect Team with ID #{t_id}" if $verbose
+
         # actually set the team id here
         self.team_id = t_id
         return
@@ -100,6 +125,15 @@ module Spaceship
       # user didn't specify a team... #thisiswhywecanthavenicethings
       loop do
         puts "Multiple iTunes Connect teams found, please enter the number of the team you want to use: "
+        puts "Note: to automatically choose the team, provide either the iTunes Connect Team ID, or the Team Name in your fastlane/Appfile:"
+        first_team = teams.first["contentProvider"]
+        puts ""
+        puts "  itc_team_id \"#{first_team['contentProviderId']}\""
+        puts ""
+        puts "or"
+        puts ""
+        puts "  itc_team_name \"#{first_team['name']}\""
+        puts ""
         teams.each_with_index do |team, i|
           puts "#{i + 1}) \"#{team['contentProvider']['name']}\" (#{team['contentProvider']['contentProviderId']})"
         end
@@ -846,8 +880,8 @@ module Spaceship
             storeFront: { value: country },
             birthDay: { value: 1 },
             birthMonth: { value: 1 },
-            secretQuestion: { value: 'secret_question' },
-            secretAnswer: { value: 'secret_answer' },
+            secretQuestion: { value: SecureRandom.hex },
+            secretAnswer: { value: SecureRandom.hex },
             sandboxAccount: nil
           }
         }.to_json
@@ -856,6 +890,22 @@ module Spaceship
       parse_response(r, 'data')['user']
     end
 
+    def delete_sandbox_testers!(tester_class, emails)
+      url = tester_class.url[:delete]
+      request(:post) do |req|
+        req.url url
+        req.body = emails.map do |email|
+          {
+            emailAddress: {
+              value: email
+            }
+          }
+        end.to_json
+        req.headers['Content-Type'] = 'application/json'
+      end
+      true
+    end
+
     #####################################################
     # @!group State History
     #####################################################

data/lib/spaceship/version.rb

@@ -1,4 +1,4 @@
 module Spaceship
-  VERSION = "0.34.3".freeze
+  VERSION = "0.35.0".freeze
   DESCRIPTION = "Ruby library to access the Apple Dev Center and iTunes Connect".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.34.3
+  version: 0.35.0
 platform: ruby
 authors:
 - Felix Krause
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-06 00:00:00.000000000 Z
+date: 2016-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager
@@ -43,16 +43,22 @@ dependencies:
   name: plist
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.1.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.1.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -394,7 +400,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: Ruby library to access the Apple Dev Center and iTunes Connect