spaceship 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f1c5ac6945f70388e4e1ad0b2f52a1f185c56fb
-  data.tar.gz: a925727b880ed220b5f1d85dd7b523b7354149f7
+  metadata.gz: 18955ceeee8e06a8037d4e9053077f64ee33e92b
+  data.tar.gz: c54aeb4a0ff162846956883e65c57ecc6902521b
 SHA512:
-  metadata.gz: d50ba6dc463d4b920716eb792f9a00a01240e5c7d42a7980889f32b831818c4007a440fcef48cbe4793ac764e3849646bbd7bb435d2f4bf69eccf029a0bbe11d
-  data.tar.gz: 1ec502faa18764220dd036e782bfafde2f9ea423469060e5b21f639454aebc0e53ffccfa7569f3cfd9f10c661726b712283377bffcb13233c0733bbeed62885a
+  metadata.gz: ac1610a26e1fc85fd5b8c6a82b4e8c20b35a6e26fb818fb57818dafda2750d996f90d7aa41ebe4ea92af1af89f37fad4dcaa673bb425d5eebe3709cf638cfabf
+  data.tar.gz: dae1c1de14ad8c744482558c2486fb0c34107b8ee5077b1ee7863d4a69aa743f6f87f35ae0840066dc0185118f2612e8097ed7ec84e1028d411bb9d6ae2ed2c1

data/README.md

@@ -110,6 +110,8 @@ Most [fastlane tools](https://fastlane.tools) already use `spaceship`, like `sig
 
 The detailed documentation of all available classes is available on [RubyDoc](http://www.rubydoc.info/github/fastlane/spaceship/frames).
 
+You can find the log file here `/tmp/spaceship[time].log`.
+
 # Technical Details
 
 ## HTTP Client

data/lib/spaceship/client.rb

@@ -20,12 +20,16 @@ module Spaceship
     attr_accessor :cookie
 
     # The logger in which all requests are logged
-    # /tmp/spaceship.log by default
+    # /tmp/spaceship[time].log by default
     attr_accessor :logger
 
     # Invalid user credentials were provided
     class InvalidUserCredentialsError < StandardError; end
 
+    # Raised when no user credentials were passed at all
+    class NoUserCredentialsError < StandardError; end
+
+
     class UnexpectedResponse < StandardError; end
 
     # Authenticates with Apple's web services. This method has to be called once
@@ -71,14 +75,14 @@ module Spaceship
     end
 
     # The logger in which all requests are logged
-    # /tmp/spaceship.log by default
+    # /tmp/spaceship[time].log by default
     def logger
       unless @logger
         if $verbose || ENV["VERBOSE"]
           @logger = Logger.new(STDOUT)
         else
           # Log to file by default
-          path = "/tmp/spaceship.log"
+          path = "/tmp/spaceship#{Time.now.to_i}.log"
           @logger = Logger.new(path)
         end
 
@@ -141,8 +145,8 @@ module Spaceship
         password ||= data.password
       end
 
-      if user.to_s.empty? or password.to_s.empty?
-        raise InvalidUserCredentialsError.new("No login data provided")
+      if user.to_s.strip.empty? or password.strip.to_s.empty?
+        raise NoUserCredentialsError.new("No login data provided")
       end
 
       send_login_request(user, password) # different in subclasses

data/lib/spaceship/portal/portal_client.rb

@@ -83,7 +83,6 @@ module Spaceship
 
     # Is the current session from an Enterprise In House account?
     def in_house?
-      # TODO: move to portal
       return @in_house unless @in_house.nil?
       @in_house = (team_information['type'] == 'In-House')
     end

data/lib/spaceship/tunes/app_submission.rb

@@ -40,7 +40,7 @@ module Spaceship
       # @return (Boolean) Export Compliance - Available on French Store
       attr_accessor :export_compliance_available_on_french_store
       
-      # @return (@TODO) Export Compliance - CCAT File
+      # @return (Not Yet Implemented) Export Compliance - CCAT File
       attr_accessor :export_compliance_ccat_file
       
       # @return (Boolean) Export Compliance - Contains proprietary cryptography

data/lib/spaceship/tunes/app_version.rb

@@ -69,9 +69,6 @@ module Spaceship
       # @return (Integer) a unqiue ID for this version generated by iTunes Connect
       attr_accessor :version_id
 
-      # @return TODO
-      attr_accessor :company_information
-
       ####
       # App Review Information
       ####
@@ -283,12 +280,12 @@ module Spaceship
         super(value)
       end
 
-      def primary_first_sub_cate=(value)gory
+      def primary_first_sub_category=(value)
         value = "MZGenre.#{value}" unless value.include?"MZGenre"
         super(value)
       end
 
-      def primary_second_sub_cat=(value)egory
+      def primary_second_sub_category=(value)
         value = "MZGenre.#{value}" unless value.include?"MZGenre"
         super(value)
       end
@@ -298,12 +295,12 @@ module Spaceship
         super(value)
       end
 
-      def secondary_first_sub_ca=(value)tegory
+      def secondary_first_sub_category=(value)
         value = "MZGenre.#{value}" unless value.include?"MZGenre"
         super(value)
       end
 
-      def secondary_second_sub_c=(value)ategory
+      def secondary_second_sub_category=(value)
         value = "MZGenre.#{value}" unless value.include?"MZGenre"
         super(value)
       end

data/lib/spaceship/tunes/application.rb

@@ -139,6 +139,8 @@ module Spaceship
       #####################################################
      
       # Create a new version of your app
+      # Since we have stored the outdated raw_data, we need to refresh this object
+      # otherwise `edit_version` will return nil
       def create_version!(version_number)
         if edit_version
           raise "Cannot create a new version for this app as there already is an `edit_version` available"
@@ -146,9 +148,7 @@ module Spaceship
 
         client.create_version!(apple_id, version_number)
 
-        # Since we have stored the outdated raw_data, we need to refresh this object
-        # otherwise `edit_version` will return nil
-        # TODO: implemented -reload method
+        # Future: implemented -reload method
       end
 
       #####################################################

data/lib/spaceship/version.rb

@@ -1,3 +1,3 @@
 module Spaceship
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Stefan Natchev
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-24 00:00:00.000000000 Z
+date: 2015-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager
@@ -258,7 +258,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Because you would rather spend your time building stuff than fighting provisioning