spaceship 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 512289a32dda1675818d359f917054b3f2e1e56e
-  data.tar.gz: 5ee2c24728b19f4fbff5ccaa23d99fb64dba3773
+  metadata.gz: e3078ea19b608c93eb3a24244c21150926510bfb
+  data.tar.gz: 4502e39e82ac1214bb99194d6952956fc3311a03
 SHA512:
-  metadata.gz: e4772e10092db2176b4b9c0994d247c92a932678433621599a852111bcad0ada3e991ea4599060f6bc4489f2bdf36a7f1bfac46192b6db8c1b30b7b49f0af409
-  data.tar.gz: a89358c7f17c498d33a20335a2d4becd8f16b5a5a192ee7467bc44c2b316b6377b48631dcc4d374639f26fc5829880e28f2ed371f8e1a0af0b04042e1de09f81
+  metadata.gz: c5c4a1641ab4dfe03f514debd2dc0a49cd6edd0502b5c4a1fde97ee6c043c40a5609a31f6d1c847044586b1160e9f0b930178a71ac74d42ba91f7d8d91392452
+  data.tar.gz: 308b92f3e5225fbb8ad6ebed31a665ef7719211cb16cd83c1d4890f802168273bcab987090ddd485880d2e90f71c74e5076391ab3fe5e3535d28a2b2f304e44f

data/README.md

@@ -13,7 +13,10 @@
   <a href="https://github.com/KrauseFx/sigh">sigh</a> &bull;
   <a href="https://github.com/KrauseFx/produce">produce</a> &bull;
   <a href="https://github.com/KrauseFx/cert">cert</a> &bull;
-  <a href="https://github.com/KrauseFx/codes">codes</a>
+  <a href="https://github.com/KrauseFx/codes">codes</a> &bull;
+  <b>spaceship</b> &bull;
+  <a href="https://github.com/fastlane/pilot">pilot</a> &bull;
+  <a href="https://github.com/fastlane/boarding">boarding</a>
 </p>
 -------
 
@@ -29,7 +32,7 @@
 [![Build Status](https://img.shields.io/travis/fastlane/spaceship/master.svg?style=flat)](https://travis-ci.org/fastlane/spaceship)
 
 
-Get in contact with the developers on Twitter: [@snatchev](https://twitter.com/snatchev/) and [@KrauseFx](https://twitter.com/KrauseFx)
+Get in contact with the developers on Twitter: [@KrauseFx](https://twitter.com/KrauseFx) and [@snatchev](https://twitter.com/snatchev)
 
 
 -------
@@ -47,7 +50,7 @@ Get in contact with the developers on Twitter: [@snatchev](https://twitter.com/s
 
 # What's spaceship?
 
-spaceship is a Ruby library that exposes the Apple Developer Center API. It’s super fast, well tested and supports all of the operations you can do via the browser. Scripting your Developer Center workflow has never been easier!
+spaceship is a Ruby library that exposes both the Apple Developer Center and the iTunes Connect API. It’s super fast, well tested and supports all of the operations you can do via the browser. Scripting your Developer Center workflow has never been easier!
 
 Up until now, the [fastlane tools](https://fastlane.tools) used web scraping to interact with Apple's web services. With spaceship it is possible to directly access the underlying APIs using a simple HTTP client only.
 
@@ -57,7 +60,7 @@ spaceship uses a combination of 3 different API endpoints, used by the Apple Dev
 
 More details about why spaceship is useful on [spaceship.airforce](https://spaceship.airforce).
 
-> No matter how many apps or profiles you have, spaceship **can** handle your scale.
+> No matter how many apps or certificates you have, spaceship **can** handle your scale.
 
 Enough words, here is some code:
 
@@ -91,256 +94,22 @@ How fast are tools using `spaceship` compared to web scraping?
 
 # Usage
 
-To quickly play around with `spaceship` launch `irb` in your terminal and execute `require "spaceship"`. 
+## Apple Developer Portal API
 
-## Login
+##### Open [DeveloperPortal.md](docs/DeveloperPortal.md) for code samples
 
-```ruby
-Spaceship.login("felix@krausefx.com", "password")
-
-Spaceship.select_team # call this method to let the user select a team
-```
-
-## Apps
-
-```ruby
-# Fetch all available apps
-all_apps = Spaceship.app.all
+## iTunes Connect API
 
-# Find a specific app based on the bundle identifier
-app = Spaceship.app.find("com.krausefx.app")
+##### Open [iTunesConnect.md](docs/iTunesConnect.md) for code samples
 
-# Show the names of all your apps
-Spaceship.app.all.each do |app|
-  puts app.name
-end
+### Spaceship in use
 
-# Create a new app
-app = Spaceship.app.create!(bundle_id: "com.krausefx.app_name", name: "fastlane App")
-```
-
-## Certificates
-
-```ruby
-# Fetch all available certificates (includes signing and push profiles)
-certificates = Spaceship.certificate.all
-```
-
-### Code Signing Certificates
-
-```ruby
-# Production identities
-prod_certs = Spaceship.certificate.production.all
-
-# Development identities
-dev_certs = Spaceship.certificate.development.all
-
-# Download a certificate
-cert_content = prod_certs.first.download
-```
-
-### Push Certificates
-```ruby
-# Production push profiles
-prod_push_certs = Spaceship.certificate.production_push.all
-
-# Development push profiles
-dev_push_certs = Spaceship.certificate.development_push.all
-
-# Download a push profile
-cert_content = dev_push_certs.first.download
-```
+Most [fastlane tools](https://fastlane.tools) already use `spaceship`, like `sigh`, `cert`, `produce`, `pilot` and `boarding`.
 
-### Create a Certificate
-
-```ruby
-# Create a new certificate signing request
-csr, pkey = Spaceship.certificate.create_certificate_signing_request
-
-# Use the signing request to create a new distribution certificate
-Spaceship.certificate.production.create!(csr: csr)
-
-# Use the signing request to create a new push certificate
-Spaceship.certificate.production_push.create!(csr: csr, bundle_id: "com.krausefx.app")
-```
-
-## Provisioning Profiles
-
-### Receiving profiles
-
-```ruby
-##### Finding #####
-
-# Get all available provisioning profiles
-profiles = Spaceship.provisioning_profile.all
-
-# Get all App Store profiles
-profiles_appstore = Spaceship.provisioning_profile.app_store.all
-
-# Get all AdHoc profiles
-profiles_adhoc = Spaceship.provisioning_profile.ad_hoc.all
-
-# Get all Development profiles
-profiles_dev = Spaceship.provisioning_profile.development.all
-
-# Fetch all profiles for a specific app identifier for the App Store
-filtered_profiles = Spaceship.provisioning_profile.app_store.find_by_bundle_id("com.krausefx.app")
-
-##### Downloading #####
-
-# Download a profile
-profile_content = profiles.first.download
-
-# Download a specific profile as file
-my_profile = Spaceship.provisioning_profile.app_store.find_by_bundle_id("com.krausefx.app")
-File.write("output.mobileprovision", my_profile.download)
-```
-
-### Create a Provisioning Profile
-
-```ruby
-# Choose the certificate to use
-cert = Spaceship.certificate.production.all.first
-
-# Create a new provisioning profile with a default name
-# The name of the new profile is "com.krausefx.app AppStore"
-profile = Spaceship.provisioning_profile.app_store.create!(bundle_id: "com.krausefx.app",
-                                                         certificate: cert)
-
-# AdHoc Profiles will add all devices by default
-profile = Spaceship.provisioning_profile.ad_hoc.create!(bundle_id: "com.krausefx.app",
-                                                      certificate: cert,
-                                                             name: "Profile Name")
-
-# Store the new profile on the filesystem
-File.write("NewProfile.mobileprovision", profile.download)
-```
-
-### Repair all broken provisioning profiles
-
-```ruby
-# Select all 'Invalid' or 'Expired' provisioning profiles
-broken_profiles = Spaceship.provisioning_profile.all.find_all do |profile| 
-  # the below could be replaced with `!profile.valid?`, which takes longer but also verifies the code signing identity
-  (profile.status == "Invalid" or profile.status == "Expired") 
-end
-
-# Iterate over all broken profiles and repair them
-broken_profiles.each do |profile|
-  profile.repair! # yes, that's all you need to repair a profile
-end
-
-# or to do the same thing, just more Ruby like
-Spaceship.provisioning_profile.all.find_all { |p| !p.valid? }.map(&:repair!)
-```
-
-## Devices
-
-```ruby
-all_devices = Spaceship.device.all
-
-# Register a new device
-Spaceship.device.create!(name: "Private iPhone 6", udid: "5814abb3...")
-```
-
-## Enterprise
-
-```ruby
-# Use the InHouse class to get all enterprise certificates
-cert = Spaceship.certificate.in_house.all.first 
-
-# Create a new InHouse Enterprise distribution profile
-profile = Spaceship.provisioning_profile.in_house.create!(bundle_id: "com.krausefx.*",
-                                                        certificate: cert)
-
-# List all In-House Provisioning Profiles
-profiles = Spaceship.provisioning_profile.in_house.all
-```
-
-## Multiple Spaceships
-
-Sometimes one `spaceship` just isn't enough. That's why this library has its own Spaceship Launcher to launch and use multiple `spaceships` at the same time :rocket:
-
-```ruby
-# Launch 2 spaceships
-spaceship1 = Spaceship::Launcher.new("felix@krausefx.com", "password")
-spaceship2 = Spaceship::Launcher.new("stefan@spaceship.airforce", "password")
-
-# Fetch all registered devices from spaceship1
-devices = spaceship1.device.all
-
-# Iterate over the list of available devices
-# and register each device from the first account also on the second one
-devices.each do |device|
-  spaceship2.device.create!(name: device.name, udid: device.udid)
-end
-```
-
-## More cool things you can do
-```ruby
-# Find a profile with a specific name
-profile = Spaceship.provisioning_profile.development.all.find { |p| p.name == "Name" }
-
-# Add all available devices to the profile
-profile.devices = Spaceship.device.all
-
-# Push the changes back to the Apple Developer Portal
-profile.update!
-
-# Get the currently used team_id
-Spaceship.client.team_id
-
-# We generally don't want to be destructive, but you can also delete things
-# This method might fail for various reasons, e.g. app is already in the store
-app = Spaceship.app.find("com.krausefx.app")
-app.delete!
-```
-
-## Spaceship in use
-
-The beta version of [sigh](https://github.com/KrauseFx/sigh) is already using `spaceship` to communicate with Apple's web services. You can see all relevant source code in [runner.rb](https://github.com/KrauseFx/sigh/blob/feature/spaceship/lib/sigh/spaceship/runner.rb).
-
-## Full Documentation
+### Full Documentation
 
 The detailed documentation of all available classes is available on [RubyDoc](http://www.rubydoc.info/github/fastlane/spaceship/frames).
 
-## Example Data
-
-Some unnecessary information was removed, check out [provisioning_profile.rb](https://github.com/KrauseFx/spaceship/blob/master/lib/spaceship/provisioning_profile.rb) for all available attributes.
-
-The example data below is a provisioning profile, containing a device, certificate and app. 
-
-```
-#<Spaceship::ProvisioningProfile::AdHoc 
-  @devices=[
-    #<Spaceship::Device 
-      @id="5YTNZ5A9AA", 
-      @name="Felix iPhone 6", 
-      @udid="39d2cab02642dc2bfdbbff4c0cb0e50c8632faaa"
-    >,  ...], 
-  @certificates=[
-    #<Spaceship::Certificate::Production 
-      @id="LHNT9C2AAA", 
-      @name="iOS Distribution", 
-      @expires=#<DateTime: 2016-02-10T23:44:20>
-    ], 
-  @id="72SRVUNAAA", 
-  @uuid="43cda0d6-04a5-4964-89c0-a24b5f258aaa", 
-  @expires=#<DateTime: 2016-02-10T23:44:20>, 
-  @distribution_method="adhoc", 
-  @name="com.krausefx.app AppStore", 
-  @status="Active", 
-  @platform="ios", 
-  @app=#<Spaceship::App 
-    @app_id="2UMR2S6AAA", 
-    @name="App Name", 
-    @platform="ios", 
-    @bundle_id="com.krausefx.app", 
-    @is_wildcard=false>
-  >
->
-```
-
 # Technical Details
 
 ## HTTP Client
@@ -354,7 +123,6 @@ Advantages of `spaceship` (HTTP client) over web scraping:
 - Great test coverage by stubbing server responses
 - Resistant against design changes of the Apple Developer Portal
 - Automatic re-trying of requests in case a timeout occurs
-- By stubbing the `spaceship` objects it is possible to also implement tests for tools like [sigh](https://github.com/KrauseFx/sigh)
 
 ## API Endpoints
 
@@ -372,6 +140,11 @@ I won't go into too much technical details about the various API endpoints, but
  - Repair provisioning profiles
  - Download provisioning profiles
  - Team selection
+- `https://itunesconnect.apple.com`: 
+ - Managing apps
+ - Managing beta testers
+ - Submitting updates to review
+ - Manaing app metadata
 
 `spaceship` uses all those API points to offer this seamless experience.
 
@@ -389,13 +162,22 @@ I won't go into too much technical details about the various API endpoints, but
 
 # Credits
 
-This project has been sponsored by [ZeroPush](https://zeropush.com). `spaceship` was developed by [@snatchev](https://twitter.com/snatchev/) and [@KrauseFx](https://twitter.com/KrauseFx).
+The initial release was sponsored by [ZeroPush](https://zeropush.com). 
+
+`spaceship` was developed by 
+- [@KrauseFx](https://twitter.com/KrauseFx).
+- [@snatchev](https://twitter.com/snatchev/)
+- [@mathcarignani](https://twitter.com/mathcarignani/)
+
+[Open full list of contributors](https://github.com/fastlane/spaceship/graphs/contributors).
 
 ##### [Like this tool? Be the first to know about updates and new fastlane tools](https://tinyletter.com/krausefx)
 
 # License
 This project is licensed under the terms of the MIT license. See the LICENSE file.
 
+> This project and all fastlane tools are in no way affiliated with Apple Inc. This project is open source under the MIT license, which means you have full access to the source code and can modify it to fit your own needs. All fastlane tools run on your own computer or server, so your credentials or other sensitive information will never leave your own computer. You are responsible for how you use fastlane tools.
+
 # Contributing
 
 1. Create an issue to start a discussion about your idea

data/lib/spaceship/base.rb

@@ -184,13 +184,50 @@ module Spaceship
       @client
     end
 
+    #####################################################
+    # @!group Storing the `attr_accessor`
+    #####################################################
+
+    # From https://stackoverflow.com/questions/2487333/fastest-one-liner-way-to-list-attr-accessors-in-ruby
+    # This will store a list of defined attr_accessors to easily access them when inspecting the values
+    def self.attr_accessor(*vars)
+      @attributes ||= []
+      @attributes.concat vars
+      super(*vars)
+    end
+
+    def self.attributes
+      @attributes ||= []
+      par = []
+
+      par = (self.superclass.attributes || []) unless (self == Base)
+
+      @attributes + par
+    end
+
+    def attributes
+      self.class.attributes
+    end
+
+    #####################################################
+    # @!group Inspect related code
+    #####################################################
+
     def inspect
-      inspectables = instance_variables - [:@client]
-      inspect_vars = inspectables.map do |ivar|
-         val = instance_variable_get(ivar)
-         "#{ivar}=#{val.inspect}"
-      end
-      "\n#<#{self.class.name}\n\t#{inspect_vars.join("\n\t")}>"
+      inspectables = self.attributes
+
+      value = inspectables.map do |k|
+        v = self.send(k).inspect
+        v.gsub!("\n", "\n\t") # to align nested elements
+
+        "\t#{k}=#{v}"
+      end.join(", \n")
+
+      "<#{self.class.name} \n#{value}>"
+    end
+
+    def to_s
+      self.inspect
     end
   end
 end

data/lib/spaceship/tunes/app_version.rb

@@ -97,7 +97,7 @@ module Spaceship
       attr_accessor :review_notes
 
       ####
-      # Localized values:
+      # Localized values
       ####
 
       # @return (Array) Raw access the all available languages. You shouldn't use it probbaly

data/lib/spaceship/tunes/application.rb

@@ -40,10 +40,6 @@ module Spaceship
       #   nil
       attr_accessor :app_icon_preview_url
 
-      # @return [Array] A list of binaries which are not even yet processing based on the version
-      #   Those builds are usually the ones that are just stuck on iTunes Connect...
-      attr_accessor :pre_processing_builds
-
       attr_mapping(
         'adamId' => :apple_id,
         'name' => :name,
@@ -54,7 +50,7 @@ module Spaceship
         'issuesCount' => :issues_count,
         'iconUrl' => :app_icon_preview_url
       )
-
+      
       class << self
         # Create a new object based on a hash.
         # This is used to create a new object based on the server response.
@@ -162,8 +158,9 @@ module Spaceship
         Tunes::BuildTrain.all(self, self.apple_id)
       end
 
-      # @return [Array] A list of all pre-processing builds
+      # @return [Array]A list of binaries which are not even yet processing based on the version
       #   These are all build that have no information except the upload date
+      #   Those builds can also be the builds that are stuck on iTC.
       def pre_processing_builds
         data = client.build_trains(apple_id) # we need to fetch all trains here to get the builds
         

data/lib/spaceship/tunes/build.rb

@@ -102,7 +102,8 @@ module Spaceship
       def setup
         super
 
-        @external_testing_enabled = (self.external_expiry_date || 0) > 0
+        self.external_expiry_date ||= 0
+        @external_testing_enabled = self.external_expiry_date > 0
       end
 
       # This will submit this build for TestFlight beta review

data/lib/spaceship/tunes/tester.rb

@@ -90,16 +90,14 @@ module Spaceship
         # @param email (String) (required): The email of the new tester
         # @param first_name (String) (optional): The first name of the new tester
         # @param last_name (String) (optional): The last name of the new tester
-        # @param group (String) (optional): The name of the group this tester should be added to
         # @example 
         #   Spaceship::Tunes::Tester.external.create!(email: "tester@mathiascarignani.com", first_name: "Cary", last_name:"Bennett")
         # @return (Tester): The newly created tester
-        def create!(email: nil, first_name: nil, last_name: nil, group: nil) 
+        def create!(email: nil, first_name: nil, last_name: nil) 
           data = client.create_tester!(tester: self,
                                         email: email,
                                    first_name: first_name,
-                                    last_name: last_name,
-                                        group: group)
+                                    last_name: last_name)
           self.factory(data)
         end
 
@@ -126,7 +124,6 @@ module Spaceship
         # Add all testers to the app received
         # @param app_id (String) (required): The app id to filter the testers
         def add_all_to_app!(app_id)
-          # TODO: Change to not make one request for each tester
           all.each do |tester|
             begin
               tester.add_to_app!(app_id)

data/lib/spaceship/tunes/tunes_client.rb

@@ -342,8 +342,7 @@ module Spaceship
       parse_response(r, 'data')['users']
     end
 
-    # @param group (String) an optional group name
-    def create_tester!(tester: nil, email: nil, first_name: nil, last_name: nil, group: nil) 
+    def create_tester!(tester: nil, email: nil, first_name: nil, last_name: nil) 
       url = tester.url[:create]
       raise "Action not provided for this tester type." unless url
 
@@ -361,15 +360,6 @@ module Spaceship
               value: true
             }
           }
-      
-      if group
-        tester_data[:groups] = [{
-                                  id: nil,
-                                  name: {
-                                    value: group
-                                  }
-                                }]
-      end
 
       data = { testers: [tester_data] }
 

data/lib/spaceship/version.rb

@@ -1,3 +1,3 @@
 module Spaceship
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spaceship
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Stefan Natchev
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-20 00:00:00.000000000 Z
+date: 2015-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: credentials_manager