soxi-wrapper 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b20b67f843afb37dc17ccbdfbc24e2dfaba81f1
-  data.tar.gz: e8b5c64012091b28c546dcc6da35a7b4aaff7fce
+  metadata.gz: 99a5138606244f09e6a7ef674243dcc4a587b2c2
+  data.tar.gz: d30988df5ed0e999921b14c7a52b9baa9b152329
 SHA512:
-  metadata.gz: 276c59679bfec7b7f0391665dd6b572563d72518a550faa23b8fa6e701473acde96eac39e335121f703bed2a3d26a82b65aa9ae0072aa6e5389048f9b329934d
-  data.tar.gz: 180ebd8307f4587ea9fc717368bb747916e745db962ffbf8a1bc36851c6ab90283ce9d5093c3923b63c86ba1b436126a9ab1abe554e9ba912d63e38dfc287f32
+  metadata.gz: 812d9182809ac412a74bc63a659e4b6c931635e603c5c4a7c0f2d802077b96a2c5ea271e8746029a31b7ed249a5faa3e2799a165cfb4afa251638369fab72118
+  data.tar.gz: 6fe70c5f37bd92bc70808fe6b6a39a85072b61343eaf7362d6c65ee6850b69b700940cf34c4889b16bf677696a4227539ee670525d01d2a39458c1fd47718257

data/README.md

@@ -1,10 +1,12 @@
 # Soxi::Wrapper
 
-TODO: Write a gem description
+This very simple wrapper has been abandonned. We haven't used it in years.
+
+We have upgraded this to ensure we don't publish unsafe code (based on work by @tomekr on https://github.com/ArnsboMedia/soxi-wrapper/pull/1)
 
 ## Installation
 
-Add this line to your application's Gemfile:
+If you must:
 
     gem 'soxi-wrapper'
 
@@ -16,14 +18,6 @@ Or install it yourself as:
 
     $ gem install soxi-wrapper
 
-## Usage
-
-TODO: Write usage instructions here
-
 ## Contributing
 
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+We have abandonned this.

data/lib/soxi/file_missing_error.rb

@@ -0,0 +1,6 @@
+module Soxi
+  module Wrapper
+    class FileMissingError < StandardError
+    end
+  end
+end

data/lib/soxi/soxi_missing_error.rb

@@ -0,0 +1,6 @@
+module Soxi
+  module Wrapper
+    class SoxiMissingError < StandardError
+    end
+  end
+end

data/lib/soxi/wrapper.rb

@@ -1,11 +1,16 @@
-require "soxi/wrapper/version"
-require "soxi/wrapper/file"
+require 'soxi/wrapper/version'
+require 'soxi/wrapper/file'
+require 'soxi/soxi_missing_error'
+require 'soxi/file_missing_error'
 
 module Soxi
   module Wrapper
-    def self.file filename
-      raise 'soxi not installed' unless soxi_exists?
-      File.new filename
+    def self.file(filename)
+      raise SoxiMissingError('Need soxi in path') unless soxi_exists?
+      unless ::File.exist?(filename)
+        raise FileMissingError("File: #{filename} does not exist")
+      end
+      Soxi::Wrapper::File.new filename
     end
 
     def self.soxi_exists?

data/lib/soxi/wrapper/file.rb

@@ -1,3 +1,6 @@
+require 'open3'
+require "soxi/wrapper/soxi_failed_error"
+
 module Soxi
   module Wrapper
     class File
@@ -43,17 +46,28 @@ module Soxi
       end
 
       def comments
-        @comments ||= run('a', false)
+        @comments ||= run_multiline('a')
       end
 
       private
 
-      def run option, remove_newlines=true
-        val = `soxi -#{option} #{filename}`
-        if remove_newlines
-          return val.gsub(/\n/,'')
-        end
-        val
+      def run_multiline(option)
+        run_soxi(option)
+      end
+
+      def run(option)
+        run_soxi(option).delete("\n")
+      end
+
+      def run_soxi(option)
+        val, std_err, status = Open3.capture3('soxi', "-#{option}", filename)
+        return val if status.success?
+        raise SoxiFailedError.new(
+          std_err: std_err,
+          std_out: val,
+          option: option,
+          filename: filename
+        )
       end
     end
   end

data/lib/soxi/wrapper/soxi_failed_error.rb

@@ -0,0 +1,16 @@
+module Soxi
+  module Wrapper
+    class SoxiFailedError < StandardError
+      attr_reader :std_err, :std_out, :option, :filename
+      def initialize(std_err: nil,
+                     std_out: nil,
+                     option: nil,
+                     filename: nil)
+        @std_err  = std_err
+        @std_out  = std_out
+        @option   = option
+        @filename = filename
+      end
+    end
+  end
+end

data/lib/soxi/wrapper/version.rb

@@ -1,5 +1,5 @@
 module Soxi
   module Wrapper
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: soxi-wrapper
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Claus Witt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-11 00:00:00.000000000 Z
+date: 2018-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: yarjuf
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Wrapper class for calling soxi on files on command line
@@ -73,13 +73,16 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- lib/soxi/file_missing_error.rb
+- lib/soxi/soxi_missing_error.rb
 - lib/soxi/wrapper.rb
 - lib/soxi/wrapper/file.rb
+- lib/soxi/wrapper/soxi_failed_error.rb
 - lib/soxi/wrapper/version.rb
 - soxi-wrapper.gemspec
 homepage: ''
@@ -92,17 +95,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.7
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Use to get information about audio files