soundx 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b6839e528155e45a2816c36a41415dee39106d12dbe409d75274a97d42b1877
-  data.tar.gz: 5c06f9d9fd44692d1a5047226bf5de33775760a021d5194be3b205d539d08747
+  metadata.gz: 86f425b567e457397df034bf61c511f8a4b783f4c16d0ff71947fcd752f9ecee
+  data.tar.gz: 4155a8c79c3992726445fe4c94401c4070328fd89aa6622a45c5bd575fff62c9
 SHA512:
-  metadata.gz: 72c4ca9bcd78e412e49fbba2368bc04abcdc63907925988338c155bf096928ec37ed2d17e51a69970057b604b21002efe413e7b50288fdc69bbfd704fcfe2947
-  data.tar.gz: f0507106a61b5d03fc713d0f54d3bd3c4c7f24a5510a27b50db796417281099793b8e131c79e863c291d26e635834654f0683f10903a06b0bebe7db833c87388
+  metadata.gz: '08d87b1bf5134634ab9738b8c5e03ca4faa2a45786c82416e8bcd3397b6eee2da3d8674a2f24a884da74a17b317e93bbcd13ea68917d56646d52dc1cf811f9ed'
+  data.tar.gz: 745e1d8033be4534f915f7402bf0847e20d6a471b5a9361790e109d1340f5cd6d94abd7ddc70df2ae82ef93d6e2373f1fdc5913a4bcf5145ed38c1739908696b

data/ext/soundx/soundx.c

@@ -46,9 +46,13 @@ static VALUE
 rb_soundx(int argc, VALUE* argv, VALUE self)
 {
   VALUE input;
+  VALUE rbDestString;
   unsigned char* src;
-  int written = 0;
+  unsigned char written = 0; // Should not exceed 3, so 8 bits is plenty.
   size_t srclen;
+  size_t i; // for looping the src
+  unsigned char current;
+  unsigned char match;
 
   /*
    Destination is padded with up to 3 trailing zeros
@@ -58,32 +62,31 @@ rb_soundx(int argc, VALUE* argv, VALUE self)
 
   rb_scan_args(argc, argv, "1", &input);
 
-  if (TYPE(input) != T_STRING) {
-    rb_raise(rb_eTypeError, "expected a String");
-  }
+  Check_Type(input, T_STRING);
 
   srclen = RSTRING_LEN(input);
   src = (unsigned char *) StringValueCStr(input);
 
+  if (src[0] > 127) {
+    rb_raise(rb_eArgError, "non-ASCII character found");
+  }
+
   dest[0] = toupper(src[0]);
 
-  for(size_t i = 1; i <= srclen; i++) {
+  for(i = 1; i < srclen; i++) {
     if (written >= 3) {
       break;
     }
 
-    if ('\0' == src[i]) {
-      break;
-    }
-
-    if (src[i] > 128) {
+    if (src[i] > 127) {
       rb_raise(rb_eArgError, "non-ASCII character found");
       break;
     }
 
-    unsigned char current = tolower(src[i]);
+    current = tolower(src[i]);
+
+    match = mapping[ current ];
 
-    unsigned char match = mapping[ current ];
     if (0xFE == match) {
       continue;
     }
@@ -112,9 +115,9 @@ rb_soundx(int argc, VALUE* argv, VALUE self)
     written++;
   }
 
-  VALUE rbString = rb_str_new_cstr(dest);
+  rbDestString = rb_str_new_cstr(dest);
 
-  return rbString;
+  return rbDestString;
 }
 void
 Init_soundx() {

data/lib/soundx/version.rb

@@ -1,3 +1,3 @@
 module SoundX
-  VERSION = '1.0.4'
+  VERSION = '1.0.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soundx
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - James Cook
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-10 00:00:00.000000000 Z
+date: 2019-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake-compiler