sounder 1.0.0 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 568c6f3644c7d7f3b1a41b30029be59d2ff60f60
-  data.tar.gz: c6fd88b98ff40e065a478859f91e0f8a48e6cd7d
+  metadata.gz: 8df9741d168eeba2db6c05ee1c6d1d9532ecd663
+  data.tar.gz: 1398cba28a6d833eb95fa07869db03492d9aec5e
 SHA512:
-  metadata.gz: a50a56173c91396b072444aaefa7bc6718c98c4f765bf0a625af24b6744b21b7f81fe9c1fdbbd5a2be4811c232f2f9a0791792d6517fb0927ac8044c791d8ca0
-  data.tar.gz: 50af1099fca25b55b760e1fcc331a45518ccf04b6f48d1b0c2f572d666b33060805d4a216791de97290563f13136649f3503a17fc40120f9c96794d8c3fe9b8f
+  metadata.gz: 3e08ffcd9195685638dffec8ca961151067f31c0b0f0df7a916bbb1c7ecf1988d6a8ec1a637ea4b4537e9047f1aadedc53125b9c01c0abfdf7b45b0cf4e88428
+  data.tar.gz: 9c99e7251d3e7147ee47dc2d3c089d6870d79e84c59710d13aa43afea55463cb8a806ce7c92c49f74f1597ed5e935c419729aabe7501c7e8121511bd9ee94c6c

data/README.md

@@ -25,10 +25,10 @@ Or install it yourself as:
     sound = Sounder::Sound.new "/path/to/audio/file"
     sound.play
 
-    my_group = Sounder::SoundGroup.new {
+    my_group = Sounder::SoundGroup.new(
       :sound_one  => File.expand_path('../../lib/support/sound1.m4a', __FILE__),
       "sound_two" => File.expand_path('../../lib/support/sound2.m4a', __FILE__)
-    }
+    )
     my_group.play "tw"  # fuzzy matching of names
     my_group.random     # plays a random sound from the group
     my_group.usage      # returns a usage string with all the sound

data/lib/sounder/sound.rb

@@ -1,8 +1,10 @@
+require 'shellwords'
+
 module Sounder
   class Sound
     attr_reader :file
     def initialize path
-      @file = path
+      @file = Shellwords.escape path
     end
 
     def play

data/lib/sounder/sound_group.rb

@@ -21,13 +21,12 @@ module Sounder
     end
 
     def usage
-      usage = [ "random (picks a random sound)",
+      [ "random (picks a random sound)",
         "<sound name> (it will fuzzy match the name)",
         "Available sounds:"
       ] + @sounds.keys.map do |sound|
         "  #{sound}"
       end
-      usage.join "\n"
     end
 
 

data/lib/sounder/version.rb

@@ -1,3 +1,3 @@
 module Sounder
-  VERSION = "1.0.0"
+  VERSION = "1.0.2"
 end

data/spec/sounder/sound_group_spec.rb

@@ -54,9 +54,9 @@ describe Sounder do
     describe '#usage' do
       it "returns usage info in a string" do
         group = Sounder::SoundGroup.new sounds
-        group.usage.should include "random"
-        group.usage.should include "sound_a"
-        group.usage.should include "sound_b"
+        group.usage.should include "random (picks a random sound)"
+        group.usage.should include "  sound_a"
+        group.usage.should include "  sound_b"
       end
     end
   end

data/spec/sounder/sound_spec.rb

@@ -15,6 +15,11 @@ describe Sounder do
         sound.should_receive(:system).with %{/usr/bin/afplay "fake/file.m4a" &}
         sound.play
       end
+      it "is not super insecure" do
+        bad_sound = Sounder::Sound.new '";echo doing bad things;"'
+        bad_sound.should_receive(:system).with %{/usr/bin/afplay \"\\\"\\;echo\\ doing\\ bad\\ things\\;\\\"\" &}
+        bad_sound.play
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sounder
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.2
 platform: ruby
 authors:
 - Adam Zaninovich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-06 00:00:00.000000000 Z
+date: 2013-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler