sortability 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8a43a19779df7ff3847545f12c4581dade2c4852
-  data.tar.gz: 2fabbb3ef162fa77e2bf7c090f79dc18b9b8bbdc
+  metadata.gz: 29973c452c7c5e7cefbedbe2dd255581109dc2e2
+  data.tar.gz: 648ede88227d43edc148332223a3ebf8c629a763
 SHA512:
-  metadata.gz: 4fa64ad8cac6a90c6886f43c7cd8b69058aaf30e2591fdd6bebb22cbecf4ce00d67f4bbf73755b7f997838dbcc579a79dc4bab12421527fa906bb8ea8034385a
-  data.tar.gz: 1b3e627ef50acdb7fb72441fed42861b9ce1d0619274005c0218d6a957fa53bb01cb2af04cc0018e14855bd66554d930765be7dcf2bce4fc7daf3ca58ee86fd4
+  metadata.gz: 7a03cc07e6a6c2289c06a8cccc7c58341d698a034fd47fea0d5a1fbb3c2d475e91ad60d332e77821ad2498c3468ad06ea6087d6df8b54447d0c6278180bddd6a
+  data.tar.gz: 7b17c665e6debd0646e8ff2a54623441b3f34273c3030efb3a808181f93bed0a91c0d7972974a07935cbf87ad15b2f4f21201f94925d193cd3d08171682db2fe

data/README.md

@@ -129,7 +129,7 @@ Here are some things that you can do:
   `container` also be automatically updated to create a gap for that `record`.
 
 - Close all gaps in the `sort_position` for the peers of a `record`
-  by calling the `compact_sort_position_peers` method.
+  by calling the `compact_sort_position_peers!` method.
 
 - Get the next or previous record by using the `next_by_sort_position` or
   `previous_by_sort_position` methods.
@@ -138,7 +138,7 @@ The `sort_position` is not guaranteed to contain consecutive numbers.
 When listing the `records`, you should compute their positions
 in application code as you iterate through the list.
 If you need the position for a single `record`, call
-`compact_sort_position_peers` first to close any gaps
+`compact_sort_position_peers!` first to close any gaps
 in its peers, then read `sort_position` directly.
 
 ## Contributing

data/lib/sortability/active_record/base.rb

@@ -19,7 +19,7 @@ module Sortability
           before_validation_mname = "#{onname}_before_validation"
           next_by_mname = "next_by_#{onname}"
           prev_by_mname = "previous_by_#{onname}"
-          compact_peers_mname = "compact_#{onname}_peers"
+          compact_peers_mname = "compact_#{onname}_peers!"
 
           class_exec do
             before_validation before_validation_mname
@@ -85,20 +85,27 @@ module Sortability
             # Renumbers the peers so that their numbers are sequential,
             # starting at 1
             define_method compact_peers_mname do
-              mysql = \
-                defined?(ActiveRecord::ConnectionAdapters::MysqlAdapter) && \
-                ActiveRecord::Base.connection.instance_of?(
-                  ActiveRecord::ConnectionAdapters::MysqlAdapter)
-              cend = mysql ? 'END CASE' : 'END'
-
+              needs_update = false
               peers = send(peers_mname)
               cases = peers.to_a.collect.with_index do |p, i|
+                old_val = p.send(on)
+                new_val = i + 1
+                needs_update = true if old_val != new_val
+
                 # Make sure "on" field in self is up to date
-                send(setter_mname, i + 1) if p == self
+                send(setter_mname, new_val) if p == self
 
-                "WHEN #{p.send(on)} THEN #{- (i + 1)}"
+                "WHEN #{old_val} THEN #{- new_val}"
               end.join(' ')
 
+              return peers unless needs_update
+
+              mysql = \
+                defined?(ActiveRecord::ConnectionAdapters::MysqlAdapter) && \
+                ActiveRecord::Base.connection.instance_of?(
+                  ActiveRecord::ConnectionAdapters::MysqlAdapter)
+              cend = mysql ? 'END CASE' : 'END'
+
               self.class.transaction do
                 peers.reorder(nil)
                      .update_all("#{onname} = CASE #{onname} #{cases} #{cend}")

data/lib/sortability/version.rb

@@ -1,3 +1,3 @@
 module Sortability
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sortability
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Dante Soares
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-05 00:00:00.000000000 Z
+date: 2014-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails