sort_this 1.0.1 → 1.0.2

Sign up to get free protection for your applications and to get access to all the features.
data/CHANGELOG.md CHANGED
@@ -7,4 +7,8 @@
7
7
  * column_name is now optional
8
8
  * added a table_name option to use when using joins
9
9
  * added default_sort class method
10
- * sort and default_sort are memoized
10
+ * sort and default_sort are memoized
11
+
12
+ ## v1.0.2
13
+
14
+ * fixing bug due to typo
@@ -66,7 +66,19 @@ module SortThis
66
66
  end
67
67
 
68
68
  def default_sort
69
- order(self.default_sort_columns.values.join(', '))
69
+ table_joins = []
70
+ order_clauses = []
71
+
72
+ self.default_sort_columns.each do |column_name, sort_clause|
73
+ join = sort_columns[column_name][:joins]
74
+ table_joins << join unless join.nil?
75
+ order_clauses << sort_clause
76
+ end
77
+
78
+ query = scoped
79
+ query = joins(table_joins.uniq!) unless table_joins.empty?
80
+ query = query.order(order_clauses.join(', '))
81
+ query
70
82
  end
71
83
 
72
84
  def sort(sort_column = nil, sort_direction = DEFAULT_SORT_DIRECTION)
@@ -91,7 +103,7 @@ module SortThis
91
103
 
92
104
  default_sorts.each do |column_name, sort_clause|
93
105
  join = sort_columns[column_name][:joins]
94
- tables_joins << join unless join.nil?
106
+ table_joins << join unless join.nil?
95
107
  order_clauses << sort_clause
96
108
  end
97
109
 
@@ -1,3 +1,3 @@
1
1
  module SortThis
2
- VERSION = "1.0.1"
2
+ VERSION = "1.0.2"
3
3
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: sort_this
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.0.1
4
+ version: 1.0.2
5
5
  prerelease:
6
6
  platform: ruby
7
7
  authors:
@@ -92,7 +92,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
92
92
  version: '0'
93
93
  segments:
94
94
  - 0
95
- hash: -2410530305062139336
95
+ hash: 3994324686683044989
96
96
  required_rubygems_version: !ruby/object:Gem::Requirement
97
97
  none: false
98
98
  requirements: