sort_n_params 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5546d17da19b3cfb15a26cb4cd14fc684545af3f743ea175d28947b0511f9758
-  data.tar.gz: 449f77325f1afb0e71ba03276bb07d095e9d00348882d50c69788e4c4902685d
+  metadata.gz: 0d4ac056564f23114d90e35df4b967adb86fa41078a7ea283b0194bc4185770e
+  data.tar.gz: 3d5ef6cb54e2332663f866fb64b4f4129ce71dcb759e7a07d81591f4305d9947
 SHA512:
-  metadata.gz: 350e519cb57c72ba5b7541f8802bba8436a57905b8adb2c293c09d1892c50e23c646a5280f1469a0c5b56e34929bc9c745d5c08a348224c95ff588d526691afc
-  data.tar.gz: 0a314e2fcdc8998dfe14fa42ceead8114474f5dccf101112bc7243d265ba56d3f22dd2f8b6e6f00d0111fa90b8d3281e3eeb8e6dd7d653abec71f9976d596ea3
+  metadata.gz: d3958ff1ccc8458fa980a3372f362663be02b5a812641fc55f2e3c8fcc290038c152045538236290f2fb530bb4fd510c9af45e8c6a35c50c4fb14c4bc3fd1172
+  data.tar.gz: 0f17254708d77572faa51439bafebac85d8b7276a7b060b78bc1e917b9d7a06095edc534983be0508dada603b432dd4e9eb2cde400235ada34cad226d47c19f9

data/lib/sort_n_params/concerns/scopes.rb

@@ -9,7 +9,7 @@ module SortNParams
       def sorting_order(ordering_array, table_name = nil)
         return all if ordering_array.blank?
 
-        all.order(parse_array(ordering_array, table_name))
+        all.order(sanitize_sql_for_order(parse_array(ordering_array, table_name)))
       end
 
       def parse_array(ordering_array, table_name = nil)

data/sort_n_params.gemspec

@@ -2,8 +2,8 @@
 
 Gem::Specification.new do |s|
   s.name        = 'sort_n_params'
-  s.version     = '1.2.3'
-  s.date        = '2022-06-22'
+  s.version     = '1.2.4'
+  s.date        = '2022-06-23'
   s.summary     = 'Sort N Params'
   s.description = 'Make your html <tables> sortables with N <th> parameters this gem.'
   s.authors     = ['Juan Francisco Ferrari']
@@ -35,6 +35,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec', '~> 3.0'
   s.add_development_dependency 'rubocop', '~> 1.30'
   s.add_development_dependency 'rubocop-rails'
+  s.add_development_dependency 'sqlite3'
 
   s.add_dependency('nokogiri', ['>= 0'])
   s.add_dependency('rails', ['>= 7.0'])

data/spec/concerns/scopes_spec.rb

@@ -1,16 +1,48 @@
 # frozen_string_literal: true
 
 require 'sort_n_params/concerns/scopes'
+require 'active_record'
 
-CustomTable = Struct.new(:custom_field) do
+class CustomTable < ActiveRecord::Base
   include SortNParams::Scopes
 end
 
 RSpec.describe SortNParams::Scopes do
+  before(:all) { create_tables }
+  after(:all) { drop_tables }
+
+  def create_tables
+    ActiveRecord::Base.connection.create_table :custom_tables do |t|
+      t.text :test_field
+    end
+  end
+
+  def drop_tables
+    ActiveRecord::Base.connection.drop_table :custom_tables
+  end
+
   let(:test_class) do
     CustomTable
   end
 
+  describe '#sorting_order' do
+    context 'when you pass only the sorting field with direction asc' do
+      subject { test_class.sorting_order(%w[test_field asc]) }
+
+      it 'builds an order with that field and direction' do
+        expect(subject.explain).to include('ORDER BY custom_tables.test_field asc')
+      end
+    end
+
+    context 'when you pass only the sorting field direction desc' do
+      subject { test_class.sorting_order(%w[test_field desc]) }
+
+      it 'builds an order with that field and direction' do
+        expect(subject.explain).to include('ORDER BY custom_tables.test_field desc')
+      end
+    end
+  end
+
   describe '#parse_array' do
     context 'when you pass only an ordering array' do
       subject { test_class.parse_array(%w[test_field asc]) }

data/spec/spec_helper.rb

@@ -2,8 +2,15 @@
 
 require 'factory_bot'
 require 'sort_n_params/sortable'
+require 'active_record'
+require 'sqlite3'
 
 RSpec.configure do |config|
   config.include FactoryBot::Syntax::Methods
   FactoryBot.find_definitions
+
+  ActiveRecord::Base.establish_connection(
+    adapter: 'sqlite3',
+    database: ':memory:'
+  )
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sort_n_params
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Juan Francisco Ferrari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-22 00:00:00.000000000 Z
+date: 2022-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement