sorbet_typed-props 1.5.5 → 1.5.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7206c19cf06589c26a6d00a673273645270a37d4957304902ee0a3eb5e5cfe9
-  data.tar.gz: 44091faa0e3dbf390cb383dbed54044230cb1416eaee7a4501003d1209622183
+  metadata.gz: 0ea0b943a9c67c764b3a231c7dee5a7067f217c6b0affbe307d41276085e243d
+  data.tar.gz: b2e761a7cc064ca3784e7f2315c916ef52e7dd92350219e206c23ba1df173c69
 SHA512:
-  metadata.gz: d196157b6961f084f2ef8b60e77348d17b2a7d72f6a75a990bdaff20747ff80807a3ca5d091dab0a1f7e072dc36a9f44fdd510e9e88205d968cee1d9359907b6
-  data.tar.gz: ce46d5dc413eb1da669a9c98a24051c56c2cbf741952a4445e55ff237a70900ea0372f7456e59caab3f4c10746babdf57e1c0b93ff5c504ffa10b76c3fa10192
+  metadata.gz: becef28ed4be57479118206763a662d5bb2c98791000bcd7d8cdd7d1e987f31fe90cce6311f81f06a7a782c336cfea2ab58cb2798736accb1ba2258bbc5fd149
+  data.tar.gz: 7b1f00d89e420e169273c7686ee8fad7acbb6234233869fa7cb9b6c35ce05451041aa69ffb109c8e9ab0a5eb5541b2650f353688d54178064a5ce4191f7f243d

data/.cz.yaml

@@ -15,7 +15,7 @@ commitizen:
     - mise run format
   tag_format: v$version
   update_changelog_on_bump: true
-  version: 1.5.5
+  version: 1.5.6
   version_files:
     - lib/sorbet_typed/props/version.rb
   version_scheme: semver2

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v1.5.6 (2026-07-29)
+
+### Fix
+
+- **tapioca**: stop generating invalid self.new RBI for generic classes
+
 ## v1.5.5 (2026-07-17)
 
 ### Fix

data/docs/phlex.md

@@ -9,6 +9,7 @@
   - [Phlex component with props](#phlex-component-with-props)
 - [Behavior notes](#behavior-notes)
 - [Automatic `::new` typing](#automatic-new-typing)
+- [When `::new` cannot be typed](#when-new-cannot-be-typed)
 - [Phlex version compatibility](#phlex-version-compatibility)
 - [Element-name collisions](#element-name-collisions)
 
@@ -78,6 +79,33 @@ calls exactly like it validates `#initialize` calls on non-Phlex classes — no
 Components::UserCard.new # error: Missing required keyword argument `name`
 ```
 
+Note that this `self.new` generation only kicks in for classes whose ancestor genuinely overrides `::new` with a real
+method (like `Phlex::SGML`) - a class descending from an _abstract_ ancestor (`abstract!`/`interface!`) does not need
+one: Sorbet already infers `.new` correctly from `#initialize` there, even though the class also happens to inherit a
+runtime-only `self.new` guard from `abstract!`.
+
+## When `::new` cannot be typed
+
+If a prop's type is one of the class's own `type_member`s/`type_template`s _and_ an ancestor overrides `::new`, the gem
+cannot generate a valid `self.new` signature: Sorbet forbids referencing a `type_member` inside a singleton method
+signature (only `type_template` is allowed there, see [srb.help/5072](https://srb.help/5072)). This combination raises a
+`RuntimeError` while generating RBI files, rather than silently emitting invalid RBI or silently omitting `self.new`
+(which would leave `.new` resolving against the wrong, Phlex-overridden signature).
+
+```ruby
+class Components::GenericCard < Phlex::HTML # Phlex::SGML overrides `::new`
+  extend T::Generic
+  include SorbetTyped::Props
+
+  DataType = type_member { { upper: Object } }
+
+  prop :data, DataType # raises when generating RBI files - `DataType` can't appear in a `self.new` signature
+end
+```
+
+To fix this, either give the prop a concrete (non-generic) type, or avoid mixing `type_member`-typed props into a class
+whose ancestor overrides `::new`.
+
 ## Phlex version compatibility
 
 `SorbetTyped::Props` requires Phlex `>= 1.0.0` when included in a Phlex component. Versions before 1.0 predate the

data/lib/sorbet_typed/props/version.rb

@@ -5,7 +5,7 @@
 
 module SorbetTyped
   module Props
-    VERSION = '1.5.5'
+    VERSION = '1.5.6'
   end
 end
 

data/lib/tapioca/dsl/compilers/sorbet_typed_props_constructor.rb

@@ -67,16 +67,9 @@ module Tapioca
 
         sig { params(name: Symbol, details: T.untyped).returns(RBI::TypedParam) }
         def create_param_from_prop(name:, details:)
-          details_struct =
-            Tapioca::Dsl::Compilers::SorbetTypedPropsConstructor::PropToParamConverter::Details.
-              from_hash(details.transform_keys(&:to_s))
-
-          Tapioca::Dsl::Compilers::SorbetTypedPropsConstructor::PropToParamConverter.
-            new(
-              name:,
-              details: details_struct
-            ).
-            create_rbi_parameter
+          details_struct = PropToParamConverter::Details.from_hash(details.transform_keys(&:to_s))
+
+          PropToParamConverter.new(name:, details: details_struct).create_rbi_parameter
         end
 
         sig { void }
@@ -94,6 +87,8 @@ module Tapioca
 
             next unless self_new_overridden?
 
+            raise_unsupported_type_variable_new if references_type_variable?
+
             klass.create_method(
               'new',
               parameters: params_with_optional_last,
@@ -104,14 +99,42 @@ module Tapioca
           end
         end
 
+        sig { returns(T.noreturn) }
+        # An ancestor overrides `self.new`, so we'd normally define our own to
+        # win ancestor-chain resolution - but a param is typed with one of
+        # this class's own type variables, illegal in a singleton signature
+        # (https://srb.help/5072). Raise rather than emit invalid RBI.
+        def raise_unsupported_type_variable_new
+          raise "#{constant}: cannot generate a `self.new` signature - an ancestor overrides `self.new`, " \
+            "but the initializer has a parameter typed with one of this class's own " \
+            '`type_member`s/`type_template`s (https://srb.help/5072). Give the prop a concrete ' \
+            '(non-generic) type, or drop the `self.new`-overriding ancestor.'
+        end
+
         sig { returns(T::Boolean) }
-        # NOTE: Phlex::SGML overrides `self.new` (untyped), so Sorbet resolves
-        # `.new` calls against that instead of synthesizing a signature from
-        # `#initialize`. Defining our own `self.new` directly on the leaf class
-        # wins ancestor-chain resolution over any such override. Gated so plain
-        # classes (the common case) get no extra RBI output.
+        # Phlex::SGML overrides `self.new` (untyped); defining our own wins
+        # ancestor-chain resolution. Excludes `abstract!`'s own `self.new`
+        # guard (Sorbet already infers `.new` through it) - otherwise every
+        # concrete descendant of an abstract class would false-positive here.
         def self_new_overridden?
-          constant.method(:new).owner != Class
+          new_method_owner = T.unsafe(constant).method(:new).owner
+          return false if new_method_owner == Class
+          return false if abstract_ancestor?(new_method_owner)
+
+          true
+        end
+
+        sig { params(singleton_class: T.untyped).returns(T::Boolean) }
+        def abstract_ancestor?(singleton_class)
+          T::AbstractUtils.abstract_module?(singleton_class.attached_object)
+        end
+
+        sig { returns(T::Boolean) }
+        # A `type_member`/`type_template` cannot appear in a singleton method
+        # signature (https://srb.help/5072) - detects whether any param
+        # references one of the class's own type variables.
+        def references_type_variable?
+          props_in_initializer.each_value.any? { |rules| rules[:type_object].is_a?(T::Types::TypeVariable) }
         end
 
         sig { returns(T::Array[RBI::TypedParam]) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sorbet_typed-props
 version: !ruby/object:Gem::Version
-  version: 1.5.5
+  version: 1.5.6
 platform: ruby
 authors:
 - Richard Kramer