sorbet-runtime 0.4.4362 → 0.4.4363

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83a3d65a2902eb4d43f12d037a3ace849d3a2ff1
-  data.tar.gz: b873428cd637d7f053992d3b9c6f1611dfcd9885
+  metadata.gz: 3a7e61287dc87698d3155d8cd937606802f6229f
+  data.tar.gz: 1bba876d0f992872f8523d6f3398a67148f9a8d4
 SHA512:
-  metadata.gz: aed781e38d9773f591c0459f402142b3dfa916594dc1fcda93edfac13b973e3292b6a9ed1e349c735c2ea7d381fb1afc0621085418ed1e28418e8a46bcdcaa51
-  data.tar.gz: 8290154bb333c23ebc8f621907c94f21a685d642f3a3db00d07d83454038df0022416330f2158344e66705c8cca301260402aa122738bad86740e0ca492344f6
+  metadata.gz: c9c83ec306edaa6848871a6ac4a7a3f0c7b1952fccd607a05b825ebe22e052a1d6f0ddee7f9627a5024be879df29c6c52f3d73b14b9267a7b0094f576a98c557
+  data.tar.gz: 869bbed31317fedeafcc3db710b2ef48ef4a2f9a1113c98283b2aeec35272d8d2f5956c1bcd24a8815f160a26fb2937c0f5c18e3b7d3fd03661cc184745d3495

data/lib/types/private/methods/_methods.rb

@@ -43,7 +43,7 @@ module T::Private::Methods
     if decl.returns == ARG_NOT_PROVIDED
       raise "Procs must specify a return type"
     end
-    if decl.soft_notify != ARG_NOT_PROVIDED
+    if decl.on_failure != ARG_NOT_PROVIDED
       raise "Procs cannot use .on_failure"
     end
 
@@ -224,7 +224,7 @@ module T::Private::Methods
         bind: current_declaration.bind,
         mode: current_declaration.mode,
         check_level: current_declaration.checked,
-        soft_notify: current_declaration.soft_notify,
+        on_failure: current_declaration.on_failure,
         override_allow_incompatible: current_declaration.override_allow_incompatible,
         generated: current_declaration.generated,
       )

data/lib/types/private/methods/decl_builder.rb

@@ -2,7 +2,7 @@
 # typed: true
 
 module T::Private::Methods
-  Declaration = Struct.new(:mod, :params, :returns, :bind, :mode, :checked, :finalized, :soft_notify, :override_allow_incompatible, :type_parameters, :generated)
+  Declaration = Struct.new(:mod, :params, :returns, :bind, :mode, :checked, :finalized, :on_failure, :override_allow_incompatible, :type_parameters, :generated)
 
   class DeclBuilder
     attr_reader :decl
@@ -25,7 +25,7 @@ module T::Private::Methods
         Modes.standard, # mode
         ARG_NOT_PROVIDED, # checked
         false, # finalized
-        ARG_NOT_PROVIDED, # soft_notify
+        ARG_NOT_PROVIDED, # on_failure
         nil, # override_allow_incompatible
         ARG_NOT_PROVIDED, # type_parameters
         ARG_NOT_PROVIDED, # generated
@@ -85,7 +85,7 @@ module T::Private::Methods
       if !decl.checked.equal?(ARG_NOT_PROVIDED)
         raise BuilderError.new("You can't call .checked multiple times in a signature.")
       end
-      if level == :never && !decl.soft_notify.equal?(ARG_NOT_PROVIDED)
+      if level == :never && !decl.on_failure.equal?(ARG_NOT_PROVIDED)
         raise BuilderError.new("You can't use .checked(:never) with .on_failure because .on_failure will have no effect.")
       end
       if !decl.generated.equal?(ARG_NOT_PROVIDED)
@@ -100,10 +100,10 @@ module T::Private::Methods
       self
     end
 
-    def on_failure(notify:)
+    def on_failure(*args)
       check_live!
 
-      if !decl.soft_notify.equal?(ARG_NOT_PROVIDED)
+      if !decl.on_failure.equal?(ARG_NOT_PROVIDED)
         raise BuilderError.new("You can't call .on_failure multiple times in a signature.")
       end
       if decl.checked == :never
@@ -113,13 +113,7 @@ module T::Private::Methods
         raise BuilderError.new("You can't use .on_failure with .generated.")
       end
 
-      # TODO consider validating that :notify is a project that sentry knows about,
-      # as per https://git.corp.stripe.com/stripe-internal/pay-server/blob/master/lib/event/job/sentry_job.rb#L125
-      if !notify || notify == ''
-        raise BuilderError.new("You can't provide an empty notify to .on_failure().")
-      end
-
-      decl.soft_notify = notify
+      decl.on_failure = args
 
       self
     end
@@ -133,7 +127,7 @@ module T::Private::Methods
       if !decl.checked.equal?(ARG_NOT_PROVIDED)
         raise BuilderError.new("You can't use .generated with .checked.")
       end
-      if !decl.soft_notify.equal?(ARG_NOT_PROVIDED)
+      if !decl.on_failure.equal?(ARG_NOT_PROVIDED)
         raise BuilderError.new("You can't use .generated with .on_failure.")
       end
 
@@ -244,13 +238,13 @@ module T::Private::Methods
       end
       if decl.checked.equal?(ARG_NOT_PROVIDED)
         default_checked_level = T::Private::RuntimeLevels.default_checked_level
-        if default_checked_level == :never && !decl.soft_notify.equal?(ARG_NOT_PROVIDED)
+        if default_checked_level == :never && !decl.on_failure.equal?(ARG_NOT_PROVIDED)
           raise BuilderError.new("To use .on_failure you must additionally call .checked(:tests) or .checked(:always), otherwise, the .on_failure has no effect.")
         end
         decl.checked = default_checked_level
       end
-      if decl.soft_notify.equal?(ARG_NOT_PROVIDED)
-        decl.soft_notify = nil
+      if decl.on_failure.equal?(ARG_NOT_PROVIDED)
+        decl.on_failure = nil
       end
       if decl.generated.equal?(ARG_NOT_PROVIDED)
         decl.generated = false

data/lib/types/private/methods/signature.rb

@@ -5,7 +5,7 @@ class T::Private::Methods::Signature
   attr_reader :method, :method_name, :arg_types, :kwarg_types, :block_type, :block_name,
               :rest_type, :rest_name, :keyrest_type, :keyrest_name, :bind,
               :return_type, :mode, :req_arg_count, :req_kwarg_names, :has_rest, :has_keyrest,
-              :check_level, :generated, :parameters, :soft_notify, :override_allow_incompatible, :ever_failed
+              :check_level, :generated, :parameters, :on_failure, :override_allow_incompatible, :ever_failed
 
   def self.new_untyped(method:, mode: T::Private::Methods::Modes.untyped, parameters: method.parameters)
     # Using `Untyped` ensures we'll get an error if we ever try validation on these.
@@ -24,7 +24,7 @@ class T::Private::Methods::Signature
       mode: mode,
       check_level: :never,
       parameters: parameters,
-      soft_notify: nil,
+      on_failure: nil,
     )
   end
 
@@ -32,7 +32,7 @@ class T::Private::Methods::Signature
     @ever_failed = true
   end
 
-  def initialize(method:, method_name:, raw_arg_types:, raw_return_type:, bind:, mode:, check_level:, parameters: method.parameters, soft_notify:, generated: false, override_allow_incompatible: false)
+  def initialize(method:, method_name:, raw_arg_types:, raw_return_type:, bind:, mode:, check_level:, parameters: method.parameters, on_failure:, generated: false, override_allow_incompatible: false)
     @method = method
     @method_name = method_name
     @arg_types = []
@@ -52,7 +52,7 @@ class T::Private::Methods::Signature
     @has_rest = false
     @has_keyrest = false
     @parameters = parameters
-    @soft_notify = soft_notify
+    @on_failure = on_failure
     @override_allow_incompatible = override_allow_incompatible
     @generated = generated
     @ever_failed = false

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.4.4362
+  version: 0.4.4363
 platform: ruby
 authors:
 - Stripe