sorbet-runtime 0.5.12210 → 0.5.12216

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0891552c564e5e30d9b00acbe5672a935d281a6b7b213e330cc166e072d02a5
-  data.tar.gz: 21e1ba18dfbd989aa5706c3d8100997616a84a132aa3aaab7350f6394c74f805
+  metadata.gz: 4d32b12d9ff3678030a22fa53f5543c41c44bd2c937da836e68b509a2e78e8aa
+  data.tar.gz: 696ca2d859d39882a9c25482c8f38272e915c81d5409e1442a14a46535ce31f1
 SHA512:
-  metadata.gz: d9919bd647ab1398de838c81655156335d2660625d8382c42ebdb079d64838873f43166943f8dec279068b0a28120d72815ee6e4da65829991846f9a918c5019
-  data.tar.gz: 7ff7137c10c15d1ae263ec8b797afed9dbdd478cff62f8ed22e3cf358e604d2aa475f7e5aca903a80c566d1fd13039e6172437fa8dd6677ade85a81e71af92f4
+  metadata.gz: ccc9012710e93b58447df837349c397a5b2ef7a0388d31f7d15c4384ac13b4d063c4f180e378544236194d394a972f23fbd2652f6bec20bdfb6347a125b2edf1
+  data.tar.gz: e678c24ccf583366c8170b91c7bd6520ac8ce354c95ac927b5b706fc25c6e5253375056256c69419351464e995588e3c71dc46a94fbcfb3b1e0b8e216858c498

data/lib/types/private/methods/_methods.rb

@@ -589,6 +589,22 @@ module T::Private::Methods
     mod.extend(SingletonMethodHooks)
   end
 
+  # `name` must be an instance method (for class methods, pass in mod.singleton_class)
+  def self.visibility_method_name(mod, name)
+    if mod.public_method_defined?(name)
+      :public
+    elsif mod.protected_method_defined?(name)
+      :protected
+    elsif mod.private_method_defined?(name)
+      :private
+    else
+      # Raises a NameError formatted like the Ruby VM would (the exact text formatting
+      # of these errors changed across Ruby VM versions, in ways that would sometimes
+      # cause tests to fail if they were dependent on hard coding errors).
+      mod.method(name)
+    end
+  end
+
   # use this directly if you don't want/need to box up the method into an object to pass to method_to_key.
   private_class_method def self.method_owner_and_name_to_key(owner, name)
     "#{owner.object_id}##{name}"

data/lib/types/private/methods/call_validation.rb

@@ -12,7 +12,7 @@ module T::Private::Methods::CallValidation
   # @param method_sig [T::Private::Methods::Signature]
   # @return [UnboundMethod] the new wrapper method (or the original one if we didn't wrap it)
   def self.wrap_method_if_needed(mod, method_sig, original_method)
-    original_visibility = visibility_method_name(mod, method_sig.method_name)
+    original_visibility = T::Private::Methods.visibility_method_name(mod, method_sig.method_name)
     if method_sig.mode == T::Private::Methods::Modes.abstract
       create_abstract_wrapper(mod, method_sig, original_method, original_visibility)
     # Do nothing in this case; this method was not wrapped in _on_method_added.
@@ -330,19 +330,6 @@ module T::Private::Methods::CallValidation
       location: caller_loc
     )
   end
-
-  # `name` must be an instance method (for class methods, pass in mod.singleton_class)
-  private_class_method def self.visibility_method_name(mod, name)
-    if mod.public_method_defined?(name)
-      :public
-    elsif mod.protected_method_defined?(name)
-      :protected
-    elsif mod.private_method_defined?(name)
-      :private
-    else
-      mod.method(name) # Raises
-    end
-  end
 end
 
 if T::Configuration::AT_LEAST_RUBY_2_7

data/lib/types/private/methods/signature_validation.rb

@@ -89,6 +89,7 @@ module T::Private::Methods::SignatureValidation
         validate_override_mode(signature, super_signature)
         validate_override_shape(signature, super_signature)
         validate_override_types(signature, super_signature)
+        validate_override_visibility(signature, super_signature)
       end
     else
       validate_non_override_mode(signature)
@@ -276,6 +277,38 @@ module T::Private::Methods::SignatureValidation
     end
   end
 
+  def self.validate_override_visibility(signature, super_signature)
+    return if super_signature.mode == Modes.untyped
+    # This departs from the behavior of other `validate_override_whatever` functions in that it
+    # only comes into effect when the child signature explicitly says the word `override`. This was
+    # done because the primary method for silencing these errors (`allow_incompatible: :visibility`)
+    # requires an `override` node to attach to. Once we have static override checking for implicitly
+    # overridden methods, we can remove this.
+    return unless [Modes.override, Modes.overridable_override].include?(signature.mode)
+    return if [:visibility, true].include?(signature.override_allow_incompatible)
+    method = signature.method
+    super_method = super_signature.method
+    mode_noun = super_signature.mode == Modes.abstract ? 'implementation' : 'override'
+    vis = method_visibility(method)
+    super_vis = method_visibility(super_method)
+
+    if visibility_strength(vis) > visibility_strength(super_vis)
+      raise "Incompatible visibility for #{mode_noun} of method #{method.name}\n" \
+            "* Base: #{super_vis} (in #{method_loc_str(super_method)})\n" \
+            "* #{mode_noun.capitalize}: #{vis} (in #{method_loc_str(method)})\n" \
+            "(The override must be at least as permissive as the supermethod)" \
+    end
+  end
+
+  private_class_method def self.method_visibility(method)
+    T::Private::Methods.visibility_method_name(method.owner, method.name)
+  end
+
+  # Higher = more restrictive.
+  private_class_method def self.visibility_strength(vis)
+    %i[public protected private].find_index(vis)
+  end
+
   private_class_method def self.base_override_loc_str(signature, super_signature)
     mode_noun = super_signature.mode == Modes.abstract ? 'Implementation' : 'Override'
     "\n * Base definition: in #{method_loc_str(super_signature.method)}" \

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sorbet-runtime
 version: !ruby/object:Gem::Version
-  version: 0.5.12210
+  version: 0.5.12216
 platform: ruby
 authors:
 - Stripe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2025-06-28 00:00:00.000000000 Z
+date: 2025-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest