songkick-transport 0.2.0 → 0.2.1

data/lib/songkick/transport/serialization.rb

@@ -16,7 +16,7 @@ module Songkick
       def build_query_string(params, fully_encode = true, sanitize = false)
         return params if String === params
         pairs = []
-        each_qs_param('', params) do |key, value|
+        each_qs_param('', params, fully_encode) do |key, value|
           value = SANITIZED_VALUE if sanitize and sanitize?(key)
           pairs << [key, value]
         end
@@ -30,19 +30,21 @@ module Songkick
         end
       end
       
-      def each_qs_param(prefix, value, &block)
+      def each_qs_param(prefix, value, fully_encode = true, &block)
         case value
         when Array
-          value.each { |e| each_qs_param(prefix + "[]", e, &block) }
+          value.each { |e| each_qs_param(prefix + "[]", e, fully_encode, &block) }
         when Hash
           value.each do |k,v|
-            key = (prefix == '') ? CGI.escape(k.to_s) : prefix + "[#{CGI.escape k.to_s}]"
-            each_qs_param(key, v, &block)
+            encoded = fully_encode ? CGI.escape(k.to_s) : k.to_s
+            key = (prefix == '') ? encoded : prefix + "[#{encoded}]"
+            each_qs_param(key, v, fully_encode, &block)
           end
         when Transport::IO
           block.call(prefix, value)
         else
-          block.call(prefix, CGI.escape(value.to_s))
+          encoded = fully_encode ? CGI.escape(value.to_s) : value.to_s
+          block.call(prefix, encoded)
         end
       end
       

data/spec/songkick/transport_spec.rb

@@ -119,7 +119,7 @@ describe Songkick::Transport do
       let(:upload) { Songkick::Transport::IO.new(file, "image/jpeg", "songkick.png") }
       
       let :params do
-        {:concert => {:file => upload, :foo => :bar}}
+        {:concert => {:file => upload, :foo => "me@thing.com"}}
       end
       
       let :expected_response do
@@ -127,7 +127,7 @@ describe Songkick::Transport do
           "filename" => "songkick.png",
           "method"   => @http_method,
           "size"     => 6694,
-          "foo"      => "bar"
+          "foo"      => "me@thing.com"
         }
       end
       

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: songkick-transport
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-19 00:00:00.000000000 Z
+date: 2013-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multipart-post
@@ -151,7 +151,6 @@ files:
 - examples/loop.rb
 - examples/thread_safety.rb
 - examples/server.rb
-- examples/foo.rb
 - examples/example.rb
 - lib/songkick/transport/request.rb
 - lib/songkick/transport/rack_test.rb
@@ -200,3 +199,4 @@ signing_key:
 specification_version: 3
 summary: HTTP client abstraction for service clients
 test_files: []
+has_rdoc: 

data/examples/foo.rb

@@ -1,9 +0,0 @@
-require './lib/songkick/transport'
-
-t = Songkick::Transport::Curb.new 'localhost:4567'
-r = Songkick::Transport.report
-
-r.execute { t.get '/' }
-
-p r.first.duration
-