solidus_webhooks 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '081615f05564d22cc05bc064b5593dbe09d2ec9342cae1b656fa909e6cf0bd53'
-  data.tar.gz: 84cb7dfd9a491681f8e823747e5221159869946c5de0fa4427d338eff8a9b814
+  metadata.gz: f94eb7d8c956dd983b90ff8ab0d14fde3fbad148400e29222c8be84d403c1baa
+  data.tar.gz: fd828061690984b542190754621d8d9b86ba34ae89070f25db9f838a0de22c78
 SHA512:
-  metadata.gz: 3a87662271d388322037918856a947ba390fc81cf4f6ddbfb46d6dde9910e527f3c4d8fa07da71f8abd1dd3680f8cf72c9cd1b684085b1b5a9e74bdf428389f2
-  data.tar.gz: 73562c98cffb0857666f9f4dba5336918c807c983548ee4b9b8eee4034d9f8629ac2c38cc59687ca13c4c98dc8f60e6478a85ab174c4c2a0dc763bda65521bcd
+  metadata.gz: 37142b4bd06257070f31083a3a99a8594654c626e52e21d41b95f075c4f3a3adc2064cd9831f2c36de5500fa91805d763e5913ea07b9b7c184ac11f6bb6755a8
+  data.tar.gz: f4cb38e4f31a7e7e1c60603c79ccc96b35365b5309b35cd959ff29175f7368ca1f95cd16be32ebdd00a8eeeb92cde2c8d1f00287f2f3e6bab42d0a65987e482a

data/.rubocop.yml

@@ -1,11 +1,28 @@
-inherit_from: .rubocop_todo.yml
-
 require:
   - solidus_dev_support/rubocop
 
 AllCops:
-  NewCops: enable
+  NewCops: disable
   Exclude:
     - sandbox/**/*
     - spec/dummy/**/*
     - vendor/bundle/**/*
+
+
+# This guys are troublemakers
+RSpec/FactoryBot/CreateList:
+  Enabled: false
+RSpec/Rails/HttpStatus:
+  Enabled: false
+
+# Deviations from the standard
+Style/ClassAndModuleChildren:
+  Enabled: false
+Style/FrozenStringLiteralComment:
+  Enabled: false
+RSpec/Capybara/FeatureMethods:
+  Enabled: false
+RSpec/MultipleExpectations:
+  Enabled: false
+RSpec/NamedSubject:
+  Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [v0.3.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.3.0) (2021-04-20)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.3.0...v0.3.0)
+
+**Closed issues:**
+
+- Prepare Solidus Webhooks for Solidus 3.0 [\#8](https://github.com/solidusio-contrib/solidus_webhooks/issues/8)
+
+**Merged pull requests:**
+
+- Allow Solidus 3 [\#10](https://github.com/solidusio-contrib/solidus_webhooks/pull/10) ([kennyadsl](https://github.com/kennyadsl))
+- Reconcile master and v0.3.0 [\#7](https://github.com/solidusio-contrib/solidus_webhooks/pull/7) ([elia](https://github.com/elia))
+- Bump solidus\_support to ~\> 0.6 [\#6](https://github.com/solidusio-contrib/solidus_webhooks/pull/6) ([peterberkenbosch](https://github.com/peterberkenbosch))
+
 ## [v0.3.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.3.0) (2020-10-20)
 
 [Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.2.0...v0.3.0)

data/README.md

@@ -3,6 +3,8 @@
 [![CircleCI](https://circleci.com/gh/solidusio-contrib/solidus_webhooks.svg?style=shield)](https://circleci.com/gh/solidusio-contrib/solidus_webhooks)
 [![codecov](https://codecov.io/gh/solidusio-contrib/solidus_webhooks/branch/master/graph/badge.svg)](https://codecov.io/gh/solidusio-contrib/solidus_webhooks)
 
+<!-- Explain what your extension does. -->
+
 ## Installation
 
 Add solidus_webhooks to your Gemfile:
@@ -19,6 +21,8 @@ bin/rails generate solidus_webhooks:install
 
 ## Usage
 
+<!-- Explain how to use your extension once it's been installed. -->
+
 A Webhook receiver is just a callable and can be registered in the Solidus configuration as follows:
 
 ```ruby
@@ -188,17 +192,7 @@ git commit -m "Update the changelog"
 
 ### Releasing new versions
 
-Your new extension version can be released using `gem-release` like this:
-
-```shell
-bundle exec gem bump -v 1.6.0
-bin/rake changelog
-git add CHANGELOG.md
-git commit --amend --no-edit
-gem tag
-git push --tags
-bundle exec gem release
-```
+Please refer to the dedicated [page](https://github.com/solidusio/solidus/wiki/How-to-release-extensions) on Solidus wiki.
 
 ## License
 

data/lib/solidus_webhooks.rb

@@ -6,21 +6,3 @@ require 'solidus_support'
 require 'solidus_webhooks/configuration'
 require 'solidus_webhooks/version'
 require 'solidus_webhooks/engine'
-
-module SolidusWebhooks
-  class << self
-    def configuration
-      @configuration ||= Configuration.new
-    end
-
-    alias config configuration
-
-    def reset_config!
-      @configuration = nil
-    end
-
-    def configure
-      yield configuration
-    end
-  end
-end

data/lib/solidus_webhooks/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'solidus_webhooks/errors'
 
 module SolidusWebhooks
@@ -19,4 +21,20 @@ module SolidusWebhooks
       @handlers[id.to_sym]
     end
   end
+
+  class << self
+    def configuration
+      @configuration ||= Configuration.new
+    end
+
+    alias config configuration
+
+    def reset_config!
+      @configuration = nil
+    end
+
+    def configure
+      yield configuration
+    end
+  end
 end

data/lib/solidus_webhooks/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusWebhooks
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/solidus_webhooks.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri'] = 'https://github.com/solidusio-contrib/solidus_webhooks'
   spec.metadata['changelog_uri'] = 'https://github.com/solidusio-contrib/solidus_webhooks/releases'
 
-  spec.required_ruby_version = Gem::Requirement.new('~> 2.5')
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.5')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -28,8 +28,8 @@ Gem::Specification.new do |spec|
   spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 3']
-  spec.add_dependency 'solidus_support', '~> 0.5'
+  spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 4']
+  spec.add_dependency 'solidus_support', '~> 0.6'
 
-  spec.add_development_dependency 'solidus_dev_support', '~> 2.1'
+  spec.add_development_dependency 'solidus_dev_support', '~> 2.2'
 end

data/spec/features/can_register_a_handler_and_receive_webhooks_spec.rb

@@ -16,14 +16,14 @@ RSpec.feature "Can register a handler and receive Webhooks", type: :request do
   let(:method_and_user_payloads) { [] }
 
   let(:proc_handler) { ->(payload) { proc_payloads << payload } }
-  let(:method_handler) { Struct.new(:payloads) do
-    def call(payload) payloads << payload end
-  end.new(method_payloads) }
+  let(:method_handler) {
+    Struct.new(:payloads) { def call(payload) payloads << payload end }.new(method_payloads)
+  }
   let(:user_handler) { ->(payload, user) { user_payloads << [payload, user] } }
   let(:splat_handler) { ->(*args) { splat_payloads << args } }
-  let(:method_and_user_handler) { Struct.new(:payloads) do
-    def call(payload, user) payloads << payload end
-  end.new(method_and_user_payloads) }
+  let(:method_and_user_handler) {
+    Struct.new(:payloads) { def call(payload, user) payloads << [payload, user] end }.new(method_and_user_payloads)
+  }
 
   let(:authorized_user) { create(:admin_user, spree_api_key: "123") }
   let(:authorized_token) { authorized_user.spree_api_key }
@@ -41,7 +41,7 @@ RSpec.feature "Can register a handler and receive Webhooks", type: :request do
     post "/webhooks/method?token=#{authorized_token}", as: :json, params: { c: 789 }
     expect(response).to have_http_status(:ok)
 
-    post "/webhooks/user?token=#{authorized_token}", as: :json, params: { d: 012 }
+    post "/webhooks/user?token=#{authorized_token}", as: :json, params: { d: 12 }
     expect(response).to have_http_status(:ok)
 
     post "/webhooks/splat?token=#{authorized_token}", as: :json, params: { e: 345 }
@@ -52,9 +52,9 @@ RSpec.feature "Can register a handler and receive Webhooks", type: :request do
 
     expect(proc_payloads).to eq([{ 'a' => 123 }, { 'b' => 456 }])
     expect(method_payloads).to eq([{ 'c' => 789 }])
-    expect(user_payloads).to eq([[{ 'd' => 012 }, authorized_user]])
+    expect(user_payloads).to eq([[{ 'd' => 12 }, authorized_user]])
     expect(splat_payloads).to eq([[{ 'e' => 345 }, authorized_user]])
-    expect(method_and_user_payloads).to eq([{ 'f' => 678 }])
+    expect(method_and_user_payloads).to eq([[{ 'f' => 678 }, authorized_user]])
   end
 
   scenario "receives a bad handler id" do

data/spec/solidus_webhooks/configuration_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe SolidusWebhooks::Configuration do
   describe '#register_webhook_handler' do
     it 'only accepts callable' do
       expect{ subject.register_webhook_handler(:foo, Object.new) }.to raise_error(SolidusWebhooks::InvalidHandler)
-      expect{ subject.register_webhook_handler(:bar, Proc.new {}) }.not_to raise_error
+      expect{ subject.register_webhook_handler(:bar, proc {}) }.not_to raise_error
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_webhooks
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Elia Schito
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-20 00:00:00.000000000 Z
+date: 2021-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -19,7 +19,7 @@ dependencies:
         version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,35 +29,35 @@ dependencies:
         version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: solidus_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: solidus_dev_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.2'
 description:
 email: contact@solidus.io
 executables: []
@@ -71,7 +71,6 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".rubocop_todo.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -89,7 +88,6 @@ files:
 - bin/rails-sandbox
 - bin/rake
 - bin/sandbox
-- bin/sandbox_rails
 - bin/setup
 - config/locales/en.yml
 - config/routes.rb
@@ -121,7 +119,7 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
       version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement

data/.rubocop_todo.yml

@@ -1,107 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2020-10-19 16:38:34 UTC using RuboCop version 0.93.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnabledMethods.
-Capybara/FeatureMethods:
-  Exclude:
-    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/BlockEndNewline:
-  Exclude:
-    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/MultilineBlockLayout:
-  Exclude:
-    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideBlockBraces:
-  EnforcedStyle: space
-
-# Offense count: 30
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: space
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/RedundantCopDisableDirective:
-  Exclude:
-    - 'bin/sandbox_rails'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
-
-# Offense count: 3
-RSpec/MultipleExpectations:
-  Max: 11
-
-# Offense count: 1
-# Configuration parameters: AllowSubject.
-RSpec/MultipleMemoizedHelpers:
-  Max: 14
-
-# Offense count: 2
-# Configuration parameters: IgnoreSharedExamples.
-RSpec/NamedSubject:
-  Exclude:
-    - 'spec/solidus_webhooks/configuration_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'app/controllers/spree/webhooks_controller.rb'
-    - 'app/models/spree/webhook.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
-  Exclude:
-    - 'spec/**/*'
-    - 'db/migrate/**/*'
-    - 'bin/**/*'
-    - 'app/controllers/spree/webhooks_controller.rb'
-    - 'app/models/spree/webhook.rb'
-    - 'lib/solidus_webhooks/configuration.rb'
-    - 'lib/solidus_webhooks/errors.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedOctalStyle.
-# SupportedOctalStyles: zero_with_o, zero_only
-Style/NumericLiteralPrefix:
-  Exclude:
-    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/Proc:
-  Exclude:
-    - 'spec/solidus_webhooks/configuration_spec.rb'

data/bin/sandbox_rails

@@ -1,18 +0,0 @@
-#!/usr/bin/env ruby
-
-# frozen_string_literal: true
-
-app_root = 'sandbox'
-
-unless File.exist? "#{app_root}/bin/rails"
-  warn 'Creating the sandbox app...'
-  Dir.chdir "#{__dir__}/.." do
-    system "#{__dir__}/sandbox" or begin # rubocop:disable Style/AndOr
-      warn 'Automatic creation of the sandbox app failed'
-      exit 1
-    end
-  end
-end
-
-Dir.chdir app_root
-exec 'bin/rails', *ARGV