solidus_webhooks 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d71609325f0e59694111c1efee4a131a283af6dfac87d9102a9e405dfca918ea
-  data.tar.gz: b9f80ecd1f6652d83915b2a49c083285df3e7e17c63b01414c273857daeadd44
+  metadata.gz: '081615f05564d22cc05bc064b5593dbe09d2ec9342cae1b656fa909e6cf0bd53'
+  data.tar.gz: 84cb7dfd9a491681f8e823747e5221159869946c5de0fa4427d338eff8a9b814
 SHA512:
-  metadata.gz: 826c8abe905a3a69d7ea642b72a047534282db7bb60c3cdced93f897c2d62f887d72807aff7cb57cc5ec1082966b9602908c97d7ba2d866ad3ffb8aeb0f09ce1
-  data.tar.gz: 8fab3c87b593ca5743818ed8551296b85709813341fa5bba3ddd2561992138fc92ba984525b3080a5c30fd9d2b64f35f99d610cdcd885115f1732eadccbe4780
+  metadata.gz: 3a87662271d388322037918856a947ba390fc81cf4f6ddbfb46d6dde9910e527f3c4d8fa07da71f8abd1dd3680f8cf72c9cd1b684085b1b5a9e74bdf428389f2
+  data.tar.gz: 73562c98cffb0857666f9f4dba5336918c807c983548ee4b9b8eee4034d9f8629ac2c38cc59687ca13c4c98dc8f60e6478a85ab174c4c2a0dc763bda65521bcd

data/.circleci/config.yml

@@ -16,12 +16,18 @@ jobs:
     executor: solidusio_extensions/mysql
     steps:
       - solidusio_extensions/run-tests
+  lint-code:
+    executor: solidusio_extensions/sqlite-memory
+    steps:
+      - solidusio_extensions/lint-code
 
 workflows:
   "Run specs on supported Solidus versions":
     jobs:
       - run-specs-with-postgres
       - run-specs-with-mysql
+      - lint-code
+
   "Weekly run specs against master":
     triggers:
       - schedule:

data/.gem_release.yml

@@ -2,4 +2,4 @@ bump:
   recurse: false
   file: 'lib/solidus_webhooks/version.rb'
   message: Bump SolidusWebhooks to %{version}
-  tag: true
+  tag: false

data/.github/stale.yml

@@ -1,17 +1,17 @@
 # Number of days of inactivity before an issue becomes stale
 daysUntilStale: 60
 # Number of days of inactivity before a stale issue is closed
-daysUntilClose: 7
+daysUntilClose: false
 # Issues with these labels will never be considered stale
 exemptLabels:
   - pinned
   - security
 # Label to use when marking an issue as stale
-staleLabel: wontfix
+staleLabel: stale
 # Comment to post when marking an issue as stale. Set to `false` to disable
 markComment: >
   This issue has been automatically marked as stale because it has not had
-  recent activity. It will be closed if no further activity occurs. Thank you
+  recent activity. It might be closed if no further activity occurs. Thank you
   for your contributions.
 # Comment to post when closing a stale issue. Set to `false` to disable
-closeComment: false
+closeComment: false

data/.github_changelog_generator

@@ -0,0 +1,2 @@
+issues=false
+exclude-labels=infrastructure

data/.gitignore

@@ -15,3 +15,6 @@ pkg
 spec/dummy
 spec/examples.txt
 /sandbox
+.rvmrc
+.ruby-version
+.ruby-gemset

data/.rubocop.yml

@@ -1,7 +1,11 @@
+inherit_from: .rubocop_todo.yml
+
 require:
   - solidus_dev_support/rubocop
 
 AllCops:
+  NewCops: enable
   Exclude:
     - sandbox/**/*
     - spec/dummy/**/*
+    - vendor/bundle/**/*

data/.rubocop_todo.yml

@@ -0,0 +1,107 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-10-19 16:38:34 UTC using RuboCop version 0.93.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnabledMethods.
+Capybara/FeatureMethods:
+  Exclude:
+    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/BlockEndNewline:
+  Exclude:
+    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/MultilineBlockLayout:
+  Exclude:
+    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideBlockBraces:
+  EnforcedStyle: space
+
+# Offense count: 30
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: space
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'bin/sandbox_rails'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
+
+# Offense count: 3
+RSpec/MultipleExpectations:
+  Max: 11
+
+# Offense count: 1
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 14
+
+# Offense count: 2
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/solidus_webhooks/configuration_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'app/controllers/spree/webhooks_controller.rb'
+    - 'app/models/spree/webhook.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'spec/**/*'
+    - 'db/migrate/**/*'
+    - 'bin/**/*'
+    - 'app/controllers/spree/webhooks_controller.rb'
+    - 'app/models/spree/webhook.rb'
+    - 'lib/solidus_webhooks/configuration.rb'
+    - 'lib/solidus_webhooks/errors.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedOctalStyle.
+# SupportedOctalStyles: zero_with_o, zero_only
+Style/NumericLiteralPrefix:
+  Exclude:
+    - 'spec/features/can_register_a_handler_and_receive_webhooks_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Proc:
+  Exclude:
+    - 'spec/solidus_webhooks/configuration_spec.rb'

data/CHANGELOG.md

@@ -0,0 +1,38 @@
+# Changelog
+
+## [v0.3.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.3.0) (2020-10-20)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.2.0...v0.3.0)
+
+**Fixed bugs:**
+
+- Fix error classes [\#5](https://github.com/solidusio-contrib/solidus_webhooks/pull/5) ([elia](https://github.com/elia))
+
+## [v0.2.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.2.0) (2020-06-10)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.1.0...v0.2.0)
+
+**Implemented enhancements:**
+
+- Expose current\_api\_user to webhook handlers [\#4](https://github.com/solidusio-contrib/solidus_webhooks/pull/4) ([elia](https://github.com/elia))
+
+## [v0.1.0](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.1.0) (2020-05-14)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.1.0.beta.1...v0.1.0)
+
+## [v0.1.0.beta.1](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.1.0.beta.1) (2020-05-13)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/v0.0.1.v0.1.0.beta.1.1...v0.1.0.beta.1)
+
+## [v0.0.1.v0.1.0.beta.1.1](https://github.com/solidusio-contrib/solidus_webhooks/tree/v0.0.1.v0.1.0.beta.1.1) (2020-05-13)
+
+[Full Changelog](https://github.com/solidusio-contrib/solidus_webhooks/compare/9573caa400232ffb44cde7f8cf907171a529ced3...v0.0.1.v0.1.0.beta.1.1)
+
+**Merged pull requests:**
+
+- Prepare the repo to be moved to @solidusio-contrib [\#2](https://github.com/solidusio-contrib/solidus_webhooks/pull/2) ([elia](https://github.com/elia))
+- Add the ability to register and receive webhooks [\#1](https://github.com/solidusio-contrib/solidus_webhooks/pull/1) ([elia](https://github.com/elia))
+
+
+
+\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

data/README.md

@@ -1,10 +1,23 @@
-SolidusWebhooks
-===============
+# Solidus Webhooks
 
-Provides comprehensive Webhook support for Solidus, with a simple and powerful way to register them and route payloads to appropriate actions, either synchronous or delayed.
+[![CircleCI](https://circleci.com/gh/solidusio-contrib/solidus_webhooks.svg?style=shield)](https://circleci.com/gh/solidusio-contrib/solidus_webhooks)
+[![codecov](https://codecov.io/gh/solidusio-contrib/solidus_webhooks/branch/master/graph/badge.svg)](https://codecov.io/gh/solidusio-contrib/solidus_webhooks)
 
-Usage
------
+## Installation
+
+Add solidus_webhooks to your Gemfile:
+
+```ruby
+gem 'solidus_webhooks'
+```
+
+Bundle your dependencies and run the installation generator:
+
+```shell
+bin/rails generate solidus_webhooks:install
+```
+
+## Usage
 
 A Webhook receiver is just a callable and can be registered in the Solidus configuration as follows:
 
@@ -33,8 +46,8 @@ The only requirement on handlers is for them to respond to `#call` and accept a
 Example:
 
 ```ruby
-class TrackingNumberHandler
-  def call(payload)
+module TrackingNumberHandler
+  def self.call(payload)
     order = Spree::Order.find_by!(number: payload[:order])
     shipment = order.shipments.find_by!(number: payload[:shipment])
     shipment.update!(tracking: payload[:tracking])
@@ -121,30 +134,15 @@ SolidusWebhooks.config.register_webhook_handler :tracking_number, -> payload, us
 }
 ```
 
+## Development
 
-Installation
-------------
-
-Add solidus_webhooks to your Gemfile:
+### Testing the extension
 
-```ruby
-gem 'solidus_webhooks'
-```
-
-Bundle your dependencies and run the installation generator:
-
-```shell
-bundle
-bundle exec rails g solidus_webhooks:install
-```
-
-Testing
--------
-
-First bundle your dependencies, then run `bin/rake`. `bin/rake` will default to building the dummy app if it does not exist, then it will run specs. The dummy app can be regenerated by using `bin/rake extension:test_app`.
+First bundle your dependencies, then run `bin/rake`. `bin/rake` will default to building the dummy
+app if it does not exist, then it will run specs. The dummy app can be regenerated by using
+`bin/rake extension:test_app`.
 
 ```shell
-bundle
 bin/rake
 ```
 
@@ -161,16 +159,15 @@ Simply add this require statement to your spec_helper:
 require 'solidus_webhooks/factories'
 ```
 
-Sandbox app
------------
+### Running the sandbox
 
-To run this extension in a sandboxed Solidus application you can run `bin/sandbox`
-The path for the sandbox app is `./sandbox` and `bin/rails` will forward any Rails command
-to `sandbox/bin/rails`.
+To run this extension in a sandboxed Solidus application, you can run `bin/sandbox`. The path for
+the sandbox app is `./sandbox` and `bin/rails` will forward any Rails commands to
+`sandbox/bin/rails`.
 
-Example:
+Here's an example:
 
-```shell
+```
 $ bin/rails server
 => Booting Puma
 => Rails 6.0.2.1 application starting in development
@@ -178,13 +175,31 @@ $ bin/rails server
 Use Ctrl-C to stop
 ```
 
-Releasing
----------
+### Updating the changelog
+
+Before and after releases the changelog should be updated to reflect the up-to-date status of
+the project:
+
+```shell
+bin/rake changelog
+git add CHANGELOG.md
+git commit -m "Update the changelog"
+```
+
+### Releasing new versions
 
 Your new extension version can be released using `gem-release` like this:
 
 ```shell
-bundle exec gem bump -v VERSION --tag --push --remote upstream && gem release
+bundle exec gem bump -v 1.6.0
+bin/rake changelog
+git add CHANGELOG.md
+git commit --amend --no-edit
+gem tag
+git push --tags
+bundle exec gem release
 ```
 
-Copyright (c) 2020 Nebulab srls, released under the New BSD License
+## License
+
+Copyright (c) 2020 Nebulab srls, released under the New BSD License.

data/Rakefile

@@ -1,6 +1,22 @@
 # frozen_string_literal: true
 
 require 'solidus_dev_support/rake_tasks'
+
+SolidusDevSupport::RakeTasks.class_eval do
+  def install_changelog_task
+    require 'github_changelog_generator/task'
+
+    source_code_uri = URI.parse(gemspec.metadata['source_code_uri'])
+    user, project = source_code_uri.path.split("/", 3)[1..2]
+
+    GitHubChangelogGenerator::RakeTask.new(:changelog) do |config|
+      config.user = user || 'solidus-contrib'
+      config.project = project || gemspec.name
+      config.future_release = "v#{gemspec.version}"
+    end
+  end
+end
+
 SolidusDevSupport::RakeTasks.install
 
 task default: 'extension:specs'

data/app/controllers/spree/webhooks_controller.rb

@@ -1,5 +1,5 @@
 class Spree::WebhooksController < Spree::Api::BaseController
-  rescue_from(Spree::Webhook::WebhookNotFound) { head :not_found }
+  rescue_from(SolidusWebhooks::WebhookNotFound) { head :not_found }
 
   def receive
     webhook = Spree::Webhook.find(params[:id])

data/app/models/spree/webhook.rb

@@ -1,9 +1,9 @@
+require 'solidus_webhooks/errors'
+
 class Spree::Webhook
   include ActiveModel::Model
   attr_accessor :handler, :id
 
-  WebhookNotFound = Class.new(StandardError)
-
   def receive(payload, user)
     if handler_arity == 1
       handler.call(payload)
@@ -16,7 +16,7 @@ class Spree::Webhook
     id = id.to_sym # normalize incoming ids
 
     handler = SolidusWebhooks.config.find_webhook_handler(id) or
-      raise WebhookNotFound, "Cannot find a webhook handler for #{id.inspect}"
+      raise SolidusWebhooks::WebhookNotFound, "Cannot find a webhook handler for #{id.inspect}"
 
     new(id: id, handler: handler)
   end

data/bin/rails

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby
+
+if %w[g generate].include? ARGV.first
+  exec "#{__dir__}/rails-engine", *ARGV
+else
+  exec "#{__dir__}/rails-sandbox", *ARGV
+end

data/bin/rails-sandbox

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+
+app_root = 'sandbox'
+
+unless File.exist? "#{app_root}/bin/rails"
+  warn 'Creating the sandbox app...'
+  Dir.chdir "#{__dir__}/.." do
+    system "#{__dir__}/sandbox" or begin
+      warn 'Automatic creation of the sandbox app failed'
+      exit 1
+    end
+  end
+end
+
+Dir.chdir app_root
+exec 'bin/rails', *ARGV

data/bin/sandbox

@@ -72,9 +72,11 @@ unbundled bundle exec rails generate spree:install \
   --user_class=Spree::User \
   --enforce_available_locales=true \
   --with-authentication=false \
+  --payment-method=none \
   $@
 
 unbundled bundle exec rails generate solidus:auth:install
+unbundled bundle exec rails generate ${extension_name}:install
 
 echo
 echo "🚀 Sandbox app successfully created for $extension_name!"

data/lib/generators/solidus_webhooks/install/install_generator.rb

@@ -4,15 +4,20 @@ module SolidusWebhooks
   module Generators
     class InstallGenerator < Rails::Generators::Base
       class_option :auto_run_migrations, type: :boolean, default: false
+      source_root File.expand_path('templates', __dir__)
+
+      def copy_initializer
+        template 'initializer.rb', 'config/initializers/solidus_webhooks.rb'
+      end
 
       def add_javascripts
-        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/solidus_webhooks\n" # rubocop:disable Metrics/LineLength
-        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/solidus_webhooks\n" # rubocop:disable Metrics/LineLength
+        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/solidus_webhooks\n"
+        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/solidus_webhooks\n"
       end
 
       def add_stylesheets
-        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/solidus_webhooks\n", before: %r{\*/}, verbose: true # rubocop:disable Metrics/LineLength
-        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/solidus_webhooks\n", before: %r{\*/}, verbose: true # rubocop:disable Metrics/LineLength
+        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/solidus_webhooks\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
+        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/solidus_webhooks\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
       end
 
       def add_migrations
@@ -20,7 +25,7 @@ module SolidusWebhooks
       end
 
       def run_migrations
-        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Metrics/LineLength
+        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Layout/LineLength
         if run_migrations
           run 'bin/rails db:migrate'
         else

data/lib/generators/solidus_webhooks/install/templates/initializer.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+SolidusWebhooks.configure do |config|
+  # TODO: Remember to change this with the actual preferences you have implemented!
+  # config.sample_preference = 'sample_value'
+end

data/lib/solidus_webhooks.rb

@@ -3,6 +3,24 @@
 require 'solidus_core'
 require 'solidus_support'
 
-require 'solidus_webhooks/version'
 require 'solidus_webhooks/configuration'
+require 'solidus_webhooks/version'
 require 'solidus_webhooks/engine'
+
+module SolidusWebhooks
+  class << self
+    def configuration
+      @configuration ||= Configuration.new
+    end
+
+    alias config configuration
+
+    def reset_config!
+      @configuration = nil
+    end
+
+    def configure
+      yield configuration
+    end
+  end
+end

data/lib/solidus_webhooks/configuration.rb

@@ -1,3 +1,5 @@
+require 'solidus_webhooks/errors'
+
 module SolidusWebhooks
   class Configuration
     def initialize
@@ -6,7 +8,7 @@ module SolidusWebhooks
 
     def register_webhook_handler(id, handler)
       unless handler.respond_to? :call
-        raise Spree::Webhook::InvalidHandler,
+        raise SolidusWebhooks::InvalidHandler,
           "Please provide a handler that responds to #call, got: #{handler.inspect}"
       end
 
@@ -17,14 +19,4 @@ module SolidusWebhooks
       @handlers[id.to_sym]
     end
   end
-
-  def self.config
-    @config
-  end
-
-  def self.reset_config!
-    @config = Configuration.new
-  end
-
-  reset_config! # initialize the extension
 end

data/lib/solidus_webhooks/errors.rb

@@ -0,0 +1,4 @@
+module SolidusWebhooks
+  WebhookNotFound = Class.new(StandardError)
+  InvalidHandler = Class.new(StandardError)
+end

data/lib/solidus_webhooks/testing_support/factories.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+end

data/lib/solidus_webhooks/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusWebhooks
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/solidus_webhooks.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri'] = 'https://github.com/solidusio-contrib/solidus_webhooks'
   spec.metadata['changelog_uri'] = 'https://github.com/solidusio-contrib/solidus_webhooks/releases'
 
-  spec.required_ruby_version = Gem::Requirement.new('~> 2.4')
+  spec.required_ruby_version = Gem::Requirement.new('~> 2.5')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 3']
-  spec.add_dependency 'solidus_support', '~> 0.5.0'
+  spec.add_dependency 'solidus_support', '~> 0.5'
 
-  spec.add_development_dependency 'solidus_dev_support'
+  spec.add_development_dependency 'solidus_dev_support', '~> 2.1'
 end

data/spec/features/can_register_a_handler_and_receive_webhooks_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 
 RSpec.feature "Can register a handler and receive Webhooks", type: :request do
   background do
-    SolidusWebhooks.reset_config!
     SolidusWebhooks.config.register_webhook_handler :proc, proc_handler
     SolidusWebhooks.config.register_webhook_handler :method, method_handler
     SolidusWebhooks.config.register_webhook_handler :user, user_handler
@@ -33,43 +32,43 @@ RSpec.feature "Can register a handler and receive Webhooks", type: :request do
   let(:unauthorized_token) { unauthorized_user.spree_api_key }
 
   scenario "calls the handler passing the payload" do
-    post "/webhooks/proc?token=#{authorized_token}", as: :json, params: {a: 123}
+    post "/webhooks/proc?token=#{authorized_token}", as: :json, params: { a: 123 }
     expect(response).to have_http_status(:ok)
 
-    post "/webhooks/proc?token=#{authorized_token}", as: :json, params: {b: 456}
+    post "/webhooks/proc?token=#{authorized_token}", as: :json, params: { b: 456 }
     expect(response).to have_http_status(:ok)
 
-    post "/webhooks/method?token=#{authorized_token}", as: :json, params: {c: 789}
+    post "/webhooks/method?token=#{authorized_token}", as: :json, params: { c: 789 }
     expect(response).to have_http_status(:ok)
 
-    post "/webhooks/user?token=#{authorized_token}", as: :json, params: {d: 012}
+    post "/webhooks/user?token=#{authorized_token}", as: :json, params: { d: 012 }
     expect(response).to have_http_status(:ok)
 
-    post "/webhooks/splat?token=#{authorized_token}", as: :json, params: {e: 345}
+    post "/webhooks/splat?token=#{authorized_token}", as: :json, params: { e: 345 }
     expect(response).to have_http_status(:ok)
 
-    post "/webhooks/method_and_user?token=#{authorized_token}", as: :json, params: {f: 678}
+    post "/webhooks/method_and_user?token=#{authorized_token}", as: :json, params: { f: 678 }
     expect(response).to have_http_status(:ok)
 
-    expect(proc_payloads).to eq([{'a' => 123}, {'b' => 456}])
-    expect(method_payloads).to eq([{'c' => 789}])
-    expect(user_payloads).to eq([[{'d' => 012}, authorized_user]])
-    expect(splat_payloads).to eq([[{'e' => 345}, authorized_user]])
-    expect(method_and_user_payloads).to eq([{'f' => 678}])
+    expect(proc_payloads).to eq([{ 'a' => 123 }, { 'b' => 456 }])
+    expect(method_payloads).to eq([{ 'c' => 789 }])
+    expect(user_payloads).to eq([[{ 'd' => 012 }, authorized_user]])
+    expect(splat_payloads).to eq([[{ 'e' => 345 }, authorized_user]])
+    expect(method_and_user_payloads).to eq([{ 'f' => 678 }])
   end
 
   scenario "receives a bad handler id" do
-    post "/webhooks/abc?token=#{authorized_token}", as: :json, params: {a: 123}
+    post "/webhooks/abc?token=#{authorized_token}", as: :json, params: { a: 123 }
     expect(response).to have_http_status(:not_found)
   end
 
   scenario "refuses a bad token" do
-    post "/webhooks/user?token=b4d-t0k3n", as: :json, params: {a: 123}
+    post "/webhooks/user?token=b4d-t0k3n", as: :json, params: { a: 123 }
     expect(response).to have_http_status(:unauthorized)
   end
 
   scenario "refuses a token without permissions" do
-    post "/webhooks/proc?token=#{unauthorized_token}", as: :json, params: {a: 123}
+    post "/webhooks/proc?token=#{unauthorized_token}", as: :json, params: { a: 123 }
     expect(response).to have_http_status(:unauthorized)
   end
 end

data/spec/models/spree/webhook_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+RSpec.describe Spree::Webhook do
+  describe '.find' do
+    before { SolidusWebhooks.config.register_webhook_handler :foo, ->(payload) {} }
+
+    it 'can find a registered handler' do
+      expect(described_class.find(:foo)).to be_a(described_class)
+      expect{ described_class.find(:bar) }.to raise_error(SolidusWebhooks::WebhookNotFound)
+    end
+  end
+end

data/spec/solidus_webhooks/configuration_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+RSpec.describe SolidusWebhooks::Configuration do
+  describe '#register_webhook_handler' do
+    it 'only accepts callable' do
+      expect{ subject.register_webhook_handler(:foo, Object.new) }.to raise_error(SolidusWebhooks::InvalidHandler)
+      expect{ subject.register_webhook_handler(:bar, Proc.new {}) }.not_to raise_error
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -6,19 +6,26 @@ ENV['RAILS_ENV'] = 'test'
 # Run Coverage report
 require 'solidus_dev_support/rspec/coverage'
 
-require File.expand_path('dummy/config/environment.rb', __dir__)
+# Create the dummy app if it's still missing.
+dummy_env = "#{__dir__}/dummy/config/environment.rb"
+system 'bin/rake extension:test_app' unless File.exist? dummy_env
+require dummy_env
 
 # Requires factories and other useful helpers defined in spree_core.
 require 'solidus_dev_support/rspec/feature_helper'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }
 
-# Requires factories defined in lib/solidus_webhooks/factories.rb
-require 'solidus_webhooks/factories'
+# Requires factories defined in lib/solidus_webhooks/testing_support/factories.rb
+require 'solidus_webhooks/testing_support/factories'
 
 RSpec.configure do |config|
   config.infer_spec_type_from_file_location!
   config.use_transactional_fixtures = false
+
+  if Spree.solidus_gem_version < Gem::Version.new('2.11')
+    config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :system
+  end
 end

data/spec/support/reset_config.rb

@@ -0,0 +1,3 @@
+RSpec.configure do |config|
+  config.before { SolidusWebhooks.reset_config! }
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_webhooks
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Elia Schito
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-06-10 00:00:00.000000000 Z
+date: 2020-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -36,29 +36,29 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: solidus_dev_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: 
+        version: '2.1'
+description:
 email: contact@solidus.io
 executables: []
 extensions: []
@@ -67,9 +67,12 @@ files:
 - ".circleci/config.yml"
 - ".gem_release.yml"
 - ".github/stale.yml"
+- ".github_changelog_generator"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -81,7 +84,9 @@ files:
 - app/controllers/spree/webhooks_controller.rb
 - app/models/spree/webhook.rb
 - bin/console
-- bin/r
+- bin/rails
+- bin/rails-engine
+- bin/rails-sandbox
 - bin/rake
 - bin/sandbox
 - bin/sandbox_rails
@@ -89,14 +94,20 @@ files:
 - config/locales/en.yml
 - config/routes.rb
 - lib/generators/solidus_webhooks/install/install_generator.rb
+- lib/generators/solidus_webhooks/install/templates/initializer.rb
 - lib/solidus_webhooks.rb
 - lib/solidus_webhooks/configuration.rb
 - lib/solidus_webhooks/engine.rb
+- lib/solidus_webhooks/errors.rb
 - lib/solidus_webhooks/factories.rb
+- lib/solidus_webhooks/testing_support/factories.rb
 - lib/solidus_webhooks/version.rb
 - solidus_webhooks.gemspec
 - spec/features/can_register_a_handler_and_receive_webhooks_spec.rb
+- spec/models/spree/webhook_spec.rb
+- spec/solidus_webhooks/configuration_spec.rb
 - spec/spec_helper.rb
+- spec/support/reset_config.rb
 homepage: https://github.com/solidusio-contrib/solidus_webhooks#readme
 licenses:
 - BSD-3-Clause
@@ -104,7 +115,7 @@ metadata:
   homepage_uri: https://github.com/solidusio-contrib/solidus_webhooks#readme
   source_code_uri: https://github.com/solidusio-contrib/solidus_webhooks
   changelog_uri: https://github.com/solidusio-contrib/solidus_webhooks/releases
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -112,17 +123,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Webhooks support for Solidus
 test_files:
 - spec/features/can_register_a_handler_and_receive_webhooks_spec.rb
+- spec/models/spree/webhook_spec.rb
+- spec/solidus_webhooks/configuration_spec.rb
 - spec/spec_helper.rb
+- spec/support/reset_config.rb