solidus_six_saferpay 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62b084c8228f6b7536f8a6344b228449d76139957232c22ed9a113228d0a4a82
-  data.tar.gz: b7840dadd009148e4ac91cebedd8f6b37cd2420a4b5a946cf235a6388bd1dca3
+  metadata.gz: ccb5b89d37a205f093576ec9a755e3fbc54d362fc45010fc5c7164b699810583
+  data.tar.gz: b115f124017c811c3fd2964dbd26d86a74c4cc74e9a934014d81a1a96ce6561e
 SHA512:
-  metadata.gz: 7b98d5ab6de7bfc969dacb92a286cb91119145151f3941e22351b5ae348e09c9f5e7dc94002de8103d45457a88443ac626aa893e523d3c7762e932adc7976b1e
-  data.tar.gz: 9565a255da9145c861eefa07ea8066a83e081e26e169d27808d6dc6ce9d11b765009d11378823dff942bb8e4c244381c6a02f52d4b9dac2b4996a198c16297f8
+  metadata.gz: 17b439ff9f469106de99a5f8dd4060fecd786525580b9f04f5d5f5ce9b26c32fc92138725457c836297f579d3208daa30f6768b5fe3acfb35fc7c5a1fdc860fc
+  data.tar.gz: 69d2115b15b049ab4d27e680c8d2169fcb2db70ebde4c0402424ff47924fcbb7adc97a941e82d9494c0981b550f446476133895f43102c8033fadc630be04aa3

data/app/assets/javascripts/solidus_six_saferpay/saferpay_payment.js

@@ -18,9 +18,7 @@ let SaferpayPayment = {
       },
 
       error: function(xhr) {
-        // debugger;
-        alert(xhr.responseText);
-        console.info(xhr.responseText);
+        console.error(xhr.responseText);
         return false;
       },
     })

data/app/assets/stylesheets/solidus_six_saferpay/loading_animation.scss

@@ -19,7 +19,7 @@
 }
 
 @keyframes sk-scaleout {
-  0% { 
+  0% {
     -webkit-transform: scale(0);
     transform: scale(0);
   } 100% {

data/app/assets/stylesheets/solidus_six_saferpay/payments.scss

@@ -1,10 +1,8 @@
 .saferpay-payment {
   &.void {
-
     .amount {
       text-decoration: line-through;
     }
   }
 }
 
-

data/app/models/spree/six_saferpay_payment.rb

@@ -30,40 +30,53 @@ module Spree
       @address ||= order.bill_address
     end
 
+    # This memoization only works if response_payment_means is not nil.
     def payment_means
-      @payment_means ||= ::SixSaferpay::ResponsePaymentMeans.new(response_hash[:payment_means])
+      @payment_means ||= begin
+         if payment_means_response = response_hash[:payment_means]
+           ::SixSaferpay::ResponsePaymentMeans.new(payment_means_response)
+         end
+       end
     end
 
     def transaction
-      @transaction ||= ::SixSaferpay::Transaction.new(response_hash[:transaction])
+      @transaction ||= begin
+         if transaction_response = response_hash[:transaction]
+           ::SixSaferpay::Transaction.new(transaction_response)
+         end
+       end
     end
 
     def liability
-      @liability ||= ::SixSaferpay::Liability.new(response_hash[:liability])
+      @liability ||= begin
+         if liability_response = response_hash[:liability]
+           ::SixSaferpay::Liability.new(liability_response)
+         end
+       end
     end
 
     def card
-      payment_means.card
+      payment_means&.card
     end
 
     def name
-      card.holder_name
+      card&.holder_name
     end
 
     def brand_name
-      payment_means.brand.name
+      payment_means&.brand&.name
     end
 
     def month
-      card.exp_month
+      card&.exp_month
     end
 
     def year
-      card.exp_year
+      card&.exp_year
     end
 
     def icon_name
-      payment_means.brand.payment_method.downcase
+      payment_means&.brand&.payment_method&.downcase
     end
   end
 end

data/app/services/spree/solidus_six_saferpay/inquire_payment.rb

@@ -25,7 +25,7 @@ module Spree
           specific_error = I18n.t(inquiry.error_name, scope: [:six_saferpay, :error_names])
           @user_message = "#{general_error}: #{specific_error}"
         end
-        
+
         @success = true
 
         self

data/app/services/spree/solidus_six_saferpay/process_authorized_payment.rb

@@ -28,7 +28,6 @@ module Spree
 
       rescue ::SolidusSixSaferpay::InvalidSaferpayPayment => e
         cancel_saferpay_payment
-        # TODO: Check if messages from liability shift check and PaymentValidator are appropriate for user!
         @user_message = e.full_message
         @success = false
 

data/lib/solidus_six_saferpay/gateway_response.rb

@@ -20,7 +20,7 @@ module SolidusSixSaferpay
     # To ensure that solidus sets the response_code after successful capture,
     # we need to pass it as an "authorization", however if we do this then
     # solidus also expects there to be an "avs_result"
-    # 
+    #
     # see https://github.com/solidusio/solidus/blob/master/core/app/models/spree/payment/processing.rb#L171
     def avs_result
       {}
@@ -29,7 +29,7 @@ module SolidusSixSaferpay
     # To ensure that solidus sets the response_code after successful capture,
     # we need to pass it as an "authorization", however if we do this then
     # solidus also expects this response to respond to :cvv_result
-    # 
+    #
     # see https://github.com/solidusio/solidus/blob/master/core/app/models/spree/payment/processing.rb#L171
     def cvv_result
       nil

data/lib/solidus_six_saferpay/version.rb

@@ -1,3 +1,3 @@
 module SolidusSixSaferpay
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_six_saferpay
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Simon Kiener
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-19 00:00:00.000000000 Z
+date: 2019-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -245,9 +245,6 @@ files:
 - app/controllers/spree/solidus_six_saferpay/checkout_controller.rb
 - app/controllers/spree/solidus_six_saferpay/payment_page/checkout_controller.rb
 - app/controllers/spree/solidus_six_saferpay/transaction/checkout_controller.rb
-- app/helpers/solidus_six_saferpay/application_helper.rb
-- app/jobs/solidus_six_saferpay/application_job.rb
-- app/mailers/solidus_six_saferpay/application_mailer.rb
 - app/models/solidus_six_saferpay/application_record.rb
 - app/models/spree/payment_method/saferpay_payment_method.rb
 - app/models/spree/payment_method/saferpay_payment_page.rb
@@ -291,7 +288,6 @@ files:
 - lib/solidus_six_saferpay/payment_page_gateway.rb
 - lib/solidus_six_saferpay/transaction_gateway.rb
 - lib/solidus_six_saferpay/version.rb
-- lib/tasks/solidus_six_saferpay_tasks.rake
 homepage: http://fadendaten.ch
 licenses:
 - MIT

data/app/helpers/solidus_six_saferpay/application_helper.rb

@@ -1,4 +0,0 @@
-module SolidusSixSaferpay
-  module ApplicationHelper
-  end
-end

data/app/jobs/solidus_six_saferpay/application_job.rb

@@ -1,4 +0,0 @@
-module SolidusSixSaferpay
-  class ApplicationJob < ActiveJob::Base
-  end
-end

data/app/mailers/solidus_six_saferpay/application_mailer.rb

@@ -1,6 +0,0 @@
-module SolidusSixSaferpay
-  class ApplicationMailer < ActionMailer::Base
-    default from: 'from@example.com'
-    layout 'mailer'
-  end
-end

data/lib/tasks/solidus_six_saferpay_tasks.rake

@@ -1,4 +0,0 @@
-# desc "Explaining what the task does"
-# task :solidus_six_saferpay do
-#   # Task goes here
-# end