solidus_signifyd 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0ac6c8ae9eeaf50a2004ed2b33b437b173414100
-  data.tar.gz: 5ee23ef2fd936d75e28bdfc367b224e759e177d5
+  metadata.gz: d4a72f66712b1ec31d58c43b6376ec26d73fa0b3
+  data.tar.gz: 82f7c527003108aa93f77df909191963ab0643b8
 SHA512:
-  metadata.gz: f7489fdd5ce725d20de28724270dae453b17ee2e9cfb60f23c77b98195a827fdc039ee68f05106597b969d15223539157654c1bdca1206f2c219a442611fe72b
-  data.tar.gz: 843dbdbd9c9a668599476db4c2b763805a0770c95b0a7c8655162ad680404ce0554c60010352ac50b3340cd56bfa606ea572b3c79da182720d3ce8f4c063f8b0
+  metadata.gz: f4ac359792627cf09505a0b68aa7ec26c7b627ef4d3de66c2d009882aac691e99a3aed2703d2828c23d8e35f436c2118997b211d615dfacf6f72d6e60c7f8b15
+  data.tar.gz: 6c96d211b2d6f697cbdd100d635eaa8b98845c5dd8116f71e43eb0125a2089dd0d3c57583be3237e7a247187ba2d4feb30dc8f419ecce50792b963a2640417f4

data/app/controllers/spree/api/spree_signifyd/orders_controller.rb

@@ -22,9 +22,14 @@ module Spree::Api::SpreeSignifyd
 
     def authorize
       request_sha = request.headers['HTTP_HTTP_X_SIGNIFYD_HMAC_SHA256']
-      computed_sha = build_sha(SpreeSignifyd::Config[:api_key], encode_request(request.raw_post))
+      computed_sha = build_sha(SpreeSignifyd::Config[:api_key], request.raw_post)
 
-      head 401 unless Devise.secure_compare(request_sha, computed_sha)
+      if !Devise.secure_compare(request_sha, computed_sha)
+        logger.error("computed digest does not match provided digest. computed=#{computed_sha.inspect} provided=#{request_sha.inspect}")
+        logger.info("content-type header: #{request.headers["Content-Type"].inspect}")
+        logger.info("raw_post bytes: #{request.raw_post.bytes}")
+        head 401
+      end
     end
 
     def load_order

data/lib/spree_signifyd.rb

@@ -20,7 +20,7 @@ module SpreeSignifyd
 
   def approve(order:)
     order.contents.approve(name: self.name)
-    order.shipments.each { |shipment| shipment.ready! unless shipment.ready? }
+    order.shipments.each { |shipment| shipment.ready! if shipment.pending? }
     order.updater.update_shipment_state
     order.save!
   end

data/lib/spree_signifyd/request_verifier.rb

@@ -1,10 +1,6 @@
 module SpreeSignifyd
   module RequestVerifier
 
-    def encode_request(request_body)
-      request_body.force_encoding('ISO-8859-1').encode('UTF-8')
-    end
-
     def build_sha(key, message)
       sha256 = OpenSSL::Digest::SHA256.new
       digest = OpenSSL::HMAC.digest(sha256, key, message)

data/solidus_signifyd.gemspec

@@ -3,7 +3,7 @@
 Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.name        = "solidus_signifyd"
-  s.version     = "1.0.0"
+  s.version     = "1.0.1"
   s.summary     = "Solidus extension for communicating with Signifyd to check orders for fraud."
   s.description = s.summary
 
@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
   s.add_dependency "active_model_serializers", "0.9.3"
   s.add_dependency "resque", "~> 1.25.1"
   s.add_dependency "signifyd", "~> 0.1.5"
-  s.add_dependency "solidus", [">= 1.0.0", "< 1.2.0"]
+  s.add_dependency "solidus", "~> 1.0"
   s.add_dependency "devise"
 
   s.add_development_dependency "rspec-rails",  "~> 2.13"

data/spec/lib/spree_signifyd/request_verifier_spec.rb

@@ -4,20 +4,6 @@ module SpreeSignifyd
   describe RequestVerifier do
     include RequestVerifier
 
-    describe "#encode_request" do
-      context "request has special characters" do
-        it "returns an unescaped UTF-8 string" do
-          expect(encode_request("R\xE9n\xE9 Pe\xF1a")).to eq "Réné Peña"
-        end
-      end
-
-      context "request doesn't contain special characters" do
-        it "returns the original string" do
-          expect(encode_request("John Doe")).to eq "John Doe"
-        end
-      end
-    end
-
     describe "#build_sha" do
       it "returns an HMAC SHA256 encoded message" do
         expect(build_sha('ABCDE', 'test')).to eq "K0y2rIeTA77lBEHP8cRPk64fVRbhMrZqEk7la39EjEM="

data/spec/lib/spree_signifyd_spec.rb

@@ -53,6 +53,14 @@ module SpreeSignifyd
         order.shipments.each { |shipment| shipment.should_receive(:ready!) }
         approve
       end
+
+      describe "when order has shipments that are not pending" do
+        it "progresses the pending one(s) and ignores the rest" do
+          shipped_shipment = order.shipments.create(state: :shipped)
+          expect(shipped_shipment).to receive(:ready).never
+          expect { approve }.to change { order.approved_at }
+        end
+      end
     end
 
     describe ".create_case" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_signifyd
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Bonobos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-26 00:00:00.000000000 Z
+date: 2016-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
@@ -56,22 +56,16 @@ dependencies:
   name: solidus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.0.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.0.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: devise
   requirement: !ruby/object:Gem::Requirement
@@ -278,22 +272,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - none
 rubyforge_project: 
-rubygems_version: 2.2.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Solidus extension for communicating with Signifyd to check orders for fraud.
-test_files:
-- spec/controllers/spree/api/spree_signifyd/orders_controller_spec.rb
-- spec/lib/spree_signifyd/create_signifyd_case_spec.rb
-- spec/lib/spree_signifyd/request_verifier_spec.rb
-- spec/lib/spree_signifyd_spec.rb
-- spec/models/spree/order_spec.rb
-- spec/models/spree/shipment_spec.rb
-- spec/serializers/spree_signifyd/address_serializer_spec.rb
-- spec/serializers/spree_signifyd/billing_address_serializer.rb
-- spec/serializers/spree_signifyd/credit_card_serializer_spec.rb
-- spec/serializers/spree_signifyd/delivery_address_serializer_spec.rb
-- spec/serializers/spree_signifyd/line_item_serializer_spec.rb
-- spec/serializers/spree_signifyd/order_serializer_spec.rb
-- spec/serializers/spree_signifyd/user_serializer_spec.rb
-- spec/spec_helper.rb
+test_files: []