solidus_related_products 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 796ec99b0714a1e62195cac718d7ee685e444885
-  data.tar.gz: 383f4d8974811a381e1ab46ca51078bdd4bb00d2
+  metadata.gz: 752931ed32a44beaa71d0065db52b172dca391c0
+  data.tar.gz: fb64275f2eca94076f2abb24c24e33a69204ff3d
 SHA512:
-  metadata.gz: df78c358ae876c2d31319614c7122020379ccdd6b7c1720646874b69b15c2164afe2fd03c22671093f6af4d236e0725b98cb0bbbfcf9932c71749741d2e0df75
-  data.tar.gz: 335f7498dbe1557d39fed0f93dadb058fbfce3bec0e66ef213b8d2953b479e3bf28d7d28c90a769bc66a60bd8111f317bffd58301a96951948b4b3cb8e77866c
+  metadata.gz: dbb92a4271f86e0d5202375a244510f177bb9d478b566449856da8d50166282abe28a3edc2e28d9dcfb1c67336c7e75aa14c203a6071a57b4d65e6c3aae59d92
+  data.tar.gz: cf0926217e19ebbf9469b772afdf0cbb71a096c02b3882d9bd83dfb009ac972eee710a8a91af93a94a4aa29f7e86e601be68ec0aa852eedacf0c3130e5ba4864

data/.hound.yml

@@ -1,25 +1,8 @@
----
-# Too picky.
-LineLength:
-  Enabled: false
-
-# This should truly be on for well documented gems.
-Documentation:
-  Enabled: false
-
-# Neatly aligned code is too swell.
-SpaceBeforeFirstArg:
-  Enabled: false
-
-# Don't mess with RSpec DSL.
-Blocks:
-  Exclude:
-    - 'spec/**/*'
-
-# It say we should use fail over raise.
-SignalException:
-  Enabled: false
-
-# Avoid contradictory style rules by enforce single quotes.
-StringLiterals:
-  EnforcedStyle: single_quotes
+ruby:
+  config_file: .rubocop.yml
+scss:
+  enabled: false
+coffeescript:
+  enabled: false
+javascript:
+  enabled: false

data/.rubocop.yml

@@ -1,8 +1,227 @@
----
-inherit_from: .hound.yml
+# Relaxed.Ruby.Style
 
 AllCops:
   Exclude:
     - spec/dummy/**/*
-    - bin/*
-    - Guardfile
+    - vendor/bundle/*
+  TargetRubyVersion: 2.1
+
+# Sometimes I believe this reads better
+# This also causes spacing issues on multi-line fixes
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+# We use class vars and will have to continue doing so for compatability
+Style/ClassVars:
+  Enabled: false
+
+# We need these names for backwards compatability
+Style/PredicateName:
+  Enabled: false
+
+Style/AccessorMethodName:
+  Enabled: false
+
+# This has been used for customization
+Style/MutableConstant:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/WordArray:
+  Enabled: false
+
+Style/ConditionalAssignment:
+  Enabled: false
+
+Performance/Count:
+  Enabled: false
+
+Style/RaiseArgs:
+  Enabled: false
+
+Style/OpMethod:
+  Enabled: false
+
+# We can use good judgement here
+Style/RegexpLiteral:
+  Enabled: false
+
+# Unicode comments are useful
+Style/AsciiComments:
+  Enabled: false
+
+Lint/EndAlignment:
+  Enabled: false
+
+Style/ElseAlignment:
+  Enabled: false
+
+Style/IndentationWidth:
+  Enabled: false
+
+Style/AlignParameters:
+  Enabled: false
+
+Style/ClosingParenthesisIndentation:
+  Enabled: false
+
+Style/MultilineMethodCallIndentation:
+  Enabled: false
+
+Style/IndentArray:
+  Enabled: false
+
+Style/IndentHash:
+  Enabled: false
+
+Style/AlignHash:
+  Enabled: false
+
+# From http://relaxed.ruby.style/
+
+Style/Alias:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylealias
+
+Style/BeginBlock:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylebeginblock
+
+Style/BlockDelimiters:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styleblockdelimiters
+
+Style/Documentation:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styledocumentation
+
+Style/DotPosition:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styledotposition
+
+Style/DoubleNegation:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styledoublenegation
+
+Style/EndBlock:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styleendblock
+
+Style/FormatString:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styleformatstring
+
+Style/IfUnlessModifier:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styleifunlessmodifier
+
+Style/Lambda:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylelambda
+
+Style/ModuleFunction:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylemodulefunction
+
+Style/MultilineBlockChain:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylemultilineblockchain
+
+Style/NegatedIf:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylenegatedif
+
+Style/NegatedWhile:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylenegatedwhile
+
+Style/ParallelAssignment:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styleparallelassignment
+
+Style/PercentLiteralDelimiters:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylepercentliteraldelimiters
+
+Style/PerlBackrefs:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#styleperlbackrefs
+
+Style/Semicolon:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylesemicolon
+
+Style/SignalException:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylesignalexception
+
+Style/SingleLineBlockParams:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylesinglelineblockparams
+
+Style/SingleLineMethods:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylesinglelinemethods
+
+Style/SpaceBeforeBlockBraces:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylespacebeforeblockbraces
+
+Style/SpaceInsideParens:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylespaceinsideparens
+
+Style/SpecialGlobalVars:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylespecialglobalvars
+
+Style/StringLiterals:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylestringliterals
+
+Style/SymbolProc:
+  Enabled: false
+
+Style/WhileUntilModifier:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylewhileuntilmodifier
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#lintambiguousregexpliteral
+
+Lint/AssignmentInCondition:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#lintassignmentincondition
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false

data/.travis.yml

@@ -1,15 +1,19 @@
-language: ruby
-rvm:
-  - 2.1
-  - 2.2
 sudo: false
 cache: bundler
+language: ruby
+rvm:
+  - 2.3.1
 env:
   matrix:
-    - SOLIDUS_BRANCH=master
-    - SOLIDUS_BRANCH=v1.2
-    - SOLIDUS_BRANCH=v1.1
-before_script:
-  - bundle exec rake test_app
-script:
-  - bundle exec rspec spec
+    - SOLIDUS_BRANCH=v1.1 DB=postgres
+    - SOLIDUS_BRANCH=v1.2 DB=postgres
+    - SOLIDUS_BRANCH=v1.3 DB=postgres
+    - SOLIDUS_BRANCH=v1.4 DB=postgres
+    - SOLIDUS_BRANCH=v2.0 DB=postgres
+    - SOLIDUS_BRANCH=master DB=postgres
+    - SOLIDUS_BRANCH=v1.1 DB=mysql
+    - SOLIDUS_BRANCH=v1.2 DB=mysql
+    - SOLIDUS_BRANCH=v1.3 DB=mysql
+    - SOLIDUS_BRANCH=v1.4 DB=mysql
+    - SOLIDUS_BRANCH=v2.0 DB=mysql
+    - SOLIDUS_BRANCH=master DB=mysql

data/CONTRIBUTING.md

@@ -1,6 +1,6 @@
 # Contributing
 
-Spree Related Products is an open source project and we encourage contributions. Please see the [contributors guidelines](http://spreecommerce.com/documentation/contributing_to_spree.html) for more information before contributing.
+Solidus Related Products is an open source project and we encourage contributions.
 
 In the spirit of [free software][1], **everyone** is encouraged to help improve this project.
 
@@ -30,7 +30,7 @@ In the issue itself please provide:
 
 * A comprehensive list of steps to reproduce the issue.
 * What you're *expecting* to happen compared with what's *actually* happening.
-* The version of Spree *and* the version of Rails.
+* The version of Solidus *and* the version of Rails.
 * A list of all extensions.
 * Any relevant stack traces ("Full trace" preferred)
 * Your `Gemfile`
@@ -77,5 +77,5 @@ Some things that will increase the chance that your pull request is accepted, ta
 And in case we didn't emphasize it enough: **we love tests!**
 
 [1]: http://www.fsf.org/licensing/essays/free-sw.html
-[2]: https://github.com/spree-contrib/spree_related_products/issues
-[3]: https://github.com/spree-contrib/spree_related_products/tree/master/config/locales
+[2]: https://github.com/solidusio-contrib/solidus_related_products/issues
+[3]: https://github.com/solidusio-contrib/solidus_related_products/tree/master/config/locales

data/Gemfile

@@ -1,6 +1,17 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
-gem 'solidus', github: 'solidusio/solidus', branch: branch
+gem "solidus", github: "solidusio/solidus", branch: branch
+
+if branch == 'master' || branch >= "v2.0"
+  gem "rails-controller-testing", group: :test
+end
+
+gem 'pg'
+gem 'mysql2'
+
+group :development, :test do
+  gem "pry-rails"
+end
 
 gemspec

data/README.md

@@ -12,7 +12,7 @@ You can manage RelationTypes via the admin configuration menu, and you can maint
 
 Add to `Gemfile`:
 ```ruby
-gem 'spree_related_products'
+gem 'solidus_related_products'
 ```
 
 Run:
@@ -73,8 +73,8 @@ See corresponding [guidelines][4]
 Copyright (c) 2010-2015 [Brian Quinn][5] and [contributors][6], released under the [New BSD License][3]
 
 [1]: http://www.fsf.org/licensing/essays/free-sw.html
-[2]: https://github.com/spree-contrib/spree_related_products/issues
-[3]: https://github.com/spree-contrib/spree_related_products/blob/master/LICENSE.md
-[4]: https://github.com/spree-contrib/spree_related_products/blob/master/CONTRIBUTING.md
+[2]: https://github.com/solidusio-contrib/solidus_related_products/issues
+[3]: https://github.com/solidusio-contrib/solidus_related_products/blob/master/LICENSE.md
+[4]: https://github.com/solidusio-contrib/solidus_related_products/blob/master/CONTRIBUTING.md
 [5]: https://github.com/BDQ
-[6]: https://github.com/spree-contrib/spree_related_products/graphs/contributors
+[6]: https://github.com/solidusio-contrib/solidus_related_products/graphs/contributors

data/Rakefile

@@ -6,7 +6,13 @@ require 'spree/testing_support/common_rake'
 
 RSpec::Core::RakeTask.new
 
-task default: :spec
+task :default do
+  if Dir["spec/dummy"].empty?
+    Rake::Task[:test_app].invoke
+    Dir.chdir("../../")
+  end
+  Rake::Task[:spec].invoke
+end
 
 desc 'Generates a dummy app for testing'
 task :test_app do

data/app/controllers/spree/admin/relations_controller.rb

@@ -38,7 +38,7 @@ module Spree
 
           respond_with(@relation) do |format|
             format.html { redirect_to location_after_destroy }
-            format.js   { render :partial => "spree/admin/shared/destroy" }
+            format.js   { render partial: "spree/admin/shared/destroy" }
           end
 
         else

data/app/models/spree/calculator/related_product_discount.rb

@@ -14,17 +14,17 @@ module Spree
 
       return unless eligible?(order)
       total = order.line_items.inject(0) do |sum, line_item|
-        relations =  Spree::Relation.where(*discount_query(line_item))
-        discount_applies_to = relations.map {|rel| rel.related_to.master }
+        relations = Spree::Relation.where(*discount_query(line_item))
+        discount_applies_to = relations.map { |rel| rel.related_to.master }
 
         order.line_items.each do |li|
-          next unless discount_applies_to.include? li.variant
+          next li unless discount_applies_to.include? li.variant
           discount = relations.detect { |rel| rel.related_to.master == li.variant }.discount_amount
-          sum +=  if li.quantity < line_item.quantity
-                    (discount * li.quantity)
-                  else
-                    (discount * line_item.quantity)
-                  end
+          sum += if li.quantity < line_item.quantity
+                   (discount * li.quantity)
+                 else
+                   (discount * line_item.quantity)
+                 end
         end
 
         sum

data/app/models/spree/product_decorator.rb

@@ -101,6 +101,6 @@ Spree::Product.class_eval do
   end
 
   def format_name(name)
-    name.to_s.downcase.gsub(' ', '_').pluralize
+    name.to_s.downcase.tr(' ', '_').pluralize
   end
 end

data/app/views/spree/admin/products/_related_products.html.erb

@@ -1,3 +1,3 @@
 <li<%== ' class="active"' if current == "Related Products" %>>
-  <%= link_to_with_icon 'resize-small', Spree.t(:related_products), related_admin_product_url(@product) %>
-</li>
+  <%= link_to_with_icon 'share-alt', Spree.t(:related_products), related_admin_product_url(@product) %>
+</li>

data/app/views/spree/admin/products/_related_products_table.html.erb

@@ -25,12 +25,9 @@
         <td><%= relation.relation_type.name %></td>
         <td>
           <%= form_for relation, url: admin_product_relation_path(relation.relatable, relation) do |f| %>
-            <div class="input-group">
-              <%= f.text_field :discount_amount, class: 'form-control text-center' %>
-              <span class="input-group-btn">
-                <%= f.button Spree.t(:update), type: 'submit', class: 'btn btn-primary' %>
-              </span>
-            </div>
+
+            <%= f.text_field :discount_amount, class: 'form-control text-center' %>
+            <%= f.button Spree.t(:update), type: 'submit', class: 'button btn-primary' %>
           <% end %>
         </td>
         <td class="actions">

data/app/views/spree/admin/products/related.html.erb

@@ -7,34 +7,38 @@
     <%= Spree.t(:no_relation_types) %>
   </div>
 <% else %>
+
   <div id="add-line-item">
     <fieldset>
       <legend><%= Spree.t(:add_related_product) %></legend>
       <div class="row">
-        <div id="related_product_name" class="col-md-5">
+        <div id="related_product_name" class="">
           <div class="form-group">
             <%= label_tag :add_variant_name, Spree.t(:name_or_sku_short) %>
             <%= hidden_field_tag :add_variant_name, '', class: 'variant_autocomplete', style: "display: block !important;" %>
           </div>
         </div>
-        <div id="related_product_type" class="col-md-4">
+
+        <div id="related_product_type" class="column">
           <div class="form-group">
             <%= label_tag :add_type, Spree.t(:type) %>
-            <%= select_tag :add_type, options_for_select(@relation_types.map { |rt| [rt.name, rt.id] }), class: 'select2' %>
+            <%= select_tag :add_type, options_for_select(@relation_types.map { |rt| [rt.name, rt.id] }), class: 'select2', style: "display: block" %>
           </div>
         </div>
-        <div id="related_product_discount" class="col-md-3">
+
+        <div id="related_product_discount" class="four width column">
           <div class="form-group">
             <%= label_tag :add_discount, Spree.t(:discount_amount) %>
-            <div class="input-group">
-              <%= text_field_tag :add_discount, 0.0, class: 'form-control text-center' %>
-              <span class="input-group-btn">
-                <%= button_link_to Spree.t(:add), admin_product_relations_url(@product), icon: 'add', class: 'btn-success', id: 'add_related_product', data: { update: 'products-table-wrapper' } %>
-              </span>
-            </div>
+            <%= text_field_tag :add_discount, 0.0, class: 'form-control text-center' %>
           </div>
         </div>
+
       </div>
+      <div class='row'>
+        <div class='column'>
+          <%= button_link_to Spree.t(:add), admin_product_relations_url(@product), icon: 'add', id: 'add_related_product', data: { update: 'products-table-wrapper' } %>
+        <div>
+      <div>
     </fieldset>
   </div>
 

data/bin/rails

@@ -4,4 +4,4 @@ ENGINE_ROOT = File.expand_path('../..', __FILE__)
 ENGINE_PATH = File.expand_path('../../lib/spree_related_products/engine', __FILE__)
 
 require 'rails/all'
-require 'rails/engine/commands'
+require 'rails/engine/commands'

data/config/locales/de.yml

@@ -16,3 +16,6 @@ de:
     add_related_product: Verwandtes Produkt hinzufügen
     name_or_sku_short: Name oder Artikelnummer
     no_relation_types: "Sie müssen Verwandschaftstypen konfigurieren, bevor Sie diese Funktion nutzen können."
+    admin:
+      tab:
+        relation_types: Verwandschaftstypen

data/config/routes.rb

@@ -1,4 +1,4 @@
-Spree::Core::Engine.add_routes do
+Spree::Core::Engine.routes.draw do
   namespace :admin do
     resources :relation_types
     resources :products, only: [] do

data/lib/generators/solidus_related_products/install/install_generator.rb

@@ -8,7 +8,7 @@ module SolidusRelatedProducts
       end
 
       def run_migrations
-        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask 'Would you like to run the migrations now? [Y/n]')
+        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]'))
         if run_migrations
           run 'bundle exec rake db:migrate'
         else

data/lib/solidus_related_products/version.rb

@@ -9,7 +9,7 @@ module SolidusRelatedProducts
 
   module VERSION
     MAJOR = 1
-    MINOR = 0
+    MINOR = 1
     TINY  = 0
     PRE   = nil
 

data/solidus_related_products.gemspec

@@ -23,8 +23,8 @@ Gem::Specification.new do |s|
 
   s.has_rdoc = false
 
-  s.add_runtime_dependency 'solidus_backend', '~> 1.0'
-  s.add_runtime_dependency 'deface'
+  s.add_runtime_dependency 'solidus_backend', ['>= 1.0', '< 3']
+  s.add_runtime_dependency 'deface', '~> 1.0'
 
   s.add_development_dependency 'factory_girl', '~> 4.5'
   s.add_development_dependency 'ffaker'
@@ -36,10 +36,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'shoulda-matchers', '~> 2.5'
   s.add_development_dependency 'simplecov', '~> 0.9'
   s.add_development_dependency 'database_cleaner', '~> 1.3'
-  s.add_development_dependency 'coffee-rails'
-  s.add_development_dependency 'sass-rails'
-  s.add_development_dependency 'guard-rspec'
-  s.add_development_dependency 'pry-rails'
   s.add_development_dependency 'rubocop', '>= 0.24.1'
   s.add_development_dependency 'rspec-activemodel-mocks'
 end

data/spec/controllers/spree/admin/relations_controller_spec.rb

@@ -39,6 +39,8 @@ RSpec.describe Spree::Admin::RelationsController, type: :controller do
       }
     end
 
+    let(:invalid_params) { { format: :js, product_id: product.id } }
+
     context '#create' do
       it 'is not routable' do
         spree_post :create, valid_params
@@ -53,14 +55,14 @@ RSpec.describe Spree::Admin::RelationsController, type: :controller do
 
       it 'raises error with invalid params' do
         expect {
-          spree_post :create, format: :js
-        }.to raise_error
+          spree_post :create, invalid_params
+        }.to raise_error(ActionController::ParameterMissing)
       end
     end
 
     context '#update' do
       it 'redirects to product/related url' do
-        spree_put :update, product_id: product.id, id: 1, relation: { discount_amount: 2.0 }
+        spree_put :update, product_id: product.id, id: relation.id, relation: { discount_amount: 2.0 }
         expect(response).to redirect_to(spree.admin_product_path(relation.relatable) + '/related')
       end
     end
@@ -68,7 +70,7 @@ RSpec.describe Spree::Admin::RelationsController, type: :controller do
     context '#destroy' do
       it 'records successfully' do
         expect {
-          spree_delete :destroy, id: 1, product_id: product.id, format: :js
+          spree_delete :destroy, id: relation.id, product_id: product.id, format: :js
         }.to change(Spree::Relation, :count).by(-1)
       end
     end

data/spec/controllers/spree/api/relations_controller_spec.rb

@@ -70,7 +70,7 @@ RSpec.describe Spree::Api::RelationsController, type: :controller do
     context '#destroy with' do
       it 'records successfully' do
         expect {
-          spree_delete :destroy, id: 1, product_id: product.id, format: :json, token: user.spree_api_key
+          spree_delete :destroy, id: relation.id, product_id: product.id, format: :json, token: user.spree_api_key
         }.to change(Spree::Relation, :count).by(-1)
       end
     end

data/spec/features/spree/admin/product_relation_spec.rb

@@ -12,7 +12,7 @@ RSpec.feature 'Admin Product Relation', :js do
   end
 
   scenario 'create relation' do
-    expect(page).to have_text 'ADD RELATED PRODUCT'
+    expect(page).to have_text /ADD RELATED PRODUCT/i
     expect(page).to have_text product.name
 
     within('#add-line-item') do
@@ -48,7 +48,7 @@ RSpec.feature 'Admin Product Relation', :js do
     end
 
     scenario 'ensure content exist' do
-      expect(page).to have_text 'ADD RELATED PRODUCT'
+      expect(page).to have_text /ADD RELATED PRODUCT/i
       expect(page).to have_text product.name
       expect(page).to have_text other.name
 

data/spec/features/spree/admin/relation_types_spec.rb

@@ -6,7 +6,7 @@ RSpec.feature 'Admin Relation Types', :js do
   end
 
   scenario 'when no relation types exists' do
-    expect(page).to have_text 'NO RELATION TYPES FOUND, ADD ONE!'
+    expect(page).to have_text /NO RELATION TYPES FOUND, ADD ONE!/i
   end
 
   context 'create' do

data/spec/models/spree/calculator/related_product_discount_spec.rb

@@ -35,9 +35,9 @@ RSpec.describe Spree::Calculator::RelatedProductDiscount, type: :model do
         create(:relation, relatable: product, related_to: related_product, relation_type: relation_type, discount_amount: 1.0)
       end
 
+      # TODO: figure out what this test is trying to accomplish
       it 'returns total count of Array' do
-        objects = Array.new { @order }
-        expect(subject.compute(objects)).to be_nil
+        expect(subject.compute([])).to be_nil
       end
 
       it 'returns total count' do

data/spec/models/spree/product_spec.rb

@@ -114,16 +114,4 @@ RSpec.describe Spree::Product, type: :model do
       end
     end
   end
-
-  context 'instance when relation_types table is missing' do
-    it 'method missing should not throw ActiveRecord::StatementInvalid when the spree_relation_types table is missing' do
-      described_class.connection.rename_table('spree_relation_types', 'missing_relation_types')
-      begin
-        product = described_class.new
-        expect { product.foo }.to raise_error(NameError)
-      ensure
-        described_class.connection.rename_table('missing_relation_types', 'spree_relation_types')
-      end
-    end
-  end
 end

data/spec/models/spree/relation_type_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe Spree::RelationType, type: :model do
       create(:relation_type, name: 'Gears')
       expect {
         create(:relation_type, name: 'gears')
-      }.to raise_error
+      }.to raise_error(ActiveRecord::RecordInvalid)
     end
   end
 end

metadata

@@ -1,43 +1,49 @@
 --- !ruby/object:Gem::Specification
 name: solidus_related_products
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Brian Quinn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-15 00:00:00.000000000 Z
+date: 2016-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_backend
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: deface
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: factory_girl
   requirement: !ruby/object:Gem::Requirement
@@ -178,62 +184,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: coffee-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: sass-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -275,7 +225,6 @@ files:
 - ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile
-- Guardfile
 - LICENSE.md
 - README.md
 - Rakefile

data/Guardfile

@@ -1,10 +0,0 @@
-guard 'rspec', cmd: 'bundle exec rspec' do
-  watch('spec/spec_helper.rb')                       { 'spec' }
-  watch('config/routes.rb')                          { 'spec/controllers' }
-  watch(%r{^spec/(.+)_spec\.rb$})                    { |m| "spec/#{m[1]}_spec.rb" }
-  watch(%r{^app/(.+)_decorator\.rb$})                { |m| "spec/#{m[1]}_spec.rb" }
-  watch(%r{^app/(.+)\.rb$})                          { |m| "spec/#{m[1]}_spec.rb" }
-  watch(%r{^app/(.*)(\.erb)$})                       { |m| "spec/#{m[1]}#{m[2]}_spec.rb" }
-  watch(%r{^lib/(.+)\.rb$})                          { |m| "spec/#{m[1]}_spec.rb" }
-  watch(%r{^app/controllers/(.+)_(controller)\.rb$}) { |m| "spec/#{m[2]}s/#{m[1]}_#{m[2]}_spec.rb" }
-end