solidus_legacy_promotions 4.6.2 → 4.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b7fe367087351a80fb8708ce2ab6a162963e0177fe489f32dfda915a3c4696d
-  data.tar.gz: 8f923a1d8643d521db0c933cbb01e2e727b4d6db4fa7e919197d21dc33b6a1b9
+  metadata.gz: 1f4488328d1d0991ae51ae2ce26d9220df5dceca5662d6212158f0fba93803a6
+  data.tar.gz: c20347dd2b0b060f86b6b919ebb3ee4ce59b84a7e2f4a0140d71cb78bb5c35e8
 SHA512:
-  metadata.gz: 359eabd33fb5cf98fef72ca96673d181b85a881366baa48ee3af7e67fa78b73862db2a9f093f846f07353b0c4e2570f517261ceb37b639765ebfbd6ad6d1d883
-  data.tar.gz: bdb0dea08feb1ecac391281d670b321f03aa8ad136c9678e2da18a2b0cf6fe455eaecade8aac5a9e55a916c84c8d3a44b9fd6a35c5dbf34198b20370000ac46a
+  metadata.gz: fc6187c4f3f4eaee61588995c50efd9560a99cf03550b3840e3ebcc048c3990c61a92de5687981953bba626569623fc0f2ae7344f2d63ea8fbfe0e4aaa966d3d
+  data.tar.gz: 6ac7409390d658619c9131d70ded81c6f56d82cd12dbc420ec1d164476407206fefe0e0891b262204f651765bfe1e57326e974234a66570a6a05d83fb3c2b9d4

data/Rakefile

@@ -1,35 +1,35 @@
 # frozen_string_literal: true
 
-require 'rubygems'
-require 'rake'
-require 'rake/testtask'
-require 'rspec/core/rake_task'
-require 'spree/testing_support/dummy_app/rake_tasks'
-require 'solidus_admin/testing_support/dummy_app/rake_tasks'
-require 'bundler/gem_tasks'
+require "rubygems"
+require "rake"
+require "rake/testtask"
+require "rspec/core/rake_task"
+require "spree/testing_support/dummy_app/rake_tasks"
+require "solidus_admin/testing_support/dummy_app/rake_tasks"
+require "bundler/gem_tasks"
 
 RSpec::Core::RakeTask.new
 task default: :spec
 
 DummyApp::RakeTasks.new(
   gem_root: File.dirname(__FILE__),
-  lib_name: 'solidus_legacy_promotions'
+  lib_name: "solidus_legacy_promotions"
 )
 
-require 'yard/rake/yardoc_task'
+require "yard/rake/yardoc_task"
 YARD::Rake::YardocTask.new(:yard)
 # The following workaround can be removed
 # once https://github.com/lsegal/yard/pull/1457 is merged.
-task('yard:require') { require 'yard' }
-task yard: 'yard:require'
+task("yard:require") { require "yard" }
+task yard: "yard:require"
 
 namespace :spec do
   task :isolated do
-    spec_files = Dir['spec/**/*_spec.rb']
+    spec_files = Dir["spec/**/*_spec.rb"]
     failed_specs =
       spec_files.reject do |file|
         puts "rspec #{file}"
-        system('rspec', file)
+        system("rspec", file)
       end
 
     if !failed_specs.empty?
@@ -40,4 +40,4 @@ namespace :spec do
   end
 end
 
-task test_app: 'db:reset'
+task test_app: "db:reset"

data/app/jobs/spree/promotion_code_batch_job.rb

@@ -14,7 +14,7 @@ module Spree
           .promotion_code_batch_finished(promotion_code_batch)
           .deliver_now
       end
-    rescue StandardError => error
+    rescue => error
       if promotion_code_batch.email?
         Spree::Config.promotions.promotion_code_batch_mailer_class
           .promotion_code_batch_errored(promotion_code_batch)

data/app/models/spree/calculator/distributed_amount.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_dependency 'spree/calculator'
+require_dependency "spree/calculator"
 
 # This is a calculator for line item adjustment actions. It accepts a line item
 # and calculates its weighted adjustment amount based on the value of the

data/app/models/spree/calculator/flat_percent_item_total.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_dependency 'spree/calculator'
+require_dependency "spree/calculator"
 
 module Spree
   class Calculator::FlatPercentItemTotal < Calculator

data/app/models/spree/calculator/flexi_rate.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-require_dependency 'spree/calculator'
+require_dependency "spree/calculator"
 
 module Spree
   class Calculator::FlexiRate < Calculator
-    preference :first_item,      :decimal, default: 0
+    preference :first_item, :decimal, default: 0
     preference :additional_item, :decimal, default: 0
-    preference :max_items,       :integer, default: 0
-    preference :currency,        :string,  default: ->{ Spree::Config[:currency] }
+    preference :max_items, :integer, default: 0
+    preference :currency, :string, default: -> { Spree::Config[:currency] }
 
     def compute(object)
       items_count = object.quantity

data/app/models/spree/calculator/percent_on_line_item.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_dependency 'spree/calculator'
+require_dependency "spree/calculator"
 
 module Spree
   class Calculator::PercentOnLineItem < Calculator

data/app/models/spree/calculator/tiered_flat_rate.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_dependency 'spree/calculator'
+require_dependency "spree/calculator"
 
 module Spree
   class Calculator::TieredFlatRate < Calculator
@@ -39,7 +39,7 @@ module Spree
 
     def preferred_tiers_content
       if preferred_tiers.is_a? Hash
-        unless preferred_tiers.keys.all?{ |key| key.is_a?(Numeric) && key > 0 }
+        unless preferred_tiers.keys.all? { |key| key.is_a?(Numeric) && key > 0 }
           errors.add(:base, :keys_should_be_positive_number)
         end
       else

data/app/models/spree/calculator/tiered_percent.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_dependency 'spree/calculator'
+require_dependency "spree/calculator"
 
 module Spree
   class Calculator::TieredPercent < Calculator
@@ -46,10 +46,10 @@ module Spree
 
     def preferred_tiers_content
       if preferred_tiers.is_a? Hash
-        unless preferred_tiers.keys.all?{ |key| key.is_a?(Numeric) && key > 0 }
+        unless preferred_tiers.keys.all? { |key| key.is_a?(Numeric) && key > 0 }
           errors.add(:base, :keys_should_be_positive_number)
         end
-        unless preferred_tiers.values.all?{ |key| key.is_a?(Numeric) && key >= 0 && key <= 100 }
+        unless preferred_tiers.values.all? { |key| key.is_a?(Numeric) && key >= 0 && key <= 100 }
           errors.add(:base, :values_should_be_percent)
         end
       else

data/app/models/spree/order_promotion.rb

@@ -6,11 +6,11 @@ module Spree
   # 1. A promotion that a user attempted to apply to their order
   # 2. The specific code that they used
   class OrderPromotion < Spree::Base
-    self.table_name = 'spree_orders_promotions'
+    self.table_name = "spree_orders_promotions"
 
-    belongs_to :order, class_name: 'Spree::Order', optional: true
-    belongs_to :promotion, class_name: 'Spree::Promotion', optional: true
-    belongs_to :promotion_code, class_name: 'Spree::PromotionCode', optional: true
+    belongs_to :order, class_name: "Spree::Order", optional: true
+    belongs_to :promotion, class_name: "Spree::Promotion", optional: true
+    belongs_to :promotion_code, class_name: "Spree::PromotionCode", optional: true
 
     validates :order, presence: true
     validates :promotion, presence: true

data/app/models/spree/promotion/actions/create_adjustment.rb

@@ -34,7 +34,7 @@ module Spree
             order:,
             source: self,
             promotion_code: options[:promotion_code],
-            label: I18n.t('spree.adjustment_labels.order', promotion: Spree::Promotion.model_name.human, promotion_name: promotion.name)
+            label: I18n.t("spree.adjustment_labels.order", promotion: Spree::Promotion.model_name.human, promotion_name: promotion.name)
           )
           true
         end

data/app/models/spree/promotion/actions/create_item_adjustments.rb

@@ -66,7 +66,7 @@ module Spree
             amount:,
             order:,
             promotion_code:,
-            label: I18n.t('spree.adjustment_labels.line_item', promotion: Spree::Promotion.model_name.human, promotion_name: promotion.name)
+            label: I18n.t("spree.adjustment_labels.line_item", promotion: Spree::Promotion.model_name.human, promotion_name: promotion.name)
           )
           true
         end

data/app/models/spree/promotion/actions/create_quantity_adjustments.rb

@@ -63,9 +63,9 @@ module Spree
           order = line_item.order
           line_items = actionable_line_items(order)
 
-          actioned_line_items = order.line_item_adjustments.reload.
-            select { |adjustment| adjustment.source == self && adjustment.amount < 0 }.
-            map(&:adjustable)
+          actioned_line_items = order.line_item_adjustments.reload
+            .select { |adjustment| adjustment.source == self && adjustment.amount < 0 }
+            .map(&:adjustable)
           other_line_items = actioned_line_items - [line_item]
 
           applicable_quantity = total_applicable_quantity(line_items)
@@ -75,7 +75,7 @@ module Spree
             line_item.quantity
           ].min
 
-          persist_quantity(usable_quantity, line_item)
+          set_line_item_action_quantity(usable_quantity, line_item)
 
           amount = adjustment_amount * usable_quantity
           [line_item.amount, amount].min * -1
@@ -83,6 +83,11 @@ module Spree
 
         private
 
+        def create_adjustment(adjustable, order, promotion_code)
+          return unless super
+          save!
+        end
+
         def actionable_line_items(order)
           order.line_items.select do |item|
             promotion.line_item_actionable? order, item
@@ -97,17 +102,16 @@ module Spree
         end
 
         def total_used_quantity(line_items)
-          line_item_actions.where(
-            line_item_id: line_items.map(&:id)
-          ).sum(:quantity)
+          line_item_actions.select { |line_item_action|
+            line_items.map(&:id).include? line_item_action.line_item_id
+          }.sum(&:quantity)
         end
 
-        def persist_quantity(quantity, line_item)
+        def set_line_item_action_quantity(quantity, line_item)
           line_item_action = line_item_actions.where(
             line_item_id: line_item.id
           ).first_or_initialize
           line_item_action.quantity = quantity
-          line_item_action.save!
         end
 
         ##

data/app/models/spree/promotion/actions/free_shipping.rb

@@ -27,7 +27,7 @@ module Spree
         end
 
         def label
-          "#{I18n.t('spree.promotion')} (#{promotion.name})"
+          "#{I18n.t("spree.promotion")} (#{promotion.name})"
         end
 
         def compute_amount(shipment)

data/app/models/spree/promotion/order_adjustments_recalculator.rb

@@ -13,12 +13,12 @@ module Spree
         @order = order
       end
 
-      def call
+      def call(persist: true)
         all_items = line_items + shipments
         all_items.each do |item|
           promotion_adjustments = item.adjustments.select(&:promotion?)
 
-          promotion_adjustments.each { |adjustment| recalculate(adjustment) }
+          promotion_adjustments.each { |adjustment| recalculate(adjustment, persist:) }
           Spree::Config.promotions.promotion_chooser_class.new(promotion_adjustments).update
 
           item.promo_total = promotion_adjustments.select(&:eligible?).sum(&:amount)
@@ -28,14 +28,16 @@ module Spree
         # in #update_adjustment_total since they include the totals from the order's
         # line items and/or shipments.
         order_promotion_adjustments = order.adjustments.select(&:promotion?)
-        order_promotion_adjustments.each { |adjustment| recalculate(adjustment) }
+        order_promotion_adjustments.each { |adjustment| recalculate(adjustment, persist:) }
         Spree::Config.promotions.promotion_chooser_class.new(order_promotion_adjustments).update
 
         order.promo_total = all_items.sum(&:promo_total) +
-                            order_promotion_adjustments.
-                              select(&:eligible?).
-                              select(&:promotion?).
-                              sum(&:amount)
+          order_promotion_adjustments
+            .select(&:eligible?)
+            .select(&:promotion?)
+            .sum(&:amount)
+
+        order.save! if persist
         order
       end
 
@@ -52,7 +54,7 @@ module Spree
       # admin) or is closed, this is a noop.
       #
       # @return [BigDecimal] New amount of this adjustment
-      def recalculate(adjustment)
+      def recalculate(adjustment, persist:)
         if adjustment.finalized?
           return adjustment.amount
         end
@@ -68,10 +70,7 @@ module Spree
 
           adjustment.eligible = calculate_eligibility(adjustment)
 
-          # Persist only if changed
-          # This is only not a save! to avoid the extra queries to load the order
-          # (for validations) and to touch the adjustment.
-          adjustment.update_columns(eligible: adjustment.eligible, amount: adjustment.amount, updated_at: Time.current) if adjustment.changed?
+          adjustment.save!(validate: false) if persist
         end
         adjustment.amount
       end

data/app/models/spree/promotion/rules/first_repeat_purchase_since.rb

@@ -5,7 +5,7 @@ module Spree
     module Rules
       class FirstRepeatPurchaseSince < PromotionRule
         preference :days_ago, :integer, default: 365
-        validates :preferred_days_ago, numericality: { only_integer: true, greater_than: 0 }
+        validates :preferred_days_ago, numericality: {only_integer: true, greater_than: 0}
 
         # This promotion is applicable to orders only.
         def applicable?(promotable)

data/app/models/spree/promotion/rules/item_total.rb

@@ -10,20 +10,20 @@ module Spree
       # To customize the error message you can also override `ineligible_message`.
       class ItemTotal < PromotionRule
         preference :amount, :decimal, default: 100.00
-        preference :currency, :string, default: ->{ Spree::Config[:currency] }
-        preference :operator, :string, default: 'gt'
+        preference :currency, :string, default: -> { Spree::Config[:currency] }
+        preference :operator, :string, default: "gt"
 
         # The list of allowed operators names mapped to their symbols.
         def self.operators_map
           {
             gte: :>=,
-            gt: :>,
+            gt: :>
           }
         end
 
         def self.operator_options
           operators_map.map do |name, _method|
-            [I18n.t(name, scope: 'spree.item_total_rule.operators'), name]
+            [I18n.t(name, scope: "spree.item_total_rule.operators"), name]
           end
         end
 
@@ -46,7 +46,7 @@ module Spree
         def operator
           self.class.operators_map.fetch(
             preferred_operator.to_sym,
-            preferred_operator_default,
+            preferred_operator_default
           )
         end
 
@@ -64,9 +64,9 @@ module Spree
 
         def ineligible_message
           case preferred_operator.to_s
-          when 'gte'
+          when "gte"
             eligibility_error_message(:item_total_less_than, amount: formatted_amount)
-          when 'gt'
+          when "gt"
             eligibility_error_message(:item_total_less_than_or_equal, amount: formatted_amount)
           else
             eligibility_error_message(:item_total_doesnt_match_with_operator, amount: formatted_amount, operator: preferred_operator)
@@ -74,7 +74,7 @@ module Spree
         end
 
         def ineligible_error_code
-          if preferred_operator == 'gte'
+          if preferred_operator == "gte"
             :item_total_less_than
           else
             :item_total_less_than_or_equal

data/app/models/spree/promotion/rules/minimum_quantity.rb

@@ -11,7 +11,7 @@ module Spree
       # it to a simple quantity check across the entire order which would be
       # better served by an item total rule.
       class MinimumQuantity < PromotionRule
-        validates :preferred_minimum_quantity, numericality: { only_integer: true, greater_than: 0 }
+        validates :preferred_minimum_quantity, numericality: {only_integer: true, greater_than: 0}
 
         preference :minimum_quantity, :integer, default: 1
 

data/app/models/spree/promotion/rules/nth_order.rb

@@ -7,7 +7,7 @@ module Spree
         preference :nth_order, :integer, default: 2
         # It does not make sense to have this apply to the first order using preferred_nth_order == 1
         # Instead we could use the first_order rule
-        validates :preferred_nth_order, numericality: { only_integer: true, greater_than: 1 }
+        validates :preferred_nth_order, numericality: {only_integer: true, greater_than: 1}
 
         # This promotion is applicable to orders only.
         def applicable?(promotable)
@@ -27,12 +27,12 @@ module Spree
         private
 
         def completed_order_count(order)
-          order.
-            user.
-            orders.
-            complete.
-            where(Spree::Order.arel_table[:completed_at].lt(order.completed_at || Time.current)).
-            count
+          order
+            .user
+            .orders
+            .complete
+            .where(Spree::Order.arel_table[:completed_at].lt(order.completed_at || Time.current))
+            .count
         end
 
         def nth_order?(order)

data/app/models/spree/promotion/rules/option_value.rb

@@ -4,7 +4,7 @@ module Spree
   class Promotion < Spree::Base
     module Rules
       class OptionValue < PromotionRule
-        MATCH_POLICIES = %w(any)
+        MATCH_POLICIES = %w[any]
         preference :match_policy, :string, default: MATCH_POLICIES.first
         preference :eligible_values, :hash
 
@@ -14,7 +14,7 @@ module Spree
 
         def eligible?(promotable, _options = {})
           case preferred_match_policy
-          when 'any'
+          when "any"
             promotable.line_items.any? { |item| actionable?(item) }
           end
         end
@@ -28,11 +28,11 @@ module Spree
 
         def preferred_eligible_values
           values = preferences[:eligible_values] || {}
-          Hash[values.keys.map(&:to_i).zip(
+          values.keys.map(&:to_i).zip(
             values.values.map do |value|
               (value.is_a?(Array) ? value : value.split(",")).map(&:to_i)
             end
-          )]
+          ).to_h
         end
 
         private

data/app/models/spree/promotion/rules/product.rb

@@ -11,17 +11,17 @@ module Spree
         has_many :product_promotion_rules,
           dependent: :destroy,
           foreign_key: :promotion_rule_id,
-          class_name: 'Spree::ProductPromotionRule',
+          class_name: "Spree::ProductPromotionRule",
           inverse_of: :promotion_rule
-        has_many :products, class_name: 'Spree::Product', through: :product_promotion_rules
+        has_many :products, class_name: "Spree::Product", through: :product_promotion_rules
 
         def preload_relations
           [:products]
         end
 
-        MATCH_POLICIES = %w(any all none)
+        MATCH_POLICIES = %w[any all none]
 
-        validates :preferred_match_policy, inclusion: { in: MATCH_POLICIES }
+        validates :preferred_match_policy, inclusion: {in: MATCH_POLICIES}
 
         preference :match_policy, :string, default: MATCH_POLICIES.first
 
@@ -45,12 +45,12 @@ module Spree
           when "any"
             unless order_products(order).any? { |product| eligible_products.include?(product) }
               eligibility_errors.add(:base, eligibility_error_message(:no_applicable_products),
-                                     error_code: :no_applicable_products)
+                error_code: :no_applicable_products)
             end
           when "none"
             unless order_products(order).none? { |product| eligible_products.include?(product) }
               eligibility_errors.add(:base, eligibility_error_message(:has_excluded_product),
-                                     error_code: :has_excluded_product)
+                error_code: :has_excluded_product)
             end
           else
             raise "unexpected match policy: #{preferred_match_policy.inspect}"
@@ -61,9 +61,9 @@ module Spree
 
         def actionable?(line_item)
           case preferred_match_policy
-          when 'any', 'all'
+          when "any", "all"
             product_ids.include? line_item.variant.product_id
-          when 'none'
+          when "none"
             product_ids.exclude? line_item.variant.product_id
           else
             raise "unexpected match policy: #{preferred_match_policy.inspect}"
@@ -71,11 +71,11 @@ module Spree
         end
 
         def product_ids_string
-          product_ids.join(',')
+          product_ids.join(",")
         end
 
         def product_ids_string=(product_ids)
-          self.product_ids = product_ids.to_s.split(',').map(&:strip)
+          self.product_ids = product_ids.to_s.split(",").map(&:strip)
         end
 
         private

data/app/models/spree/promotion/rules/taxon.rb

@@ -5,19 +5,19 @@ module Spree
     module Rules
       class Taxon < PromotionRule
         has_many :promotion_rule_taxons,
-          class_name: 'Spree::PromotionRuleTaxon',
+          class_name: "Spree::PromotionRuleTaxon",
           foreign_key: :promotion_rule_id,
           dependent: :destroy,
           inverse_of: :promotion_rule
-        has_many :taxons, through: :promotion_rule_taxons, class_name: 'Spree::Taxon'
+        has_many :taxons, through: :promotion_rule_taxons, class_name: "Spree::Taxon"
 
         def preload_relations
           [:taxons]
         end
 
-        MATCH_POLICIES = %w(any all none)
+        MATCH_POLICIES = %w[any all none]
 
-        validates :preferred_match_policy, inclusion: { in: MATCH_POLICIES }
+        validates :preferred_match_policy, inclusion: {in: MATCH_POLICIES}
 
         preference :match_policy, :string, default: MATCH_POLICIES.first
         def applicable?(promotable)
@@ -28,7 +28,7 @@ module Spree
           order_taxons = taxons_in_order(order)
 
           case preferred_match_policy
-          when 'all'
+          when "all"
             matches_all = taxons.all? do |rule_taxon|
               order_taxons.where(id: rule_taxon.self_and_descendants.ids).exists?
             end
@@ -36,11 +36,11 @@ module Spree
             unless matches_all
               eligibility_errors.add(:base, eligibility_error_message(:missing_taxon), error_code: :missing_taxon)
             end
-          when 'any'
+          when "any"
             unless order_taxons.where(id: rule_taxon_ids_with_children).exists?
               eligibility_errors.add(:base, eligibility_error_message(:no_matching_taxons), error_code: :no_matching_taxons)
             end
-          when 'none'
+          when "none"
             if order_taxons.where(id: rule_taxon_ids_with_children).exists?
               eligibility_errors.add(:base, eligibility_error_message(:has_excluded_taxon), error_code: :has_excluded_taxon)
             end
@@ -58,9 +58,9 @@ module Spree
           ).exists?
 
           case preferred_match_policy
-          when 'any', 'all'
+          when "any", "all"
             found
-          when 'none'
+          when "none"
             !found
           else
             raise "unexpected match policy: #{preferred_match_policy.inspect}"
@@ -68,11 +68,11 @@ module Spree
         end
 
         def taxon_ids_string
-          taxons.pluck(:id).join(',')
+          taxons.pluck(:id).join(",")
         end
 
         def taxon_ids_string=(taxon_ids)
-          taxon_ids = taxon_ids.to_s.split(',').map(&:strip)
+          taxon_ids = taxon_ids.to_s.split(",").map(&:strip)
           self.taxons = Spree::Taxon.find(taxon_ids)
         end
 
@@ -80,8 +80,8 @@ module Spree
 
         # All taxons in an order
         def taxons_in_order(order)
-          Spree::Taxon.joins(products: { variants_including_master: :line_items })
-            .where(spree_line_items: { order_id: order.id }).distinct
+          Spree::Taxon.joins(products: {variants_including_master: :line_items})
+            .where(spree_line_items: {order_id: order.id}).distinct
         end
 
         # ids of taxons rules and taxons rules children

data/app/models/spree/promotion/rules/user.rb

@@ -5,7 +5,7 @@ module Spree
     module Rules
       class User < PromotionRule
         has_many :promotion_rule_users,
-          class_name: 'Spree::PromotionRuleUser',
+          class_name: "Spree::PromotionRuleUser",
           foreign_key: :promotion_rule_id,
           dependent: :destroy,
           inverse_of: :promotion_rule
@@ -24,11 +24,11 @@ module Spree
         end
 
         def user_ids_string
-          user_ids.join(',')
+          user_ids.join(",")
         end
 
         def user_ids_string=(user_ids)
-          self.user_ids = user_ids.to_s.split(',').map(&:strip)
+          self.user_ids = user_ids.to_s.split(",").map(&:strip)
         end
       end
     end

data/app/models/spree/promotion/rules/user_role.rb

@@ -6,7 +6,7 @@ module Spree
       class UserRole < PromotionRule
         preference :role_ids, :array, default: []
 
-        MATCH_POLICIES = %w(any all)
+        MATCH_POLICIES = %w[any all]
         preference :match_policy, default: MATCH_POLICIES.first
 
         def applicable?(promotable)
@@ -25,7 +25,7 @@ module Spree
         private
 
         def all_match_policy?
-          preferred_match_policy == 'all' && preferred_role_ids.present?
+          preferred_match_policy == "all" && preferred_role_ids.present?
         end
 
         def user_roles(order)