solidus_dev_support 2.5.5 → 2.5.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe379e7fb130ab58c9441d18cae3d9c0eb6041c112db22497d93d170f4670267
-  data.tar.gz: 0a2bbcd253dd04a0b76723aa46279c68a0d2596c57fb7dc197c89bc4b8d50e16
+  metadata.gz: a256697ae6d1f388aeabf3bb92518d06656d898ffa5b843dd0c75f9b4998615e
+  data.tar.gz: eee6cf88c1bdf7dbe42ff1aa0354503250537d30ad00983e3b442a4eae4252f3
 SHA512:
-  metadata.gz: 16934e61453c2437bf129eaaa4ffb91927ccb811d5325490da187ede88a8d14c956e3e9d44bfb2b358f745036b4fdeced91a20884467e6bf2e3899222f72fae5
-  data.tar.gz: 31090179be805e26f804ee26e7fb3ac70865d73105087777e2485961ddfed1a41c6ce48d32c7e4b1cceb45796cb5a2e189099756665228301196b73c13212a9d
+  metadata.gz: 62cf34cab1efaa87e55bc217602fb5b511efb2b2ad9b164e3844c5503a5359fbbd29e4cf861f4035ed092f7cab8354bfdc39d0849af3bccfde975c30e675b37d
+  data.tar.gz: f708bf5e2de29af086d0890629e12cf9d233790cf86792762cdc6cb3b2060c068114c41570a43c27a5c24d7490ea8cd2d591b7a3b29c0a28801d71c5a589d230

data/.circleci/config.yml

@@ -21,13 +21,19 @@ commands:
 
 jobs:
   solidus-master:
-    executor: solidusio_extensions/sqlite
+    executor:
+      name: solidusio_extensions/sqlite
+      ruby_version: '3.1'
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-master']
   solidus-current:
-    executor: solidusio_extensions/sqlite
+    executor:
+      name: solidusio_extensions/sqlite
+      ruby_version: '3.0'
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-current']
   solidus-older:
-    executor: solidusio_extensions/sqlite
+    executor:
+      name: solidusio_extensions/sqlite
+      ruby_version: '2.7'
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-older']
   lint-code:
     executor: solidusio_extensions/sqlite

data/.github/stale.yml

@@ -0,0 +1 @@
+_extends: .github

data/CHANGELOG.md

@@ -1,8 +1,25 @@
 # Changelog
 
-## [2.5.5](https://github.com/solidusio/solidus_dev_support/tree/2.5.5) (2022-09-08)
+## [2.5.6](https://github.com/solidusio/solidus_dev_support/tree/2.5.6) (2023-04-24)
 
-[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v2.5.4...2.5.5)
+[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v2.5.5...2.5.6)
+
+**Implemented enhancements:**
+
+- Allow Solidus 4 [\#203](https://github.com/solidusio/solidus_dev_support/pull/203) ([elia](https://github.com/elia))
+- Update proposed defaults [\#191](https://github.com/solidusio/solidus_dev_support/pull/191) ([elia](https://github.com/elia))
+
+**Fixed bugs:**
+
+- Fix sandbox default solidus branch [\#192](https://github.com/solidusio/solidus_dev_support/pull/192) ([RyanofWoods](https://github.com/RyanofWoods))
+
+**Merged pull requests:**
+
+- Remove Slack notifications for CI failures [\#199](https://github.com/solidusio/solidus_dev_support/pull/199) ([waiting-for-dev](https://github.com/waiting-for-dev))
+
+## [v2.5.5](https://github.com/solidusio/solidus_dev_support/tree/v2.5.5) (2022-09-08)
+
+[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v2.5.4...v2.5.5)
 
 **Implemented enhancements:**
 

data/Gemfile

@@ -13,6 +13,9 @@ gem 'solidus', github: 'solidusio/solidus', branch: branch
 # A workaround for https://github.com/bundler/bundler/issues/6677
 gem 'rails', '>0.a'
 
+gem 'bundler'
+gem 'rake'
+
 # These gems will be used by the temporary extensions generated by tests
 group :test do
   gem 'mysql2'

data/README.md

@@ -38,11 +38,11 @@ in solidus_dev_support.
 
 #### Updating existing extensions
 
-If you have an existing extension and want to update it to use the latest standards from this gem,
-you can run the following in the extension's directory:
+If you have an existing extension generated with `solidus_dev_support` and want to update it to use
+the latest standards from this gem, you can run the following in the extension's directory:
 
 ```console
-$ solidus extension .
+$ bundle exec solidus extension .
 ```
 
 In case of conflicting files, you will be prompted for an action. You can overwrite the files with
@@ -238,7 +238,7 @@ To release a new version:
 
 1. update the version number in `version.rb`
 2. update the changelog with `bin/rake changelog`
-3. commit the changes using `Bump SolidusDevSupport to 1.2.3` as the message
+3. commit the changes using `Release SolidusDevSupport v1.2.3` as the message
 3. run `bin/rake release`
 
 The last command will create a git tag for the version, push git commits and tags, and push the `.gem` file to

data/lib/solidus_dev_support/templates/extension/.circleci/config.yml

@@ -11,25 +11,30 @@ orbs:
   solidusio_extensions: solidusio/extensions@volatile
 
 jobs:
+  run-specs-with-sqlite:
+    executor: solidusio_extensions/sqlite
+    steps:
+      - browser-tools/install-chrome
+      - solidusio_extensions/run-tests
   run-specs-with-postgres:
     executor: solidusio_extensions/postgres
     steps:
-      - browser-tools/install-browser-tools
+      - browser-tools/install-chrome
       - solidusio_extensions/run-tests
   run-specs-with-mysql:
     executor: solidusio_extensions/mysql
     steps:
-      - browser-tools/install-browser-tools
+      - browser-tools/install-chrome
       - solidusio_extensions/run-tests
   lint-code:
     executor: solidusio_extensions/sqlite-memory
     steps:
-      - browser-tools/install-browser-tools
       - solidusio_extensions/lint-code
 
 workflows:
   "Run specs on supported Solidus versions":
     jobs:
+      - run-specs-with-sqlite
       - run-specs-with-postgres
       - run-specs-with-mysql
       - lint-code
@@ -43,5 +48,6 @@ workflows:
               only:
                 - master
     jobs:
+      - run-specs-with-sqlite
       - run-specs-with-postgres
       - run-specs-with-mysql

data/lib/solidus_dev_support/templates/extension/.github/stale.yml

@@ -1,17 +1 @@
-# Number of days of inactivity before an issue becomes stale
-daysUntilStale: 60
-# Number of days of inactivity before a stale issue is closed
-daysUntilClose: false
-# Issues with these labels will never be considered stale
-exemptLabels:
-  - pinned
-  - security
-# Label to use when marking an issue as stale
-staleLabel: stale
-# Comment to post when marking an issue as stale. Set to `false` to disable
-markComment: >
-  This issue has been automatically marked as stale because it has not had
-  recent activity. It might be closed if no further activity occurs. Thank you
-  for your contributions.
-# Comment to post when closing a stale issue. Set to `false` to disable
-closeComment: false
+_extends: .github

data/lib/solidus_dev_support/templates/extension/{Gemfile → Gemfile.tt}

@@ -15,9 +15,10 @@ gem 'solidus_frontend' if branch >= 'v3.2' # rubocop:disable Bundler/DuplicatedG
 # See https://github.com/bundler/bundler/issues/6677
 gem 'rails', '>0.a'
 
+<% if file_name != 'solidus_auth_devise' %>
 # Provides basic authentication functionality for testing parts of your engine
 gem 'solidus_auth_devise'
-
+<% end %>
 case ENV.fetch('DB', nil)
 when 'mysql'
   gem 'mysql2'

data/lib/solidus_dev_support/templates/extension/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) <%= Time.now.year %> [name of plugin creator]
+Copyright (c) <%= Time.now.year %> <%= gemspec.authors.join ', ' %>
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification,

data/lib/solidus_dev_support/templates/extension/README.md

@@ -71,21 +71,10 @@ $ bin/rails server
 Use Ctrl-C to stop
 ```
 
-### Updating the changelog
-
-Before and after releases the changelog should be updated to reflect the up-to-date status of
-the project:
-
-```shell
-bin/rake changelog
-git add CHANGELOG.md
-git commit -m "Update the changelog"
-```
-
 ### Releasing new versions
 
-Please refer to the dedicated [page](https://github.com/solidusio/solidus/wiki/How-to-release-extensions) on Solidus wiki.
+Please refer to the [dedicated page](https://github.com/solidusio/solidus/wiki/How-to-release-extensions) in the Solidus wiki.
 
 ## License
 
-Copyright (c) <%= Time.now.year %> [name of extension author], released under the New BSD License.
+Copyright (c) <%= Time.now.year %> <%= gemspec.authors.join ', ' %>, released under the New BSD License.

data/lib/solidus_dev_support/templates/extension/bin/sandbox.tt

@@ -1,43 +1,18 @@
 #!/usr/bin/env bash
 
 set -e
-if [ ! -z $DEBUG ]
-then
-  set -x
-fi
+test -z "${DEBUG+empty_string}" || set -x
 
-case "$DB" in
-postgres|postgresql)
-  RAILSDB="postgresql"
-  ;;
-mysql)
-  RAILSDB="mysql"
-  ;;
-sqlite3|sqlite)
-  RAILSDB="sqlite3"
-  ;;
-'')
-  echo "~~> Use 'export DB=[postgres|mysql|sqlite]' to control the DB adapter"
-  RAILSDB="sqlite3"
-  ;;
-*)
-  echo "Invalid value specified for the Solidus sandbox: DB=\"$DB\"."
-  echo "Please use 'postgres', 'mysql', or 'sqlite' instead."
-  exit 1
-  ;;
-esac
-echo "~~> Using $RAILSDB as the database engine"
+test "$DB" = "sqlite" && export DB="sqlite3"
 
-if [ -n $SOLIDUS_BRANCH ]
+if [ -z "$SOLIDUS_BRANCH" ]
 then
-  BRANCH=$SOLIDUS_BRANCH
-else
   echo "~~> Use 'export SOLIDUS_BRANCH=[master|v3.2|...]' to control the Solidus branch"
-  BRANCH="master"
+  SOLIDUS_BRANCH="master"
 fi
-echo "~~> Using branch $BRANCH of solidus"
+echo "~~> Using branch $SOLIDUS_BRANCH of solidus"
 
-if [ -z $SOLIDUS_FRONTEND ]
+if [ -z "$SOLIDUS_FRONTEND" ]
 then
   echo "~~> Use 'export SOLIDUS_FRONTEND=[solidus_frontend|solidus_starter_frontend]' to control the Solidus frontend"
   SOLIDUS_FRONTEND="solidus_frontend"
@@ -52,7 +27,8 @@ function unbundled {
 }
 
 rm -rf ./sandbox
-unbundled bundle exec rails new sandbox --database="$RAILSDB" \
+unbundled bundle exec rails new sandbox \
+  --database="${DB:-sqlite3}" \
   --skip-bundle \
   --skip-git \
   --skip-keeps \
@@ -68,7 +44,7 @@ fi
 
 cd ./sandbox
 cat <<RUBY >> Gemfile
-gem 'solidus', github: 'solidusio/solidus', branch: '$BRANCH'
+gem 'solidus', github: 'solidusio/solidus', branch: '$SOLIDUS_BRANCH'
 gem 'rails-i18n'
 gem 'solidus_i18n'
 

data/lib/solidus_dev_support/templates/extension/gitignore

@@ -8,6 +8,7 @@
 .sass-cache
 coverage
 Gemfile.lock
+Gemfile-local
 tmp
 nbproject
 pkg

data/lib/solidus_dev_support/templates/extension/lib/generators/%file_name%/install/install_generator.rb.tt

@@ -6,6 +6,10 @@ module <%= class_name %>
       class_option :auto_run_migrations, type: :boolean, default: false
       source_root File.expand_path('templates', __dir__)
 
+      def self.exit_on_failure?
+        true
+      end
+
       def copy_initializer
         template 'initializer.rb', 'config/initializers/<%= file_name %>.rb'
       end

data/lib/solidus_dev_support/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module SolidusDevSupport
-  VERSION = "2.5.5"
+  VERSION = "2.5.6"
 
   def self.gem_version
     Gem::Version.new(VERSION)

data/solidus_dev_support.gemspec

@@ -45,9 +45,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rubocop-performance', '~> 1.5'
   spec.add_dependency 'rubocop-rails', '~> 2.3'
   spec.add_dependency 'rubocop-rspec', '~> 2.0'
-  spec.add_dependency 'solidus_core', ['>= 2.0', '< 4']
+  spec.add_dependency 'solidus_core', ['>= 2.0', '< 5']
   spec.add_dependency 'webdrivers', '>= 4.4'
-
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rake'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_dev_support
 version: !ruby/object:Gem::Version
-  version: 2.5.5
+  version: 2.5.6
 platform: ruby
 authors:
 - Alessandro Desantis
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-09 00:00:00.000000000 Z
+date: 2023-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -255,7 +255,7 @@ dependencies:
         version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -265,7 +265,7 @@ dependencies:
         version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: webdrivers
   requirement: !ruby/object:Gem::Requirement
@@ -280,34 +280,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.4'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description:
 email:
 - alessandrodesantis@nebulab.it
@@ -318,7 +290,7 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".gem_release.yml"
-- ".github/PULL_REQUEST_TEMPLATE.md"
+- ".github/stale.yml"
 - ".github_changelog_generator"
 - ".gitignore"
 - ".mergify.yml"
@@ -351,7 +323,7 @@ files:
 - lib/solidus_dev_support/templates/extension/.github/stale.yml
 - lib/solidus_dev_support/templates/extension/CHANGELOG.md
 - lib/solidus_dev_support/templates/extension/CONTRIBUTING.md
-- lib/solidus_dev_support/templates/extension/Gemfile
+- lib/solidus_dev_support/templates/extension/Gemfile.tt
 - lib/solidus_dev_support/templates/extension/LICENSE
 - lib/solidus_dev_support/templates/extension/README.md
 - lib/solidus_dev_support/templates/extension/Rakefile
@@ -412,7 +384,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.21
+rubygems_version: 3.4.12
 signing_key:
 specification_version: 4
 summary: Development tools for Solidus extensions.

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -1,10 +0,0 @@
-Fixes #XXX.
-
-## Summary
-
-<!-- Describe what you have changed in this PR. -->
-
-## Checklist
-
-- [ ] I have structured the commits for clarity and conciseness.
-- [ ] I have added relevant automated tests for this change.