solidus_dev_support 1.5.0 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2320ceaf62d68e7e76f5ebd54a77ed582fddbc0f4933caaba3f823d8f8ebb53f
-  data.tar.gz: 765116a27d6167455eee850837d71aee6d807a1ff1437efa916c0890db2e638a
+  metadata.gz: 57ffc454eba9fcbba02fb86c44287829fff79b729667b7337e3acf2c7fa09528
+  data.tar.gz: 1e408fd52a16aa8bafb5a87d8180661bf2e43126a61203916c0bee70b3dbe13d
 SHA512:
-  metadata.gz: a263c2ce6e5ce6de123cb52e4e1a9457be7979b2eb811de170efbbfd5c10b774a697efa116899e08a75e5f1062b6f878d8796d543d172d1b369a760089425e70
-  data.tar.gz: 12a2731dadf62796e4880f7911eb14125691e9fc7886b8bcbde881705a218334e36ac1d5d4602594836fc9de4df0c1eca5b36ecce557522085bae2ce7ccb4970
+  metadata.gz: 754b6f714db2c8436875c69c9af9aabe018f321c5ea12b683657d56e5a1e6595fb7f16f965cf5ea6701bcd5ea6e0f3c10a27fabd4d07f9abc815f9b1499046d2
+  data.tar.gz: c2f11a1b7bd1983dca96baf5a9f62f61b237ff6402657ba4bba72e91133e3a835887e4f9d15a1a423d8236d035516eddc64dab4ff1ba194c39c3c1ca4216f08f

data/.circleci/config.yml

@@ -7,19 +7,6 @@ orbs:
   # or goes EOL.
   solidusio_extensions: solidusio/extensions@volatile
 
-executors:
-  # We don't rely directly on the DB, but we still want to ensure generated
-  # extensions are able to connect and spin up Solidus. Using an in-memory
-  # SQLite makes it blazingly fast.
-  sqlite-memory:
-    docker:
-       - image: circleci/ruby:2.5.6-node-browsers
-         environment:
-           RAILS_ENV: test
-           DB: sqlite
-           DATABASE_URL: sqlite3::memory:?pool=1
-           DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL: true
-
 commands:
   setup:
     steps:
@@ -28,14 +15,17 @@ commands:
 
 jobs:
   solidus-master:
-    executor: sqlite-memory
+    executor: solidusio_extensions/sqlite-memory
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-master']
   solidus-current:
-    executor: sqlite-memory
+    executor: solidusio_extensions/sqlite-memory
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-current']
   solidus-older:
-    executor: sqlite-memory
+    executor: solidusio_extensions/sqlite-memory
     steps: ['setup', 'solidusio_extensions/run-tests-solidus-older']
+  lint-code:
+    executor: solidusio_extensions/sqlite-memory
+    steps: ['setup', 'solidusio_extensions/lint-code']
 
 workflows:
   "Run specs on supported Solidus versions":
@@ -43,6 +33,7 @@ workflows:
       - solidus-master
       - solidus-current
       - solidus-older
+      - lint-code
 
   "Weekly run specs against master":
     triggers:

data/.rubocop.yml

@@ -1,11 +1,53 @@
 inherit_from:
   - https://relaxed.ruby.style/rubocop.yml
 
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+Style/AccessorGrouping:
+  Enabled: true
+Style/BisectedAttrAccessor:
+  Enabled: true
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/RedundantAssignment:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
+
 AllCops:
+  TargetRubyVersion: 2.5
   Exclude:
     - tmp/**/*
+    - "vendor/**/*"
+    # Generated binstubs
+    - bin/rake
 
 Style/FrozenStringLiteralComment:
   Exclude:
     - "**/bin/*"
     - "**/exe/*"
+    - "spec/**/*"
+

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## [Unreleased](https://github.com/solidusio/solidus_dev_support/tree/HEAD)
+
+[Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v1.5.0...HEAD)
+
+**Implemented enhancements:**
+
+- Let the extension name include spaces [\#133](https://github.com/solidusio/solidus_dev_support/pull/133) ([elia](https://github.com/elia))
+- Add precompiled badges fro CI and coverage [\#132](https://github.com/solidusio/solidus_dev_support/pull/132) ([elia](https://github.com/elia))
+- Add Changelog Rake task [\#128](https://github.com/solidusio/solidus_dev_support/pull/128) ([tvdeyen](https://github.com/tvdeyen))
+- Readme fixes [\#122](https://github.com/solidusio/solidus_dev_support/pull/122) ([elia](https://github.com/elia))
+
+**Fixed bugs:**
+
+- Don't install a payment-method in the sandbox [\#131](https://github.com/solidusio/solidus_dev_support/pull/131) ([elia](https://github.com/elia))
+- Run extension generator in sandbox [\#127](https://github.com/solidusio/solidus_dev_support/pull/127) ([elia](https://github.com/elia))
+
 ## [v1.5.0](https://github.com/solidusio/solidus_dev_support/tree/v1.5.0) (2020-06-13)
 
 [Full Changelog](https://github.com/solidusio/solidus_dev_support/compare/v1.4.0...v1.5.0)

data/Gemfile

@@ -15,10 +15,10 @@ gem 'rails', '>0.a'
 
 # These gems will be used by the temporary extensions generated by tests
 group :test do
-  gem 'solidus_auth_devise'
   gem 'factory_bot', '> 4.10.0'
   gem 'mysql2'
   gem 'pg'
+  gem 'solidus_auth_devise'
   gem 'sqlite3'
 end
 

data/README.md

@@ -1,6 +1,8 @@
 # solidus_dev_support
 
-[![CircleCI](https://circleci.com/gh/solidusio/solidus_dev_support.svg?style=svg)](https://circleci.com/gh/solidusio/solidus_dev_support)
+
+[![CircleCI](https://circleci.com/gh/solidusio/solidus_dev_support.svg?style=shield)](https://circleci.com/gh/solidusio/solidus_dev_support)
+[![codecov](https://codecov.io/gh/solidusio/solidus_dev_support/branch/master/graph/badge.svg)](https://codecov.io/gh/solidusio/solidus_dev_support)
 
 This gem contains common development functionality for Solidus extensions.
 

data/Rakefile

@@ -1,8 +1,18 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-require "rspec/core/rake_task"
 
+require 'github_changelog_generator/task'
+GitHubChangelogGenerator::RakeTask.new :changelog do |config|
+  config.user = 'solidusio'
+  config.project = 'solidus_dev_support'
+  config.exclude_labels = %w[infrastructure]
+  config.issues = false
+  config.base = "#{__dir__}/OLD_CHANGELOG.md"
+  config.since_tag = 'v1.4.0'
+end
+
+require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec

data/lib/solidus_dev_support/extension.rb

@@ -89,7 +89,7 @@ module SolidusDevSupport
           'remote get-url origin',
           "git@github.com:#{github_user}/#{file_name}.git"
         ).sub(
-          %r{^.*github\.com.([^/]+)/([^/\.]+).*$},
+          %r{^.*github\.com.([^/]+)/([^/.]+).*$},
           'https://github.com/\1/\2'
         )
       end

data/lib/solidus_dev_support/rake_tasks.rb

@@ -23,6 +23,7 @@ module SolidusDevSupport
       install_test_app_task
       install_dev_app_task
       install_rspec_task
+      install_changelog_task
     end
 
     def install_test_app_task
@@ -71,5 +72,16 @@ module SolidusDevSupport
         end
       end
     end
+
+    def install_changelog_task
+      require 'github_changelog_generator/task'
+
+      user, project = gemspec.homepage.split("/")[3..5]
+      GitHubChangelogGenerator::RakeTask.new(:changelog) do |config|
+        config.user = user || 'solidus-contrib'
+        config.project = project || gemspec.name
+        config.future_release = "v#{gemspec.version}"
+      end
+    end
   end
 end

data/lib/solidus_dev_support/rspec/feature_helper.rb

@@ -22,18 +22,27 @@ end
 
 require 'spree/testing_support/capybara_ext'
 
+def dev_support_assets_preload
+  if Rails.application.respond_to?(:precompiled_assets)
+    Rails.application.precompiled_assets
+  else
+    # For older sprockets 2.x
+    Rails.application.config.assets.precompile.each do |asset|
+      Rails.application.assets.find_asset(asset)
+    end
+  end
+end
+
 RSpec.configure do |config|
   config.when_first_matching_example_defined(type: :feature) do
     config.before :suite do
-      # Preload assets
-      if Rails.application.respond_to?(:precompiled_assets)
-        Rails.application.precompiled_assets
-      else
-        # For older sprockets 2.x
-        Rails.application.config.assets.precompile.each do |asset|
-          Rails.application.assets.find_asset(asset)
-        end
-      end
+      dev_support_assets_preload
+    end
+  end
+
+  config.when_first_matching_example_defined(type: :system) do
+    config.before :suite do
+      dev_support_assets_preload
     end
   end
 end

data/lib/solidus_dev_support/rspec/rails_helper.rb

@@ -67,14 +67,17 @@ RSpec.configure do |config|
   rescue NameError => e
     class ZeitwerkNameError < NameError; end
 
-    message = <<~WARN
-      Zeitwerk raised the following error when trying to eager load your extension:
-
-      #{if e.message =~ /expected file .*? to define constant [\w:]+/
+    error_message =
+      if e.message =~ /expected file .*? to define constant [\w:]+/
         e.message.sub(/expected file #{Regexp.escape(File.expand_path('../..', Rails.root))}./, "expected file ")
       else
         e.message
-      end}
+      end
+
+    message = <<~WARN
+      Zeitwerk raised the following error when trying to eager load your extension:
+
+      #{error_message}
 
       This most likely means that your extension's file structure is not
       compatible with the Zeitwerk autoloader.

data/lib/solidus_dev_support/rubocop/config.yml

@@ -1,203 +1,82 @@
-# Relaxed.Ruby.Style
-## Version 2.4
-
-Style/Alias:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylealias
-
-Style/AsciiComments:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styleasciicomments
-
-Style/BeginBlock:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylebeginblock
-
-Style/BlockDelimiters:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styleblockdelimiters
-
-Style/CommentAnnotation:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylecommentannotation
-
-Style/Documentation:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styledocumentation
-
-Layout/DotPosition:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#layoutdotposition
-
-Style/DoubleNegation:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styledoublenegation
-
-Style/EndBlock:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styleendblock
-
-Style/FormatString:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styleformatstring
-
-Style/IfUnlessModifier:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styleifunlessmodifier
-
-Style/Lambda:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylelambda
-
-Style/ModuleFunction:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylemodulefunction
-
-Style/MultilineBlockChain:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylemultilineblockchain
-
-Style/NegatedIf:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylenegatedif
-
-Style/NegatedWhile:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylenegatedwhile
-
-Style/NumericPredicate:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylenumericpredicate
-
-Style/ParallelAssignment:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styleparallelassignment
-
-Style/PercentLiteralDelimiters:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylepercentliteraldelimiters
-
-Style/PerlBackrefs:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styleperlbackrefs
-
-Style/Semicolon:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylesemicolon
-
-Style/SignalException:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylesignalexception
-
-Style/SingleLineBlockParams:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylesinglelineblockparams
-
-Style/SingleLineMethods:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylesinglelinemethods
-
-Layout/SpaceBeforeBlockBraces:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#layoutspacebeforeblockbraces
-
-Layout/SpaceInsideParens:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#layoutspaceinsideparens
-
-Style/SpecialGlobalVars:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylespecialglobalvars
-
-Style/StringLiterals:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylestringliterals
-
-Style/TrailingCommaInArguments:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainarguments
-
-Style/TrailingCommaInArrayLiteral:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainarrayliteral
-
-Style/TrailingCommaInHashLiteral:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainhashliteral
-
-Style/SymbolArray:
-  Enabled: false
-  StyleGuide: http://relaxed.ruby.style/#stylesymbolarray
-
-Style/WhileUntilModifier:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylewhileuntilmodifier
-
-Style/WordArray:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#stylewordarray
-
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#lintambiguousregexpliteral
-
-Lint/AssignmentInCondition:
-  Enabled: false
-  StyleGuide: https://relaxed.ruby.style/#lintassignmentincondition
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/BlockNesting:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-# Metrics/LineLength:
-#   Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-# Our overrides after this point:
-
-require:
-  - rubocop-rspec
-  - rubocop-rails
-  - rubocop-performance
-
-AllCops:
-  TargetRubyVersion: 2.5
-  Exclude:
-    - spec/dummy/**/*
-    - sandbox/**/*
-    - vendor/**/*
-
-Metrics/BlockLength:
-  Enabled: false
-
-Metrics/LineLength:
-  Enabled: true
-  Max: 100
-
-RSpec/ExampleLength:
-  Enabled: false
-
-Layout/AlignArguments:
-  EnforcedStyle: with_fixed_indentation
-
-Layout/MultilineOperationIndentation:
-  Enabled: false
+require: ["rubocop-rspec", "rubocop-rails", "rubocop-performance"]
+
+AllCops: {TargetRubyVersion: 2.5, Exclude: ["spec/dummy/**/*", "sandbox/**/*", "vendor/**/*"]}
+
+Layout/ArgumentAlignment: {EnforcedStyle: with_fixed_indentation}
+Layout/DotPosition: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#layoutdotposition"}
+Layout/EmptyLinesAroundAttributeAccessor: {Enabled: true}
+Layout/FirstArgumentIndentation: {EnforcedStyle: "consistent"}
+Layout/FirstArrayElementIndentation: {EnforcedStyle: "consistent"}
+Layout/LineLength: {Enabled: true, Max: 120}
+Layout/MultilineOperationIndentation: {Enabled: false}
+Layout/SpaceAroundMethodCallOperator: {Enabled: true}
+Layout/SpaceBeforeBlockBraces: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#layoutspacebeforeblockbraces"}
+Layout/SpaceInsideParens: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#layoutspaceinsideparens"}
+Lint/AmbiguousRegexpLiteral: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#lintambiguousregexpliteral"}
+Lint/AssignmentInCondition: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#lintassignmentincondition"}
+Lint/DeprecatedOpenSSLConstant: {Enabled: true}
+Lint/MixedRegexpCaptureTypes: {Enabled: true}
+Lint/RaiseException: {Enabled: true}
+Lint/StructNewOverride: {Enabled: true}
+Metrics/AbcSize: {Enabled: false}
+Metrics/BlockLength: {Enabled: false}
+Metrics/BlockNesting: {Enabled: false}
+Metrics/ClassLength: {Enabled: false}
+Metrics/CyclomaticComplexity: {Enabled: false}
+Metrics/MethodLength: {Enabled: false}
+Metrics/ModuleLength: {Enabled: false}
+Metrics/ParameterLists: {Enabled: false}
+Metrics/PerceivedComplexity: {Enabled: false}
+Performance/AncestorsInclude: {Enabled: true}
+Performance/BigDecimalWithNumericArgument: {Enabled: true}
+Performance/RedundantSortBlock: {Enabled: true}
+Performance/RedundantStringChars: {Enabled: true}
+Performance/ReverseFirst: {Enabled: true}
+Performance/SortReverse: {Enabled: true}
+Performance/Squeeze: {Enabled: true}
+Performance/StringInclude: {Enabled: true}
+RSpec/DescribeClass: {Exclude: ["spec/features/**/*"]} # Feature specs are not describing any class or module.
+RSpec/ExampleLength: {Enabled: false}
+Style/AccessorGrouping: {Enabled: true}
+Style/Alias: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylealias"}
+Style/AsciiComments: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styleasciicomments"}
+Style/BeginBlock: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylebeginblock"}
+Style/BisectedAttrAccessor: {Enabled: true}
+Style/BlockDelimiters: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styleblockdelimiters"}
+Style/CommentAnnotation: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylecommentannotation"}
+Style/Documentation: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styledocumentation"}
+Style/DoubleNegation: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styledoublenegation"}
+Style/EndBlock: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styleendblock"}
+Style/ExponentialNotation: {Enabled: true}
+Style/FormatString: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styleformatstring"}
+Style/FrozenStringLiteralComment: {Exclude: ["spec/**/*", "db/migrate/**/*", "bin/**/*"]}
+Style/HashEachMethods: {Enabled: true}
+Style/HashTransformKeys: {Enabled: true}
+Style/HashTransformValues: {Enabled: true}
+Style/IfUnlessModifier: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styleifunlessmodifier"}
+Style/Lambda: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylelambda"}
+Style/ModuleFunction: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylemodulefunction"}
+Style/MultilineBlockChain: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylemultilineblockchain"}
+Style/NegatedIf: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylenegatedif"}
+Style/NegatedWhile: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylenegatedwhile"}
+Style/NumericPredicate: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylenumericpredicate"}
+Style/ParallelAssignment: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styleparallelassignment"}
+Style/PercentLiteralDelimiters: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylepercentliteraldelimiters"}
+Style/PerlBackrefs: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styleperlbackrefs"}
+Style/RedundantAssignment: {Enabled: true}
+Style/RedundantFetchBlock: {Enabled: true}
+Style/RedundantRegexpCharacterClass: {Enabled: true}
+Style/RedundantRegexpEscape: {Enabled: true}
+Style/Semicolon: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylesemicolon"}
+Style/SignalException: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylesignalexception"}
+Style/SingleLineBlockParams: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylesinglelineblockparams"}
+Style/SingleLineMethods: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylesinglelinemethods"}
+Style/SlicingWithRange: {Enabled: true}
+Style/SpecialGlobalVars: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylespecialglobalvars"}
+Style/StringLiterals: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylestringliterals"}
+Style/SymbolArray: {Enabled: false, StyleGuide: "http://relaxed.ruby.style/#stylesymbolarray"}
+Style/TrailingCommaInArguments: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styletrailingcommainarguments"}
+Style/TrailingCommaInArrayLiteral: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styletrailingcommainarrayliteral"}
+Style/TrailingCommaInHashLiteral: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#styletrailingcommainhashliteral"}
+Style/WhileUntilModifier: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylewhileuntilmodifier"}
+Style/WordArray: {Enabled: false, StyleGuide: "https://relaxed.ruby.style/#stylewordarray"}

data/lib/solidus_dev_support/solidus_command.rb

@@ -18,4 +18,3 @@ module SolidusDevSupport
     end
   end
 end
-

data/lib/solidus_dev_support/templates/extension/.circleci/config.yml

@@ -16,12 +16,18 @@ jobs:
     executor: solidusio_extensions/mysql
     steps:
       - solidusio_extensions/run-tests
+  lint-code:
+    executor: solidusio_extensions/sqlite-memory
+    steps:
+      - solidusio_extensions/lint-code
 
 workflows:
   "Run specs on supported Solidus versions":
     jobs:
       - run-specs-with-postgres
       - run-specs-with-mysql
+      - lint-code
+
   "Weekly run specs against master":
     triggers:
       - schedule:

data/lib/solidus_dev_support/templates/extension/README.md

@@ -1,6 +1,13 @@
-# <%= class_name %>
+# <%= class_name.gsub(/(?<=[^A-Z])([A-Z])/, ' \1') %>
 
-[Explain what your extension does.] 
+<!-- Replace REPO_ORG and uncomment the following to show badges for CI and coverage. -->
+
+<!--
+[![CircleCI](https://circleci.com/gh/REPO_ORG/<%= file_name %>.svg?style=shield)](https://circleci.com/gh/REPO_ORG/<%= file_name %>)
+[![codecov](https://codecov.io/gh/REPO_ORG/<%= file_name %>/branch/master/graph/badge.svg)](https://codecov.io/gh/REPO_ORG/<%= file_name %>)
+-->
+
+[Explain what your extension does.]
 
 ## Installation
 
@@ -13,8 +20,7 @@ gem '<%= file_name %>'
 Bundle your dependencies and run the installation generator:
 
 ```shell
-bundle
-bundle exec rails g <%= file_name %>:install
+bin/rails generate <%= file_name %>:install
 ```
 
 ## Usage
@@ -30,7 +36,6 @@ app if it does not exist, then it will run specs. The dummy app can be regenerat
 `bin/rake extension:test_app`.
 
 ```shell
-bundle
 bin/rake
 ```
 
@@ -55,7 +60,7 @@ the sandbox app is `./sandbox` and `bin/rails` will forward any Rails commands t
 
 Here's an example:
 
-```shell
+```
 $ bin/rails server
 => Booting Puma
 => Rails 6.0.2.1 application starting in development
@@ -63,12 +68,23 @@ $ bin/rails server
 Use Ctrl-C to stop
 ```
 
+### Updating the changelog
+
+Before and after releases the changelog should be updated to reflect the up-to-date status of
+the project:
+
+```shell
+bin/rake changelog
+git add CHANGELOG.md
+git commit -m "Update the changelog"
+```
+
 ### Releasing new versions
 
 Your new extension version can be released using `gem-release` like this:
 
 ```shell
-bundle exec gem bump -v VERSION --tag --push --remote upstream && gem release
+bundle exec gem bump -v VERSION --tag --push --remote origin && gem release
 ```
 
 ## License

data/lib/solidus_dev_support/templates/extension/bin/rails-sandbox

@@ -5,7 +5,7 @@ app_root = 'sandbox'
 unless File.exist? "#{app_root}/bin/rails"
   warn 'Creating the sandbox app...'
   Dir.chdir "#{__dir__}/.." do
-    system "#{__dir__}/sandbox" or begin # rubocop:disable Style/AndOr
+    system "#{__dir__}/sandbox" or begin
       warn 'Automatic creation of the sandbox app failed'
       exit 1
     end

data/lib/solidus_dev_support/templates/extension/bin/sandbox.tt

@@ -72,9 +72,11 @@ unbundled bundle exec rails generate spree:install \
   --user_class=Spree::User \
   --enforce_available_locales=true \
   --with-authentication=false \
+  --payment-method=none
   $@
 
 unbundled bundle exec rails generate solidus:auth:install
+unbundled bundle exec rails generate ${extension_name}:install
 
 echo
 echo "🚀 Sandbox app successfully created for $extension_name!"

data/lib/solidus_dev_support/templates/extension/lib/generators/%file_name%/install/install_generator.rb.tt

@@ -6,13 +6,13 @@ module <%= class_name %>
       class_option :auto_run_migrations, type: :boolean, default: false
 
       def add_javascripts
-        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/<%= file_name %>\n" # rubocop:disable Metrics/LineLength
-        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/<%= file_name %>\n" # rubocop:disable Metrics/LineLength
+        append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/<%= file_name %>\n"
+        append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/<%= file_name %>\n"
       end
 
       def add_stylesheets
-        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/<%= file_name %>\n", before: %r{\*/}, verbose: true # rubocop:disable Metrics/LineLength
-        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/<%= file_name %>\n", before: %r{\*/}, verbose: true # rubocop:disable Metrics/LineLength
+        inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/<%= file_name %>\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
+        inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/<%= file_name %>\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
       end
 
       def add_migrations
@@ -20,7 +20,7 @@ module <%= class_name %>
       end
 
       def run_migrations
-        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Metrics/LineLength
+        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]')) # rubocop:disable Layout/LineLength
         if run_migrations
           run 'bin/rails db:migrate'
         else

data/lib/solidus_dev_support/templates/extension/spec/spec_helper.rb.tt

@@ -6,17 +6,17 @@ ENV['RAILS_ENV'] = 'test'
 # Run Coverage report
 require 'solidus_dev_support/rspec/coverage'
 
-require File.expand_path('dummy/config/environment.rb', __dir__).tap { |file|
-  # Create the dummy app if it's still missing.
-  system 'bin/rake extension:test_app' unless File.exist? file
-}
+# Create the dummy app if it's still missing.
+dummy_env = "#{__dir__}/dummy/config/environment.rb"
+system 'bin/rake extension:test_app' unless File.exist? dummy_env
+require dummy_env
 
 # Requires factories and other useful helpers defined in spree_core.
 require 'solidus_dev_support/rspec/feature_helper'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }
 
 # Requires factories defined in lib/<%= file_name %>/factories.rb
 require '<%= file_name %>/factories'
@@ -24,4 +24,8 @@ require '<%= file_name %>/factories'
 RSpec.configure do |config|
   config.infer_spec_type_from_file_location!
   config.use_transactional_fixtures = false
+
+  if Spree.solidus_gem_version < Gem::Version.new('2.11')
+    config.extend Spree::TestingSupport::AuthorizationHelpers::Request, type: :system
+  end
 end

data/lib/solidus_dev_support/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusDevSupport
-  VERSION = "1.5.0"
+  VERSION = "1.6.0"
 end

data/solidus_dev_support.gemspec

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'solidus_dev_support/version'
+require_relative 'lib/solidus_dev_support/version'
 
 Gem::Specification.new do |spec|
   spec.name = 'solidus_dev_support'
@@ -16,29 +14,33 @@ Gem::Specification.new do |spec|
 
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'https://github.com/solidusio/solidus_dev_support'
+  spec.metadata['changelog_uri'] = 'https://github.com/solidusio/solidus_dev_support/blob/master/CHANGELOG.md'
+
+  spec.required_ruby_version = Gem::Requirement.new('~> 2.5')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  end
-  spec.bindir = 'exe'
-  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ['lib']
+  files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0") }
+
+  spec.files = files.grep_v(%r{^(test|spec|features)/})
+  spec.test_files = files.grep(%r{^(test|spec|features)/})
+  spec.bindir = "exe"
+  spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
 
   spec.add_dependency 'apparition', '~> 0.4'
   spec.add_dependency 'capybara', '~> 3.29'
   spec.add_dependency 'capybara-screenshot', '~> 1.0'
-  spec.add_dependency 'codecov', '~> 0.1.16'
+  spec.add_dependency 'codecov', '~> 0.2'
   spec.add_dependency 'database_cleaner', '~> 1.7'
   spec.add_dependency 'factory_bot_rails', '~> 5.1'
   spec.add_dependency 'ffaker', '~> 2.13'
   spec.add_dependency 'gem-release', '~> 2.1'
   spec.add_dependency 'github_changelog_generator', '~> 1.15'
   spec.add_dependency 'puma', '~> 4.3'
-  spec.add_dependency 'rspec-rails', '~> 4.0.0.beta3'
   spec.add_dependency 'rspec_junit_formatter'
-  spec.add_dependency 'rubocop', '~> 0.76.0'
+  spec.add_dependency 'rspec-rails', '~> 4.0.0.beta3'
+  spec.add_dependency 'rubocop', '~> 0.87.1'
   spec.add_dependency 'rubocop-performance', '~> 1.5'
   spec.add_dependency 'rubocop-rails', '~> 2.3'
   spec.add_dependency 'rubocop-rspec', '~> 1.36'

data/spec/features/create_extension_spec.rb

@@ -0,0 +1,166 @@
+# frozen_string_literal: true
+
+require 'fileutils'
+require 'open3'
+require 'spec_helper'
+
+RSpec.describe 'Create extension' do
+  include FileUtils
+
+  let(:gem_root) { File.expand_path('../..', __dir__) }
+  let(:solidus_cmd) { "#{gem_root}/exe/solidus" }
+  let(:extension_name) { 'test_extension' }
+  let(:gemspec_name) { "solidus_#{extension_name}.gemspec" }
+  let(:tmp_path) { Pathname.new(gem_root).join('tmp') }
+  let(:install_path) { tmp_path.join("solidus_#{extension_name}") }
+
+  class CommandFailed < StandardError; end
+
+  before do
+    rm_rf(install_path)
+    mkdir_p(tmp_path)
+  end
+
+  it 'checks the create extension process' do
+    check_solidus_cmd
+    check_create_extension
+    check_bundle_install
+    check_default_task
+    check_run_specs
+    check_sandbox
+  end
+
+  private
+
+  def check_solidus_cmd
+    cd(tmp_path) do
+      output = `#{solidus_cmd} -h`
+      expect($?).to be_success
+      expect(output).to include('Commands:')
+    end
+  end
+
+  def check_create_extension
+    cd(tmp_path) do
+      output = `#{solidus_cmd} extension #{extension_name}`
+      expect($?).to be_success
+      expect(output).to include(gemspec_name)
+      expect(output).to include('.circleci')
+    end
+
+    cd(install_path) do
+      aggregate_failures do
+        %w[
+          bin/console
+          bin/rails
+          bin/rails-engine
+          bin/rails-sandbox
+          bin/sandbox
+          bin/setup
+        ].each do |bin|
+          bin = Pathname(bin)
+          expect(
+            name: bin,
+            exist: bin.exist?,
+            executable: bin.stat.executable?
+          ).to eq(
+            name: bin,
+            exist: true,
+            executable: true
+          )
+        end
+      end
+    end
+  end
+
+  def check_bundle_install
+    cd(install_path) do
+      open('Gemfile', 'a') { |f| f.puts "gem 'solidus_dev_support', path: '../../..'" }
+    end
+
+    expect { bundle_install }.to raise_error(CommandFailed, /invalid gemspec/)
+
+    # Update gemspec with the required fields
+    gemspec_path = install_path.join(gemspec_name)
+    gemspec = gemspec_path.read.lines
+    gemspec.grep(/spec\.author/).first.replace("  spec.author = 'John Doe'\n")
+    gemspec.grep(/spec\.email/).first.replace("  spec.email = 'john@example.com'\n")
+    gemspec.grep(/spec\.summary/).first.replace("  spec.summary = 'A nice extension'\n")
+    gemspec.grep(/spec\.description/).first.replace("  spec.description = 'A super nice extension'\n")
+    gemspec_path.write(gemspec.join)
+
+    expect(bundle_install).to match(/Bundle complete/)
+  end
+
+  def check_default_task
+    cd(install_path) do
+      output = sh('bin/rake')
+      expect(output).to include('Generating dummy Rails application')
+      expect(output).to include('0 examples, 0 failures')
+    end
+  end
+
+  def check_run_specs
+    install_path.join('spec', 'some_spec.rb').write(
+      "require 'spec_helper'\nRSpec.describe 'Some test' do it { expect(true).to be_truthy } end\n"
+    )
+    cd(install_path) do
+      output = sh('bundle exec rspec')
+      expect(output).to include('1 example, 0 failures')
+      expect(output).to include(ENV['CODECOV_TOKEN'] ? 'Coverage reports upload successfully' : 'Provide a CODECOV_TOKEN environment variable to enable Codecov uploads')
+    end
+  end
+
+  def check_sandbox
+    cd(install_path) do
+      # rubocop:disable Lint/InterpolationCheck
+      command = 'bin/rails-sandbox runner "puts %{The version of SolidusTestExtension is #{SolidusTestExtension::VERSION}}"'
+      # rubocop:enable Lint/InterpolationCheck
+
+      first_run_output = sh(command)
+      expect(first_run_output).to include("Creating the sandbox app...")
+      expect(first_run_output).to include('The version of SolidusTestExtension is 0.0.1')
+
+      second_run_output = sh(command)
+      expect(second_run_output).not_to include("Creating the sandbox app...")
+      expect(second_run_output).to include('The version of SolidusTestExtension is 0.0.1')
+    end
+  end
+
+  def sh(*args)
+    command = args.size == 1 ? args.first : args.shelljoin
+    output, status = with_unbundled_env { Open3.capture2e(command) }
+
+    if status.success?
+      output.to_s
+    else
+      if $DEBUG
+        warn '~' * 80
+        warn "$ #{command}"
+        warn output.to_s
+      end
+      raise(CommandFailed, "command failed: #{command}\n#{output}")
+    end
+  end
+
+  def with_unbundled_env(&block)
+    if Bundler.respond_to?(:with_unbundled_env)
+      Bundler.with_unbundled_env(&block)
+    else
+      Bundler.with_clean_env(&block)
+    end
+  end
+
+  def bundle_install
+    # Optimize the bundle path within the CI, in this context using bundler env
+    # variables doesn't help because commands are run with a clean env.
+    bundle_path = "#{gem_root}/vendor/bundle"
+
+    command = 'bundle install'
+    command += " --path=#{bundle_path.shellescape}" if File.exist?(bundle_path)
+
+    output = nil
+    cd(install_path) { output = sh command }
+    output
+  end
+end

data/spec/lib/extension_spec.rb

@@ -0,0 +1,33 @@
+require 'solidus_dev_support/extension'
+
+RSpec.describe SolidusDevSupport::Extension do
+  describe '#default_homepage' do
+    before do
+      expect(subject).to receive(:git).with('remote get-url origin', any_args).and_return(remote)
+      expect(subject).to receive(:github_user).and_return('[USERNAME]')
+      expect(subject).to receive(:file_name).and_return('solidus_foo_bar')
+    end
+
+    context 'with a git ssh-style remote' do
+      let(:remote) { 'git@github.com:solidusio-contrib/solidus_extension_dev_tools.git' }
+
+      it 'generates a github home page value' do
+        expect(subject.default_homepage).to eq('https://github.com/solidusio-contrib/solidus_extension_dev_tools')
+      end
+    end
+
+    context 'with a git https remote' do
+      let(:remote) { 'https://github.com/solidusio-contrib/solidus_extension_dev_tools.git' }
+
+      it 'generates a github home page value' do
+        expect(subject.default_homepage).to eq('https://github.com/solidusio-contrib/solidus_extension_dev_tools')
+      end
+    end
+  end
+
+  describe '#default_gemspec' do
+    it 'has a changelog_uri' do
+      expect(subject.default_gemspec.metadata['changelog_uri']).to end_with('/releases')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "bundler/setup"
+require "solidus_dev_support"
+
+RSpec.configure do |config|
+  # Enable flags like --only-failures and --next-failure
+  config.example_status_persistence_file_path = ".rspec_status"
+
+  # Disable RSpec exposing methods globally on `Module` and `main`
+  config.disable_monkey_patching!
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_dev_support
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - Alessandro Desantis
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-06-13 00:00:00.000000000 Z
+date: 2020-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: apparition
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.16
+        version: '0.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.16
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
@@ -151,47 +151,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4.3'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta3
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta3
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec_junit_formatter
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0.beta3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.0.0.beta3
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.76.0
+        version: 0.87.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.76.0
+        version: 0.87.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -354,29 +354,36 @@ files:
 - lib/solidus_dev_support/testing_support/preferences.rb
 - lib/solidus_dev_support/version.rb
 - solidus_dev_support.gemspec
+- spec/features/create_extension_spec.rb
+- spec/lib/extension_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/solidusio/solidus_dev_support
 licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/solidusio/solidus_dev_support
   source_code_uri: https://github.com/solidusio/solidus_dev_support
+  changelog_uri: https://github.com/solidusio/solidus_dev_support/blob/master/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Development tools for Solidus extensions.
-test_files: []
+test_files:
+- spec/features/create_extension_spec.rb
+- spec/lib/extension_spec.rb
+- spec/spec_helper.rb