solidus_dev_support 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57982502f6b6cda3d014e241f319db1a59e5fb7c5b108d5c41e60e2458ce7fe3
-  data.tar.gz: 4a738944d3d5fa4789ea68c372f861a0665c0ad9347cb9bda11195b4dcf3c451
+  metadata.gz: e564494d205d3ad1b785d19a2755125c0b22ddae03f485ae2ff136ed6a84fbcf
+  data.tar.gz: 9f6d4d0d80bcc84c14e0c49ae6d8aff768a41318a08b22281923b670ac2c8e60
 SHA512:
-  metadata.gz: 65cf8c5ebb47608aaeb7aab52823d7ad8ccec81697ad922144880a971ffea891442cc1fa584b1311df120fc85e762ae06f90a1849083f0058f05c5026336f3b9
-  data.tar.gz: f013f6ee048e65a40be05b330e7472fb934c1a14a345efd7319466e976681daba40425b0723356f5f95b3ce0f1ebb65183a8397c7e3afa544b96c5741f830b7e
+  metadata.gz: eeac780a3f6da8740951d1798c1543b6bc4a7def6b9ec5841ccd7600163f5c08c52d26bc5606d006f723666c68f74c78eac71eb6f63830354f736445f4418e9d
+  data.tar.gz: aa0b8514fac3724ab7272af5fe2675ef9eb1aa1d859b8b2ebaf20616efbfad948b3b3a069ed7f553b34310691c2739b675759311167b971f644f894cacab47db

data/.mergify.yml

@@ -0,0 +1,7 @@
+pull_request_rules:
+  - name: automatic merge when GitHub branch protection passes on master
+    conditions:
+      - base=master
+    actions:
+      merge:
+        method: merge

data/CHANGELOG.md

@@ -7,6 +7,30 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [1.3.0]
+
+### Added
+
+- Ignored `.rvmrc`, `.ruby-version` and `.ruby-gemset` by default in extensions
+- Added deprecation warning when extensions don't support Zeitwerk
+
+### Changed
+
+- Updated the extension template to use latest (0.5.X) solidus_support
+- Set Ruby 2.5+ as the minimum Ruby version in generated extensions
+
+### Removed
+
+- Removed Stale from the default extension configuration
+
+## [1.2.0]
+
+### Changed
+
+- Updated the extension template with the latest modifications
+
+## [1.1.0]
+
 ### Added
 
 - Made Git ignore `sandbox` in generated extensions
@@ -15,8 +39,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 ### Changed
 
 - Split `bin/rails` into `bin/r` and `bin/sandbox_rails`
-- Updated the extension template with the latest modifications
- 
+
+
 ### Fixed
 
 - Fixed the sandbox Gemfile not including Solidus
@@ -152,7 +176,10 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 Initial release.
 
-[Unreleased]: https://github.com/solidusio/solidus_dev_support/compare/v1.0.1...HEAD
+[Unreleased]: https://github.com/solidusio/solidus_dev_support/compare/v1.3.0...HEAD
+[1.3.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.2.0...v1.3.0
+[1.2.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.1.0...v1.2.0
+[1.1.0]: https://github.com/solidusio/solidus_dev_support/compare/v1.0.1...v1.1.0
 [1.0.1]: https://github.com/solidusio/solidus_dev_support/compare/v1.0.0...v1.0.1
 [1.0.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.6.0...v1.0.0
 [0.6.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.5.0...v0.6.0

data/lib/solidus_dev_support/rspec/rails_helper.rb

@@ -59,4 +59,29 @@ RSpec.configure do |config|
   end
 
   config.include ActiveJob::TestHelper
+
+  config.after(:suite) do
+    if Rails.respond_to?(:autoloaders) && Rails.autoloaders.zeitwerk_enabled?
+      Rails.autoloaders.main.class.eager_load_all
+    end
+  rescue NameError => e
+    class ZeitwerkNameError < NameError; end
+
+    message = <<~WARN
+      Zeitwerk raised the following error when trying to eager load your extension:
+
+      #{if e.message =~ /expected file .*? to define constant [\w:]+/
+        e.message.sub(/expected file #{Regexp.escape(File.expand_path('../..', Rails.root))}./, "expected file ")
+      else
+        e.message
+      end}
+
+      This most likely means that your extension's file structure is not
+      compatible with the Zeitwerk autoloader.
+      Refer to https://github.com/solidusio/solidus_support#engine-extensions in
+      order to update the file structure to match Zeitwerk's expectations.
+    WARN
+
+    raise ZeitwerkNameError, message
+  end
 end

data/lib/solidus_dev_support/rubocop/config.yml

@@ -180,7 +180,7 @@ require:
   - rubocop-performance
 
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
   Exclude:
     - spec/dummy/**/*
     - vendor/**/*

data/lib/solidus_dev_support/templates/extension/extension.gemspec.tt

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri'] = '<%= gemspec.homepage %>'
   spec.metadata['changelog_uri'] = '<%= gemspec.metadata["changelog_uri"] %>'
 
-  spec.required_ruby_version = Gem::Requirement.new('~> 2.4')
+  spec.required_ruby_version = Gem::Requirement.new('~> 2.5')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 3']
-  spec.add_dependency 'solidus_support', '~> 0.4.0'
+  spec.add_dependency 'solidus_support', '~> 0.5'
 
   spec.add_development_dependency 'solidus_dev_support'
 end

data/lib/solidus_dev_support/templates/extension/gitignore

@@ -15,3 +15,6 @@ pkg
 spec/dummy
 spec/examples.txt
 /sandbox
+.rvmrc
+.ruby-version
+.ruby-gemset

data/lib/solidus_dev_support/templates/extension/spec/spec_helper.rb.tt

@@ -6,7 +6,10 @@ ENV['RAILS_ENV'] = 'test'
 # Run Coverage report
 require 'solidus_dev_support/rspec/coverage'
 
-require File.expand_path('dummy/config/environment.rb', __dir__)
+require File.expand_path('dummy/config/environment.rb', __dir__).tap { |file|
+  # Create the dummy app if it's still missing.
+  system 'bin/rake extension:test_app' unless File.exist? file
+}
 
 # Requires factories and other useful helpers defined in spree_core.
 require 'solidus_dev_support/rspec/feature_helper'

data/lib/solidus_dev_support/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusDevSupport
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_dev_support
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Alessandro Desantis
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-24 00:00:00.000000000 Z
+date: 2020-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: apparition
@@ -293,8 +293,8 @@ files:
 - ".circleci/config.yml"
 - ".gem_release.yml"
 - ".github/PULL_REQUEST_TEMPLATE.md"
-- ".github/stale.yml"
 - ".gitignore"
+- ".mergify.yml"
 - ".rspec"
 - ".rubocop-https---relaxed-ruby-style-rubocop-yml"
 - ".rubocop.yml"

data/.github/stale.yml

@@ -1,17 +0,0 @@
-# Number of days of inactivity before an issue becomes stale
-daysUntilStale: 60
-# Number of days of inactivity before a stale issue is closed
-daysUntilClose: 7
-# Issues with these labels will never be considered stale
-exemptLabels:
-  - pinned
-  - security
-# Label to use when marking an issue as stale
-staleLabel: wontfix
-# Comment to post when marking an issue as stale. Set to `false` to disable
-markComment: >
-  This issue has been automatically marked as stale because it has not had
-  recent activity. It will be closed if no further activity occurs. Thank you
-  for your contributions.
-# Comment to post when closing a stale issue. Set to `false` to disable
-closeComment: false