solidus_dev_support 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22dbc17966230ac110fc0129505cbda25986817faa51629c7b0a68455dc893f5
-  data.tar.gz: edd55039b0d7d67f84ef65ef20979e935c3705cd599e5a9b88f1f388f6d6b070
+  metadata.gz: 4fe993c357db63da319ab7b482eabd1ab7ceedf0a1f83d1f851f4eda2a195b4a
+  data.tar.gz: 0b63c3d1e43bd550057bfa6e713dd995626f97f69ed319dd8b331f3391e08557
 SHA512:
-  metadata.gz: 8ce7fb47313fa68bcd1a3d53244cf45f878f164d0cf3d4f4a637326d9ffd11b4762c9a8b4baa0268e9303ad3b8ee7fd6d2a217b1a0b30783e22e37e64d2bb88f
-  data.tar.gz: 2b4e414288b002b2ad832a5284632ae819fd54e04ac8a870993ceb2bd1dc427b2f6736554963259f1e73e4de5aceb05d6d9a5931928a030f3ba3405c86e78093
+  metadata.gz: a021a1a433d58aafba6b5e795e190a6d16cbe58f10a11906a4a0039faa6bf80e3cab2819091e85df725e53c623689e7e5ef5e4e8af82c5865cb7fcd1f8153b2c
+  data.tar.gz: 5bc26377586f11f2ac750251adf044aa62c11be97b9edb2037ae4463cbd3be080bcb8418571ae9c0b5321f3273739310ab3678a10c9f48349db6880e84e8929a

data/.gitignore

@@ -7,7 +7,8 @@
 /spec/reports/
 /tmp/
 /vendor/bundle/
-Gemfile.lock
+/Gemfile.lock
+/Gemfile-local*
 
 # rspec failure tracking
 .rspec_status

data/CHANGELOG.md

@@ -7,6 +7,22 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [0.6.0] - 2020-01-20
+
+### Added
+
+- Added support for a local Gemfile for local development dependencies (e.g. 'pry-debug')
+
+### Changed
+
+- The default rake task no longer re-generates the `test_app` each time it runs.
+  In order to get that behavior back simply call clobber before launching it:
+  `bin/rake clobber default`
+
+### Fixed
+
+- Fixed generated extensions isolating the wrong namespace
+
 ## [0.5.0] - 2020-01-16
 
 ### Added
@@ -104,7 +120,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 Initial release.
 
-[Unreleased]: https://github.com/solidusio/solidus_dev_support/compare/v0.5.0...HEAD
+[Unreleased]: https://github.com/solidusio/solidus_dev_support/compare/v0.6.0...HEAD
+[0.6.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.5.0...v0.6.0
 [0.5.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.4.1...v0.5.0
 [0.4.1]: https://github.com/solidusio/solidus_dev_support/compare/v0.4.0...v0.4.1
 [0.4.0]: https://github.com/solidusio/solidus_dev_support/compare/v0.3.0...v0.4.0

data/Gemfile

@@ -21,3 +21,7 @@ group :test do
   gem 'pg'
   gem 'sqlite3'
 end
+
+# Use a local Gemfile to include development dependencies that might not be
+# relevant for the project or for other contributors, e.g.: `gem 'pry-debug'`.
+eval_gemfile 'Gemfile-local' if File.exist? 'Gemfile-local'

data/README.md

@@ -34,6 +34,19 @@ $ solidus extension my_awesome_extension
 This will generate the basic extension structure, already configured to use all the shiny helpers
 in solidus_dev_support.
 
+#### Updating existing extensions
+
+If you have an existing extension and want to update it to use the latest standards from this gem,
+you can run the following in the extension's directory:
+
+```console
+$ solidus extension .
+```
+
+In case of conflicting files, you will be prompted for an action. You can overwrite the files with
+the new version, keep the current version or view the diff and only apply the adjustments that make
+sense to you.
+
 ### RSpec helpers
 
 This gem provides some useful helpers for RSpec to setup an extension's test environment easily.
@@ -123,15 +136,16 @@ releases for your gem.
 For instance, you can run the following to release a new minor version:
 
 ```console
-$ gem bump --version minor --tag --release
+$ gem bump -v minor -r
 ```
 
 The above command will:
 
-* bump the gem version to the next minor;
-* commit the change and push it to `upstream/master`;
+* bump the gem version to the next minor (you can also use `patch`, `major` or a specific version
+  number);
+* commit the change and push it to `origin/master`;
 * create a Git tag;
-* push the tag to the `upstream` remote;
+* push the tag to the `origin` remote;
 * release the new version on RubyGems.
 
 You can refer to
@@ -146,7 +160,7 @@ To install extension-related Rake tasks, add this to your `Rakefile`:
 require 'solidus_dev_support/rake_tasks'
 SolidusDevSupport::RakeTasks.install
 
-task default: %w[extension:test_app extension:specs]
+task default: 'extension:specs'
 ```
 
 (If your extension used the legacy extension Rakefile, then you should completely replace its
@@ -157,7 +171,11 @@ This will provide the following tasks:
 - `extension:test_app`, which generates a dummy app for your extension
 - `extension:specs` (default), which runs the specs for your extension
 
-It also allows you to run `rake` to, respectively, generate a test app and run all tests.
+If your extension requires the `test_app` to be always recreated you can do so by running:
+
+```rb
+bundle exec rake extension:test_app extension:specs
+```
 
 ## Development
 

data/lib/solidus_dev_support/rake_tasks.rb

@@ -34,10 +34,16 @@ module SolidusDevSupport
       ::CLOBBER.include test_app_path
 
       namespace :extension do
+        # We need to go back to the gem root since the upstream
+        # extension:test_app changes the working directory to be the dummy app.
         task :test_app do
           Rake::Task['extension:test_app'].invoke
           cd root
         end
+
+        directory ENV['DUMMY_PATH'] do
+          Rake::Task['extension:test_app'].invoke
+        end
       end
     end
 

data/lib/solidus_dev_support/templates/extension/Gemfile

@@ -24,3 +24,7 @@ else
 end
 
 gemspec
+
+# Use a local Gemfile to include development dependencies that might not be
+# relevant for the project or for other contributors, e.g.: `gem 'pry-debug'`.
+eval_gemfile 'Gemfile-local' if File.exist? 'Gemfile-local'

data/lib/solidus_dev_support/templates/extension/Rakefile

@@ -3,4 +3,4 @@
 require 'solidus_dev_support/rake_tasks'
 SolidusDevSupport::RakeTasks.install
 
-task default: %w[extension:test_app extension:specs]
+task default: 'extension:specs'

data/lib/solidus_dev_support/templates/extension/bin/setup

@@ -5,4 +5,4 @@ set -vx
 
 gem install bundler --conservative
 bundle update
-bundle exec rake extension:test_app
+bundle exec rake clobber

data/lib/solidus_dev_support/templates/extension/lib/%file_name%/engine.rb.tt

@@ -6,7 +6,7 @@ module <%= class_name %>
   class Engine < Rails::Engine
     include SolidusSupport::EngineExtensions::Decorators
 
-    isolate_namespace Spree
+    isolate_namespace ::Spree
 
     engine_name '<%= file_name %>'
 

data/lib/solidus_dev_support/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusDevSupport
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_dev_support
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Alessandro Desantis
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-16 00:00:00.000000000 Z
+date: 2020-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: apparition