solidus_core 1.4.0.beta1 → 1.4.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8aa4c3e58ebb0c1418f96f55061e429329292ed3
-  data.tar.gz: 90e3439877e5e1632c288d009a442a05bce4631d
+  metadata.gz: c5889aa9a1d498a6573bfefa369fb4530f98b69c
+  data.tar.gz: e3e60915860a0ae80dc0e2a1c728ca5754d1017c
 SHA512:
-  metadata.gz: cc8e9cba50b0b5eb46b7305513e28e395194d01f4b8304d1929eff3bf2db019d8f6b683691df073890aaf955946a3fdd7bf57d5e935c91c403f2dd68d9dd4488
-  data.tar.gz: 4b98fa39ceb46b0ccf5c85163bf1fc778f6641eafe8d2e99dd8a249b0657d5232ff74fc025593e3cb14c1ff40b430dc666896d666fd60e7733d404444eac2d05
+  metadata.gz: 920ce1f524585315b5133505ab449cb7cbfb74d1d100adfc222238cbde476c7b1da389e0683c359e8679b7409bd50bd46490f4f06175f9dc29471e7b0f899cea
+  data.tar.gz: 48cbf7e4f562469a4ee959bf83afd94dcbc2ea09b784677dea321bf0ef8b996d21b83a4214987518ba87c7f94035667a8d8ed08c544ad775232148a9ddc84222

data/app/models/spree/adjustment.rb

@@ -26,6 +26,11 @@ module Spree
     validates :amount, numericality: true
     validates :promotion_code, presence: true, if: :require_promotion_code?
 
+    # We need to use `after_commit` here because otherwise it's too early to
+    # tell if any repair is needed.
+    after_commit :repair_adjustments_associations_on_create, on: [:create]
+    after_commit :repair_adjustments_associations_on_destroy, on: [:destroy]
+
     scope :not_finalized, -> { where(finalized: false) }
     scope :open, -> do
       Spree::Deprecation.warn "Adjustment.open is deprecated. Instead use Adjustment.not_finalized", caller
@@ -177,5 +182,19 @@ module Spree
     def require_promotion_code?
       promotion? && source.promotion.codes.any?
     end
+
+    def repair_adjustments_associations_on_create
+      if adjustable.adjustments.loaded? && !adjustable.adjustments.include?(self)
+        Spree::Deprecation.warn("Adjustment was not added to #{adjustable.class}. Add adjustments via `adjustable.adjustments.create!`. Partial call stack: #{caller.select { |line| line =~ %r(/(app|spec)/) }}.", caller)
+        adjustable.adjustments.proxy_association.add_to_target(self)
+      end
+    end
+
+    def repair_adjustments_associations_on_destroy
+      if adjustable.adjustments.loaded? && adjustable.adjustments.include?(self)
+        Spree::Deprecation.warn("Adjustment was not removed from #{adjustable.class}. Remove adjustments via `adjustable.adjustments.destroy`. Partial call stack: #{caller.select { |line| line =~ %r(/(app|spec)/) }}.", caller)
+        adjustable.adjustments.proxy_association.target.delete(self)
+      end
+    end
   end
 end

data/app/models/spree/item_adjustments.rb

@@ -83,11 +83,7 @@ module Spree
     private
 
     def adjustments
-      # This is done intentionally to avoid loading the association. If the
-      # association is loaded, the records may become stale due to code
-      # elsewhere in spree. When that is remedied, this should be changed to
-      # just item.adjustments
-      @adjustments ||= item.adjustments.all.to_a
+      @adjustments ||= item.adjustments.to_a
     end
   end
 end

data/app/models/spree/order.rb

@@ -47,7 +47,7 @@ module Spree
     belongs_to :store, class_name: 'Spree::Store'
     has_many :state_changes, as: :stateful
     has_many :line_items, -> { order(:created_at, :id) }, dependent: :destroy, inverse_of: :order
-    has_many :payments, dependent: :destroy
+    has_many :payments, dependent: :destroy, inverse_of: :order
     has_many :return_authorizations, dependent: :destroy, inverse_of: :order
     has_many :reimbursements, inverse_of: :order
     has_many :adjustments, -> { order(:created_at) }, as: :adjustable, inverse_of: :adjustable, dependent: :destroy
@@ -503,7 +503,6 @@ module Spree
       elsif shipments.any? { |s| !s.pending? }
         raise CannotRebuildShipments.new(Spree.t(:cannot_rebuild_shipments_shipments_not_pending))
       else
-        adjustments.shipping.destroy_all
         shipments.destroy_all
         self.shipments = Spree::Config.stock.coordinator_class.new(self).shipments
       end
@@ -511,9 +510,7 @@ module Spree
 
     def apply_free_shipping_promotions
       Spree::PromotionHandler::FreeShipping.new(self).activate
-      shipments.each { |shipment| ItemAdjustments.new(shipment).update }
-      updater.update_shipment_total
-      persist_totals
+      update!
     end
 
     # Clean shipments and make order back to address state

data/app/models/spree/order/payments.rb

@@ -43,10 +43,6 @@ module Spree
           break if payment_total >= total
 
           payment.public_send(method)
-
-          if payment.completed?
-            self.payment_total += payment.amount
-          end
         end
       rescue Core::GatewayError => e
         result = !!Spree::Config[:allow_checkout_on_gateway_error]

data/app/models/spree/order_capturing.rb

@@ -21,22 +21,15 @@ class Spree::OrderCapturing
     Spree::OrderMutex.with_lock!(@order) do
       uncaptured_amount = @order.display_total.cents
 
-      begin
-        sorted_payments(@order).each do |payment|
-          amount = [uncaptured_amount, payment.money.cents].min
-
-          if amount > 0
-            payment.capture!(amount)
-            uncaptured_amount -= amount
-          elsif Spree::OrderCapturing.void_unused_payments
-            payment.void_transaction!
-          end
+      sorted_payments(@order).each do |payment|
+        amount = [uncaptured_amount, payment.money.cents].min
+
+        if amount > 0
+          payment.capture!(amount)
+          uncaptured_amount -= amount
+        elsif Spree::OrderCapturing.void_unused_payments
+          payment.void_transaction!
         end
-      ensure
-        # FIXME: Adding the inverse_of on the payments relation for orders -should- fix this,
-        # however it only appears to make it worse (calling with changes three times instead of once.
-        # Warrants an investigation. Reloading for now.
-        @order.reload.update!
       end
     end
   end

data/app/models/spree/order_contents.rb

@@ -119,7 +119,6 @@ module Spree
       shipment = options[:shipment]
       shipment.present? ? shipment.update_amounts : order.ensure_updated_shipments
       PromotionHandler::Cart.new(order, line_item).activate
-      ItemAdjustments.new(line_item).update
       reload_totals
       line_item
     end

data/app/models/spree/order_updater.rb

@@ -80,11 +80,11 @@ module Spree
 
       all_items = line_items + shipments
 
-      order.adjustment_total = all_items.sum(&:adjustment_total) + adjustments.eligible.sum(:amount)
+      order.adjustment_total = all_items.sum(&:adjustment_total) + adjustments.select(&:eligible?).sum(&:amount)
       order.included_tax_total = all_items.sum(&:included_tax_total)
       order.additional_tax_total = all_items.sum(&:additional_tax_total)
 
-      order.promo_total = all_items.sum(&:promo_total) + adjustments.promotion.eligible.sum(:amount)
+      order.promo_total = all_items.sum(&:promo_total) + adjustments.select(&:eligible?).select(&:promotion?).sum(&:amount)
 
       update_order_total
     end

data/app/models/spree/promotion/actions/create_adjustment.rb

@@ -22,10 +22,9 @@ module Spree
           return if promotion_credit_exists?(order)
 
           amount = compute_amount(order)
-          Spree::Adjustment.create!(
+          order.adjustments.create!(
             amount: amount,
             order: order,
-            adjustable: order,
             source: self,
             promotion_code: options[:promotion_code],
             label: "#{Spree.t(:promotion)} (#{promotion.name})"

data/app/models/spree/promotion/actions/create_item_adjustments.rb

@@ -40,9 +40,9 @@ module Spree
         def create_adjustment(adjustable, order, promotion_code)
           amount = compute_amount(adjustable)
           return if amount == 0
-          adjustments.create!(
+          adjustable.adjustments.create!(
+            source: self,
             amount: amount,
-            adjustable: adjustable,
             order: order,
             promotion_code: promotion_code,
             label: "#{Spree.t(:promotion)} (#{promotion.name})"

data/app/models/spree/tax/item_adjuster.rb

@@ -15,7 +15,6 @@ module Spree
         @rates_for_order_zone = options[:rates_for_order_zone]
         @rates_for_default_zone = options[:rates_for_default_zone]
         @order_tax_zone = options[:order_tax_zone]
-        @skip_destroy_adjustments = options[:skip_destroy_adjustments]
       end
 
       # Deletes all existing tax adjustments and creates new adjustments for all
@@ -27,8 +26,8 @@ module Spree
       # @return [Array<Spree::Adjustment>] newly created adjustments
       def adjust!
         return unless order_tax_zone(order)
-        # Using .destroy_all to make sure callbacks fire
-        item.adjustments.tax.destroy_all unless @skip_destroy_adjustments
+
+        item.adjustments.destroy(item.adjustments.select(&:tax?))
 
         rates_for_item(item).map { |rate| rate.adjust(order_tax_zone(order), item) }
       end

data/app/models/spree/tax/order_adjuster.rb

@@ -16,8 +16,6 @@ module Spree
       def adjust!
         return unless order_tax_zone(order)
 
-        order.all_adjustments.tax.destroy_all
-
         (order.line_items + order.shipments).each do |item|
           ItemAdjuster.new(item, order_wide_options).adjust!
         end
@@ -30,7 +28,6 @@ module Spree
           rates_for_order_zone: rates_for_order_zone(order),
           rates_for_default_zone: rates_for_default_zone,
           order_tax_zone: order_tax_zone(order),
-          skip_destroy_adjustments: true
         }
       end
     end

data/app/models/spree/tax_rate.rb

@@ -85,13 +85,13 @@ module Spree
 
       included = included_in_price && amount > 0
 
-      adjustments.create!({
-        adjustable: item,
+      item.adjustments.create!(
+        source: self,
         amount: amount,
         order_id: item.order_id,
         label: adjustment_label(amount),
         included: included
-      })
+      )
     end
 
     # This method is used by Adjustment#update to recalculate the cost.

data/app/models/spree/unit_cancel.rb

@@ -16,8 +16,8 @@ class Spree::UnitCancel < Spree::Base
 
     amount = compute_amount(inventory_unit.line_item)
 
-    create_adjustment!(
-      adjustable: inventory_unit.line_item,
+    self.adjustment = inventory_unit.line_item.adjustments.create!(
+      source: self,
       amount: amount,
       order: inventory_unit.order,
       label: "#{Spree.t(:cancellation)} - #{reason}",

data/lib/spree/core/version.rb

@@ -5,7 +5,7 @@ module Spree
   end
 
   def self.solidus_version
-    "1.4.0.beta1"
+    "1.4.0.rc1"
   end
 
   def self.solidus_gem_version

data/lib/spree/testing_support/factories/adjustment_factory.rb

@@ -12,22 +12,27 @@ FactoryGirl.define do
     label 'Shipping'
     association(:source, factory: :tax_rate)
     eligible true
-  end
 
-  factory :tax_adjustment, class: Spree::Adjustment do
-    order { adjustable.order }
-    association(:adjustable, factory: :line_item)
-    amount 10.0
-    label 'VAT 5%'
-    association(:source, factory: :tax_rate)
-    eligible true
+    after(:build) do |adjustment|
+      adjustments = adjustment.adjustable.adjustments
+      if adjustments.loaded? && !adjustments.include?(adjustment)
+        adjustments.proxy_association.add_to_target(adjustment)
+      end
+    end
+
+    factory :tax_adjustment, class: Spree::Adjustment do
+      order { adjustable.order }
+      association(:adjustable, factory: :line_item)
+      amount 10.0
+      label 'VAT 5%'
 
-    after(:create) do |adjustment|
-      # Set correct tax category, so that adjustment amount is not 0
-      if adjustment.adjustable.is_a?(Spree::LineItem)
-        adjustment.source.tax_category = adjustment.adjustable.tax_category
-        adjustment.source.save
-        adjustment.update!
+      after(:create) do |adjustment|
+        # Set correct tax category, so that adjustment amount is not 0
+        if adjustment.adjustable.is_a?(Spree::LineItem)
+          adjustment.source.tax_category = adjustment.adjustable.tax_category
+          adjustment.source.save
+          adjustment.update!
+        end
       end
     end
   end

data/spec/lib/tasks/order_capturing_spec.rb

@@ -18,7 +18,7 @@ describe "order_capturing:capture_payments" do
 
   context "with a mix of canceled and shipped inventory" do
     before do
-      Spree::OrderCancellations.new(order).short_ship([order.inventory_units.first])
+      Spree::OrderCancellations.new(order).short_ship([order.line_items.first.inventory_units.first])
       order.shipping.ship_shipment(order.shipments.first)
       order.update_attributes!(payment_state: 'balance_due')
     end

data/spec/models/spree/item_adjustments_spec.rb

@@ -272,6 +272,9 @@ module Spree
     context "multiple updates" do
       let(:adjustment) { create(:tax_adjustment, amount: -10) }
       let(:item) { adjustment.adjustable }
+      # we need to get this from the line item so that we're modifying the same
+      # tax rate that is cached by line_item.adjustments
+      let(:source) { item.adjustments.to_a.first.source }
 
       def update
         described_class.new(item).update
@@ -283,18 +286,17 @@ module Spree
       end
 
       it "persists each change" do
-        adjustment.source.update_attributes!(amount: 0.1)
+        source.update_attributes!(amount: 0.1)
         update
         expect(item).not_to be_changed
         expect(db_record).to have_attributes(adjustment_total: 1)
 
-        adjustment.source.update_attributes!(amount: 0.20)
-        item.reload
+        source.update_attributes!(amount: 0.20)
         update
         expect(item).not_to be_changed
         expect(db_record).to have_attributes(adjustment_total: 2)
 
-        adjustment.source.update_attributes!(amount: 0.10)
+        source.update_attributes!(amount: 0.10)
         update
         expect(item).not_to be_changed
         expect(db_record).to have_attributes(adjustment_total: 1)

data/spec/models/spree/order/payment_spec.rb

@@ -6,49 +6,53 @@ module Spree
     let(:updater) { Spree::OrderUpdater.new(order) }
 
     context "processing payments" do
+      let(:order) { create(:order_with_line_items, shipment_cost: 0, line_items_price: 100) }
       before do
         # So that Payment#purchase! is called during processing
         Spree::Config[:auto_capture] = true
-
-        allow(order).to receive_message_chain(:line_items, :empty?).and_return(false)
-        allow(order).to receive_messages total: 100
       end
 
       it 'processes all checkout payments' do
-        payment_1 = create(:payment, amount: 50)
-        payment_2 = create(:payment, amount: 50)
-        allow(order).to receive(:unprocessed_payments).and_return([payment_1, payment_2])
+        payment_1 = create(:payment, order: order, amount: 50)
+        payment_2 = create(:payment, order: order, amount: 50)
 
         order.process_payments!
         updater.update_payment_state
+
         expect(order.payment_state).to eq('paid')
+        expect(order.payment_total).to eq(100)
 
-        expect(payment_1).to be_completed
-        expect(payment_2).to be_completed
+        expect(payment_1.reload).to be_completed
+        expect(payment_2.reload).to be_completed
       end
 
       it 'does not go over total for order' do
-        payment_1 = create(:payment, amount: 50)
-        payment_2 = create(:payment, amount: 50)
-        payment_3 = create(:payment, amount: 50)
-        allow(order).to receive(:unprocessed_payments).and_return([payment_1, payment_2, payment_3])
+        payment_1 = create(:payment, order: order, amount: 50)
+        payment_2 = create(:payment, order: order, amount: 50)
+        payment_3 = create(:payment, order: order, amount: 50)
 
         order.process_payments!
         updater.update_payment_state
+
         expect(order.payment_state).to eq('paid')
+        expect(order.payment_total).to eq(100)
 
-        expect(payment_1).to be_completed
-        expect(payment_2).to be_completed
-        expect(payment_3).to be_checkout
+        expect(payment_1.reload).to be_completed
+        expect(payment_2.reload).to be_completed
+        expect(payment_3.reload).to be_checkout
       end
 
       it "does not use failed payments" do
-        payment_1 = create(:payment, amount: 50)
-        payment_2 = create(:payment, amount: 50, state: 'failed')
+        create(:payment, order: order, amount: 50)
+        create(:payment, order: order, amount: 50, state: 'failed')
+        order.payments.reload
 
-        expect(payment_2).not_to receive(:process!)
+        expect(order.payments[0]).to receive(:process!).and_call_original
+        expect(order.payments[1]).not_to receive(:process!)
 
         order.process_payments!
+
+        expect(order.payment_total).to eq(50)
       end
     end
 

data/spec/models/spree/order_cancellations_spec.rb

@@ -139,9 +139,9 @@ describe Spree::OrderCancellations do
         order.contents.add(line_item.variant)
 
         # make the total $1.67 so it divides unevenly
-        Spree::Adjustment.tax.create!(
+        line_item.adjustments.create!(
+          source_type: 'Spree::TaxRate',
           order: order,
-          adjustable: line_item,
           amount: 0.01,
           label: 'some fake tax',
           finalized: true

data/spec/models/spree/order_capturing_spec.rb

@@ -4,8 +4,8 @@ describe Spree::OrderCapturing do
   describe '#capture_payments' do
     subject { Spree::OrderCapturing.new(order, payment_methods).capture_payments }
 
-    # Regression for the order.update! in the ensure block.
-    # See the comment there.
+    # Regression for https://github.com/solidusio/solidus/pull/407
+    # See also https://github.com/solidusio/solidus/pull/1406
     context "updating the order" do
       let(:order) { create :completed_order_with_totals }
       let(:payment_methods) { [] }

data/spec/models/spree/order_spec.rb

@@ -591,16 +591,12 @@ describe Spree::Order, type: :model do
 
   context "#apply_free_shipping_promotions" do
     it "calls out to the FreeShipping promotion handler" do
-      shipment = double('Shipment')
-      allow(order).to receive_messages shipments: [shipment]
-      expect(Spree::PromotionHandler::FreeShipping).to receive(:new).and_return(handler = double)
-      expect(handler).to receive(:activate)
+      expect_any_instance_of(Spree::PromotionHandler::FreeShipping).to(
+        receive(:activate)
+      ).and_call_original
 
-      expect(Spree::ItemAdjustments).to receive(:new).with(shipment).and_return(adjuster = double)
-      expect(adjuster).to receive(:update)
+      expect(order.updater).to receive(:update).and_call_original
 
-      expect(order.updater).to receive(:update_shipment_total)
-      expect(order.updater).to receive(:persist_totals)
       order.apply_free_shipping_promotions
     end
   end

data/spec/models/spree/tax/item_adjuster_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 RSpec.describe Spree::Tax::ItemAdjuster do
   subject(:adjuster) { described_class.new(item) }
-  let(:order) { Spree::Order.new }
+  let(:order) { create(:order) }
   let(:item) { Spree::LineItem.new(order: order) }
 
   before do
@@ -64,7 +64,6 @@ RSpec.describe Spree::Tax::ItemAdjuster do
           before { allow(item).to receive(:tax_category).and_return(item_tax_category) }
 
           it 'creates an adjustment for every matching rate' do
-            expect(rate_1).to receive_message_chain(:adjustments, :create!)
             expect(adjuster.adjust!.length).to eq(1)
           end
         end

data/spec/models/spree/tax/order_adjuster_spec.rb

@@ -31,7 +31,6 @@ RSpec.describe Spree::Tax::OrderAdjuster do
                                               rates_for_order_zone: rates_for_order_zone,
                                               rates_for_default_zone: [],
                                               order_tax_zone: zone,
-                                              skip_destroy_adjustments: true
                                             ).and_return(item_adjuster)
       expect(Spree::Tax::ItemAdjuster).to receive(:new).
                                             with(
@@ -39,7 +38,6 @@ RSpec.describe Spree::Tax::OrderAdjuster do
                                               rates_for_order_zone: rates_for_order_zone,
                                               rates_for_default_zone: [],
                                               order_tax_zone: zone,
-                                              skip_destroy_adjustments: true
                                             ).and_return(item_adjuster)
 
       expect(item_adjuster).to receive(:adjust!).twice

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus_core
 version: !ruby/object:Gem::Version
-  version: 1.4.0.beta1
+  version: 1.4.0.rc1
 platform: ruby
 authors:
 - Solidus Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-19 00:00:00.000000000 Z
+date: 2016-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemerchant