solidus_advanced_pricing 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0feded43570200af31d61d2822614677e232d696b480196576c0651edafee278
-  data.tar.gz: 20b1184e197fc387a095d5af68b7936fc894ccd213b6386a259bff8f0e77e6e5
+  metadata.gz: 35df8c1a684ddc6520796b75efe4f865cd2bee381230ad1a5323afe4207f3bd3
+  data.tar.gz: db971affc7d958d3e84c31fedc96be694723ea83f040b397ef752cc6917e8155
 SHA512:
-  metadata.gz: c2a90ff27650243c41246a0dfa7b9cd1b6a672c73060dcf6abcaf007f101baefdf3d627c28301ac06e576b1a7bb1a4f9602135935a6cbe2327ea62918fa20d20
-  data.tar.gz: 5b57c0ee2ef362b15e377db52ebd80c1624db43c3c94d69846e8e93bfacb7ce17864766f35cb9ee56c8113a424b3afb5a6d550be20b18872eefa6f8bd04ef595
+  metadata.gz: c62e682f06170ff5f6322f5a08ee020e88383a216fd3e955bb5cfba667b007711bb0396c2f9d7567df1b5cc827389bbee0c4f04c28d5ab8d928a81c00b2e6d87
+  data.tar.gz: 57bf9dfe07f8cf5849a15dd675efe63022a92032c9e431b2cbfa164d76a35f47dab71772ced385f8f451c5b7c153cca9e8ed696cbf63783556b9aea47a55062d

data/CHANGELOG.md

@@ -4,6 +4,28 @@ All notable changes to this project are documented here. The format is based on
 [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.3.1] - 2026-09-23
+
+### Fixed
+
+- **Installing the gem without registering its price selector broke every
+  `variant.price = ...`**, product creation included, with
+  `NoMethodError: undefined method 'price_type_id' for an instance of
+  Spree::Variant::PricingOptions`. Core calls `default_price` on the way into
+  `price=`, and this gem's override reached for a typed fallback through
+  `pricing_options.with(price_type_id: :any)` — which only works on this gem's
+  own `PricingOptions`. A store that left
+  `Spree::Config.variant_price_selector_class` alone got core's, where `with`
+  falls through to ActiveSupport's `Object#with` and `public_send`s the key.
+  Present since 0.2.0, when the fallback was added.
+
+  The fallback is now skipped unless this gem's pricing options are in play.
+  Without the selector there are no typed prices to fall back to, so the right
+  answer is core's: nothing.
+- `Spree::Variant#price_of_type` and `#base_price` now raise
+  `SolidusAdvancedPricing::SelectorNotRegistered`, naming the setting to change,
+  instead of a `NoMethodError` about `price_type_id`.
+
 ## [0.3.0] - 2026-09-23
 
 ### Added
@@ -113,6 +135,7 @@ Initial release.
   bucket. Without the role component a role-targeted price would be cached and served to
   guests.
 
+[0.3.1]: https://github.com/fcpeuro/solidus_advanced_pricing/compare/v0.3.0...v0.3.1
 [0.3.0]: https://github.com/fcpeuro/solidus_advanced_pricing/compare/v0.2.0...v0.3.0
 [0.2.0]: https://github.com/fcpeuro/solidus_advanced_pricing/compare/v0.1.0...v0.2.0
 [0.1.0]: https://github.com/fcpeuro/solidus_advanced_pricing/releases/tag/v0.1.0

data/app/decorators/models/solidus_advanced_pricing/spree/variant_decorator.rb

@@ -27,6 +27,8 @@ module SolidusAdvancedPricing
 
       # nil means the untyped base price. Accepts a PriceType, an id, or a code.
       def price_of_type(price_type, pricing_options = ::Spree::Config.default_pricing_options)
+        SolidusAdvancedPricing.assert_advanced_pricing_options!(pricing_options)
+
         price_selector.price_for_options(
           pricing_options.with(price_type_id: SolidusAdvancedPricing.resolve_price_type_id(price_type))
         )
@@ -41,9 +43,22 @@ module SolidusAdvancedPricing
       # A MAP-restricted variant may carry no untyped price at all; fall back so
       # variant.price is never blank when some price exists.
       def default_price
-        super || price_selector.price_for_options(
-          ::Spree::Config.default_pricing_options.with(price_type_id: :any)
-        )
+        super || typed_fallback_price
+      end
+
+      private
+
+      # Core calls default_price on the way into `price=`, so this runs in stores
+      # that installed the gem and never registered its selector. Those get core's
+      # PricingOptions, which has no price_type_id, and `with` would raise rather
+      # than fall back -- breaking every `variant.price = ...`, product creation
+      # included. Without the selector there are no typed prices to fall back to
+      # anyway, so the right answer is core's: nothing.
+      def typed_fallback_price
+        pricing_options = ::Spree::Config.default_pricing_options
+        return unless SolidusAdvancedPricing.advanced_pricing_options?(pricing_options)
+
+        price_selector.price_for_options(pricing_options.with(price_type_id: :any))
       end
 
       ::Spree::Variant.prepend self

data/lib/solidus_advanced_pricing/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidusAdvancedPricing
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/lib/solidus_advanced_pricing.rb

@@ -5,6 +5,38 @@ require "solidus_advanced_pricing/version"
 require "solidus_advanced_pricing/engine"
 
 module SolidusAdvancedPricing
+  # Raised when an advanced-pricing lookup is attempted in a store that never
+  # registered this gem's price selector.
+  class SelectorNotRegistered < StandardError
+    def initialize(message = nil)
+      super(message || <<~MESSAGE.strip)
+        SolidusAdvancedPricing::PriceSelector is not registered, so pricing options
+        carry no price type and this lookup cannot be answered. Set
+
+          Spree::Config.variant_price_selector_class = "SolidusAdvancedPricing::PriceSelector"
+
+        (the install generator writes this into config/initializers/solidus_advanced_pricing.rb).
+      MESSAGE
+    end
+  end
+
+  # Whether this gem's PricingOptions -- and therefore its selector -- is in play.
+  # A store can install the gem and leave Spree::Config.variant_price_selector_class
+  # alone; everything then has to behave exactly as core does.
+  #
+  # Tested by class, not by `respond_to?(:price_type_id)`: price_type_id is not a
+  # reader on either class, it lives in desired_attributes. What actually differs
+  # is that this gem's PricingOptions overrides `with` to merge arbitrary
+  # attributes, where core's falls through to ActiveSupport's Object#with, which
+  # public_sends every key it is given.
+  def self.advanced_pricing_options?(pricing_options = ::Spree::Config.default_pricing_options)
+    pricing_options.is_a?(SolidusAdvancedPricing::PricingOptions)
+  end
+
+  def self.assert_advanced_pricing_options!(pricing_options = ::Spree::Config.default_pricing_options)
+    raise SelectorNotRegistered unless advanced_pricing_options?(pricing_options)
+  end
+
   # nil stays nil (the base price); a PriceType or id passes through; a code resolves.
   def self.resolve_price_type_id(price_type)
     case price_type

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: solidus_advanced_pricing
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Patrick McMorran