solidus-adyen 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d25ff04beda14b6f6f753c04115a9d76cdc3a647
-  data.tar.gz: 5d8805603afd3248f6cd697d4427ef485f97ef91
+  metadata.gz: 08b088acce113a3bfb9cbbb3e9c2ef2537440a0f
+  data.tar.gz: efe31205a5b93b5901c4a7c0d31d9a862dfd46dd
 SHA512:
-  metadata.gz: 315134e5e8c44eb5923a6c7aeb57061879608ab459e149afdeafb11663302f156209fbd51a60ad98151deb98f2ae736e6d646cc47b9d37a804e959d5d98c634c
-  data.tar.gz: 2c13cddda66a8387274be8a075c13e82a35c03479f5cd6de6fa98ab357e7d1d07328749fc9d9a84fe8171c647fc61a53ce2847387ac99f79f212089f31a440dc
+  metadata.gz: 7d6a081a47bf73716edc97270f2ea7319b58960a1b6eba7764b6403488bacdc8159904e46027c8914b2e7a4ed3e6d4cb9528fb1f15d73667c514229433084369
+  data.tar.gz: 1ee9ade8ed1b00679ee61c7e27d120be94945dcd1af96cbdb995c3d8d8ade8e279d5cfe445fe97effaf3398b9de58c9fbac22733324d420a0d0aeac979c7d554

data/app/models/spree/adyen/notification_processor.rb

@@ -72,7 +72,7 @@ module Spree
             refund_reason_id: ::Spree::RefundReason.first.id # FIXME
           )
           # payment was processing, move back to completed
-          payment.complete!
+          payment.complete! unless payment.completed?
           notification.processed!
         end
       end

data/lib/spree/adyen/version.rb

@@ -1,5 +1,5 @@
 module Spree
   module Adyen
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
   end
 end

data/spec/models/spree/adyen/notification_processor_spec.rb

@@ -146,23 +146,37 @@ RSpec.describe Spree::Adyen::NotificationProcessor do
     end
 
     context "when event is REFUND" do
-      include_examples "processed event"
+      shared_examples "refund" do
+        let(:event_type) { :refund }
+        it "creates a refund" do
+          expect { subject }.
+            to change { payment.reload.refunds.count }.
+            from(0).
+            to(1)
+        end
+      end
 
-      let(:event_type) { :refund }
-      let(:payment_state) { "processing" }
+      context "when refunded from Solidus" do
+        let(:payment_state) { "processing" }
+        include_examples "refund"
 
-      it "creates a refund" do
-        expect { subject }.
-          to change { payment.reload.refunds.count }.
-          from(0).
-          to(1)
+        it "changes the payment state to completed" do
+          expect { subject }.
+            to change { payment.reload.state }.
+            from("processing").
+            to("completed")
+        end
       end
 
-      it "changes the payment state to completed" do
-        expect { subject }.
-          to change { payment.reload.state }.
-          from("processing").
-          to("completed")
+      context "when refunded from Adyen" do
+        let(:payment_state) { "completed" }
+        include_examples "refund"
+
+        it "does not change the payment state" do
+          expect { subject }.
+            not_to change { payment.reload.state }.
+            from("completed")
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solidus-adyen
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Dylan Kendal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-09 00:00:00.000000000 Z
+date: 2015-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: adyen