solid_queue_autoscaler 1.0.18 → 1.0.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 12251748d310789a1f51b7276742e216bb4f45c1baa17a70999210f65dce31a0
-  data.tar.gz: 2ee4b1e5aada9cd196021b9cc18d84b2a3e8550ff4e42b430c98318dd5fe2267
+  metadata.gz: 8a4488b919923025829a72e3c9a23220a528f76499adfe1575b3f7484adca8ec
+  data.tar.gz: 19b2bf974f03231b8f060ebaaa12ff0ce214ee3bb89620a1b90981fee3e0410e
 SHA512:
-  metadata.gz: bbac46ee43f97d0c4beac6e5c54c1edd646b82c673eb524833ce5c9e3a812808ec1229385af5c4a28eff98b10e9d5b7ca52b3a2cc87776d4cbe0f5a34ef3d3e4
-  data.tar.gz: 9139d323751360748f79ea86263a59d6cf68eb4b1b7888d35659cf5c5fba76f0b9f3817b52695de98f388a4d981e7a20d363c608ecb3419239beeaf7943f4b25
+  metadata.gz: 4dac7f9c83dab082137824c6a730fb6bb68e042758f155aac8480067810904bc234b9f152c7ee023264b6fcb4eb09c2fbfebc43b668520b0fdb446cc66eb1dad
+  data.tar.gz: 56c9cc4d51523f1752fc36e70f8c3cc4cb83177c4e7c345c8972116d27b0e12812aedbe2839f8bcb958f4ea50dd20432f3a686d2e9217e2fbf2588bf0cbfe872

data/CHANGELOG.md

@@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.0.19] - 2025-02-02
+
+### Added
+- **AutoscaleJob string/symbol validation** - Detects when `recurring.yml` passes a quoted string like `":all"` instead of the symbol `:all`
+  - Raises a helpful `ConfigurationError` with exact before/after YAML examples
+  - Plain strings like `"default"` are leniently converted to symbols
+  - New `normalize_worker_name` helper method with comprehensive tests
+
+### Improved
+- **Better error message for missing Procfile process types** - When `batch_update` returns 404 (process type doesn't exist), the error now explains:
+  - The process type doesn't exist in the Procfile
+  - How to verify with `heroku ps -a <app_name>`
+  - That the configured `process_type` must exactly match a Procfile entry
+
 ## [1.0.18] - 2025-01-31
 
 ### Fixed

data/lib/solid_queue_autoscaler/adapters/heroku.rb

@@ -115,9 +115,24 @@ module SolidQueueAutoscaler
         end
         quantity
       rescue Excon::Error => e
+        status = e.respond_to?(:response) ? e.response&.status : nil
+        
+        # 404 from batch_update means the process type doesn't exist in the Procfile
+        # This is different from 404 on formation.update (which means scaled to 0)
+        if status == 404
+          raise HerokuAPIError.new(
+            "Process type '#{process_type}' does not exist. " \
+            "Verify that '#{process_type}:' is defined in your Procfile. " \
+            "Available process types can be viewed with 'heroku ps -a #{app_name}' or in your Procfile. " \
+            "The configured process_type must exactly match a Procfile entry.",
+            status_code: status,
+            response_body: e.respond_to?(:response) ? e.response&.body : nil
+          )
+        end
+
         raise HerokuAPIError.new(
           "Failed to create formation #{process_type} with quantity #{quantity}: #{e.message}",
-          status_code: e.respond_to?(:response) ? e.response&.status : nil,
+          status_code: status,
           response_body: e.respond_to?(:response) ? e.response&.body : nil
         )
       end

data/lib/solid_queue_autoscaler/autoscale_job.rb

@@ -21,6 +21,8 @@ module SolidQueueAutoscaler
     # @param worker_name [Symbol] The worker type to scale (:default, :critical_worker, etc.)
     #                             Pass :all to scale all registered workers
     def perform(worker_name = :default)
+      worker_name = normalize_worker_name(worker_name)
+
       if worker_name == :all
         perform_scale_all
       else
@@ -79,5 +81,33 @@ module SolidQueueAutoscaler
       worker_label = worker_name == :default ? '' : "[#{worker_name}] "
       Rails.logger.error("[AutoscaleJob] #{worker_label}Failed: #{result.error&.message}")
     end
+
+    # Normalize and validate worker_name argument.
+    # Detects common YAML misconfiguration where symbols are quoted as strings.
+    #
+    # @param worker_name [Symbol, String] The worker name to normalize
+    # @return [Symbol] The normalized worker name as a symbol
+    # @raise [ConfigurationError] If a string that looks like a symbol is passed
+    def normalize_worker_name(worker_name)
+      return worker_name if worker_name.is_a?(Symbol)
+
+      # Detect strings that look like symbols (e.g., ":all", ":default")
+      # This is a common YAML misconfiguration
+      if worker_name.is_a?(String) && worker_name.start_with?(':')
+        symbol_name = worker_name[1..] # Remove the leading colon
+        raise ConfigurationError,
+              "Invalid worker_name argument: received string #{worker_name.inspect} instead of symbol :#{symbol_name}. " \
+              "In your recurring.yml, change:\n" \
+              "  args:\n" \
+              "    - \"#{worker_name}\"\n" \
+              "to:\n" \
+              "  args:\n" \
+              "    - :#{symbol_name}\n" \
+              '(Remove the quotes around the symbol)'
+      end
+
+      # Convert plain strings to symbols (lenient mode)
+      worker_name.to_sym
+    end
   end
 end

data/lib/solid_queue_autoscaler/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SolidQueueAutoscaler
-  VERSION = '1.0.18'
+  VERSION = '1.0.19'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solid_queue_autoscaler
 version: !ruby/object:Gem::Version
-  version: 1.0.18
+  version: 1.0.19
 platform: ruby
 authors:
 - reillyse
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-31 00:00:00.000000000 Z
+date: 2026-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord