solicit 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f5b1cad9b91d13d346961819928a674b6824888f0e818158fbbdb7704d89baa9
-  data.tar.gz: 0ac5da6eaf980b98278586226619c5588ae079862a1556be2c42b061a842c97a
+  metadata.gz: 28afc0d984a9b486938fd856dfcc52bd5c41cb3efd805fbe971f0244a2a148a9
+  data.tar.gz: 32c9c9b211bae525eccc274d81f5ecd474e7058811e72960c4182aec2e0c9dfd
 SHA512:
-  metadata.gz: 0bf4790797bfbc9ff95d9a5d0b210b5cf7965286f83f27d89be6ee3276200a8bab430950448d08bbbf4e14c3fce1b4638474dfabb4e366d1144b08ce930f3508
-  data.tar.gz: 33060e277208026d64bf1b38bcd3ba25a00706f7e544cc4fa62115d058250b82187e0e1f4c9b8c63c710ba7fff6c5b14391b6175e00162eb8435f803fde2a5a9
+  metadata.gz: 6a91c4ca2760f2c77d3d59b75fc16f9237fda4562e9db9fedbbaeb592fb0fc7c8350e75c784955c27c50efe2f42f0eb98b5c2a843c04291f95cca3555ae3c05b
+  data.tar.gz: db2294ee3ebd39beaffac1882dd49bf75e6b5cbed233f95de41e4ed66dcea1ed7555fb52a950f0040ec7679be34f075dab48b68b82b17e9c28b66b291b414b44

data/app/controllers/solicit/pull_requests_controller.rb

@@ -15,7 +15,7 @@ module Solicit
     def notify
       PostToSlack.perform(
         url: Solicit.slack_webhook_url,
-        channel: Solicit.labels_map[payload.dig(:label, :name).to_sym],
+        channel: Solicit.labels_map.stringify_keys[payload.dig(:label, :name).to_s],
         username: Solicit.slack_username,
         payload: payload
       )
@@ -34,9 +34,11 @@ module Solicit
     end
 
     def ensure_can_notify
+      label = payload.dig(:label, :name).to_s
       head :ok unless request_is_from_github? &&
                       payload[:action] == 'labeled' &&
-                      Solicit.labels_map.key?(payload.dig(:label, :name).to_sym) &&
+                      Solicit.labels_map.stringify_keys.key?(label) &&
+                      Solicit.needs_more_assignees.call(payload[:pull_request], label) &&
                       payload.dig(:pull_request, :number) &&
                       payload.dig(:repository, :url)
     end

data/app/use_cases/solicit/post_to_slack.rb

@@ -1,24 +1,27 @@
 module Solicit
   class PostToSlack
+    attr_reader :text
+
     def initialize(url:, channel:, username:, payload:)
       @url      = url
       @channel  = channel
       @username = username
       @payload  = payload
+      @text     = I18n.t(:"engines.solicit.title", title_options)
     end
 
     def self.perform(*args)
-      new(*args).perform
+      new(*args).tap(&:perform)
     end
 
     def perform
       Slack::Notifier.new(@url, channel: @channel, username: @username).ping(
-        text: I18n.t(:"engines.solicit.title", title_options),
+        text: text,
         attachments: [{
           title: I18n.t(:"engines.solicit.review"),
           callback_id: callback_id,
           color: :warning,
-          actions: Array(claim_action),
+          actions: [claim_action],
         }]
       )
     end
@@ -27,9 +30,10 @@ module Solicit
 
     def title_options
       {
-        link: @payload.dig(:pull_request, :html_url),
-        title: @payload.dig(:pull_request, :title),
-        label: @payload.dig(:label, :name),
+        author: author_name,
+        link:   @payload.dig(:pull_request, :html_url),
+        title:  @payload.dig(:pull_request, :title),
+        label:  @payload.dig(:label, :name),
       }
     end
 
@@ -50,5 +54,11 @@ module Solicit
         value: @payload.dig(:label, :name),
       }
     end
+
+    def author_name
+      Solicit.contributors_map.detect do |_, value|
+        value[:handle] == @payload.dig(:sender, :login)
+      end&.dig(1, 'name') || I18n.t(:"engines.solicit.someone")
+    end
   end
 end

data/config/locales/en.yml

@@ -4,4 +4,5 @@ en:
       volunteer: "%{name} has volunteered! :%{emoji}:"
       claim:     "I'll do it!"
       review:    "Review this PR"
-      title:     "PR <%{link}|%{title}> now has a %{label} label!"
+      someone:   "Someone"
+      title:     "%{author} has added a %{label} label to a PR: <%{link}|%{title}>"

data/lib/solicit/version.rb

@@ -1,3 +1,3 @@
 module Solicit
-  VERSION = "0.1.3"
+  VERSION = '0.1.4'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solicit
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Optimal Workshop
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-16 00:00:00.000000000 Z
+date: 2019-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -162,8 +162,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Solicit reviewers for your github pull requests on Slack