solargraph 0.40.3 → 0.40.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8eaae0cf888e025f51bdbeea3c414f98e7014d416f58e23d29770b4969f1eb5a
-  data.tar.gz: 4d0b4b1d24e81953aa819b83f318767e79ce7d6ed3cfb5f6e4b1fcf6a3b5ffc0
+  metadata.gz: eff7d664014ae6d25990957afb4328baafe88ff76ef892db8b3d50791860845e
+  data.tar.gz: 8038c884a63ce269f1a0faaf635e4c295fadd61c456ba2665c84a17b4f03a031
 SHA512:
-  metadata.gz: 668db64477f7249ad2d9381292e19f4007a28d607eedfb96848bbb9efd55645ec78c705976e31f765d706c47f08243a322594ccf177f54c950432f565f286789
-  data.tar.gz: e0986273bb88005f0471c5837f979507fd8f2d13b9d45c1717e6bd77c3ebfd42c746e87aaf41fdf0271007c31849f8622fe9e5a4974e8a35bd0d9f6a4b8e9e3c
+  metadata.gz: a7b95e2ba342b191642a1d5ea228243a60b9211f6c05cab2acf09ddcaab3efb25cef488ca910964e0ac1c32edacc2f0ced4eef09fa819b03d2919af4ac734ca7
+  data.tar.gz: 6990c07591d43fdb583484c00fc5221d228850fa75e12b5cd2632413a21c1984f634ce2655371d9be7016a035e23fe622469418779bf3285f03a087a38c394ae

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.40.4 - March 3, 2021
+- Fix optarg and blockarg ordering
+- Override specialization for #initialize
+- Find definitions with cursor after double colon
+
 ## 0.40.3 - February 7, 2021
 - Simplify and allow to configure rubocop formatter (#403)
 - Type checker shows tag in param type errors (#398)

data/lib/solargraph/api_map/store.rb

@@ -238,11 +238,16 @@ module Solargraph
         pins_by_class(Pin::Reference::Override).each do |ovr|
           pin = get_path_pins(ovr.name).first
           next if pin.nil?
+          new_pin = if pin.path.end_with?('#initialize')
+            get_path_pins(pin.path.sub(/#initialize/, '.new')).first
+          end
           (ovr.tags.map(&:tag_name) + ovr.delete).uniq.each do |tag|
             pin.docstring.delete_tags tag.to_sym
+            new_pin.docstring.delete_tags tag.to_sym if new_pin
           end
           ovr.tags.each do |tag|
             pin.docstring.add_tag(tag)
+            new_pin.docstring.add_tag(tag) if new_pin
           end
         end
       end

data/lib/solargraph/parser/rubyvm/node_processors/args_node.rb

@@ -55,19 +55,19 @@ module Solargraph
                 )
                 region.closure.parameters.push locals.last
               end
-              if node.children.last
-                locals.push Solargraph::Pin::Parameter.new(
-                  location: region.closure.location,
-                  closure: region.closure,
-                  comments: comments_for(node),
-                  name: node.children.last.to_s,
-                  presence: region.closure.location.range,
-                  decl: :blockarg
-                )
-                region.closure.parameters.push locals.last
-              end
             end
             process_children
+            if node.children.last
+              locals.push Solargraph::Pin::Parameter.new(
+                location: region.closure.location,
+                closure: region.closure,
+                comments: comments_for(node),
+                name: node.children.last.to_s,
+                presence: region.closure.location.range,
+                decl: :blockarg
+              )
+              region.closure.parameters.push locals.last
+            end
           end
 
           private

data/lib/solargraph/parser/rubyvm/node_processors/opt_arg_node.rb

@@ -16,12 +16,7 @@ module Solargraph
               presence: region.closure.location.range,
               decl: :optarg
             )
-            idx = region.closure.parameters.find_index { |par| par.decl != :arg }
-            if idx
-              region.closure.parameters.insert idx, locals.last
-            else
-              region.closure.parameters.push locals.last
-            end
+            region.closure.parameters.push locals.last
             node.children[1] && NodeProcessor.process(node.children[1], region, pins, locals)
           end
         end

data/lib/solargraph/source.rb

@@ -175,7 +175,7 @@ module Solargraph
       synced
     end
 
-    # @param position [Position]
+    # @param position [Position, Array(Integer, Integer)]
     # @return [Source::Cursor]
     def cursor_at position
       Cursor.new(self, position)

data/lib/solargraph/source/source_chainer.rb

@@ -64,7 +64,7 @@ module Solargraph
           elsif end_of_phrase.strip == '::'
             chain.links.push Chain::UNDEFINED_CONSTANT
           end
-        elsif chain.links.last.is_a?(Source::Chain::Constant) && end_of_phrase.strip == '::'
+        elsif chain.links.last.is_a?(Source::Chain::Constant) && end_of_phrase.strip == '::' && !source.code[Position.to_offset(source.code, position)].match?(/[a-z]/i)
           chain.links.push Source::Chain::UNDEFINED_CONSTANT
         end
         chain

data/lib/solargraph/type_checker.rb

@@ -95,7 +95,7 @@ module Solargraph
           result.push Problem.new(pin.location, "Untyped method #{pin.path} could not be inferred")
         end
       elsif rules.validate_tags?
-        unless pin.node.nil? || declared.void? || macro_pin?(pin) || abstract?(pin)
+        unless pin.node.nil? || declared.void? || virtual_pin?(pin) || abstract?(pin)
           inferred = pin.probe(api_map).self_to(pin.full_context.namespace)
           if inferred.undefined?
             unless rules.ignore_all_undefined? || external?(pin)
@@ -111,7 +111,7 @@ module Solargraph
       result
     end
 
-    def macro_pin? pin
+    def virtual_pin? pin
       pin.location && source_map.source.comment_at?(pin.location.range.ending)
     end
 

data/lib/solargraph/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Solargraph
-  VERSION = '0.40.3'
+  VERSION = '0.40.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: solargraph
 version: !ruby/object:Gem::Version
-  version: 0.40.3
+  version: 0.40.4
 platform: ruby
 authors:
 - Fred Snyder
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-07 00:00:00.000000000 Z
+date: 2021-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backport