solargraph-rspec 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b29106f92a5279085cce258a7aabc92070d5452446a8f5a0b9c141d2a3d5a52d
-  data.tar.gz: a153e3a43ff36c494484ecef9e7ef4f31066b0c002f0c3e16505a3357231591f
+  metadata.gz: 46e92fa0735bc1e0b1129ce3c06208969dd8917a28e70286876d7f6307928e8c
+  data.tar.gz: 718485f0ea53780cb3ee6d076cb5be112d160d1c39866c91334142d1abff515a
 SHA512:
-  metadata.gz: 7c12a1454723f6acfe6bafcb856ff300734d27429d6ee08f053f2c05b30f7ff3885bb595ce14fb360bbfeec1cbf9339938a52cfa2f63874fce4cbd2d6efacbcf
-  data.tar.gz: 3b81a6a82e580bc0e5ff86a0aeb66d61f6f9c8a8e7191ac0df52a31ac482b9dc774cd10b43d881babf80fdd6e60c93dc87a25a7f72ad296aea6d57743c550055
+  metadata.gz: '06580663bc8c5424219a171e4f61121d98d04dfe9048bfaa3595c7717bdd2a88b6dcd5055218cbf2fe3c50f7ade5a148811a7c23b780c86d9f0bae8ea554a236'
+  data.tar.gz: 28ea8fe4be4f3402ca3079a747764013d6154adac0b114c2f9f23afe81599b403f0bb024856c3744ce7e8b64f80898eba210962cec68253e0edf25c90f3ce1d6

data/CHANGELOG.md

@@ -9,6 +9,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - 
 
+## [0.1.1] - 2024-05-13
+
+### Removed
+- Removed redundant `active_support` dependency ([Issue #2](https://github.com/lekemula/solargraph-rspec/issues/2))
+
+### Fixed
+- Fixed completions inside `subject` and `subject!` blocks
+
 ## [0.1.0] - 2024-05-11 (First Release 🎉)
 
 ### Added

data/README.md

@@ -1,5 +1,6 @@
-# Solargraph::Rspec - A Solargraph plugin for better RSpec support
+# Solargraph::Rspec - A [Solargraph](https://solargraph.org/) plugin for better [RSpec](https://rspec.info/) support
 
+[![Gem Version](https://badge.fury.io/rb/solargraph-rspec.svg)](https://badge.fury.io/rb/solargraph-rspec)
 ![Tests](https://github.com/lekemula/solargraph-rspec/actions/workflows/ruby.yml/badge.svg)
 [![codecov](https://codecov.io/gh/lekemula/solargraph-rspec/graph/badge.svg?token=FH7ER8ZDPW)](https://codecov.io/gh/lekemula/solargraph-rspec)
 

data/lib/solargraph/rspec/convention.rb

@@ -18,6 +18,7 @@ module Solargraph
     HELPER_MODULES = ['RSpec::Matchers'].freeze
     HOOK_METHODS = %w[before after around].freeze
     LET_METHODS = %w[let let!].freeze
+    SUBJECT_METHODS = %w[subject subject!].freeze
     EXAMPLE_METHODS = %w[
       example
       it

data/lib/solargraph/rspec/correctors/example_and_hook_blocks_binding_corrector.rb

@@ -34,6 +34,12 @@ module Solargraph
 
             yield [] if block_given?
           end
+
+          rspec_walker.on_subject do |subject_ast|
+            bind_closest_namespace(subject_ast, source_map)
+
+            yield [] if block_given?
+          end
         end
 
         private

data/lib/solargraph/rspec/spec_walker.rb

@@ -105,9 +105,15 @@ module Solargraph
           end
         end
 
-        walker.on :send, [nil, :subject] do |ast|
+        walker.on :block do |block_ast|
+          next if block_ast.children.first.type != :send
+
+          method_ast = block_ast.children.first
+          method_name = method_ast.children[1]
+          next unless Rspec::SUBJECT_METHODS.include?(method_name.to_s)
+
           @handlers[:on_subject].each do |handler|
-            handler.call(ast)
+            handler.call(method_ast)
           end
         end
 

data/lib/solargraph/rspec/version.rb

@@ -2,6 +2,6 @@
 
 module Solargraph
   module Rspec
-    VERSION = '0.1.0'
+    VERSION = '0.1.1'
   end
 end

data/lib/solargraph-rspec.rb

@@ -2,7 +2,6 @@
 # frozen_string_literal: true
 
 require 'solargraph'
-require 'active_support'
 
 require_relative 'solargraph/rspec/version'
 require_relative 'solargraph/rspec/convention'

data/solargraph-rspec.gemspec

@@ -28,7 +28,6 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'activesupport', '~> 6.0'
   spec.add_runtime_dependency 'solargraph', '~> 0.49', '>= 0.49.0'
 
   # For more information and examples about making a new gem, check out our

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: solargraph-rspec
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Lekë Mula
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-05-11 00:00:00.000000000 Z
+date: 2024-05-13 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: solargraph
   requirement: !ruby/object:Gem::Requirement