soft_deletion 1.4.0 → 1.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: eb38e89312439df81fdb57dd5be332d8e23f1daea98e0bc6433ae3970ae25d2f
4
- data.tar.gz: 60086929f21fbb26f458b4621bfd80623b64b9235a48d3c95ed4ef7931d4f6af
3
+ metadata.gz: db3c7a48df996a8310a84a136f37fcd4bfdfe07f61bdbc7a43b6d5f9ba45210e
4
+ data.tar.gz: d9fea741aa8989fba51e8d17818d47ead85e6a47f7dbc512e57d4f8769d4f8d6
5
5
  SHA512:
6
- metadata.gz: d91633a4a6a91922464990c2afbbd5900ac0fc37c9318cc82627fb4b3b7907b6ffe69c12846ec1743b08ebf681b08afe5da09c021ece62e973a8959bee3d6237
7
- data.tar.gz: 748dace888a26d27f1ef87a1b9376c5cff7572f5ce191c453c0429d99c9962978cdc1bcccd0d093074b0ee619ef6d9af12cf1b21f17a55c03a9017405950deaf
6
+ metadata.gz: 47fe455d06da39fa6cf28e7f211ef22c4395e35aa5bfb87b2674a0a58ecc5333b6126e66d78b87975573e4811795e17900a2a1f885311f585f690a35bd7f4dd3
7
+ data.tar.gz: d7d4dc1c097043553e385aaabe42b3c919b214e2f3566166a83cc7d9c8f9eff48460295bfc7f083b197ee02d7f0a01d4ab2366b73ca6876c30ecddbcbbff26d1
data/Readme.md CHANGED
@@ -48,7 +48,6 @@ User.soft_delete_all!(1,2,3,4)
48
48
 
49
49
  TODO
50
50
  ====
51
- - nullify should use update_all on has_many on soft_delete (performance)
52
51
  - has_many :through should delete join associations on soft_delete
53
52
  - cascading soft_deletes should use the same timestamp for easy reverts
54
53
 
@@ -62,6 +61,7 @@ Authors
62
61
  - [Noel Dellofano](https://github.com/pinkvelociraptor)
63
62
  - [Oliver Nightingale](https://github.com/olivernn)
64
63
  - [Kumar Pandya](https://github.com/kpandya91)
64
+ - [Alex Pauly](https://github.com/apauly)
65
65
 
66
66
  [Zendesk](http://zendesk.com)<br/>
67
67
  michael@grosser.it<br/>
@@ -10,7 +10,7 @@ module SoftDeletion
10
10
  def execute_soft_delete(method, args)
11
11
  case association.options[:dependent]
12
12
  when :nullify
13
- nullify_dependencies
13
+ dependency.update_all(association.foreign_key => nil)
14
14
  when :delete_all
15
15
  dependency.update_all(dependency.mark_as_soft_deleted_sql)
16
16
  true
@@ -27,12 +27,6 @@ module SoftDeletion
27
27
 
28
28
  protected
29
29
 
30
- def nullify_dependencies
31
- dependencies.each do |dependency|
32
- dependency.update_column(association.foreign_key, nil)
33
- end
34
- end
35
-
36
30
  def klass
37
31
  association.klass
38
32
  end
@@ -1,3 +1,3 @@
1
1
  module SoftDeletion
2
- VERSION = '1.4.0'
2
+ VERSION = '1.5.0'
3
3
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: soft_deletion
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.4.0
4
+ version: 1.5.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Michael Grosser
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2019-06-29 00:00:00.000000000 Z
11
+ date: 2019-08-24 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activerecord