soft_deletion 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 855e30bb57aed54bfc4f5dad35add6d1e4016adf
-  data.tar.gz: ddbd760ed9411b44d2b9108b189201976e7b7157
+  metadata.gz: f1865ab76d9db34c7e26eb92400a99b31180e3e2
+  data.tar.gz: e9123420db3c2e6f6cbf1cdf846d4d540ce85d1e
 SHA512:
-  metadata.gz: 74ab08e62c1364f560b4d9c101ab0523ded919eb564fd5fb90dd5abcc269bb91ca4fac1900bc2a9bbe6eb59048987c41b34060d730655dd8a4ad5921dbb2d392
-  data.tar.gz: 7149e993a547f9ab9747364b2da31616e9029ffd5164d78888d0ee731ae5fd641b4f03fd6d2844245d347d9ed983cf707729b5ce03bd9c09c64349c54ee7213b
+  metadata.gz: 86ffdda398270cf731fadfd7fb4c90524885559643e8c108181b9344209e132fbf953960feb8d31b5dd9aefa2dffa063856ad0e0024d0f0e10e0c6ea7a347ded
+  data.tar.gz: 07d2e6b5ee0d8187df14c8aa5e38a6b6b236cb1ed3616d3b6bafae1e1e7d364f773dc8f32f3ab5de4dfc0fcfb64ae9a64263355a2b07cf2e81e10eb9f015c74a

data/Readme.md

@@ -36,6 +36,8 @@ User.with_deleted do
   user.products.count == 0
 end
 
+# Do NOT use on assocations: Account.first.users.with_deleted {
+
 # soft undelete them all
 user.soft_undelete!
 user.products.count == 10

data/lib/soft_deletion/core.rb

@@ -94,12 +94,30 @@ module SoftDeletion
 
     protected
 
+    if ActiveRecord::VERSION::MAJOR < 4
+      def each_counter_cached_associations
+        reflections.each do |name, reflection|
+          yield association(name.to_sym) if reflection.belongs_to? && reflection.counter_cache_column
+        end
+      end
+    end
+
+    def update_soft_delete_counter_caches(value)
+      each_counter_cached_associations do |association|
+        if association.target
+          target = association.target
+          target.class.update_counters(target.id, association.reflection.counter_cache_column => value)
+        end
+      end
+    end
+
     def _run_soft_delete(&block)
       result = false
       internal = lambda do
         mark_as_deleted
         soft_delete_dependencies.each(&:soft_delete!)
         result = block.call
+        update_soft_delete_counter_caches(-1)
       end
 
       self.class.transaction do
@@ -118,6 +136,7 @@ module SoftDeletion
         mark_as_undeleted
         soft_delete_dependencies.each { |m| m.soft_undelete!(limit)}
         result = block.call
+        update_soft_delete_counter_caches(1)
       end
 
       self.class.transaction do

data/lib/soft_deletion/version.rb

@@ -1,3 +1,3 @@
 module SoftDeletion
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: soft_deletion
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Zendesk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-28 00:00:00.000000000 Z
+date: 2017-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -128,6 +128,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email: michael@grosser.it
 executables: []